From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E026C3DA60 for ; Thu, 18 Jul 2024 03:19:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6A5F6B0083; Wed, 17 Jul 2024 23:19:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1A796B0088; Wed, 17 Jul 2024 23:19:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B08626B0089; Wed, 17 Jul 2024 23:19:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 930B96B0083 for ; Wed, 17 Jul 2024 23:19:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 48479121909 for ; Thu, 18 Jul 2024 03:19:34 +0000 (UTC) X-FDA: 82351418268.19.3555851 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id A69DA40003 for ; Thu, 18 Jul 2024 03:19:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ouvqrdYy; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+8a855cc45d05e91dc6c7+7634+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8a855cc45d05e91dc6c7+7634+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721272727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/LTPAcX/ZdjGkJwMuB2EgBlggsZFjsN2rKA6eaMLSE8=; b=oF9Z8d1oz8/Yug5b9DcwRkJJAuw+r8kQUnr2g//aL5WiFlcDGr7lp04/np2i/qO47wQT9D useoHNiUeKwdQDpH36LCRsdMmTzFOUM3bhvLSfF5e3dvxMQfrCRaIgYQKUX1+F+Cki+JX6 l61EOgNkLJNHTMx7/p0O3D4dCLSMIFk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721272727; a=rsa-sha256; cv=none; b=6ODewghKLRVoI62zL0xMjg7VZ4PYk9JFvrVgtK7q26LlKsNc8rapIWDUeJqRoGIw81qG9S dS4FM0Jz6cr6xzUZyLFciyH/whx2Raqj2CF5vxVmwnoM/5sE2A3GbkWt7uTAGlSEwKvYEG uIfPVeSDmwSlyCNTzWWJOX6MhFre62s= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ouvqrdYy; dmarc=none; spf=none (imf04.hostedemail.com: domain of BATV+8a855cc45d05e91dc6c7+7634+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8a855cc45d05e91dc6c7+7634+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/LTPAcX/ZdjGkJwMuB2EgBlggsZFjsN2rKA6eaMLSE8=; b=ouvqrdYykFU+bNpobimR6tPIcb 8NVCZ3LzwWqCgBwgzE5KcKF6vi++xgF+5VFZaPkj2K5xCbUC/PQCfsuOG3cXOWdEUzJG49cKQmljT ucgMwNZILMaMifaz0Z38PZbDjiWbtXt6r4sr3ZggLYUh2/t+IdI4VEkPDJ1Z1Yc1E8OSWI7ts8vG5 E+vRVLGgdr4NHWg4o53/RRR7y46J/tDfh+VnVW14E42kYPJAdU0TnkgbZw/VF5ZBxAWLpAO/mBClu jfupGLl2SauTXBANww59ennqTdZiqq2lPcCHPnj7O+CtyWZ6+pDEDDiiLqqRy3nNYzj6QFMh2NOLF LD70kLfw==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sUHfy-0000000Fbpe-1eTd; Thu, 18 Jul 2024 03:19:26 +0000 Date: Wed, 17 Jul 2024 20:19:26 -0700 From: Christoph Hellwig To: Danilo Krummrich Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, urezki@gmail.com, hch@infradead.org, kees@kernel.org, ojeda@kernel.org, wedsonaf@gmail.com, mhocko@kernel.org, mpe@ellerman.id.au, chandan.babu@oracle.com, christian.koenig@amd.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH 2/2] mm: kvmalloc: align kvrealloc() with krealloc() Message-ID: References: <20240717222427.2211-1-dakr@kernel.org> <20240717222427.2211-3-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240717222427.2211-3-dakr@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A69DA40003 X-Stat-Signature: jtkgsjwnte7rghejyccu8k66ncwzewkf X-Rspam-User: X-HE-Tag: 1721272772-548204 X-HE-Meta: U2FsdGVkX18FbA9qFK15kWtD0dc0Iron4fMzhZBrHvTEUSYg3tqBE5Yea6KFaQd3P66BJmuyr5JtPsIiN5XGpp22uSSf48m7oo1CRkm9tjNU52N/X862tvnsa2eI06/l7ge/WM6RwoTmP/r+DNT124zrzgBOoYORbg6RQuGW/HQH4WMZ1jQ2CPC5uxoAF24KDv5bkB112huPdIDhG+xf243ndN+mdmyOOU/Bn8DM/pVaOAOyro98ps5rUfJU57P8VhyTIRp+uXDwSGSopF51AuJIS0PwQ6yZ7ncxOd4zZuUeSJXT8G8+hRqPdj8IZiqkarGt8GDvahHHur3VBIgL99eHPAwpI55l3aQHtum40hWXJKCbtwgZLbTECVFd+evPYjjcpHT7FNUp1cb+eSaYaDqhMHJHYoHT6BMi1wCpkwXLCFZBdJOKT+l1x2fV6Smt+vZcz98C6mrX5tkL3+kFAkAtNa1hDFjSwfB3kHKjF7IYop11LvevoqOw9xfiTlXz6+BkuWE6Ylu+uETbFx3uC2J3tqwMy9Gw9YWXCnCRjLPAebJmnhd8mtBsvUFadY9ehSaYr5IS9ml8l77/tCnStwlIPyFHGiH4B/IHe3JPP45E7xDR6MsLjdXyFdkDRoFBh/Cgxz4cpaCcWE41TQth8XAUEbqyOCXUohcRzSCpE0iJ/k+BV+ocgj2u1zCvZR7cvKX/N4cgXb4rewFaXLtFsFM+dSqkfahbGsY358a6wPsiD8RFFmPOTPdHpZ+1U6THqR0lbUp16JatmUDAFgpcsiKRsPXZZiHll1JKMM5ILdnHMaBwyX0nKDpZ4SC50fvo+hiAiNhozKn322TtKSM72UuDA2/VB7CxgtqNp5NwSCAcC+sqcP+QJemM9Avggl2balref4V1EYzqF1CQshH7jryDoTfmzNPvDXDc+GmhFSUBhS51jxBnVIJQVlglgSmU0y7OAA0a84ucExKzbfs M8ZCA5/q OJ2OZ3zqTsaNjjusqE2Txg5X7TF/HDL8lFuX26WPAfaUkNkLIcnXG0bcA1rMBFHHyvELTo5rIpQ0KeToDDCNtcFdMylu6pgshV4rNo9qgrvu0om1Y7+q56fhAt6M3iMXVDRuMyIM2OCbxEU+//awYr/JsIkF3kvBIP+yVhrKEETUiwvP7e9NmDjysiLvE/BMgNeYXEbkq/Amfpj/go0J53JPDbo/Cv6giIiQZ49yEp3QQOaKK4NUN4tPzUQGf0M7N8bK4uONrm5mmUejP2jFMPQ/zJTT3Ni02CyNOT3Gl5XcCepb8LyBhhuOS3DFqVqeNBfJRdiybP8x/VZba+kq4xiri/qfA4+e270nOg/AUcBzmHkgRY2YBHgDg3RfkPxtfaRev9IScUhKzD4V3EYKAWkUbRsBw5bDeKfFYNRwaDwg9x0fa0RapwZpYFAZrwT5ZKG+NNk5AoMXtBEpy7PEpw5BJk99l1SNTvDU3VTodX/uW1ouvkZ1VxnDbt6aHmlBMI112INEV3SN7EbY1Oe97rkkJig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +extern void *kvrealloc_noprof(const void *p, size_t size, gfp_t flags) __realloc_size(2); Please drop the extern while you're at it and move the __realloc_size attribute to a separate line. > +static gfp_t to_kmalloc_flags(gfp_t flags, size_t size) > +{ > + if (size > PAGE_SIZE) { > + flags |= __GFP_NOWARN; > + > + if (!(flags & __GFP_RETRY_MAYFAIL)) > + flags |= __GFP_NORETRY; > + > + /* nofail semantic is implemented by the vmalloc fallback */ > + flags &= ~__GFP_NOFAIL; > + } > + > + return flags; The name for this function sounds a bit odd. Maybe kmalloc_gfp_adjust instead? Also the comment explaining these flags tweaks should move from the caller to this function.