From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B816C3DA5D for ; Thu, 18 Jul 2024 01:24:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B08BD6B0083; Wed, 17 Jul 2024 21:24:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A91F46B0085; Wed, 17 Jul 2024 21:24:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90B1D6B0089; Wed, 17 Jul 2024 21:24:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6E5626B0083 for ; Wed, 17 Jul 2024 21:24:54 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DC805A0B54 for ; Thu, 18 Jul 2024 01:24:53 +0000 (UTC) X-FDA: 82351129266.08.D3C839E Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) by imf10.hostedemail.com (Postfix) with ESMTP id F04CCC001E for ; Thu, 18 Jul 2024 01:24:51 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HsdhufZL; spf=pass (imf10.hostedemail.com: domain of htejun@gmail.com designates 209.85.167.176 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721265838; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gQNtnKrhFtO13VagV8HA7OXr7C3K2JA1TX8HuWa49AU=; b=8ZgpKTsrfFgF8uP5CXgUNBjCYANNqmreIc5xSSHgyuzaPOWRuoDQeNcVUkjzScBC2TSfnJ 2ngD4aVn8LDI9z+iU+s9gMfq891JCVwys/E15qZUsRWuxq+PQDrxC8rLV/XEW9BqT619k3 eZj1iBw8idxlabEGtMBRabBgToDz1Aw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HsdhufZL; spf=pass (imf10.hostedemail.com: domain of htejun@gmail.com designates 209.85.167.176 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721265838; a=rsa-sha256; cv=none; b=aWN6HqXkBXB8pH1QC+DDr8ARZEg2E0fpnXTrCw3JcHBQrFQgeSGlB7yKQWaSiXRculUdRo TgUaDOqrbUWvD4GkY38tvWW6UoibZvy6r0knatAGvj0tbcUGgapMG2UqZOqb+jdNyo+Eof 1FFUbEm5GZnPCsuPuHCMawfB+km7qwI= Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3d9c487b2b5so197498b6e.3 for ; Wed, 17 Jul 2024 18:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721265891; x=1721870691; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=gQNtnKrhFtO13VagV8HA7OXr7C3K2JA1TX8HuWa49AU=; b=HsdhufZLHJ3kz8/K1J19j+9SUOc73jiKplZ7Z9u97HDeiWZGj9YOcvxOf5dU0kXiNq T3rTNy0i1OE73zFLge9JXSjzafY+B2zUVKOS6Ohx1idL+n9rzu6dsg/g6j+UrOby+Hki RabwLZpufUt0H9ZuL5YuCtIkyhOlZeAVLgPikIVY57GCIr3KmevvoXw1BbW3loLap8Q+ eeVgfKGyswPAalmoQScAGhw8h2cEv8Hk9XaS1dw3LvO5KlOH5bB7U3x3hOTAp7M4wTRN Qrm5JYoiGhMkLk3buGlvxKITXmRBRVHGM/ZNXWD1+BzlbSQ7GjVFl21pBzyJmJTxU1iO E1hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721265891; x=1721870691; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gQNtnKrhFtO13VagV8HA7OXr7C3K2JA1TX8HuWa49AU=; b=cbnyTiD1JslmJnNwbww9guia3c6tyVDLOlXMOyFDdt7kHmgsm7W/3mvSL5ZI20llcj M48tcNZ/xdsVdYYUoKLcT6BtusDp1i2BiEUwDZEbPXxPI5+Kww0taK6WFVNeDtVJpbod mTlhdYHot2BnnAlfC8RDjcI/KdllaFk/DlLqFk8qlA2Jd7Zlrv+vhWdWqKAnxGa29fFR R4pMW8OulqFUJOunA2/Rxc/uBG33yiZeB0/nqcppQTc54PiBE9BNs/rG/qNuiDWyOteY pSFueDEGtJnm1qti4dZD8wYhHCy+DICUTa6KooDleYqvsONo7rYsnbKYyBSPo+AWwVh1 hiQg== X-Forwarded-Encrypted: i=1; AJvYcCWIWEt+u7GuRzGgy0xp6Nm4Ubyd/rNYYpl65qe+2uIECYnmF2XSQ5gNZPpzQE7NaJVym+OzGrhNxPdOx2QHGUNaEuY= X-Gm-Message-State: AOJu0YyWRdL9GQ2kAZ2cU7yMWidqg2WpR4VV09vyVEQmmymBeBv8Os0C L5UpZ0jAfpp9JYUxFa+eNy0KBtRqWKHGNkvRwqO0VriHrG8ja4ZAdV/aSw== X-Google-Smtp-Source: AGHT+IFskbJPGL4FR45rPVai7E+FgAv9lrfLD+0WVnqBaVOiIStnDRYbtBAbFfk7sXYaG+c0L+hS6w== X-Received: by 2002:a05:6808:309b:b0:3d9:2cc5:190d with SMTP id 5614622812f47-3dad52936abmr3088964b6e.38.1721265890868; Wed, 17 Jul 2024 18:24:50 -0700 (PDT) Received: from localhost (dhcp-141-239-149-160.hawaiiantel.net. [141.239.149.160]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-78e38c951c6sm6804246a12.61.2024.07.17.18.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 18:24:50 -0700 (PDT) Date: Wed, 17 Jul 2024 15:24:49 -1000 From: Tejun Heo To: Waiman Long Cc: David Finkel , Johannes Weiner , Michal Hocko , Muchun Song , Andrew Morton , core-services@vimeo.com, Jonathan Corbet , Roman Gushchin , Shuah Khan , Zefan Li , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shakeel Butt Subject: Re: [PATCH] mm, memcg: cg2 memory{.swap,}.peak write handlers Message-ID: References: <20240715203625.1462309-1-davidf@vimeo.com> <20240715203625.1462309-2-davidf@vimeo.com> <20240717170408.GC1321673@cmpxchg.org> <20240717204453.GD1321673@cmpxchg.org> <85a67b00-9ae7-42a1-87e0-19b5563b9a0f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85a67b00-9ae7-42a1-87e0-19b5563b9a0f@redhat.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F04CCC001E X-Stat-Signature: ogncb6fapfhczs8trkrc1w8xjo5tom1e X-Rspam-User: X-HE-Tag: 1721265891-922734 X-HE-Meta: U2FsdGVkX1/lsLQxeZ+x8ORVFpz3fcKVJQZ3dJLXr9G8V3LeJwUcv60pT40nugeUdul+p1DtLZ0AOEY+qB0a/P7jAOm1KyIkNMIfP86/u7Kw926RTzkwI3Oa/3zkmVhl9WgMRR6/vRTswFPhPccuvRdfrcZp6wtfXpHz9ckG8sR0U1pwTxZhK2sxRCGqsOtqQqlv+mGW8tK4kgiEp6do0SgxqU6UEXI+/CumDtC4+Lqw9hIM4PvdzWaqWb39W9CtdJBCtL9sDcuJgXHB8V6UBjvvEId2cBdxKwkF9m/EhsgXhWiOrXOCHWTuJyzyxbTk756yOn2VWHz3a9m0a5kb08j93f2fdDNrVstZHZvmtpq/a6fv9jP6hUQfWHfHLHB9i4MorbSdUjbhq5Tfi2ApcEsFrq2Kk/gVnaoeXBHe/xJ2vD7j4yoMJpNfnD4D9ac7Mg0Rz4xf+6+KXbHiOX3FZMSiW4LJGX1uu4inuGmzRf2NuR/SFV/uDpmoS8ubuTZSRTX56LSzFH5oGoD1syfb7mtpogoWx6rrUc+1mWozVaGZU2Jl/bSBJxRVnWr1bX+cCu07rMY/uQVMXvW8QVLFW5ywxE5hYZXretjr55WhmwQI8R7n7bKSfe2nNn1rtu6zpJcPVWHsXMRknC/zLFls89OVhKNBgqmzJOL+fNnkT79MseH74Dz/Neo+i0/NqbwVqALsGLSCoz8n4x2ZfDYp4Wu25Z15kRUomWtvKdrJ87y0XeWKRDhyWfXBUEPV+3YzzX8NzPItbKvL5RauUjAJiOMw4kaZpANr4Gi5X2Q1HsGmhBeDD35bL4IAhYEZ6HmqNAMtMjd+1YkYvAvYrv4k7zv7AlARSHmYv7+wSw5Um/lL2cZvZbV4OWFintbZVSCFzd/p4Bz9hm6rS2B1TTMKODLfh/2RaoqYD2HRmBB2LdVdhRtDJuZU/A9jl8fEXWOM3lWKmL0Qhq536A4uxFh JFvOW4yx PNGYu8py7kgoEKW0AGznuW0TKRnpi2CaT9m6cNGhaRRDWHcOVvuXxcq+xnbZ8SHMMs1QdFHm9DT7ODTBjyzpzGmrinEjlpwxOYOwDdCo7shObAaMk86Dv86oIt8MeLHsbyC0SXN8CVrqUuutaBN+GH9eZOMBMnKS/Bkp+ECBJbWuXdeX008va2XlS+bf79sbzTsHbDSa2/wmB28qNE0648XcamxOvtbsBk2BpU+/7S23Gv9BL+bgHqM/6J0tIlb7n6n7RuLCZzB0biI3zolXudVEvPPUKwk7C3BHWRGk7+IqKQ3jAJn0bqJqPiBWvXRcoAVUxIJDcYkxwThNot/WxSU6Be1WnKoDBwGe28ixCUI55vPwDZzzz9Y0igbeQUrrUdf8iwX6Fiy10EQYfY+4t3br6riSuVe3iO1agQPFDSASNBkaasTkkSkwHt3G4qkTuwWW/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 07:48:40PM -0400, Waiman Long wrote: ... > How about letting .peak shows two numbers? The first one is the peak since > the creation of the cgroup and cannot be reset. The second one is a local > maximum that can be reset to 0. We just to keep track of one more counter > that should be simple enough to implement. What Johannes suggested seems to hit all the marks - it's efficient and relatively simple, the overhead is only on the users of the facility, and flexible in a straightforward manner. I have a hard time buying the argument that it's more difficult to use - the benefit to cost ratio seems pretty clear. Given that, I'm not sure why we'd want to add something fishy that can lead to longterm problems. Thanks. -- tejun