From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4ED6C3DA60 for ; Thu, 18 Jul 2024 02:17:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F23FA6B0082; Wed, 17 Jul 2024 22:17:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED3C56B0083; Wed, 17 Jul 2024 22:17:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D74AD6B0085; Wed, 17 Jul 2024 22:17:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B82796B0082 for ; Wed, 17 Jul 2024 22:17:34 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 81D8C8184D for ; Thu, 18 Jul 2024 02:17:33 +0000 (UTC) X-FDA: 82351261986.23.B85152D Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf17.hostedemail.com (Postfix) with ESMTP id A925F40007 for ; Thu, 18 Jul 2024 02:17:30 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=u37XGcnN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721269006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=68sXNRc9aX1kYOm4EbIZEtLCrD/0gXEQ3WebTzoEtqU=; b=MUeRvAiIpVNh/6RIABHsLVFS0mTZL4ym8H+CtpkmWeY3mSedJWVbhzlxkGTzBpQkvugas2 LLY/KElMbvAK1x4VRc9WiGig7OqQZYwqAVNB36KuezCx6it5EiZn3PLB99wgBtvqk9gGc5 1rWqYjtLN3ooYDHk5f+LwEubCfIvNPc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721269006; a=rsa-sha256; cv=none; b=A8beB8i1afT2LARI7j7M+Kb0pjwiyFLUARC0V6aCnw9MrCM4gYeXLRMatF1gBIHUp1FE7a /ojp+jJyzA1uyFo9ny8D0F3NGbdtdQ2hf/0UFtZdZkEw0ng9AbEr9vSy/3oPAX1b1RW74P HtGe/BD4KF5HaU7YlpjrEYBYWUc1sXE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=u37XGcnN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev X-Envelope-To: tj@kernel.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721269048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=68sXNRc9aX1kYOm4EbIZEtLCrD/0gXEQ3WebTzoEtqU=; b=u37XGcnNYIkm7CZp0xVQulO63AGKHfEhofgSq9I3JUGi8vomRFMkTFJ9pXAW/r51S9tZNy EFOmQYMZivqm6B8ev52sG8BAcy2ISBMXc68Z8ujGDbt21h2hvy11H2bhpHLDDlcivbOBjG RcfIfO6APi0RRqkrWsmxvoGvEjTCzJU= X-Envelope-To: longman@redhat.com X-Envelope-To: davidf@vimeo.com X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@suse.com X-Envelope-To: muchun.song@linux.dev X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: core-services@vimeo.com X-Envelope-To: corbet@lwn.net X-Envelope-To: shuah@kernel.org X-Envelope-To: lizefan.x@bytedance.com X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: linux-doc@vger.kernel.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kselftest@vger.kernel.org X-Envelope-To: shakeel.butt@linux.dev Date: Thu, 18 Jul 2024 02:17:16 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Tejun Heo Cc: Waiman Long , David Finkel , Johannes Weiner , Michal Hocko , Muchun Song , Andrew Morton , core-services@vimeo.com, Jonathan Corbet , Shuah Khan , Zefan Li , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shakeel Butt Subject: Re: [PATCH] mm, memcg: cg2 memory{.swap,}.peak write handlers Message-ID: References: <20240715203625.1462309-1-davidf@vimeo.com> <20240715203625.1462309-2-davidf@vimeo.com> <20240717170408.GC1321673@cmpxchg.org> <20240717204453.GD1321673@cmpxchg.org> <85a67b00-9ae7-42a1-87e0-19b5563b9a0f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A925F40007 X-Stat-Signature: c3wa1c3r3obx38ahbgr3wzoh7bwjotyy X-Rspam-User: X-HE-Tag: 1721269050-931100 X-HE-Meta: U2FsdGVkX1889kVRrAtGcGYvJcZNwHJwmJnssVHIlw9nuxnQIuWm7I1rc9tjVautHJ+um9bxi5Of8Zj4wN3rJe/d/97pw88/i210RUt/K/x7bf32jPU1Q0iBsoOnp9CMyQfoW4ybZ5T5EjrQfIaW0mkyBYxTuWeYhLy87WWQbF97TdwKiRovoFXxNKiD85/jyYyy8QSAjqjW6dG9fGg9eQmwRt9mEtuXP+5r9bzXb6FElVP0RfIrX0DI0SFiNL2mGZJhnslsJB2YmFjHUsdYrFaTBcNVdLBwFVDYfeuE36lI2r5RJL3c43o/GfKy+Wqf9Ymo+WNKw6IlnFEwDSsWa7O71AUuC6UFBo28MNciBidF3bFkZQHffJcup1nAnsI2Nmrnx+7nFyxHxbCDCgNsSvxH6y1a3KxW2AzTGabxLQnkwNDlMS0vIcDwpy9iHv3szMp++4UV/BFuOm2hMOc4LublwAQBo4T+RO3e9spRy4nHtvCquo1tEixtu5u2LtItO4avbzaovDWhy1c0W/DiRDQyOxkd5ra2Wx+SmVhrNklxMQRYwLtY8e7QWP8cfY01ki5crRe98fX8+kT1Bgnl5urfIYWU/vgP5ejQvtaE4vh3GQgbnq8aqLyEmI+wbsUas65l+Nqr2NIDeHYDjv9cwv8RJ/42ty1fp+9JTysVrmT7kPEf0puu1u+F9ZUkK9wd2yemaTtAzm8cpWXkF3cyZ0W43SIE7Y74op2aNRbl/wgrNrplqGtwqKUcO0bue6unpGwbVbOQ/9Co+whu5NjDkOPs/T6AEGXSdkFyKSiOMXgdr/rvPRq+lIOq6Nev5xiq5DAw5lMGztFfGdZ/MUGRgIPuXYAFM1LyjnGgCVtuLRyADNTU7DlPmsj0Pqph5cLFRcPun/wunjRWoJUAUXsNgX7w6OwOE4/PJqw2kqHRul3+zADUn2LlzpVEyRV+vzQ+JuTqqop8ZVWV59dFpvM 7a+dkOda sjeceTkvGtqUWQOUiIJdaIfMCfCNuWYxKZTOp9zpDG86rDojjQaWvgxd6lEBYa5J6NkztCqDw+GtAu8pUfK3Y9Tx7AHJzifGNHnd4UdZnhpuySsrN9CfY04GNOXcmIoFEUKnvakJ6aZi7fxVJeMV4kxwU+MSSrEIzrwqE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 03:24:49PM -1000, Tejun Heo wrote: > On Wed, Jul 17, 2024 at 07:48:40PM -0400, Waiman Long wrote: > ... > > How about letting .peak shows two numbers? The first one is the peak since > > the creation of the cgroup and cannot be reset. The second one is a local > > maximum that can be reset to 0. We just to keep track of one more counter > > that should be simple enough to implement. > > What Johannes suggested seems to hit all the marks - it's efficient and > relatively simple, the overhead is only on the users of the facility, and > flexible in a straightforward manner. I have a hard time buying the argument > that it's more difficult to use - the benefit to cost ratio seems pretty > clear. Given that, I'm not sure why we'd want to add something fishy that > can lead to longterm problems. +1 to that. I really like Johannes's suggestion. Thanks