From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E6CFC3DA60 for ; Wed, 17 Jul 2024 18:10:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B72B46B0092; Wed, 17 Jul 2024 14:10:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B232E6B0095; Wed, 17 Jul 2024 14:10:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E93C6B0096; Wed, 17 Jul 2024 14:10:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 820C76B0092 for ; Wed, 17 Jul 2024 14:10:35 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9C8AE40C10 for ; Wed, 17 Jul 2024 18:10:34 +0000 (UTC) X-FDA: 82350034788.18.7E4EF08 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 63817C0005 for ; Wed, 17 Jul 2024 18:10:32 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f4gAelR7; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721239792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XdILWDpsCDSoW2G5wLGtJwqP7KLoKEtOgvidIoe0/j0=; b=Cjs+2y4+9z9Ea7tHETqh/PGPm6Z1HYKuMStFiJcZrJbQGVpXdzVQA5JatbfCwPIPaNPs0N 8lho9OBOBq4n3TExIxPcvkwXzdhXURlTUtWLBj1Yp2w+Wtv7I2GMEmyHRemr7c3G3xgpif YHWvxyyjMxOfnKRhAT/FHvUSC1s1Ttg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721239792; a=rsa-sha256; cv=none; b=3dZL8t8eoEoInPvoBXeTLjMe5SFmiwE1wTVNn3IU6Np5SCloge6pQovxW/XcyFvdCNZITA D03uKtIRjK7so8o7XiMQYkH1Zvv46hkGbydf9zkz6cXQZCggXcWrQdBKVFSpE9HlvZdEo7 7RWPxjr/C4txxqt/Wx3aojcUKMVmd7M= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f4gAelR7; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721239831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XdILWDpsCDSoW2G5wLGtJwqP7KLoKEtOgvidIoe0/j0=; b=f4gAelR78B3UvZsK7FTrMrsTIeCFwoFKifVRBaSfSagZww8J7UM8gk7fxkK4JlXKNrnkw1 5Hp3+7fjLczavjfuDj/4yx0EVNqvSNR1U8NdOgbcgV8oYzURv2XTwCBe6WN6cCgNkEeBUA fC/xk6YuR9LVyMilXUtUoA+yNB2PijM= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-e5U-cYoVPNupvHJu0WpWNA-1; Wed, 17 Jul 2024 14:10:27 -0400 X-MC-Unique: e5U-cYoVPNupvHJu0WpWNA-1 Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-5c696b8e759so125087eaf.0 for ; Wed, 17 Jul 2024 11:10:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721239827; x=1721844627; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XdILWDpsCDSoW2G5wLGtJwqP7KLoKEtOgvidIoe0/j0=; b=osTR9aiDLfdWCzwR2uaiemhCBLRBKdyFmzU8g2h0SLLwQMSK3s9zjO7GQW+W2f5KsJ l0RjLBXGwVG/OELSlE9mC2JWHQLSgQeR1aN1HdIJ3dClZy+cBJVlvhn5FrbsLQfUJYQV ds3uk/qV6FsXyJDFgMSiiiUwk4P/KBA8QzOklpYwXdAX9YoB8cJ/QuGAxXGNJ68OBVK/ Iiyi+N2k7SkFriCOECxqaeN+3IQG+QXuCaJPthpP19zGXJMpWCgSIWzpK6nMINQC/RjX Fd31W3jQ9Bi/eOCg2AADIJ8U8JSbQ6jgzgt1omrdAo+7Y3iO12xpJ/jy32+ft/qR9C6S VPUw== X-Forwarded-Encrypted: i=1; AJvYcCW5RCAPxiKugVO2x0iCWVAQtDk1d+sztl2ySFRpD96C9OzUv/VH1NT307k7qXW+J/R9m5b+Q0WYyrbAbnn9H22SsPU= X-Gm-Message-State: AOJu0YxIszrMKedSW6FPqqxNO39vuE1ldhkSXvYaomAvapjofAMGy7UD aNbx3UShVXp2CvLpdUr8bZ2GZZIjcwqCpyWyAGUZ10RsuOqy6IgHajw9dk/IGM1mP/ctgxZTLj6 xMC+G4F+RMH3HX7i9HVmU9yaN+WWcVQAJITaMMwllnXyi+h4S X-Received: by 2002:a05:6820:810:b0:5c6:6aae:b5f5 with SMTP id 006d021491bc7-5d416357f02mr2270259eaf.0.1721239827140; Wed, 17 Jul 2024 11:10:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjcUX1q+2rOEkj/PltU6LP9up/Pim26cnYrvjthRosahbP02nv/53iGAEYPNWh6a3mYWvy/g== X-Received: by 2002:a05:6820:810:b0:5c6:6aae:b5f5 with SMTP id 006d021491bc7-5d416357f02mr2270227eaf.0.1721239826780; Wed, 17 Jul 2024 11:10:26 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b79c4d18f1sm924356d6.19.2024.07.17.11.10.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 11:10:26 -0700 (PDT) Date: Wed, 17 Jul 2024 14:10:23 -0400 From: Peter Xu To: Jason Gunthorpe Cc: David Hildenbrand , Yan Zhao , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Andrew Morton , Alex Williamson , Al Viro , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "Kirill A . Shutemov" , "x86@kernel.org" , "Tian, Kevin" , Pei Li , David Wang <00107082@163.com>, Bert Karwatzki , Sergey Senozhatsky Subject: Re: [PATCH] mm/x86/pat: Only untrack the pfn range if unmap region Message-ID: References: <20240712144244.3090089-1-peterx@redhat.com> <116ca902-103d-47cb-baf0-905983baf9bb@redhat.com> <20240717163154.GF1482543@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20240717163154.GF1482543@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: xwu5qjnfuujuio8rzww8drsn9oq8qpbh X-Rspamd-Queue-Id: 63817C0005 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721239832-551157 X-HE-Meta: U2FsdGVkX19HRNSpGzmJ671tzArUASUu3CYmqXwSvCHI4DuLTsak9CTJtZczhRAyuYCfDIuWlwama4hHP/LTGR5eRKY0L5Nl9cVcGQ7CFV/NxFil8ewfT7b9bj0W3BiUaHvq9+KbXu/VCNDXsySqtgqsmXYz3FFQ3qge7/Dy5FtNwUNLV45ABeK3K8YyeJ6xjZx/g3707A1CqGFCNA8qh2BE5gXfbmyQu1ttC+MUkiM6PNSUTAj1qADZE4fLWFx48/1463AFu9SyjTy7fZUW06hWPmK3lza0X6GUkf0nwyzIN5bBlLZfrwQ4rX4zI9LKxgZ/vum524pRX53KXLYzojx5AWYv++18CYPxnBd6bKibAKgOi+/hpHBAFF3nIUq+whefVwezQDTBWfEQbi0x23Tb2ocTazczdviUopUhQJdnQqhQI2QEs8rE2uyND/tA0FrT8kSYBXX4pwcZwtaHgOSkIziJd4s6RIuqgL6FtpAjdZJYdKji7Ep3C4BQRoEbMph2UlNe+UZrGjn7kXukChrV8atbVju0Sk39Clc3+8oWQQ0XbFdtI5B9aP8mXo2cuUTH3nFi3tLuMZJscY2H9GQAjFCkniiY0sX5a13jx2nByof4gKcvsQ3vWnWz/iogRbvTy6q7sX2pkjeLsN4enfSlk252ps87ZDw85EftQWExIwyHBPGSKuF2MbC2pGVRmdiyFbCE29k53gQO31GIdLCc3jArHYPpiJvZNsfZDUImbV1UVdGT5xVKx+eJZhbGNs9Q4HD6T80viwhlA2E+6bHUctnUNC5KZr65QAjxC8/L1rauiCBfxDJmVo2Xhcp34WDoAr0z0d8LxgwTj30OLvhGRxnc3dpq0h1v79OFvHAupMuSVyZauJsJTYTHO1Bu6INnwQddnDqfT8UcLrP5GwLxGZRSEn1pDqNN2hbeh4P6R69Wl2jnJD2urLCf4A0WBzKj1y0uApZ0P+OEzqL 2IPi87hM ucNQYYh3Y3D7XB5S7BghSCxbRXXkoC1LUUNJMQUOt7Gt+o5Qr1lMCeZ/U7c0SBd52W016OmetR+2tk/nNDrv/fO8TjIcqI0GZBc63OZMddq3iCDGT28KsRqhaNsuHJ5dwkmcUHytCrnO8c5QEkliKdcOJRy4A7cjrDBHUnk6xLjGxGWediz63uk0P3gfd24aUrBXBAjIGpg1+V8a7XQ9ug/DYj+GP+O4iLexSCqjefeJ1uMmtiiw9dRNWpA4GyqGtS3vL+O97CKLP89Onc2C0wYauroeUMBEo6vHuBz68jIfQeQb/2YjzyjW0+x+7aai13bByj0v7rtC8JbvOFVUhovlaoALJmJ2JoHpfsXSGQ9okU3Xzn1HBAS/sAEXwcnuebeyswnQ6+aciEPA+d3yGzP0BvaKuEgK4ih5gTDXJqonkJcgFciqXsDCuMWencFl3Kte7kLrBC1A+UXE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 01:31:54PM -0300, Jason Gunthorpe wrote: > On Wed, Jul 17, 2024 at 12:30:19PM -0400, Peter Xu wrote: > > On Wed, Jul 17, 2024 at 04:17:12PM +0200, David Hildenbrand wrote: > > > I'd be curious how a previous truncation on a file can tear down a PFNMAP > > > mapping -- and if there are simple ways to forbid that (if possible). > > > > Unfortunately, forbiding it may not work for vfio, as vfio would like to > > allow none (or partial) mapping on the bars.. at least so far that's the > > plan. > > vfio doesn't support truncation? Or does that means something else > here? Here I meant VFIO can explicitly zapping pgtables via vfio_pci_zap_bars(), irrelevant of any form of truncations. I suppose it'll have the same effect where we may need to stop assuming PFNMAP vmas will always have fully installed pgtables. Thanks, -- Peter Xu