From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B17C3C3DA60 for ; Wed, 17 Jul 2024 16:14:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43DCD6B008C; Wed, 17 Jul 2024 12:14:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C7726B0092; Wed, 17 Jul 2024 12:14:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 268256B0093; Wed, 17 Jul 2024 12:14:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 07E436B008C for ; Wed, 17 Jul 2024 12:14:22 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 940AD141890 for ; Wed, 17 Jul 2024 16:14:21 +0000 (UTC) X-FDA: 82349741922.25.B8207CD Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf29.hostedemail.com (Postfix) with ESMTP id 7A53212001B for ; Wed, 17 Jul 2024 16:14:19 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=eI5hMPQe; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721232819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LEwhtems285VRp+VcimErqgA9+/z6aK+6Ol/iXReRes=; b=ov1hCzxnwmVs2VJMky+EFYdJmw2+v19rm/TEYBahiGGzOgqdDXRHYZ5qdy3ydKEZvbMH43 x7vHVRqJadmTiCETsTub6CIuJyTWurApy50RVdtV5LfKv5MXaLslctxw3b4uP7/o0I4npf ZRKc0y6rxPau07HDj8vK663tNoVx2NI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721232819; a=rsa-sha256; cv=none; b=N7CBwXFHopwVnD6Uo6wXGaC7c821kCGJVB/VY3I1/q3BAjulDhTbAi8Xwvmdn6Loxm1leO Z4w5lhYQMleAcL9/SKha04LpzfLuDP8BOwx68W7v/8AlcZOFHqIoS7PVfgjH3/o9qR0bHa TueId3RYq8k6C/vYnUhj4gcyIZn/6jQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=eI5hMPQe; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5854ac817afso8429117a12.2 for ; Wed, 17 Jul 2024 09:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721232858; x=1721837658; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LEwhtems285VRp+VcimErqgA9+/z6aK+6Ol/iXReRes=; b=eI5hMPQeLGSshLPoAITGw4R0Y68OUaD3njriu70dWJMIEw4syw7H68JrQ36TjQmXtx iB8iZc3DNkvGWUqjguvFofycor9m2DzDr4e5KvnkXD4x6JhkhEYr58y0cI+/uKYA6oJX 2nC7HOzX5ENnMsxDdOF2HsPEzMjcsBqZQpxCsEFO3ToiewUY7+2eeqTkHUDmAOrsz5tH axm6AVbrWyxyvcFWywwa8vpsLgBjvqE529rWkpoqvhdOTxTcZ8GbzbIvFFEqQAvDbmDp lnyd11TXkhD60xj7QiEzRdufUFZze/j+GzFfuo8jOVHxymMqcamnjz4uOX4io6aywe32 0VoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721232858; x=1721837658; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LEwhtems285VRp+VcimErqgA9+/z6aK+6Ol/iXReRes=; b=h1+etOZth/5BuSk0FEgZ1tIsbbGFOZgGgq8Q2W26HojqssU2gQWe3Ij48OPZGIx3uO TSOe6SNQ8vYbKBIfEUB77rn7/EVO7Oe4ownpsJx4M5ny6zaUjAHJFMOdKVWoW6LXdlwL ibj/IJmEVsyh2GwKKnQY4wShfvHv/saSBZrbrvPFDroSwkV1c/dBfZwY2h2pLwpvOqYh rBgqEgCxf1JHZV9of/lYra4xSqYc4VCJHhAOo8HuIAdpWE/EX0hzXu4qFEunQB0Yu33b IGw2jEv1VZ6Phr0NWWlJI0WGJAZZNQ8lYZiG/qG0ECn18kOj1/HFSrI/s8+gYWbAiL/E QpDA== X-Forwarded-Encrypted: i=1; AJvYcCU141c2XDOfEGgkIa5pT7FeJCiz8XpIoP0FHC2O2n+dpFMiExccb8dlVCWlf3imNiEq4oS2WR+Vs7RbRAiTnrmPsNg= X-Gm-Message-State: AOJu0YzT9yTGqVsX3cuQWZkP1rPLAVJ06/sVIhb9J/gLqChSGv2NRyZp ypFLcbPVTgkKNCY4K3ofFyz/6468E9wiG9admZzB89mW3Bl+dvJO7tEfAs+/rmU= X-Google-Smtp-Source: AGHT+IFvguqbwiQzSbD3S1ODpOLNKCNwaosZroB1gY+Xq6Ja1OO6D7EXUW+FPqr+DM5hB6DiiOcNoQ== X-Received: by 2002:a17:906:490d:b0:a77:c0f5:69cc with SMTP id a640c23a62f3a-a7a01352eb4mr151904066b.61.1721232857851; Wed, 17 Jul 2024 09:14:17 -0700 (PDT) Received: from localhost (109-81-86-75.rct.o2.cz. [109.81.86.75]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc7f21afsm456637366b.119.2024.07.17.09.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 09:14:17 -0700 (PDT) Date: Wed, 17 Jul 2024 18:14:16 +0200 From: Michal Hocko To: "Vlastimil Babka (SUSE)" Cc: Qu Wenruo , linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Cgroups Subject: Re: [PATCH 0/2] mm: skip memcg for certain address space Message-ID: References: <8faa191c-a216-4da0-a92c-2456521dcf08@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8faa191c-a216-4da0-a92c-2456521dcf08@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7A53212001B X-Stat-Signature: 5ifjwwjms3tpa89oxez3beueewwpngt3 X-HE-Tag: 1721232859-985831 X-HE-Meta: U2FsdGVkX182OZP96CG4FnTZ9dyX92JTcPuQAKB+1L9MZpIMGWiZ7mXMDKzH+8mq2XuyuDKvbl3CIceeNi6wD1s5Fw8x/MDbiL5mkaN//WQWYlOrAdpIHgxOnWbLEzLK72bfKYMOF3igR8tyCjR8rsypI4pN3VjmpWLcbTHVjIzQW0X/jM9XzwHIh45CbFqNHl06IHOndhlwXFgpq2TCRLzUTywOx7rTxZtQ0neWnEL5T2IvOk5+zAi976KjNAmg1nXv345b/hfzga7hLJ0kGYPWYe9ZZISagxNm75ibMLOiXALRlWnkoWKtFE9MSuUp/ckjXW5AmkcD4MZKwVgQBXEvmAsTYKqxtZqrfOzEVbdW+WO6jw52KNwH8kLqv1LKiQtMgWtRw3DPPOGNNS9Y4pw5+6GKYjNKKTb3QmTtGOMbB1bfLIkpyPRFHM7SN8fo1EoMSaEH7diL21G3JM1d3bCVbOa4cTBexvwQbF2Ir/Hs3aT7xW3eMkyQuXdnn2zTphMXVpLYxavvwNLDh4mCjQa7w6xd0iHqjTX9Mc+6ylEUrnNZQ2dO+YtYtffhDUsGdH+8OPxpx62ujKb+IaX3y79P2xwMm/FYZnlgsPGZ9i3VfUsPtJsR1lGaOotdk/KrVVg9r7icMxZ7znoLfQPnc9onRsXKluUYJ7ZcGT473Q/yZ47+UoLrTiFsT+yWe5osKlqlj+2uHVpz6f+Y+QpbSuml9VKgpDyopEKrGe81LY9Tye36XkKqf5zLxVjtBWNZctzGbBe4BSeFdiIY/H41x7U6zoA89Dh3LQ4uWySBeAa9t7yzbSr5l//x9SIVXJE4aPmuh9RY68QdWqaAr6sjxSlOrpOP9QOVR66xT3KpdzzBNpxPXbscenTcEGo/gBQYW/WLARxaTWlIGDXMGho8zjHja4+0sxhQnhiX1YgehGGh0FEtCFe4STKFjIDB6SlByxpPeRC4JpReh6jq+Q0 GRYvvpcL b9kdFgFcpZNl8glv4cy0O0dq+a3igfFDld2foaBtHEaNwivExHC0XcIpqpJmAyoC1Fq94BJfojOJOWrvNF6EwTCDj0HMzRRoS4pbHPzSxf1584Md/pP5lVbzX17QHqxICImNNGm8ytdsvKXei24543b4Rk/d0uvwwDPQc3llKMEtn9LV7y0eYCvas/BSBrJ5h8uYn3mB5VElcMrx67TNLTD/slMN0pJRa+0+xxJHIlfOp3r9ws7H9D4EFLnpvERUgk5buL3QCyEbwCWmJxg6S1jITOF84bDnV2gk2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 17-07-24 17:55:23, Vlastimil Babka (SUSE) wrote: > Hi, > > you should have Ccd people according to get_maintainers script to get a > reply faster. Let me Cc the MEMCG section. > > On 7/10/24 3:07 AM, Qu Wenruo wrote: > > Recently I'm hitting soft lockup if adding an order 2 folio to a > > filemap using GFP_NOFS | __GFP_NOFAIL. The softlockup happens at memcg > > charge code, and I guess that's exactly what __GFP_NOFAIL is expected to > > do, wait indefinitely until the request can be met. > > Seems like a bug to me, as the charging of __GFP_NOFAIL in > try_charge_memcg() should proceed to the force: part AFAICS and just go over > the limit. > > I was suspecting mem_cgroup_oom() a bit earlier return true, causing the > retry loop, due to GFP_NOFS. But it seems out_of_memory() should be > specifically proceeding for GFP_NOFS if it's memcg oom. But I might be > missing something else. Anyway we should know what exactly is going first. Correct. memcg oom code will invoke the memcg OOM killer for NOFS requests. See out_of_memory /* * The OOM killer does not compensate for IO-less reclaim. * But mem_cgroup_oom() has to invoke the OOM killer even * if it is a GFP_NOFS allocation. */ if (!(oc->gfp_mask & __GFP_FS) && !is_memcg_oom(oc)) return true; That means that there will be a victim killed, charges reclaimed and forward progress made. If there is no victim then the charging path will bail out and overcharge. Also the reclaim should have cond_rescheds in the reclaim path. If that is not sufficient it should be fixed rather than workaround. -- Michal Hocko SUSE Labs