From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E872AC3DA42 for ; Wed, 17 Jul 2024 15:46:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 475476B0089; Wed, 17 Jul 2024 11:46:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 423F16B0093; Wed, 17 Jul 2024 11:46:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 313236B0099; Wed, 17 Jul 2024 11:46:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1213D6B0089 for ; Wed, 17 Jul 2024 11:46:50 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8A53F1A119E for ; Wed, 17 Jul 2024 15:46:49 +0000 (UTC) X-FDA: 82349672538.16.748843E Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf12.hostedemail.com (Postfix) with ESMTP id 6B4D64001A for ; Wed, 17 Jul 2024 15:46:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=EFPxp3Lc; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf12.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721231178; a=rsa-sha256; cv=none; b=m/GdF5wDJwjx01qcmT1mpHbrmhS6CC8uzPWBUEMw/E3YEKZQ0VFWzqQWbTFb1qn+fK5fZ2 H91mnXG5s1Hlzc6uhUZTP49TxOgSl/mlJWoEyR6cDv2qP0W5Z1X8l0ZVTbAs7d5SfYn/Z6 ltMXuIBsYtv+qcgweI4j5MWstLDRJ08= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=EFPxp3Lc; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf12.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721231178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=itVRxRQ4fgSvCkmp4ZT/tO0ArO/vcPF2tBOypwTVJTY=; b=kFwEIzwseCr+aDH+6ph9nzWMwcGR7KAtoJRcacRDAK3NsQvTBjQRoph661OIG4n2O2Fhcl hDcm+PFP7zC3asckk1T2ZaH1HOuRuztmeugy8altHDg+E22H8MreU5itbL8u/blWAXlRRl 5uF5ChRC7LdTgvUMI66XCEs2wdFnpMw= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-59a47d5c22aso8257823a12.1 for ; Wed, 17 Jul 2024 08:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721231206; x=1721836006; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=itVRxRQ4fgSvCkmp4ZT/tO0ArO/vcPF2tBOypwTVJTY=; b=EFPxp3LcTEfWdw1FpcUvcw6ihIadDWwVFgVCcFHpObH06ReLl3KN+Ov8b+7PQwvgV/ O0PGd0VpA3GIEDIMQ7z9uSIFYqy2G9uDoOmUx3PWklj5fB2UA1ovK/BrIT+F6LgfUd5R 2DeZdtE/klyyP+zi1Q3SBWq4hlyVDNcnQfXEyyYzxSMKcGUlu+2usE7OOtWI7QDVJhNh 3JCCCPxYErqcSDqK/ooIqBXmbS9YGvxhIt/H6OOyx5swYzPh8IjN8v24ZbyWu78uD4P2 vesbBOIYvdyu2gaFcfDhEVXqAcCw5UveTOZA6MIN/Si1tK25GyLJB4Osk0+SGYzs2HRc wZtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721231206; x=1721836006; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=itVRxRQ4fgSvCkmp4ZT/tO0ArO/vcPF2tBOypwTVJTY=; b=GDKr35wlo3HxfF7sRE9V43fW7gHiLtUsa8zl8JcsaBq23Hw/XezdQCeqjFqg43wqTi zeMxNsURxzP1Hm3/0+n1c+q/mUlEY6dzbdbWY5PoO9MkC4npQnZgnPCjKEthPzN+OfVd 2jOPCuqrGjFIYPnxR9VnKRLTPNUpa4EsvAZJ2OqAX8pT1l0z45Ls/YSNaJw45EqbvUpn aBIIsmoeM7IDT/ScBYfmTd7nHxGzUr9sbYtNvV7zQnagVAyM8VKJ/zObXjkK8h5lR1cY jNJ1QvvtDqilH08Q0DgYlH+dMObG9445yDvyn7NdoNCzg7z+VEy49BcCGfdTSnwmZzKS W8UA== X-Forwarded-Encrypted: i=1; AJvYcCWThJKIclrfqWY71rSqWu5hLOmFl0nJoorka53XmGbEcdpOC8VjjgZfaNCXEf1qh3L9I8OLOz/I7XE4X4+TZsH9sOA= X-Gm-Message-State: AOJu0Yx2dzUeopPqz+LRHUkvwQVSCMow2Xq36X2BY4ftcU0l4rdJGANg WRhDC5sqEYEFQ4WocrdAu2/h60LJwPzxEBQ5L9TDeZU7C1/fLpu8tPsvYc7Nmk4= X-Google-Smtp-Source: AGHT+IGS8IY18QSmrzGhSf+9nBg/8OXqPmS/hfbRyHNmZ0PhqQ2RvzORNPd8rwXPBcuIP3heqkOwVg== X-Received: by 2002:a17:906:79c4:b0:a77:da14:8403 with SMTP id a640c23a62f3a-a7a0111619cmr176072266b.2.1721231205823; Wed, 17 Jul 2024 08:46:45 -0700 (PDT) Received: from localhost (109-81-86-75.rct.o2.cz. [109.81.86.75]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc5a3a93sm460671166b.6.2024.07.17.08.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 08:46:45 -0700 (PDT) Date: Wed, 17 Jul 2024 17:46:44 +0200 From: Michal Hocko To: David Finkel Cc: Tejun Heo , Muchun Song , Andrew Morton , core-services@vimeo.com, Jonathan Corbet , Roman Gushchin , Shuah Khan , Johannes Weiner , Zefan Li , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shakeel Butt Subject: Re: [PATCH] mm, memcg: cg2 memory{.swap,}.peak write handlers Message-ID: References: <20240715203625.1462309-1-davidf@vimeo.com> <20240715203625.1462309-2-davidf@vimeo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 6B4D64001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7b4eejb84fkoyimw8rkjtg3s6t7hq969 X-HE-Tag: 1721231207-681101 X-HE-Meta: U2FsdGVkX19RF6f6l2ZMdEuWctmasB3n1qQQvSlfa2ZSBdfwnY6S4ECzDZaTESSwsbPujGmSsqQ58IDn1yFMNaGGRftaPZ8ZMP0LHiZI6dpprqAT0eaNDGqkxej19PZWoQwlrtw4oDmq0pYPXeuHOPfbJ4MMccyqOOp+89hSGaOAYz9/tBhy8lCePK7/40ze9qFEP/gzRrxG6V4silP8f2ygzwi2Sc6hAXfzNLsk+CMen3ldnFO6KZrDZL7Q0MvZpyxbcLdf4W2NGZ6ipL+LlB7tYs/kPqbXrTw5giwwcRCYgSjTZ1Qy04iCbUsn3hGhEaaZSATaVk6QdF1p7JCldBvjc1wlKjnpS4PBX5I6CXucnNxrsK62uD2ocaiAEX9Ry8aqqsp2sIJq8QUl1TekjnPxVlVBEiBZI3iEYMOpBr/pyeP79/5ffllx+ySZzUJFmkAMs3ElUw83U/3sc7rNxA6YuOU4LpjFZyVSCTT+nnt+3XyWq8/2HEpQiHKrZ4rWKqJFEjwXUfdVQ02ePK34omctN/7i0w05K5ngoNo9dV/Obu3pxZFOmypPQcBqMY0h1ZT/GJtxsPPiN5twRdXljEPxQyTvitsSrKGEHRgOInyylrNHXnvOkpg4uEpTCJx0AonJvOA2G7wByANL/lR6MuI+0YgHTeiapCFlHym401hyGRZE7LVU9tBkYuFOFSh4DoW28ZzAoNHfJmR33XEGHXB9d2oiUQHNeUuXQSMjtgE1f+7/inNCqM8E22zDPi2+xM9ba9ncRGsN4RxzWRSgh7mSyqZUZav3ufq58dtlAWHvoviqsPG7cjeo3t2WxAMzTkZ6okH6RPCiQQdJEB+FRXj9279MJcYSu3SPjEBcoL/8bMdvGxNXYf1Ulk/6E942nfg6DzZf2fof9+564Qar8MKzKy0qGJoohYPMjfm66F6Ci+N5+VBPs3aaw5tKSxungtebNacTRNzJIYnzZ2c jTU+InT/ zXn8p4n3KM0iM9vfkSK8HJf5C/PgNwFgRgrckNA8GDGXrS9OjRWpYE26ksqHDAZXy2RFO4I/eQIZ8hnfRVxmzs8jLq734A3Spy8Bq00mB7JsUtK1vv4mSD8L1fgqzquEJ8Ytb6Q34sBdjZjmkcqSC37gehykeMtOScIQ2Lg+6U9JMH58x3XP81GvTaaHTNfJZG5O8QVrsTVLnmg4AB/IyL4tvpPLwDrtQ7e4IGNArdK3ZrS1PqIKP7fVEpk2mtxduUR07idOHhS8ZjlEeZQ72MuSdzG/4mHjXDfUCwZFyfzJnrSEM9xRw7op7oReiQV0Gt1KvX4SHUpV4jrO+dq+eUwcDJ9y4xe70WR/oq+1is6+y0rut8rkdr4j+TA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 17-07-24 10:24:07, David Finkel wrote: > On Wed, Jul 17, 2024 at 2:26 AM Michal Hocko wrote: > > > > On Tue 16-07-24 18:06:17, David Finkel wrote: [...] > > > I'm thinking of something like "global_reset\n", so if we do something like the > > > PSI interface later, users can write "fd_local_reset\n", and get that > > > nicer behavior. > > > > > > This also has the benefit of allowing "echo global_reset > > > > /sys/fs/cgroup/.../memory.peak" to do the right thing. > > > (better names welcome) > > > > This would be a different behavior than in v1 and therefore confusing > > for those who rely on this in v1 already. So I wouldn't overengineer it > > and keep the semantic as simple as possible. If we decide to add PSI > > triggers they are completely independent on peak value because that is > > reclaim based interface which by definition makes peak value very > > dubious. > > That's fair. > > My only thought is that "write any non-empty string", is a very wide interface > to support, and limits other possible behaviors later. yes, that ship has sailed long time ago. -- Michal Hocko SUSE Labs