From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52DD9C3DA42 for ; Wed, 17 Jul 2024 07:25:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EE556B0089; Wed, 17 Jul 2024 03:25:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89E486B008C; Wed, 17 Jul 2024 03:25:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78C786B0092; Wed, 17 Jul 2024 03:25:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5C7C06B0089 for ; Wed, 17 Jul 2024 03:25:52 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D9E1540922 for ; Wed, 17 Jul 2024 07:25:51 +0000 (UTC) X-FDA: 82348410102.01.048CAA5 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf07.hostedemail.com (Postfix) with ESMTP id CB32340009 for ; Wed, 17 Jul 2024 07:25:49 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ZwMM8uvO; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721201130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zyNEJ2CjDStmZXq/bezWo1H2BjnQ1NOltp+UcNHYMQs=; b=z1agn92nBcLUYe2Y4KCIC8Mv73XNzL7VvoH8J0S/I3vioYpq04nTDcQNOoVQJWUlEmM5r6 sb95fV6MapTHYBvF0jFVIYikkN7jjGw7WT1QQNjbQCbIpeHd1hYZ11d/m7PlRiCKlYSzfM c4fxLj1hE73kiHBuTru/GKpBUtTWbRs= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ZwMM8uvO; spf=pass (imf07.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721201130; a=rsa-sha256; cv=none; b=sDa5Dq4BZ8ONbBIkKqNIpEUTN96yF69QKssRIxoFwCI8FcF207/lUZLaqNPqj5jRxgPag1 SzzMVpwjI6R2RIW1NY7ysB04w4wmDz9CIn+K04wkI7Xn0YYOuCAD9QFMvFHoiZcJfQdCOP O+a1mwzBuT8xPFJ4VIbWDLZmWHOXMk4= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a77d9217e6fso722981666b.2 for ; Wed, 17 Jul 2024 00:25:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721201148; x=1721805948; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zyNEJ2CjDStmZXq/bezWo1H2BjnQ1NOltp+UcNHYMQs=; b=ZwMM8uvO5W1PBmqQJZ3qg+MAr0V97aROubGLg8EDFXM+hxq5wxB1BDTTFbsQz07g6g B8rdsG9R0fj6AWiSDQuh4jxGTKYJ2DbAK3nCs1RVpugBeu001CCr39eyps2pnujUVhsF DrwmEe1qT9aZqwxRbFSDP5u4Qq+UEiXFbU0vVpJdgy+brQY1lYlI/vVVDyGE2BXpc3pQ T11IFcf253q9e/6sg/cWBUbESZeS3Wnl8Nf+48eN/+dORElnLFFsSoYp07cc7e+rr0kY K2Cr8MAqxNTIuiybKCiZT2YusC399LvQhWTylStcmb7QMPOirHq1gc8/pqYUM+FSFzhi 2d4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721201148; x=1721805948; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zyNEJ2CjDStmZXq/bezWo1H2BjnQ1NOltp+UcNHYMQs=; b=nr8uDyyzSotUaHAZPslgnds164jsgN6LXutpDyMqdS19FCDLfUnlc1CKoWJRe+Xqva psz2YI/a+40Itut56S9GaJxXM/rwTobvRxhoISGpppCw0n69ncgabx9E+2P4U1b0Xc31 d1HY5cOfxM0Kn4bhQLPDUQy/3rvNoqnNJ7RTMXd0MD4ghx/O7w3xC2jOPSJ6z5oANMPB v7astAmnd76b8+jPdazfEQoZ81S0XxHgwOpKJSoTEqnb6+Ycf7H8As+CV6LG2ORG+Pqh neFyh/D9fcRJyEYJiqgLIq85PQ+e3G1hvk13h2q42L/e+pkg/ljhczLzb0FnaCIQwoiP vgtg== X-Forwarded-Encrypted: i=1; AJvYcCViYv4noem4j7LOcXtANnSfMWwzNe8/QhRmjeFQFt1tHsj85YZcENay+S6b+itJ0yvWoaR/SNTeDqSlXzsWCQyxUNc= X-Gm-Message-State: AOJu0Ywx6lIfOp8CTuc+Q2v5bH7R8fVYeise6oyfvKv0pYp1eeFCGosN M3360en8fx9ooWGQfr5l50pk54SlBcGZx5PzT5CfOO7u0RVHlSxJ7KP/9BFxwKk= X-Google-Smtp-Source: AGHT+IHldCA0Kvfuc4j9iOIsN2k2QfRHmmcKeV/g8sdl2YYZp2EsSMhCl/uEN0fFPMPtavMAZ+Jv+Q== X-Received: by 2002:a17:906:234b:b0:a77:dcda:1fd8 with SMTP id a640c23a62f3a-a7a01153ed2mr49492366b.23.1721201148159; Wed, 17 Jul 2024 00:25:48 -0700 (PDT) Received: from localhost (109-81-86-75.rct.o2.cz. [109.81.86.75]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc800056sm423308866b.174.2024.07.17.00.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jul 2024 00:25:48 -0700 (PDT) Date: Wed, 17 Jul 2024 09:25:46 +0200 From: Michal Hocko To: Miaohe Lin Cc: akpm@linux-foundation.org, nao.horiguchi@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/hwpoison: reset hwpoison filter parameters in pfn_inject_exit() Message-ID: References: <20240716033516.606582-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CB32340009 X-Stat-Signature: xu3ui6u8zr653tibnye7nbaejo6wc8ww X-Rspam-User: X-HE-Tag: 1721201149-79118 X-HE-Meta: U2FsdGVkX193T3fKq3JNCnuGoETFQspc+yBo15uMSbYkZsDdQZac794lVZ8J4qlACSiK853znggECLFHuXRPhETlnAWSpeJTGFLMY09uCuUlQcO1nYr1HNu+q4dSmtSUOP5u36iDB7BczFdsPmdp+jzSQYzP4sZiUUn1e3IaD5AXd3HAJHunvnncvgoRALPfXe5QKZub26my4Fg4+EwTvHtjMzcqREKziTCWB/9o2W+ONzuZYXUgkxstksvYl8ajyuEcA4t8x0noo2JRe0V8cw8+2HUHbQiEj0n3xEI5TjWRqz0oQ/yViAfhIDWFcSCumAJbXKDNry/vQou9pdZY6dUebiDvZpQ6KCkuTs3Co+P2Ht0YGYXGGe2zXQnvrjQE6XwwYlvYcZjwhbpAnORr1UegrRQ1LaieyoiN0tAMmbsP3z2qirkh6XibmLCGRf/ZA0989mbecgsHIZZmvZM95IFip4lQ8OZqpMwXpqtuSXIZvY156pKOe0DYAwoGSUH60NGhuKG1610gcbRplwzOUpqDp0Aume4XluoyHkF65pT5SaCFO1ZPOa7zfFpFZYuL2hDa1cviqJChe++lreLRXIf+q5Zke59PZxWbXwxAUTfMCbb6yOBzq+By9hNFs4qilZMAzFSsqSDcPRL4S6O1qdMjm5caTNYxwHjs0xNXseybRD1aw32FQ56lewjNKGQ4jWEZ/bskMyNR2C6PukS5g83tV53y0kiWVOxMpIxVxdXlCMUSuocCA4nJ7M7fBzDyL0/qb/CP9tJw1zt1MUH3tD3KojFbuWoI1Kf8rJRStfPvY/DybtenD8kCHgmcsK4FfxkAljYCDnxoyXy2uqFusbkJeS0D5yvGg+5UQYqw1VG03hSeXF+UQMTsfuii9BSCa0KpL9bnAG+HGt9mKKc6EAxHMru8n7mcETGjhKrs9OPTMzjPA/Gte8DpPFDSVBfOEnh4IIGl/Myw/Tp9Zyz //HpnDFb Sk0n7xmXsVcYiF4GWb11mD52XjRsPoIzOEBqGAalFocpjzpGX9610Px6mFaVgnKLGAKVQTATaJWUcbdTZDNuYr8ty7ruSk0PTJm2qKk9MdQxUxvRElgCdEgDJ0BcSSlzFX7e7t5OqVJ6dVwVWcFJCpmxC20asaQr1BQ9uTyA3p41r/ek/xED0juWBy89YlIKM6bfJo8hHiHwFZmuC8ra1XMVy+au5tZKwt1mFvxBY+ehElAWQvJ8KvHFoUvXuZ4d6CwjN+vpk7gY2zjzmn6zblTA/P9lXYh7sTTBxIvXXy/Xdilynu32xOS2ei38SNr+sKsT7747F1MEocyQI1fayjqkUdJ/a1zrSQonnDqQjfsJVunrQw6EsbTthsya5L9BsPdOpT+Oxfsxa6pS0MGujMLOkGw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.014841, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 17-07-24 14:59:40, Miaohe Lin wrote: > On 2024/7/17 14:18, Michal Hocko wrote: [...] > > Why does this need to be done through different modules? Why it cannot > > be part of the memory-filure.c? > > This is a bold idea for me. :) I think it can be part of the memory-filure.c. > So CONFIG_HWPOISON_INJECT should be removed from the world and then make > hwpoison-inject default on when MEMORY_FAILURE is configured? I would start by moving code into mm/hwpoison-inject.c. Whether this should also remove CONFIG_HWPOISON_INJECT is a different question. I am not really sure a debugfs interface warrants a config option. Anyway two things for two separate patches -- Michal Hocko SUSE Labs