From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE67C3DA42 for ; Wed, 17 Jul 2024 06:18:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE0CD6B0082; Wed, 17 Jul 2024 02:18:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A906B6B0083; Wed, 17 Jul 2024 02:18:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 957BD6B0085; Wed, 17 Jul 2024 02:18:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 77AF96B0082 for ; Wed, 17 Jul 2024 02:18:38 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1D9C440902 for ; Wed, 17 Jul 2024 06:18:38 +0000 (UTC) X-FDA: 82348240716.17.53C95B2 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf29.hostedemail.com (Postfix) with ESMTP id 3C7EB120019 for ; Wed, 17 Jul 2024 06:18:35 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=EM1gKwcN; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721197063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ft3uDiuXc9eH9qPA+tznvZpzXYRNDs/NnXbEjvWw+aE=; b=C/cc+klVCxmBzCtPiEHioAh+dxFuUznGH/dkqtNqEf8hBvT2osPGUYwH+IilIWvb+SmDN/ ZaFQTKzMgdeJrisUHczLRPar2yscGIwZIdG4CnXQSrz2MFl16Lkipnpxn1dt2uXwe0udLw D7g2ZeD5OEKHnO7YSXlfLec3X8lpFNo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=EM1gKwcN; spf=pass (imf29.hostedemail.com: domain of mhocko@suse.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721197063; a=rsa-sha256; cv=none; b=mOmq2pUU+Qohk+bZrV+6RFSVquirwJ/+XO2bsT4mlzxNl9gBIWqRrlmIsjVyjgbIrP5VwL WDynhRJGHQ+Yt3pVHHrTz+z1XGEkhGn/n/wAtqkff2hBpwKTDmIzuVLFYxfIxhErT2f8Qk TjBhfmpZYB73BKK+l5ToFd54F5udZAU= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52eafa1717bso6475436e87.2 for ; Tue, 16 Jul 2024 23:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721197114; x=1721801914; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ft3uDiuXc9eH9qPA+tznvZpzXYRNDs/NnXbEjvWw+aE=; b=EM1gKwcN7Blc6Snv/v3HJN6GSCMUnZ7phsO1S0VIC9bqiCcU27Alk7TkjyN+XPbxlQ draNyi1LQRq9JPDlq6kGUF44Usylcmr3upcRyrFKXMSBuB+O3xvGhsZSWz3CrnkBjEXm barThSiRrx/7jH1pQ9xngWLuSyDIL/DEpxiB4akcRVGBPCaPok7BYsGPoCgNtuj7t9ld GorWQ1HAsswGOOE105y3+QrLjPQoVZQyBLOmBuROtpxvnJ0WUCUTZYY+FpA+Dwul6wnr utG6aDvoCI3wIay2qm617OcCqy7hFSSfzZpana5YpITI0NILBr6HhLwQ+pxjts3ZDTmP 18Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721197114; x=1721801914; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ft3uDiuXc9eH9qPA+tznvZpzXYRNDs/NnXbEjvWw+aE=; b=Yz37m9VuAwPv6S2kWNTmFqx9x1hR6TeFAWg59XYVAwKFOnhN/vtW2nrkhSkavWgAkO c+ZQyKFreut8qSWYXWaoYqRppW6vxRXEpx59YJUZPtTf9v4AWEpTA3hXsLKzuHVtKSgS S907vs0neQUuf+2jicw8VhaevkXJYonpBZsyt21dHJ/MGEIE4wHjl62mVAZhehpjwgmr K8vWJUMeXbkcyINu5rRt16A0wyfOi7enkZ8YzpL6oI326sKJYDSuEs6BPVIvww1gQ8QN Jl7A9dYgt3Ri8QOKZsV9flgrSrJvRGhOARBE2UcY4q44Sf7itSqNinsEAHIkFqX5CL/z EKYQ== X-Forwarded-Encrypted: i=1; AJvYcCUhzx18mo8xVc41SG65tOHR1xFkMKkP9W5BocmKq9k/vfsf5FbQMRTg5Ng23mjjo33qdqG3AEAQkTMCI60jKDyP1zg= X-Gm-Message-State: AOJu0YwcKrFkjcRjMEUPRAY71GTeCqvDzPfjVJgXqOB/VxsSZoq2SccI t8H5XYU9MsYQ06j4kilnknLM87yfXV9nHWntJqQiJtw/pbibcYECEPEheOxtvA8= X-Google-Smtp-Source: AGHT+IGgWbb2IPkjfEDoNx2g+eoVjB/B6K526lBWKCCRxuVqxHJLxM76gIzPizZ7r48jQdJZprEGsA== X-Received: by 2002:a05:6512:3d08:b0:52e:9951:7891 with SMTP id 2adb3069b0e04-52ee544b0d6mr376783e87.53.1721197114165; Tue, 16 Jul 2024 23:18:34 -0700 (PDT) Received: from localhost (109-81-86-75.rct.o2.cz. [109.81.86.75]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc5ea482sm410071566b.92.2024.07.16.23.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 23:18:33 -0700 (PDT) Date: Wed, 17 Jul 2024 08:18:32 +0200 From: Michal Hocko To: Miaohe Lin Cc: akpm@linux-foundation.org, nao.horiguchi@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/hwpoison: reset hwpoison filter parameters in pfn_inject_exit() Message-ID: References: <20240716033516.606582-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3C7EB120019 X-Stat-Signature: iqicgyj6mqtjm7nfi8fkkq88ba83zzmy X-Rspam-User: X-HE-Tag: 1721197115-4103 X-HE-Meta: U2FsdGVkX1+M9HpjX7+r5HcyVHQ8xCA89lCORZcLw9Vazv67tKuzSw/zZro7IdWLt59b3AU7wuGOt+W+LWGN4Hff3hi8RhTO6vOealW90OpHB91B4CVhQes1opokFCivYIveFKB89RiVWQ9exx9SruUI43SEuJMxA5zAixhFknzTJgS8E5QbVrs7sCH5T3icGLI8uHD7YunjDpVKIgD68quI0B7HJge3npQ2qNKcJHJfnr3paAeK7ofZDpJLVI9fhvfenBYq0/GCv7JqPReJ2vSw72dluyB0yzZ9nCh1xREQQNaoNR72tk2OPNjg1kbumhTnA9Hgj2/m8og3FcXhrV8PbEpwON/nLfRxdarH5ui1j+vRVxbrL0p74RKuckMssWBDBuCDnU69wVpRMsqnGA3G0nngXPHi7XF3CXddjgK1RBuTnr/rsB61VdLS0toevmWmRtksCeJr4v3azPY+K5UdE2VyVNKABBeV2d/11iit0pRmYxiwSgOvHOC8zYzup3D9l3yFBzA4e1Nl4PkzmEet0WwLxg0T0ltshVW4TC+qyRE6dNUyZFdj0jeWMrE5rrFvMd53LZFiGT6OmWUB7SHS5rJJjSxm8xj8arEXG06KwFlAaHS7Vtl0Avh9PlBIX+3Y2G2n1P9o8zB0/Twoh8InVhs/m38HAKGgzJbeqYl8jmGDlREeF1Nq2mmfQPC8b4mY3e0Eod4It5Iti2v2ptIgCo/laSpuvylzIFqSW5TsPMmst6rfmBQDByNg/QLHDSaI5REWmguF0NJbvcCpugL9JtAWt/2SFeIEdg4O6DlkwYTrziPRyFifRWDiQa/GLFWtGXzAKsAItLhFd6zx2xL2pJKyCNin9OMfekJhr3v3LYIgo0oV7uC2DvAK18ACxawATquzBINtd5Zlhj5fkG1s2xyMlMtS+YRZ7KBP2Wjnlynflr1ulaZgaNgm0q7SOcQaEcu92xVeDMDq5Ll zIvBWqVQ GCrRSJ9eYA/qLRSF+XB59OnVJVGiTXAB+xQFMIa2NQ1HRZxRpd0RoX2RZ0tl4N9FMnKrcvsR/CIcLGSIoBBxNwNIIoWTzFIz2gaD22sKJHvtNNyRaxl1tOWY5CvPu4phno8FFzLlhs4xMekzdTj81AJ1gx9mSq23ynxJDj9tboe9rbCap+kbe+YRyPDyD22OYRdq0LpOJSKLDbTxJDLHfFrB7ayFl6d0s2NSTrXTArLoeDO+TguaJtkuMAV0YnnCpQCuVkwgn/hYiigLMCe2VPZHy+jWV+LVYiAe0W86LYHWVo6oQhEaV06pugPjEkaRodHfO7giu9nNJXxTpxPillqAnoCD62e6EKaBw3kDZcjnU/mLAgoMSfBUB/zPCIxXSo1Q97u0F3Ny8cP9p/Mx2B5A8aA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 17-07-24 10:23:06, Miaohe Lin wrote: > On 2024/7/16 16:38, Michal Hocko wrote: > > On Tue 16-07-24 11:35:16, Miaohe Lin wrote: > >> When hwpoison_inject module is removed, hwpoison_filter_* parameters > >> should be reset. Otherwise these parameters will have non-default values > >> at next insmod time. > > > > There is a clear layering broken here. We have mm/memory-failure.c using > > values and mm/hwpoison-inject.c defining the values. Both with a > > potentially different life time. Shouldn't that be fix instead? > > In fact, we have mm/memory-failure.c defining and using these values while they can > only be modified through mm/hwpoison-inject.c from userspace. Yes, this is exactly what I mean by broken layering that should be fixed. > The common usecase should be: > > 1. User set hwpoison filter parameters first through mm/hwpoison-inject.c. > 2. Then doing memory hwpoison test through mm/hwpoison-inject.c. Why does this need to be done through different modules? Why it cannot be part of the memory-filure.c? -- Michal Hocko SUSE Labs