From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC63C3DA59 for ; Tue, 16 Jul 2024 08:38:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAF396B0085; Tue, 16 Jul 2024 04:38:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5F166B0089; Tue, 16 Jul 2024 04:38:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B26516B008A; Tue, 16 Jul 2024 04:38:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 95DBA6B0085 for ; Tue, 16 Jul 2024 04:38:46 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3354F141355 for ; Tue, 16 Jul 2024 08:38:46 +0000 (UTC) X-FDA: 82344965052.05.41B0F9C Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf15.hostedemail.com (Postfix) with ESMTP id 350C3A0027 for ; Tue, 16 Jul 2024 08:38:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fM+g1Ei5; spf=pass (imf15.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721119105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V7uH+X/kXufVOwwqdWmlv4iHyPanTfww+ZGvsG9tFG8=; b=Hq8qjtLzbPvnqG7mT/2P9kOxNO8s9Pn/T1tXASzf1jU5GQ5I4zOoZzZOZpJhWv+cQc7+Qx xRTyt4jz8f2/hffoOEsz4r5Ydx9SK8Qi8XBPhsDc4meBdZ+1VpuE9wdBtMKqQDYGdHA537 R7SQ28SaHglStq/ZmJ1wK2vBr8mvBiU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=fM+g1Ei5; spf=pass (imf15.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721119105; a=rsa-sha256; cv=none; b=VzpcqwFm9i8HLxbKsVbMzHRdw0i1LIkz9nMEZd+c9sLA+3Gy1PcTlnM/jyrcvP4dVUT88R 101fV3RDF4K6lyX6HFqvhccrp5Tl6BqQkC6hmTUep65m+C0xyo8aPWf3CrQg/AQsIODzGX K81R1DGaJJWvOrKcNe/NyTfN3G2Q1s0= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a77c7d3e8bcso652062366b.1 for ; Tue, 16 Jul 2024 01:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721119122; x=1721723922; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=V7uH+X/kXufVOwwqdWmlv4iHyPanTfww+ZGvsG9tFG8=; b=fM+g1Ei5DYMW67CIR3TIUI78Rp0BXGIX7ea3sduPBBV4qcwQYS2vCOGmrwCBBsRdXf A7Ks4j71TOeIiyJeQITdhr2lYcGFj7PqBdC7AJj88oHOulOwsVrItxyqllNHr/O5pT2g 5LOuw7wvr/MSOQDWioOiNMoKT0FX9W4aWK2YkZemCwA6i5hSIys7f/u0je1ztEvBUuFR 4G5mBWN+9t4qtscp8jWzU36CR5kSsoSIPFoWPA+QkSvX3AZW85tD6zMSw3GxfwW5BFGH RSnkrNkZ9BFt/+8u/20RqDNciGgfP0yFGueR5N1Cs8NMNZQkdBvTeaRiCNVM0tZqLLZs hgPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721119122; x=1721723922; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V7uH+X/kXufVOwwqdWmlv4iHyPanTfww+ZGvsG9tFG8=; b=pa/aFmTvIDL109NeNhRYmjBGoZn5hSiadejoyXEnGTJhe1NuaTl5jCqUmcoP3WgtNr yeq2shgKjonWVz+/f5Jc1dlmZsI2kgLSyHJatI9c1DS9vRSaXTRtnnAkrGp0PB4t4Trw JyEEJyo2AzA8j5S3BaiC9h1/X2AGFL0ex26vGruiL+uLNucQrG950/LI4BpygpSS/wJf yQdfzWNiSfO3gMS4pH+HXcDQGJAxILcUdr71A3ydBl4lsbKnQIa/5KlH2Bi+8MkPKDsF IE+aNlO6vrtJsMNPBzEhRW/DjUsS63jvpKGdVBZJ5D0X/9fpWkhBiJECw1jTSqKmpprf zZXw== X-Forwarded-Encrypted: i=1; AJvYcCV1/wxec8wF7mgD/o6t3QoISilWlBy31PF4UFvga+uvxzxqy4PJOweIJ1B2ublPU1z9m5GEQkmhoUkWWk2ZxLYAT5Q= X-Gm-Message-State: AOJu0YzWC1vsK+UmRD5yZqfZgJ/VT9khXhslCkqATIuumc18MWa6EmTb wiPlcfP/HnQyglQr3ziMYsSWr++htn1FN8R185wNtdkNCss6H2a9Vxg+xWk/xn8= X-Google-Smtp-Source: AGHT+IHK3WhdLwyoATR7rg7aAkU5WgoIseDDBHwrGI8juwQQ2tOm31BysCr6fu6ZI61YUKWTDUucTg== X-Received: by 2002:a17:906:a399:b0:a72:40b4:c845 with SMTP id a640c23a62f3a-a79ea9342f9mr105809766b.51.1721119122566; Tue, 16 Jul 2024 01:38:42 -0700 (PDT) Received: from localhost (109-81-86-75.rct.o2.cz. [109.81.86.75]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc5b7ef5sm286159466b.82.2024.07.16.01.38.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 01:38:42 -0700 (PDT) Date: Tue, 16 Jul 2024 10:38:40 +0200 From: Michal Hocko To: Miaohe Lin Cc: akpm@linux-foundation.org, nao.horiguchi@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/hwpoison: reset hwpoison filter parameters in pfn_inject_exit() Message-ID: References: <20240716033516.606582-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240716033516.606582-1-linmiaohe@huawei.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 350C3A0027 X-Stat-Signature: rfhcs6aryok484iw7h546wp9qm3xiucy X-HE-Tag: 1721119123-786693 X-HE-Meta: U2FsdGVkX1+iUqUFi6SpHR0LnpHbfgSQsokSBSiO1eaIUbSpEUaTxY/xLRvHn6hyn818VPRZhekNtFGn8psSWpif7d5RSJZfYRFQDPq5iTtk6m379daHF9vPEjxif0SHy477UUcvWudav+YJTIpV0SuJDCeiv5+zKzyFz/xXVos6W6xaGdaL6yhkTWPdoDYj3re1Bjh5gVQ2RctSBKDkl0z/uyHto/5psp2uNFbWTxpegNVSFkpRu9slwdcAiqYKwHDX655CQww7WgCiNCAzcHC+zLHaTkqoL1dEzmh94rVIahLRyZzbcQbAXs/HRQWqjK56nNWfvHCjsMfq5gMe0dsm1Eow5B4dvcIWQoXKW0K+ANiDP8RhC+G+J+2F11dmFHVHyKwUxXtXS6GyHpupYGbFT9V6YLx4F1mgMU2Jg3z82m7nzEcB3RNYCIkiL/uvzqliSbrpQVwZr8NR0ObcmFkAlWm8eJlKLnBq6VwLty9L8WyjmxpAQ0UDWJpsr0sIVF7qsO7K4pcw8CFD5gcfOo4DBDUpj9ilEmWRoKIRjAevZFXbCIB3QPSYdYxsu3dowqT3Qj1YetKI5jTY4L/Dhglgu2styl7dy6e7o3EQ+jExb5NKOZUQMuEyC74OvhAQ9RutZoMCY5H3zP4vD3fJ6mNt4PgDCebz7pCLsi8OdlHAE/3yNPzn17ns6Za5D+BNOxG+/SOb4FbZ5eVqhwKmpaDIqV8tiPJVd+loja1KzhcQyMsqDCkTVxfrrC8w/htlMA2nV0HoMGjdGYK2d6IEG5G8ElH63gkxlbtbszS78sx0/Phg/ZOwa8IF3lxVy32+B7UU9rtbeqEu6QdVJr4op15smJ5+jDeYZn4FN59m9nqDNenhAiMCidPSzmjh4viO+fG3XIMpA3dtffG3M+SMxg6gS3nlae72It2qSQcTB/KsG/Yz8EKi8ImPvGvksTKp4xU/cRDQrdsrQXJNiPN rdxX+iux RJbtC/3KBwq1of3IutyTUU1Hasp0kd78/oND2FqCmjgblHAoiDe9wghrLTjX+1Wo84EhbIDHARKgd3HEXRnHLIPd6uvFtSbFEZX/5c13JI5IR519PX6Qsfg7hD/Ok7hZBagWJdHYtlORQSLabl0Cwov2qNgWBHkTaMI48OLyUajavC3+qaFiPgHiQ1grl+88m9ZRqOltrnmRRw5RQq/XELwETULm9pokR36V3zKp6rDdL27D2qas5U+FxG8Grtu6aw2g8BGGPmGJcq4kq4TfwEiw3PjNYnSgqzVCy8dRCIPkPTfp5fJ8ZcxADPvHrfJRJh76B8Ef3ml85u0VNwSYIcrPghJqbrlr1ZFbnHjs2IMcfUik0cuSPl64imRi3BB/0P+5CQ3D8DVgUayimltvF0ny+Gw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000492, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 16-07-24 11:35:16, Miaohe Lin wrote: > When hwpoison_inject module is removed, hwpoison_filter_* parameters > should be reset. Otherwise these parameters will have non-default values > at next insmod time. There is a clear layering broken here. We have mm/memory-failure.c using values and mm/hwpoison-inject.c defining the values. Both with a potentially different life time. Shouldn't that be fix instead? -- Michal Hocko SUSE Labs