From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 999D7C3DA59 for ; Mon, 15 Jul 2024 22:18:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCED76B008C; Mon, 15 Jul 2024 18:18:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7FAF6B0092; Mon, 15 Jul 2024 18:18:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A481A6B0093; Mon, 15 Jul 2024 18:18:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8686F6B008C for ; Mon, 15 Jul 2024 18:18:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 33ED4A38C2 for ; Mon, 15 Jul 2024 22:18:50 +0000 (UTC) X-FDA: 82343402820.25.B1EB0D9 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf27.hostedemail.com (Postfix) with ESMTP id 8CCC140003 for ; Mon, 15 Jul 2024 22:18:47 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GGceJGDY; spf=pass (imf27.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721081908; a=rsa-sha256; cv=none; b=JQ+WfzHq3coFiUFn830DorFvyI3pl7BJTpeUDNftgVuhtr5meYWd9fAQD4lanzS7xPqVO+ RPM7unYCm3G3NPftRFvK2KZGbVJQDoIkJM1NyYpYmzNjnObM6Sn6k0uiXHigQHyhOl+yuV p3LfYcRnO4NeQW3Z9nFjxNH5KjGbVXI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=GGceJGDY; spf=pass (imf27.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721081908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X7bEFxNiJqRfyC/mXt6ygUCHixC1nCej/Q7vGVmvLrw=; b=ZT0fdOrZGDbex9PHtPqKpxYDNB/xwHQpvjIjFqrRBuRwljbVvbxqgrH0xmR7ASHszdMN4F SgtB8TTWIBQjYVoc7g0WkzP42TiHmZwC+DEirmb/qW/JvwIXEgp0kuCTdeFWRPjwGvbj9k /6EuuJVNO/Y/fCbyaY2qxtqHgI8iLRg= X-Envelope-To: oliver.sang@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1721081925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X7bEFxNiJqRfyC/mXt6ygUCHixC1nCej/Q7vGVmvLrw=; b=GGceJGDYQ/HGmUtPaoTlyt96ECaP1FIhIW0AY3LKqmjh4Q9yhl4Zj7AY/FDB+vi/7SAExK a4pqcAtHvmdSImaH3nCx721Eqy/xNaljA/ym5F8sht88enRNAOGHQu8Bo5V97612h9ELFP IP9Yq5cjcXyv6qDDX/bLbv1T5AUpNGE= X-Envelope-To: oe-lkp@lists.linux.dev X-Envelope-To: lkp@intel.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: shakeel.butt@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: ying.huang@intel.com X-Envelope-To: feng.tang@intel.com X-Envelope-To: fengwei.yin@intel.com Date: Mon, 15 Jul 2024 22:18:39 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Oliver Sang Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Shakeel Butt , Johannes Weiner , Michal Hocko , Muchun Song , cgroups@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [linux-next:master] [mm] 98c9daf5ae: aim7.jobs-per-min -29.4% regression Message-ID: References: <202407121335.31a10cb6-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: rycwg7gb1s5xrtr54u51iquut9jajopj X-Rspamd-Queue-Id: 8CCC140003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721081927-902201 X-HE-Meta: U2FsdGVkX19vbWKukc/WUjr3+HNw0yH1MY7+oyUm3NuUOMyfLzcMcF8fbR/zvJFyLecY7xbGocSWsWHxjKXe+728DK8JLQjQNFdwJ37HH7THSSdnyoosRGO3ogbAV0n/8iQaIJPALHl7Y/wvN4Sc/m+v6GmPQJcHcfmYDFC0fO6eU97swPFjgSZSlrA49ZdjQnQpQ0cPsqdAsFtALqo6TEgwkf6ZcopLGEN/6pEenPeDXQdI1XJH4WfHFYr5WIXf5+WvvTQ9oKt277LJhj1MMzc36R2FJGMwFfHHnL5uaDtHnA5yphFlgR3ZX4kKFDHHSLYCdXtD5VmNBDonxKCcwVGmx86k9L77w+Ubg129XxV1pJxybFk4/RiXjsUcQ/u4D7m04HkwdiVSmBo6lZDBQxK/aupKxuv9zW7QPQp9gxLBQ2CckfGvr4Qw+WVHtPuRGRwoRLaB0IHByS8YIIGiKySK0Ok/1Ra6LKUGHjCPoB6S5ixENgdC9EOYE6eIEBKHEthS7+eelCGWGyEzklsCry0x3oJxFd3Q0qGL5osXgp1ig01Sr2UgScEKf2LaHnBiVbLr0JFFJ9bZGMMH1RJrjuaO0dHbibZf2SA/UGU+4G/0lTsISI8DwHHpb5hQI8PNwctLefFbeXIs67m5qVfsmNzug+VhjDrmzTC77hz5Yj7FvBDZRKDGDpgGqO+q7G5N1GHxwzTWFFwYzUya/EBe3hcRvSiVlgH9pZS6Dkeubn8DraJrIXksYXLRS70edEbDp96w+b3rfh7uclmufGzfqY17q6lnToCvY2h3/4lIviNSzdyQ7CgzYxpbBc6DfhLsS9A/FH8cOIQK61AWc1zDc/MKdiapHoVGUeEd5OybrsFoR3rJOVpTLN90xyIafvJsg2PQRg7ZQJhP1VhaZ9G8zPBf18GfSl6mvpwouRPQefMVcnghlPSsJFnYhP4JnwtClTx75nBd8OMdmF959bS W1RU0npv Qf0X8u15xRNfQ38+T8DrAfQKLEyib/gyrTX0xYETlmEUzliXbxQMRUFx76v4a9BoO7NokAYBQzFZIS2UspVyXHPGziP7YVZVuwvZAcbDdHsVjrYuqgU/LBmITY2gX0a99MrIbNHgel8/QnAp/RCJtIfgWc97aPWbRecNlQgU3Kakpk31oJipxvqhdTAtVXu7gyMN/3Fh25PSjKHS28aB1oxr1xg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 15, 2024 at 10:14:31PM +0800, Oliver Sang wrote: > hi, Roman Gushchin, > > On Fri, Jul 12, 2024 at 07:03:31PM +0000, Roman Gushchin wrote: > > On Fri, Jul 12, 2024 at 02:04:48PM +0800, kernel test robot wrote: > > > > > > > > > Hello, > > > > > > kernel test robot noticed a -29.4% regression of aim7.jobs-per-min on: > > > > > > > > > commit: 98c9daf5ae6be008f78c07b744bcff7bcc6e98da ("mm: memcg: guard memcg1-specific members of struct mem_cgroup_per_node") > > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master > > > > Hello, > > > > thank you for the report! > > > > I'd expect that the regression should be fixed by the commit > > "mm: memcg: add cache line padding to mem_cgroup_per_node". > > > > Can you, please, confirm that it's not the case? > > > > Thank you! > > in our this aim7 test, we found the performance partially recovered by > "mm: memcg: add cache line padding to mem_cgroup_per_node" but not fully Thank you for providing the detailed information! Can you, please, check if the following patch resolves the regression entirely? Thanks, Roman -- diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 60418934827c..3aae347cda09 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -110,6 +110,7 @@ struct mem_cgroup_per_node { /* Fields which get updated often at the end. */ struct lruvec lruvec; unsigned long lru_zone_size[MAX_NR_ZONES][NR_LRU_LISTS]; + CACHELINE_PADDING(_pad2_); struct mem_cgroup_reclaim_iter iter; };