From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D3D6C2BD09 for ; Fri, 12 Jul 2024 14:43:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80CF36B0083; Fri, 12 Jul 2024 10:43:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BD0C6B0085; Fri, 12 Jul 2024 10:43:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6847D6B0088; Fri, 12 Jul 2024 10:43:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 494C16B0083 for ; Fri, 12 Jul 2024 10:43:35 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CF482C0B9C for ; Fri, 12 Jul 2024 14:43:34 +0000 (UTC) X-FDA: 82331369148.09.6B57DC8 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) by imf12.hostedemail.com (Postfix) with ESMTP id CE37940008 for ; Fri, 12 Jul 2024 14:43:32 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=debian.org header.s=smtpauto.stravinsky header.b="N/z5Vvml"; dmarc=none; spf=none (imf12.hostedemail.com: domain of corsac@debian.org has no SPF policy when checking 82.195.75.108) smtp.mailfrom=corsac@debian.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720795385; a=rsa-sha256; cv=none; b=quvh5ICESpcSZC55n1RL9zmtWkBchrvSiKKkUFjZDTk4ZP1c+nUtdoH8qZUCTYn2ge8Acd /xpP+MyQ1r6MVm4lKQmLL4UpI8cDEcY4gsBpTnfhLZPC+MLU/UuI7fVF/EgBGGj21RGdU1 /SyCRD1WaorBI/G/ueBxjuFXXU6vMW4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=debian.org header.s=smtpauto.stravinsky header.b="N/z5Vvml"; dmarc=none; spf=none (imf12.hostedemail.com: domain of corsac@debian.org has no SPF policy when checking 82.195.75.108) smtp.mailfrom=corsac@debian.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720795385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DogGsreGZlacWKpAGSJpIB1wlRRqT/2GkqnxKuBXHqo=; b=HCcftrksuyxXe87k/p4qmG2xTCHDYTkyZZIvJsDidNqO5uMkbC0USIa03gRr7hklLtd0LM H0WTTUg9DwVE2K4FPWZib7eonRmPcQ4nfFQ18Ztno6fsB29rxiMRz2PEX3x7ewx3hByDia kUUUrEKKRHDvkLGafRBaLz4I5/tGdpM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description; bh=DogGsreGZlacWKpAGSJpIB1wlRRqT/2GkqnxKuBXHqo=; b=N/z5Vvmlhs85Il9/7pdtp61ewx yRrto5KQLNMnayKJ1+6Pf+jbVXyZNe24SIX64SKnTzbNovs3HohNz+aRVucHgyIEUdvtlU4FPG6vQ iMeeBY+RavEiEQtw8hfX0fO92YZBF1DHGojaISOryL7wD0J0EFcj9ejjkz8AAtcjbC4MzhRop8fuP tx3qZ672TH5qzpNsIiChOqqd4rY4zQYh06GR6K9h5sCgHT2cXhTN3GgWmMFavyniatTX88PIYfFcS v/9c4bGiAtPBumcrBkTEeatF6gxs1caOgIhdYVKOO/vFNS1vyC3djOPP2uhg3EHrX4UXTBtTGZIZH f/ZtHbJg==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1sSHUX-00BSVo-Qi; Fri, 12 Jul 2024 14:43:21 +0000 Date: Fri, 12 Jul 2024 16:41:59 +0200 From: Yves-Alexis Perez To: Yang Shi Cc: Matthew Wilcox , jirislaby@kernel.org, surenb@google.com, riel@surriel.com, cl@linux.com, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Salvatore Bonaccorso , Ben Hutchings Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit Message-ID: References: <20240118133504.2910955-1-shy828301@gmail.com> <2d7bd8b2b9736d4a7d0a26169978372b5e002a62.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Debian-User: corsac X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CE37940008 X-Stat-Signature: aauj5jda436m43axuafi1udpo4p1zwk7 X-Rspam-User: X-HE-Tag: 1720795412-583947 X-HE-Meta: U2FsdGVkX1/bWAZLRaqaqhvy3mBR20Q+v+UhkDuhX2Sdi2nbQnun3dUtTQgQwFbKY7/iXsjbgSMni+exoC50XwgVZP/AZvNlNq/TQfPF6p0aq8l1Yp4PfVQFnVM6dEX9iN/wctRy42a7WwYAs+XlHvnV3VS2gzsoDQ4WXSU0bM3ZvJVxaPuPe2GQ4YDY1LSvS4yWhm/wGNAdfRqS5n1Zttn/1TIVOPy/rCrPM34XyY94YIjhpKDWBkP0z1DKodncXx/2xAUc8GlQVYUZ/KXLMJHcUcAgQ57rtZaGnZ3RARkTTE60xqp8tud75A1TAadRQ5ac8sKqPMsJhDQtOBB86bJgauhkSat4REtiJCX39UiirorP461QaqmKSSDqGgcVCM4NQWg2npbbMPK7mXMKawFWyx6jzqCVQ4QysTST7YDxndnuU28m6hpE1TC2h81f7lRzedDiaACVD2WHmBCzWuN+Ok9qIdUdk0/5quCz7aVkA4n09TLVQY69MS7PO/WOKMFxqt+ud7tQl3Li3J/1OIWvs0iInckCR4S7qNF0Tu5Eo4hwN045ylWJh2PBBz2NBhTFevxeH2bIYedd0GmjY+PZbFYh04yHxkBN8XR7P3Js0h+zbOficzfqCsOsdDxwDIr1NhNxWaf+1MabjbwZpcduS6l2zjJDtyjqHp2Crhfn2P9fatKcSEUwPHTumkImdmqN+ubpyot02aKE/oj7r3L3tlvO3y0lTJDdyFZnLrQGgz9Sf2JKKzh2mIyI62hnywnjalL2uKTvxzI5l8+g7FnXKNPOmcb9rYk9LkQCiwGkiXF0HlpKoeVoM+l3PWQtYTFXxZHQFg3sUM9oXTQ+ixTaoF8k18vhzL5kequD//nVtx3DZFAVpvaN2od8ZBfBzaxvzYVeZiWBoKz2f91Sp/8FqrEYw5GTqzxA8rV01XbBZjl3TnFliIbKJL/loGfnYRCh0nPdjGF9tluOwdH aVYWb4XM fmtsmNoGc9PzkOz+2g62YctuweL4+7h9kNmo4PoS7O29QT8GY/QMOq10H7gpbbXiK5eAevgIzKEFD5wbJ1Ra92+btBJ16XF3CPr8Tlt80zfrMOUL0fr1VbQTyW29wP51yNhxXE7YhD70iGZ1YfBinOxtX0hIm6zyoMo8Zt+sgX/W5SfzuFLZphgOIu9nrlDPi7KnT+NS2rOLYAPvs3yYgmvwtQF2Te9XgniCU+KQq3IWY3C92JoPk+kxWTT1j1PVdT9mThT9mO3syQc2a0cmHuanw0Ccccy6t+H6KGOGZgptZY+iQq+2tpQ8wmgnU3NUbnUahi4IhWMNczf6xgB1l00RE4SbF4v8PovHay0ZL5WXMqa7NEza5U0k42SvqSYkoOvNB8oVzmbeUAV6eESFXih+ptf+0lkOM2PbxQDu58skpnDpFAPNp7Ic2rg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 11, 2024 at 01:53:04PM -0700, Yang Shi wrote: > On Thu, Jul 11, 2024 at 1:50 PM Matthew Wilcox wrote: > > > > On Thu, Jul 11, 2024 at 01:47:00PM -0700, Yang Shi wrote: > > > +++ b/mm/huge_memory.c > > > @@ -857,7 +857,8 @@ static unsigned long > > > __thp_get_unmapped_area(struct file *filp, > > > loff_t off_align = round_up(off, size); > > > unsigned long len_pad, ret, off_sub; > > > > > > - if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) > > > + if (IS_ENABLED(CONFIG_32BIT) || IS_ENABLED(CONFIG_X86_32) || > > > + in_compat_syscall()) > > > > Why not: > > > > if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall()) > > Nothing specific, just didn't think of it, sigh... > > Thanks for the suggestion. Definitely preferable way. > And I just did a quick test rebuilding a kernel with !IS_ENABLED(CONFIG_64BIT) and running on an i386 Debian sid installation. I can confirm it seems to work as intended: Before: root@testvm:~# uname -a Linux testvm 6.9.8-686-pae #1 SMP PREEMPT_DYNAMIC Debian 6.9.8-1 (2024-07-07) i686 GNU/Linux root@testvm:~# for i in {0..9}; do cat /proc/self/maps |grep libc.so |head -n1; done b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7c00000-b7c22000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 After: root@testvm:~# uname -a Linux testvm 6.9.8+ #1 SMP PREEMPT_DYNAMIC Fri Jul 12 15:23:07 CEST 2024 i686 GNU/Linux root@testvm:~# for i in {0..9}; do cat /proc/self/maps |grep libc.so |head -n1; done b7cf3000-b7d15000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7d7a000-b7d9c000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7d8b000-b7dad000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7d4b000-b7d6d000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7d64000-b7d86000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7d15000-b7d37000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7c9e000-b7cc0000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7d68000-b7d8a000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7cf6000-b7d18000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 b7ce6000-b7d08000 r--p 00000000 fe:00 933 /usr/lib/i386-linux-gnu/libc.so.6 So: Tested-By: Yves-Alexis Perez I didn't try on other 32b architectures though. Regards, -- Yves-Alexis Perez