From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D248C3DA49 for ; Fri, 12 Jul 2024 02:59:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFD336B0099; Thu, 11 Jul 2024 22:59:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CABDF6B009C; Thu, 11 Jul 2024 22:59:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9AB16B009D; Thu, 11 Jul 2024 22:59:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9EE7C6B0099 for ; Thu, 11 Jul 2024 22:59:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2B8A3408C6 for ; Fri, 12 Jul 2024 02:59:13 +0000 (UTC) X-FDA: 82329594186.29.E32FAF4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id B004B16000F for ; Fri, 12 Jul 2024 02:59:10 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="X/LwbqQP"; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720753134; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i9V/ScIZojD8XsoVocyVm5ZLToZi3gLaiIOhUgdAAlQ=; b=pmNlJAPz+u0pEsjOPX1bxNsBnbJ8XWKcfyD2hvxLK7L3NK6QvWjRfJR1wS9a/fV/Z23R2y TEzAb0odrpnnttzjEvaxNVUMBBAUXGjZiy2xfFNUWXsi4GevFayczODb8j//2tQ2Xq9srJ CXJBtHF2ie1ENLq9wu6VNZKXCd3X6mM= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="X/LwbqQP"; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720753134; a=rsa-sha256; cv=none; b=2vWLFwotwERpnBCitp1wSsuvry+4NxaeeCQhT8MY8zVCp3oAfXpmv1Q5CNTy0riLHTFx74 txZ0fJRmM9xvvBs+GPf8KwIEOrm5MTOlWJwF4gh9k0CC498w32W5P5EQAK2lwHRE5XE2LO vFqL8wsbJoAxKygsRs9ksKWRGA3E9Lg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=i9V/ScIZojD8XsoVocyVm5ZLToZi3gLaiIOhUgdAAlQ=; b=X/LwbqQPgV6iIQoyh8M2amdNbP CvEd14tZEypHdAoWuqB/WmkGzIEc0rKU/IfD5NSyUswWssuhWSC1mmQ1zb8emXGa+f/LUa66ynRvE 7Ym0Oyv6h6IkTh3x99lfgHbsyjHZDfsIEqIbqtNWTRPlvGWfj3cdCz4SZtnfaHCSXQbCkPiQsjWeh BES4yjMmkGtJJ+h62pJCo9J/CbxaJJ80Ig6TyMHUJtJJ+AY78llaklaCA5O15VuAa4h4+2jqD+YqU +NiMDXyUcrZEPoQ0NHQJrQ4qCK9J4t6dqeYMhz5j1bVxxTH90wV0VU0xADwNGVKVFjElaSxxw5TR1 Vh3CYuuQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sS6V2-0000000BvEd-19CY; Fri, 12 Jul 2024 02:59:08 +0000 Date: Fri, 12 Jul 2024 03:59:08 +0100 From: Matthew Wilcox To: Yajun Deng Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: unified folio_test_anon()/folio_anon_vma() and use them Message-ID: References: <20240711130351.2830-1-yajun.deng@linux.dev> <66e43c92d3b4ecfff50e84bdaeedfad3aa477df6@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66e43c92d3b4ecfff50e84bdaeedfad3aa477df6@linux.dev> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B004B16000F X-Stat-Signature: o5pkx3p4ehg6is5g4c49x71xfueqfqsn X-Rspam-User: X-HE-Tag: 1720753150-543637 X-HE-Meta: U2FsdGVkX1/te4YfBavwUzh/DxuYjMPkhoE98meg1LZw8g0AeXvU5uKfjIJBFr6uc9V986yNw9leg6dMolG6wGzYCAhsjM4izO2rdq0WE/ohVbXo/2NVtV5lsZigd/h19TLCfPeW8KzCUg6W0EL2PYgCAnvgFTCqK48eN3WHNhantJWpDCrcuWkbe3tpaFJKPFacN1FKczvH9tsH30asV6dYL74sblONzFfUXpsAc4BSi+E+jRC3JruQC/QgSnW6WRD864oJNLo8TpydAh+YbnUqhX5Wl5Dr9U3GFeLqvz0pQoCIEOVTSKDycEOQqh7foE6y3jauRUohW2yuFKbkMPTSiYeXYO7QinDfkTgOqTU7/XE6LdYved456wttBhIM4s4fV+Ma2QgOHaxHLaDQf773jpttTSLDBoN8A17PGqVVZX70NmOZiaJODdDawbXa5Ui2b5/S5r4sPXVfNCnpOmFwfoCq/rFdmiWUI61eRgci1be9oOCvh2cpan76xRU4A8nAX0WzMJJqjKqcuwie8wvSeWSVWbpgxfkIQV+4jsafTXnRibbGGlM+HxoIi9o/cmYOmEgriC4L0jfsHVjfCUeWBDWSMbnWoPj44hKSP4hVg2suueQ4eI3hBpZhHTmm8FvHppQEMJX6WJ24GuG3epYR0Jj0NHB4rrsgDFz44UPO6LX81Rc1I/GY/K1WjWHueBh/7QlKB2d8tetj6qpBIpUNCYljIJ/LHQAQ3AQ9yfwKfR0uod9kV3qrGhNIuFduC0Mb316hlXUO9o7F9f4ztVyc0S+F/voUKB9cvv9LPzzmHNWcpirskRtkVg3YRZ/lgr+OIAjJi2NDkYl4oAeh1W1oV9HfbV+GHPgCeTzovIfvO+4nbYm932KMsRfFitc56cHarloFfp4O0lPoQcvxKzVM+PSKZ64/BGMGPz62ibZcIlpH+xK6JOlil7UKCtmZG5cs4fs3gM+KEspnjYa FUmR8Ujt M0+9Umzn+ahoIYjUO6fvgfI3+lrIplR9YuhTvIlpPA7aNLllkPZ/Lxft9hCzaDK45f3YRGNw2+/cp9L66LFkNAsj0HtkisJAGsOrFs1a1tBJL9y3kSP0ZtWFCpXgo5YDIEjz0aC5rRwYkQXvyD0t+g01ObwRDT0EljtFapKNKXW9SDj7r15drD6d7P1XMMakvgH/ja1Inz4NpKbAVQjoVf4wEzGZiVv9XchTOIsviJehYhy5tVC//QeIEtVw/ocjWZKu3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000046, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 12, 2024 at 02:29:50AM +0000, Yajun Deng wrote: > I think I need to add a new helper function, like __folio_test_movable. e.g. I can't understand your commit message. I think you might be better off dropping this idea and working on something else.