From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70478C3DA45 for ; Thu, 11 Jul 2024 20:50:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD1EC6B0099; Thu, 11 Jul 2024 16:50:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C829A6B009A; Thu, 11 Jul 2024 16:50:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B49206B009D; Thu, 11 Jul 2024 16:50:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 969926B0099 for ; Thu, 11 Jul 2024 16:50:36 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0CD2D1207CF for ; Thu, 11 Jul 2024 20:50:36 +0000 (UTC) X-FDA: 82328665272.15.9219CBA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 6C14914001F for ; Thu, 11 Jul 2024 20:50:34 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SYrZngTV; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720731018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O7sfw4UaChI/0QPbmvEbRPHylAdZXJH0kBGEe7mU1bQ=; b=r/Kj06FLkf7rwtYCilPWVZ2kKd2/NofqKZ3DawUXIhvObPjhyraY2IU+Lyd9u9oh6n9H60 28keV4yLcvoMhf2dS6jmXvoXnnsSVvjDGQbthkaUtcCvzXvk5aH8RK/iGD/GdO83xIhgY9 /SxYFjXkzJNDEDpkvUb9u7uyCU3CYe4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SYrZngTV; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720731018; a=rsa-sha256; cv=none; b=RgcMjRzHBodHmD5KVyKqwaq2SjifO+Q5CApcOTYOuj/ABsBPZ0ezjI03cW1DbIiBKXH+rT YCCeO+em2D57UL1qA1x/R4o25D0fKNnXCF2lsILlCJFzMWaidPXRXK8PGq5T7ucFriaovU LGuztWNkApoHjAAnwMS+1Vqd/mo2rZ8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=O7sfw4UaChI/0QPbmvEbRPHylAdZXJH0kBGEe7mU1bQ=; b=SYrZngTVOG1gdQRHzIXZCzqzzb 0EyUHSkSovZYOYZh37ruzUbu4dbHkPBli7iWZhzkg5IRejbAJB0rg2B3+QUvMG9PG8HZe8/24pDvu WlmtpyJbSB6dJu2VM1XZRoHSedp8U66dl2r7TfXUVignnmgEbbJ7xVpM2p5aKTDqnzXs5v8DEi56b /yH2tIVLm7K4S7eh/M9IoRcriPsPZjAFVv6/qsSQCb68MVlKfzj/n7kq7rGio/N8TYOs+TESFxLTA 71k7Jmj5qAHcqolef+z3CBdBqK98A3HHvvKDbXJMKrq8sl9CUusSbkg4qSZvTy1Bm5l9F6Dqll1PP KIy8Mi4g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sS0kB-0000000BeCS-0g4J; Thu, 11 Jul 2024 20:50:23 +0000 Date: Thu, 11 Jul 2024 21:50:23 +0100 From: Matthew Wilcox To: Yang Shi Cc: Yves-Alexis Perez , jirislaby@kernel.org, surenb@google.com, riel@surriel.com, cl@linux.com, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Salvatore Bonaccorso , Ben Hutchings Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit Message-ID: References: <20240118133504.2910955-1-shy828301@gmail.com> <2d7bd8b2b9736d4a7d0a26169978372b5e002a62.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 6C14914001F X-Stat-Signature: 3eb1fgfxksxmuozcwcs1dogh1dtwhdhn X-HE-Tag: 1720731034-939790 X-HE-Meta: U2FsdGVkX194NjInS6PIVQL40957TO37gRFWg25QUtEI2VmAF8M1ooDGEKCq+5AriJw7lOaYiovOrBt8fc/VAE29sh1KLkdpHk7pvPlqroT0GnB6wQxC2xxLQYDErkPaVCi+VBVXfL2HtIhAuObJy3E7mquqvZx/cplbDFNgYgFe+xyNnecbhpIFjVudnXaNHVJwxF3GmmjONCKOqW/QRef9L6jRuyniEL2zZwa2X2zGY2l4/0ZDNyCF964Mm6vtSf0bUjaDFmnXE2f2gNc2Ia+66S3MTOOKpieksj39ggHSv4eAPFJaxs4KyidHo+j9yZzygMshuyExpRQToblTJ5nQjnk05kc2iYJozx/EGbx7D12IV6bn4rnF5DwGSE7R/gSnO6m5/EI5emH/nPdrA5oVR7csQkJVusyqqurmaFJQEq5R8TPNN9wdBP8QnD4uRf7+B7J+HroBBUqzjyE/7lgUdkk8N2cLjmVRZStJAvsmiMUGKoKVRyzouj+kD4phWN10uDqKxknI0CXMTSCgXDkgJ07xF9VPvG4jb6Og/FS/3qo/PQMXHQwpXdOmDP3epFeTh4YArycAAu4BLXYISM7kglY67xLu6hbauHwh5yHtefo6nQSZzt3bZncVzpm9AYVvsvOzODEvhYPCWzTUHZmszYDOFueYtKw/DyA966/J0U9pgVgzkwy5tZEAfwxIOR7CjGikr5WZOkytqRD0XZOTztjMncONAmqMECz8g2IL7N20hn5Rk3ypckZGg3N02kvvTIUnx5iqCZ728UuPT5y+nN6gnpj68nVBwqdUg+lAFbj5R1SyUo18HojhXLjOlmwGrh/DdD1G2u6mRIQ+ctWhiJBXrLii8kq6qshOzCJt3+/Mk2UCqLzVodcY66liL+829pBkVkiKzmwZ09ycm68jCZIixne7hviaTLD9TCZxjLL30ebnm5v/7Ojp/c5+YXPeZVq3pZj1e9oaTTp w4kUaAV3 7bu30ULt8CnOSq2O3pjnfYLlm5PJYGJlgghb+xPUuFWZjWIEHoHSEJeTpSYt+AFfAU+cljN70ca9UaV+Ld6el1bqK5NF/Xsyu3CIDh+PuuTYYCiySH8RAb06dDdQYMplGgMtTB0oIhv0NFv47SJOBuMW5khT/UbOt7FZEZhEeHEyIpM65BTXrcatDStxnGBTSDiuDCnd+63t309te34BqVh1RXItm5/W4d0MrEOKXi2XyzXoWE4xBne+8I4e9NbrsVns6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 11, 2024 at 01:47:00PM -0700, Yang Shi wrote: > +++ b/mm/huge_memory.c > @@ -857,7 +857,8 @@ static unsigned long > __thp_get_unmapped_area(struct file *filp, > loff_t off_align = round_up(off, size); > unsigned long len_pad, ret, off_sub; > > - if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) > + if (IS_ENABLED(CONFIG_32BIT) || IS_ENABLED(CONFIG_X86_32) || > + in_compat_syscall()) Why not: if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall())