From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A9E0C3DA45 for ; Thu, 11 Jul 2024 18:54:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B18A6B0093; Thu, 11 Jul 2024 14:54:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 660FB6B0095; Thu, 11 Jul 2024 14:54:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 528266B0096; Thu, 11 Jul 2024 14:54:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 33FFE6B0093 for ; Thu, 11 Jul 2024 14:54:52 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AAB951A07AC for ; Thu, 11 Jul 2024 18:54:51 +0000 (UTC) X-FDA: 82328373582.18.19A9D43 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf01.hostedemail.com (Postfix) with ESMTP id 32CE04000D for ; Thu, 11 Jul 2024 18:54:48 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=klUTpteH; spf=pass (imf01.hostedemail.com: domain of "SRS0=Le2v=OL=zx2c4.com=Jason@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=Le2v=OL=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720724064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hF+3z5UiUkBzxLE2MWTvPzkBeBx1F35CrkpoATtAvH0=; b=RsMX88dFHPzwzJWjMfBAZYNdOnVw/VNx/j0OT7w0Nj57Ihy3XTtoePcmhREQb+0vpM7hCp 7udQDNC2XYS5wQOtcQkej0KdW5c3cL1eAsjEyVj88E3HnYx2+LHGBGVm6mERxhaPeD33j9 uEtrWboRLixrgJgdaBSF3aFJVFHYA2Y= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=klUTpteH; spf=pass (imf01.hostedemail.com: domain of "SRS0=Le2v=OL=zx2c4.com=Jason@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=Le2v=OL=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720724064; a=rsa-sha256; cv=none; b=39Kw2brDqH+075jdpJB/wHX0vajSlce0XIkQD3zCGrIw2GbY8HFp0URRdKq12QDRZERHtw 9OtdWNiEz/iIKxA67HdlM4tWIM830cjnXLzMGXTrdCS+4wunCrpbUhuJVXQeNlBFh9ZDkI 0er7ZoeCN8sexpD/moIEOVrdYPlA3Sc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1AC95CE0E77; Thu, 11 Jul 2024 18:54:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF5ACC116B1; Thu, 11 Jul 2024 18:54:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1720724082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hF+3z5UiUkBzxLE2MWTvPzkBeBx1F35CrkpoATtAvH0=; b=klUTpteHhlYFjt5i9Uxa+JDW827nLqbHIXxDsRFWVsoUOdmLhVZKq87UIao1H1qXD+1hCf 7sRdozUl1084JtxXpTDHU+UvtkKFrmYC8MLe84dz2Zx+NJlm8gCXpk7NOjYQ0ZVcXxptiK lp4bYSdKO+ttMb3gE2qxqRWRG8dq3GA= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id ff525a5f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 11 Jul 2024 18:54:40 +0000 (UTC) Date: Thu, 11 Jul 2024 20:54:38 +0200 From: "Jason A. Donenfeld" To: David Hildenbrand Cc: Linus Torvalds , linux-kernel@vger.kernel.org, patches@lists.linux.dev, tglx@linutronix.de, linux-crypto@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , Adhemerval Zanella Netto , Carlos O'Donell , Florian Weimer , Arnd Bergmann , Jann Horn , Christian Brauner , David Hildenbrand , linux-mm@kvack.org Subject: Re: [PATCH v22 1/4] mm: add MAP_DROPPABLE for designating always lazily freeable mappings Message-ID: References: <98798483-dfcd-451e-94bb-57d830bf68d8@redhat.com> <54b6de32-f127-4928-9f4a-acb8653e5c81@redhat.com> <8586b19c-2e14-4164-888f-8c3b86f3f963@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8586b19c-2e14-4164-888f-8c3b86f3f963@redhat.com> X-Stat-Signature: 9epp7z6ig5w8mm4up37uermfemi7p88s X-Rspam-User: X-Rspamd-Queue-Id: 32CE04000D X-Rspamd-Server: rspam02 X-HE-Tag: 1720724088-189735 X-HE-Meta: U2FsdGVkX19cYz9epFXx1uJDpCvSQ1q1g6JLHMuAFWrPGi5wzfvna3AFcFoVFpQRkC9PV9MYWHy5GnMQnQNRTjCuLgH0zhRvUWeWkOSU3BJPBHbgDBxCdskEpyc/a/Ow/NcP8UzuA4yuG2Mj4K7miX8KNHHUTsE7Z7uAFOjYpOf0oDhkn6mqv8DsSWbxwzy9F2hV2f5VCBqax83kWqwE3MkjiVukKyHhB0wCn+Trp4HntxaizUOqrmbrEHR/Zf1NRapZwqpZ2LQpP35DqAFT0IG1UY3D+IsYh15P0oHUtO9akRXLDQV1/Fcnby3RWZLEzbxQV1TizZV3np72RXaiHkeV7VXjYSUKsSoWCp48UH+TtPMsRMaBH7sPzssbf0FPTVNRQVqMJAUmmgcwXfvg85sO4u1DjtjmKQ5OhTYvs9KDbHJzHK3R96ma+f031K2gKLPJlWIjp4ZJqYncGsj7g73AOvslyYzmtiM43Fhv+H9dNyD4CBjmWmdILNSitan14OTTm/8/OkZnTNKUmcFfeCKKH2O2vu82lzku7iz4G4bs/N3pzr6/Ct33n2DZq5w2gTargnRfC1Ge+Exg5opaElNydoYUt9PT+CSVJ88w6z4SviVvzHO/C+uRO9BWR4mEFCzzS++bgAwggxl06DN/OrCrxQSyvnN/Uu4ewFDJ2YWBlwFaNgh6N1jlIr+T5NhGb/x4rp+PMB2tzK3gLzaqS1HzNb8fCziur/p72c3xhKSQQIBX8GgFIxmSzPGTghGOC9nnZkYN0eANyb7fGLb8kVL+pZBXgcBg2PxvbKQI4q/7RgINP96Vg1W2v691YxDErSi8Qk1a00UPV5KfJgAVMrhphBdDhgsPqWH+BFmsk8buKzmtps93Uc1qVraJBQDKL4uBKzX6swOLCtrpVD2jGxyk7/2t3a316qFzfZhMB0QuJOt1Fb0QtG44R2npAPk/dmPIWZlWCLLERsBVHRe f9ANo3dS w3sjrf1e1HkbdWjUHQHF5bWQL41MFD7Mqb9DcwQDMrxS/WN6IDlblWITYHSJXjjogYnwrHlQiHB1P6+vtea4Mk/diIwBH0iVwXAetrYS/dHpq/Y0t6XvYdLCK1lZ74CVWZ5zQvoLtIxUxhaztdaox5VzDOgYPles8BUmmWu3gVxFutHP3sBI2envFuOZ11pxLvkAHHCV4Hb6L/SHhhYPAYG0FALPE++bY2z2r8opdTg+kyWFnceSy0nsFB0qYQPZk1sIMUT5qBNINwX6hNAaWVWzyjq1SYOQLZXOjc7X3z66hzrpmwi7U4ss3vgOciw6n6ft4JoNZ9qEytoVlTdB4RipRnXdTDD7yXVk9C9cAH9/FuW0XTfnU/akdidD0TQJhCqDzrCfz65DBUOYFS6ztvSE+JcVC5a+W8+JX3U8B6omXBfz73t4KTjmW+O8jTzqmN2RBwPVvInG1AIY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 11, 2024 at 08:24:07PM +0200, David Hildenbrand wrote: > > And PG_large_rmappable seems to only be used for hugetlb branches. > > It should be set for THP/large folios. And it's tested too, apparently. Okay, well, how disappointing is this below? Because I'm running out of tricks for flag reuse. diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index b9e914e1face..c1ea49a7f198 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -110,6 +110,7 @@ enum pageflags { PG_workingset, PG_error, PG_owner_priv_1, /* Owner use. If pagecache, fs may use*/ + PG_owner_priv_2, PG_arch_1, PG_reserved, PG_private, /* If pagecache, has fs-private data */ @@ -190,6 +191,9 @@ enum pageflags { /* At least one page in this folio has the hwpoison flag set */ PG_has_hwpoisoned = PG_error, PG_large_rmappable = PG_workingset, /* anon or file-backed */ + + /* Zero page under memory pressure. */ + PG_droppable = PG_owner_priv_2, }; #define PAGEFLAGS_MASK ((1UL << NR_PAGEFLAGS) - 1) @@ -549,6 +553,8 @@ PAGEFLAG(Private, private, PF_ANY) PAGEFLAG(Private2, private_2, PF_ANY) TESTSCFLAG(Private2, private_2, PF_ANY) PAGEFLAG(OwnerPriv1, owner_priv_1, PF_ANY) TESTCLEARFLAG(OwnerPriv1, owner_priv_1, PF_ANY) +PAGEFLAG(OwnerPriv2, owner_priv_2, PF_ANY) + TESTCLEARFLAG(OwnerPriv2, owner_priv_2, PF_ANY) /* * Only test-and-set exist for PG_writeback. The unconditional operators are @@ -640,6 +646,8 @@ FOLIO_TEST_CLEAR_FLAG_FALSE(young) FOLIO_FLAG_FALSE(idle) #endif +FOLIO_FLAG(droppable, FOLIO_SECOND_PAGE) + /* * PageReported() is used to track reported free pages within the Buddy * allocator. We can use the non-atomic version of the test and set diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h index b63d211bd141..986551588805 100644 --- a/include/trace/events/mmflags.h +++ b/include/trace/events/mmflags.h @@ -108,6 +108,7 @@ DEF_PAGEFLAG_NAME(active), \ DEF_PAGEFLAG_NAME(workingset), \ DEF_PAGEFLAG_NAME(owner_priv_1), \ + DEF_PAGEFLAG_NAME(owner_priv_2), \ DEF_PAGEFLAG_NAME(arch_1), \ DEF_PAGEFLAG_NAME(reserved), \ DEF_PAGEFLAG_NAME(private), \ diff --git a/mm/rmap.c b/mm/rmap.c index 1f9b5a9cb121..73b4052b2f82 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1403,6 +1403,8 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma, */ if (!(vma->vm_flags & VM_DROPPABLE)) __folio_set_swapbacked(folio); + else + folio_set_droppable(folio); __folio_set_anon(folio, vma, address, true); if (likely(!folio_test_large(folio))) { @@ -1852,7 +1854,7 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, * ones can be dropped even if they've * been dirtied. */ - (vma->vm_flags & VM_DROPPABLE))) { + folio_test_droppable(folio))) { dec_mm_counter(mm, MM_ANONPAGES); goto discard; } @@ -1866,7 +1868,7 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, * Unlike MADV_FREE mappings, VM_DROPPABLE ones * never get swap backed on failure to drop. */ - if (!(vma->vm_flags & VM_DROPPABLE)) + if (!folio_test_droppable(folio)) folio_set_swapbacked(folio); ret = false; page_vma_mapped_walk_done(&pvmw); diff --git a/mm/vmscan.c b/mm/vmscan.c index 2e34de9cd0d4..41340f2a12c7 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4266,7 +4266,8 @@ static bool sort_folio(struct lruvec *lruvec, struct folio *folio, struct scan_c } /* dirty lazyfree */ - if (type == LRU_GEN_FILE && folio_test_anon(folio) && folio_test_dirty(folio)) { + if (type == LRU_GEN_FILE && folio_test_anon(folio) && + folio_test_dirty(folio) && !folio_test_droppable(folio)) { success = lru_gen_del_folio(lruvec, folio, true); VM_WARN_ON_ONCE_FOLIO(!success, folio); folio_set_swapbacked(folio);