From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 632D9C41513 for ; Thu, 11 Jul 2024 20:20:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D33B06B0098; Thu, 11 Jul 2024 16:20:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CE3856B009A; Thu, 11 Jul 2024 16:20:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAB376B00A5; Thu, 11 Jul 2024 16:20:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 988636B0098 for ; Thu, 11 Jul 2024 16:20:36 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 029CA407C3 for ; Thu, 11 Jul 2024 20:20:35 +0000 (UTC) X-FDA: 82328589672.19.4BB78AF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 3BDB020016 for ; Thu, 11 Jul 2024 20:20:34 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=B08k7FoK; spf=pass (imf03.hostedemail.com: domain of "SRS0=Le2v=OL=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Le2v=OL=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720729200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yt6QePxaysQIEy2W33NFuV82FH1yOwTPMayUT9I0nRc=; b=Re16fBRhJbSbF+tXDCtpmiVyXBSrOofxKiEqQFlCdbZTokYyeg6ey2JbNESGKCmUDpq0J8 SoGdZli+FYkVSr4VTA+0ieRLrINIuX4OvRI54JbS2mqT6Hm+4dPLyMW2+q3ZDMM6fRQVl9 7SiKXwe5mYJEfvT45RUC66QN91dTlkg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720729200; a=rsa-sha256; cv=none; b=QiIChlf5my9Hsk7GXhLEH3Kv/6MtGQhLCgGadTibNxJ8RhiGl7jmsBAojr5uhjPAU2g4eV Zi3ivNXUnttYdHe1gstgxjTI+Ij5AD2KcU/UHUottuiazzjiYqXuOwcnC3jDApsogJ+Mmv Wk4zdDVYu+Y6h5pq9Zg8PS2nSld6ihE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=B08k7FoK; spf=pass (imf03.hostedemail.com: domain of "SRS0=Le2v=OL=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Le2v=OL=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 37E8D61DE2; Thu, 11 Jul 2024 20:20:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45713C116B1; Thu, 11 Jul 2024 20:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1720729229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yt6QePxaysQIEy2W33NFuV82FH1yOwTPMayUT9I0nRc=; b=B08k7FoKM2lth8Goud21+qdX9b42LABqtbFegs2oLDnZEvSCsNyDg1bmjyhL5o8Z9rok38 0bDYNxgm6Q6JMUOebYHP2hMK+PLa6CubiFXMr8PKb3jvY6/5lUdoVrvXPIB35+82ogkpdJ pJFYgPAVaSkR/6oG//+B/wc8s6FL04E= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 0ffe4054 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 11 Jul 2024 20:20:29 +0000 (UTC) Date: Thu, 11 Jul 2024 22:20:26 +0200 From: "Jason A. Donenfeld" To: Yu Zhao Cc: David Hildenbrand , Linus Torvalds , linux-kernel@vger.kernel.org, patches@lists.linux.dev, tglx@linutronix.de, linux-crypto@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , Adhemerval Zanella Netto , Carlos O'Donell , Florian Weimer , Arnd Bergmann , Jann Horn , Christian Brauner , David Hildenbrand , linux-mm@kvack.org Subject: Re: [PATCH v22 1/4] mm: add MAP_DROPPABLE for designating always lazily freeable mappings Message-ID: References: <54b6de32-f127-4928-9f4a-acb8653e5c81@redhat.com> <8586b19c-2e14-4164-888f-8c3b86f3f963@redhat.com> <443146f4-9db8-4a19-91f1-b6822fad8ce8@redhat.com> <1c8632b4-06a5-49da-be0c-6fc7ac2b3257@redhat.com> <2c464271-1c61-4cd8-bd4e-4bd8aa01fa00@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: h8kxkqkejpkh4dd47bykwpgxe46bxrkg X-Rspamd-Queue-Id: 3BDB020016 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720729234-150877 X-HE-Meta: U2FsdGVkX19fcva/a22pp4EpQY/0UTffYQkdgfJk8Lvvj205KnJGVHGW9wDXx2iGzb0TZmVlowgAp6WWaa3aHfppjN6OsLyZqVqNps7le4Ms2YfMgwKZ3VFjZtDuEYE3WxyzySJm+IQvaXNG9i/2K3dlNXGzDXAbGvJT7Ri1+H+ep77kSM4NXzkNpm8EgNCU8BiZTxgraqbLL2QOZ6vkE90IIbwd5OmbutNPrsHb8ML4pnwwE/XwclQ8ncoSRFhKnWzPi8CZXjnyWcaz65yfstnmRzdZgCHcLEAwx0bvjsgSX6ndESGmrZZVHLOokct6bE9ibcW4KsArCgBph4nzz2L3fJDDSeKUgrvzzOOGuoOYMZrItwJelbux9CWXPyDlgV2rWPM8TkIWLCSf8D1XcuTKMw6mX6fHHOpdFGngm+ufWq09wYrX0cBPNLE/ZgDg99JcIk0LA1iFTsfIr6R1Z1zJ5ip6415YkltnXddJkarQQ8f7+ItkbF5BH+NHTXs4l4NuQcDQSJW8oZWP4Wmayoamxubj6JLXQUHvzwrKR6TXpyls3qcGokNH66yK/9iubqs3LfoNJuLi1UcNuVqDAsgh83AS7OWiL3t+wkAMzykiMOurt952WkbXwnohsDSDfrNhd3POjIZFBffgYCd7cbsfVlhM0+mOcVziO3E5qvLG0oJmcLzRwmlsUOsJ7pFJF5CXcaINhEW6wlj7DYp4PxEnrSXNua0/dpuVaVuN/cuU88JWMrOvOMpT1yMtr6YUOX7BuaQcaHoA/KLLOGKq40u6grGO+Eia6Ps9oJrBVtLaR6Qm0BNwhOc+pF7k38+PJXexhK4vNadI374YCiV3JrRm9lx8PV2Js61q/IvrpbZQPRlzukccntIZPnFDyk9Gi2EdisPTxW8lvCUOqB95v6uLkFclRgr36eLGFrKKaTZwDC9NKnmTsRKQAdWUVl8oIToGHDkBiMwK37SFr27 5B7FrlVL mQrf3QO2BhVxwrpIAYVrWEOjTnj0oo483yltZ5gjDGKeVnoUcKmTcalXyUW8e8o88nXEIwYfhutAcEGWORKmn52RtIrsdAz0JvVCBMK+5ijIsFwsh1ywaQ/vZNTlYGZtkVPjUEpxNyVf8txj86MIwvw+zH7+REMjZZzpDzPDHtWIrfme1aXd67Vh9cCmgKDErBzP1AH8u8LGhWE1djn1ldOowvbSSTFNrDMCt5xc9w4VFopG3GWBH1iMhlsg+G207DTj1V1jt+1RqP6umkaz1eWCLIHh/Gt7QRj17lFGdaVFKCDT03Zzst7I8qnDz1ShmjBGR3yZfvF70j5WdIE65nEYexZL45uQmYZz4I0Z+wHxmvfgMLI+bM5VHCig9Zb0su+2AwnuKslAf27DnGNrWuAgVtsVov6ZI0oTiv64H5HkM4S87tFnPv8NaVz4tQmSsvYxW4RfeNbBydmnqWyBfc0ki6GRmuorylfEMYPSZG/5kKux+Kjd0/AaL8oPgpykD3tQYqeG/637HotTPLCTWSOMqtw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, On Thu, Jul 11, 2024 at 01:49:42PM -0600, Yu Zhao wrote: > On Thu, Jul 11, 2024 at 1:20 PM David Hildenbrand wrote: > > > - /* dirty lazyfree */ > > > - if (type == LRU_GEN_FILE && folio_test_anon(folio) && folio_test_dirty(folio)) { > > > - success = lru_gen_del_folio(lruvec, folio, true); > > > - VM_WARN_ON_ONCE_FOLIO(!success, folio); > > > - folio_set_swapbacked(folio); > > > - lruvec_add_folio_tail(lruvec, folio); > > > - return true; > > > - } > This is an optimization to avoid an unnecessary trip to > shrink_folio_list(), so it's safe to delete the entire 'if' block, and > that would be preferable than leaving a dangling 'if'. Alright, I'll just remove that entire chunk then, for v+1 of this patch? That sounds prettttty okay. Jason