From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E168CC3DA59 for ; Mon, 22 Jul 2024 23:18:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FD056B007B; Mon, 22 Jul 2024 19:18:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3860E6B0085; Mon, 22 Jul 2024 19:18:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2277D6B0089; Mon, 22 Jul 2024 19:18:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 02BE36B007B for ; Mon, 22 Jul 2024 19:18:52 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 96BA481B52 for ; Mon, 22 Jul 2024 23:18:52 +0000 (UTC) X-FDA: 82368955704.10.A0F54B4 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id 5ED0140023 for ; Mon, 22 Jul 2024 23:18:50 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="Mhg/HFwI"; spf=none (imf01.hostedemail.com: domain of BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721690308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QkB2CarJO3KoWhwQozqGRMZUNqwQd4nuqT1lzojgvuA=; b=dggC2U8KyvHoLe9HslFvgEweGBx08PGgiVPQg7rPkvYUuvnEiYDLcRwFnlPKfG2yK7CPqC JEMBJzkh82ZYlcqu1dVcwTTWckXD4/qeiKOy1ho61gQx0upg2t6je1lginmLKRmgFbRxdv DbG47tN6n5c9Wj/GLFglrlPZ/baVCJM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="Mhg/HFwI"; spf=none (imf01.hostedemail.com: domain of BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721690308; a=rsa-sha256; cv=none; b=TEA7h+09IOuGukIdi2TxiQw3HSPBV5+IdtdK2bBy/vGtoJutSeDd9ginKfKdzTR5VaFcSD qku8TReyjt6fgKD9HsZtnmGMdxf2M1yeRcgI6qnN+Y9n3ohO/PvH1R1gAZOkfkxYQaEIg2 MHN+VqJIw4Sbn8blJBNhD6noO1w8ZJE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QkB2CarJO3KoWhwQozqGRMZUNqwQd4nuqT1lzojgvuA=; b=Mhg/HFwIKkjjK48OshXNweXAW5 WbVtwBOI3AyB/h2xwEx9LHf+uvUC5BbIfmUplFEVHi7q2do/UFFK0fjdbM1nuXLSptOA17/KmVrCs rb73LhgheTILxXA4Ev3QvO2EWmTK57NUhxt1S4ZuOL+opaW6ppwfECgfW/i1k16ug4d8HYG6PZizb 2ShLF+3gYHF3XXBSQ4yabzRcaFxs2LdgGJ0t0aww+XbOl+uv/p5WYQqzteDhqzIX7vYhEBSc1N6EW zSdd/WvG8vVT2DGV5Ut0eNO9usvhQs9a2nLyunOIUEbgig9UuAkfTDUNJ9d1SjmJVsFROBuCdej2/ K+Mg/nPg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sW2Io-0000000AqJ4-0L27; Mon, 22 Jul 2024 23:18:46 +0000 Date: Mon, 22 Jul 2024 16:18:46 -0700 From: Christoph Hellwig To: Michal Hocko Cc: Barry Song <21cnbao@gmail.com>, Christoph Hellwig , akpm@linux-foundation.org, linux-mm@kvack.org, Barry Song , Uladzislau Rezki , Lorenzo Stoakes , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 5ED0140023 X-Stat-Signature: nnphdcr8xswfzdw5yc4wn94ipmn5akyy X-HE-Tag: 1721690330-903342 X-HE-Meta: U2FsdGVkX1/ZP9ibfswA8Vh7bx8+AkJayF2pISh8pflvbXegTYt77NdUVcIuoYmt/dR/1vtOQlVWPBjqy02p1CkEAlCuYFx4pYLR+Fn3rumJnaNXMlUV0Z00vCsihU3luUk0wgdfGMveedwp6E6qGHw18TIavSU+z9/uV7lnC1djy9lH6mKO93jgGFDS25OvXr+7axXyn6kFQov0lkJFWrDg7NA4uNabRbLNKHENl3RgQSh5VdjJQzaeMZLz7IPtg1QI0fp94sa4pt6m9hZpdO8HZD/Pb8MzjL9GFo7WAP5u0tRtOLzgAmEX/1zXCAhGzdFeDDnD5nT1I/0N20niD+3ZhNJWEgcCtcGYEE2Z9zw9bcGEns2aZFXzTfLfrkzRD9Z2qQgq1NId8nFxyOqjZgNqDsm2L5rpkmvSeblDY4E2072NomqsJJCiLEkEQUKevNIowsIC71xLTzFQBDXTrMZZ+FIKiNF6OCToi5U9LMXJNb55SaCtNe/j6e4NcA4gWr8OHPGVZQ7wV/ZCEtfge4HV+bDcwV05z0YaJJO5pm6uiUUDl7sviLK4uJxb9Zie7FGLpOxec0qEhaDTtXO5x6asCzb57R3P/ymtpJGs8QoL+8rGCwXKukZ1vlDZTnbbGTGQWkIc9rr4tsj8e4VJ7eV5aGsIuLqpWDAhHIpBKyhq7iZg5qKJyqTjjxjY6aNjfq/361sPWamcUsa7oVSNsCiIKrR7RFCQ/LDf0p4qPi+V/MXgLZw5UqCuvqTPGAYYyadmk6D6qhgCCtvsZnnUVhPnupnSwl7ZjN1mnE+wOlFn/MNYWmay/BFd32MlyFbZZPYETY/xjWliwCmRlvsuptVeKyIaNMFMEeGPqdPurLjyheW5w8CGbIW1DWU7+LKD/FBKivItT5tuJF2L+Wg9o04RTKJw7tSGVnntOGL2YOHnQbZRrQP9YyN0C/5kyDTIY+2BMAww/jkCWBASFog 0gI/9mEH IhV/ar+o/xQeKffKjrjBvipU1wOVr/lq1bkouO6H57/kLvJngVfdPmW/u5DLl2wqe0EQdUJl/VGPqSpbUewOs1Nm72MEL4Qlcq/OsUzluilDih89qCapVNXbkas5L+rHnbQqD03ssXv/MCtlpeIlq3s+aUoTkRo3nIRZS0mQskLWebNpNFWXYmoP9ZGiiukV2AHgrB0UBT9/OaV95DSNRW8t8g2CDn0vrCgrFAm8V5LGGal81N6W61yD25Qi77bGQCTKSceCBDjYgd3rm+ZoMWn0H1D+jYrpkpZuRXo8Cg+pILLHTclxIrx0WbcUUPM+ajlhQeVUq2GDFxPyVyjVLURlc2mYx9h/bHFFxbwO1YbeoU/jibNRo0jIgGZIbAJFQPzqJQ2pINMMeogpzu0W7F9rjsVU9w/kF9pwcej6b+DRDfYXyaQpkpYE9nLHHOmulXXi6+SGvTCxJk9mpBw8HW6+dCdZ3umnd6Dq890fb/7kX/B822OZm8LLM5rfMK5crKZpEAtCLdjaj5TliUZDX0qGOi+ySQRu0kuJDJ1mJPMKwI/9rfc5hsjTk1cCVyjLKn3AIp3eMvZuuTaBgh1BhRIM7TJnLfllINz6E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 22, 2024 at 11:01:23AM +0200, Michal Hocko wrote: > __GFP_$FOO are usually low level. GFP_$FOO are high level and they > combine several subflags to have a specific meaning. So this would need > to be GFP_NOFAIL. Btw. the same applies to __GFP_NORETRY and > __GFP_RETRY_MAYFAIL. True. But I think adding GFP_NOFAIL and slowly upping the enforcement that no one is using __GFP_NOFAIL directly will get us a similar effect to my *_nofail proposal. It will require manual or scripted checking instead of relying on the compiler, but it's much better than what we have right now.