From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD1B6C3DA59 for ; Mon, 22 Jul 2024 18:03:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 536456B0082; Mon, 22 Jul 2024 14:03:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BF4E6B0083; Mon, 22 Jul 2024 14:03:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 338726B0085; Mon, 22 Jul 2024 14:03:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 117106B0082 for ; Mon, 22 Jul 2024 14:03:26 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B23E181A37 for ; Mon, 22 Jul 2024 18:03:25 +0000 (UTC) X-FDA: 82368160770.27.18167AD Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf25.hostedemail.com (Postfix) with ESMTP id 61B50A002C for ; Mon, 22 Jul 2024 18:03:23 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lIBUhNpn; spf=pass (imf25.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721671367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0Ftgu8SNLkpVNUG84750DkvC5uADEAzoZ1JgtAWqSUA=; b=CdycAWGvgc8vsBYZn2zL4PejamcKKLOKtvVSrVO/EyVcu7J0lc3Ba59hkQDEtJMFujxQ3W m4FP0c9saEVN4b4+fj2XjUCm01ClX/418d4fLLPqPSPWSoY3oer4QjSja2YfcLbiSZ2FDs Dftm7NwVPK2Egzpl/vTVawZlF4fKpYk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lIBUhNpn; spf=pass (imf25.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721671367; a=rsa-sha256; cv=none; b=akZ8Qo/wPot+IgIKDrJV7qFmaH7RsDTdEqqt6Q+viCE8C69lUx9xZhJB0XNyytF7GIOCLf 3VsdVAAdkyWmd2RJaWGExq8IOozQe8pALJATDwBY8PV+o6dgRgAPNxSdKWcDPyODzuJ2F7 w2WwFPLlj14oJ91ueqJpsa59kStNQsk= Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-6b97097f7fdso10948846d6.0 for ; Mon, 22 Jul 2024 11:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721671402; x=1722276202; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=0Ftgu8SNLkpVNUG84750DkvC5uADEAzoZ1JgtAWqSUA=; b=lIBUhNpnUDwumZwOSNtCuo4/lO22dYqFn7hFy56QII0rfcNzkSn6geZ01Gf0M1p0LP YizLY77Hfgnb8kCtsgrnul2IPPF+GmoiUd8UgdbD5oIJqGJXkBqQ8uXkycqlzUOLSBzK kwzGtvqzazV6nvw58Is1qRj/RyUrdDkaT/+qf9gmh2zFLGHQWCR92Ksdw8S8c58m4DyZ JnjCRLlq+vB5Maz/YOZATRlwVukezX/cziBA7DatPYxkYI0ezQW7OatlAQPwwgQJD2ph Ixa6pQtiiG3IkZufqDHgvk80CzVlGbOAXlNCwNXwStjZqRkIsYgBsVJzMfPWmJksxr77 1pTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721671402; x=1722276202; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Ftgu8SNLkpVNUG84750DkvC5uADEAzoZ1JgtAWqSUA=; b=nzszfFFdo8gG3xR1m5iPVqqrnXpLJunYSt+Y3XkA+w6JTwl4IUg7rB2A42/SD/n7W1 016P0MOjf0tWY3C3NihlM3p7VUcKbfo5lmKDLmahXyNgNlAq7NL7+MOp0D3R4lMO0zun asPK5BPaF7l9RZtzH6yfdvMeGlKi67k6UhQ0GbdwK1IMQknMrD1Ltx8epIaVtMG3/1Mt zNrxAKVg4NNbaQKD/NlDcTlxwQjL3LSC8tetwf4vU48BS9cgGSCR9gtkywvfFFm5c3VX ETGG0tQxikJvG/R9dOYcvWqSWfCZVsEcSDQq2WLyjnCMYy6xchYbcEZbAiza+wfu73eW er3A== X-Forwarded-Encrypted: i=1; AJvYcCV803R33JQ/A3eTjmJTqZXv9H/0D1LgDQMrfrv8yn4PkWtf0xiRWU0yGq7fTY+VgnEPBLo/0Qa2Gm3WRTTjKaGqGwA= X-Gm-Message-State: AOJu0YzyHN1zabjOlJVD4w7RAs7kK7HvDacUzb/Z2Ky6rf9oVJ0pYfxI YflySPTNDXk3pTcika8tHPkJ92N3ST4mIAZz1YPbSpxhIEzsUYdT X-Google-Smtp-Source: AGHT+IEvR5vz3iMOJL6CHHVTEO59XBqteVoFFbdVHCISLz7Mv+5XsNQ72J/iis6vR4FrCJpuD3qCzQ== X-Received: by 2002:ad4:5c6c:0:b0:6b5:7e0b:eafb with SMTP id 6a1803df08f44-6b958e86ddamr113580546d6.24.1721671402425; Mon, 22 Jul 2024 11:03:22 -0700 (PDT) Received: from fauth2-smtp.messagingengine.com (fauth2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b7ac7d9a2dsm37850506d6.30.2024.07.22.11.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 11:03:21 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfauth.nyi.internal (Postfix) with ESMTP id 2E7D41200043; Mon, 22 Jul 2024 14:03:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 22 Jul 2024 14:03:20 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrheejgdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhu nhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpeehudfgudffffetuedtvdehueevledvhfelleeivedtgeeuhfegueeviedu ffeivdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gsohhquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeiledvgeehtdei gedqudejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmhgrihhlrdgtohhmsehfih igmhgvrdhnrghmvg X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Jul 2024 14:03:19 -0400 (EDT) Date: Mon, 22 Jul 2024 11:03:00 -0700 From: Boqun Feng To: Tejun Heo Cc: kernel test robot , Suren Baghdasaryan , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Kent Overstreet , Kees Cook , Alexander Viro , Alex Gaynor , Alice Ryhl , Andreas Hindborg , Benno Lossin , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Christoph Lameter , Dennis Zhou , Gary Guo , Miguel Ojeda , Pasha Tatashin , Peter Zijlstra , Vlastimil Babka , Wedson Almeida Filho , linux-mm@kvack.org, lkmm@lists.linux.dev Subject: Re: [linus:master] [mm] 24e44cc22a: BUG:KCSAN:data-race_in_pcpu_alloc_noprof/pcpu_block_update_hint_alloc Message-ID: References: <202407191651.f24e499d-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 3h5cu9yh576fs3rimjyuctbt5croec1s X-Rspam-User: X-Rspamd-Queue-Id: 61B50A002C X-Rspamd-Server: rspam02 X-HE-Tag: 1721671403-92124 X-HE-Meta: U2FsdGVkX1+pf9Cku/Z0j3QFWq2vzGW55wH1i4Cp5nEazyJxKzH4Yk/PN4CpFqHAVgcUbXiqM12ix9jIHsAhkxet15s3IB0PPkQkIVNgzZ2ERWaIh5YqPk81ZMECrqfn/8nbngwU/zUxkpyxHPnl4M6+DMzQOLDX3QV5dvFnZAp5T0wMGuN8KgZKzEUhxm41hbzHZGGlBp65kV0vuoVhmwC1KDPaK0XKeOy050Reso1msw4d49Q6V4J1e2tWuO4Lf2yj1i+/JZ0M7gKaLTgd5Mtwim4jJwLIzCKAq07xAgLyF2b+m9yRv2h/1PkESk4+VCD9hR+/F6Aiz06OWf3rmAwgQy0TuFh7yeXw7ZmJ9r6c81fd+a6BB3cgzpupfElLltwolejFCxczG0AIMXnPGUURpZww1uFNFkBx3Hl+FnPoWy28gNe3vO6A6eVfFGPy3bw6B5g0w6d8z2sW/ks8LXhiC7r/ybAGs4syDhcs4VKaHfmsczta8kQyiTyeVVo4WvIOk25URIarGkqrByIl/Tor3omcH4psH6BcRuMFhYZfmVKu1l6udc6IZrG1Jznl2N/M0Z0lx61fAl5Lyo1vSWjGhwySdalI7K1SlxFYirkXB1K+pw+OaNCNzezI5pXWxaGYbW+EsxjeW3ty+QXEwZ1Z09/eQ6Cq0qoJaUxHV2ism0BxVUi/eTzUZfFcvDu86fXfhEcARFIxs0kv4yrNbJDw01dhBa6V7AFtT1IMQ+X4h+8UCY/d3o7b4lnqHXoXvLu31YBTt8+UbaoPoA0k8c/nWgQLk7kLLp0dJljJAv06VTp6BuQtmz2jDQnnuoCPpzNBJ95wbnW8oo18YmXNWkXkqmRBDSyg5s1dVBX1GFBBWhgSpqRvDBgTdipWY21WUllCy05ZXMOrf7iiuamxdh3NSLUbFYcmvmOAtOqE1L0CpBm5aeuK0TqviLoLb52Cg9GHSUJbBPctkzFm8Zx rrwkAbnn dRs9BNUg3Bg6lhs/2w5F4OuUoqjMYzg+ey4dCN9iRlGoNqfLaMHi5zoQodsMnc3SpDf/KuZvgRWqYdG2ezJPWu8Vf8xhzQWkd1j1U5qQe27/chwmZb6OE6sxxVXvzVacg0fTORcI0wflgIeFpk5Obp10zotQTZf4WIXM3KPT5XvzEoeEwC52eUA+kLUm/wvIVhB4Ez/ZzHljFeIxG8ULSaaEXlYzByP84JJI0iB3Dg7bwQaFJxxXiuKpMbeb6U/90vy0qEOoboC5g/wlqr+PX84hVE1SJDUpCLSW5AU1ISFa8y9T9uEV7tmlHiXWdAldAsqunizc5Pnfeh155c5e5WPO4Q1xMFfm78HQHrAgFGcVUDtnk0bWb9BbWxFrjGJcAl5ygnaDnxQ5WdvyD5jYspLTmW5HkaJyKVbKnysOONCMc13sOWH1c3tnY4zpizQUPrxUoReXQcAcfD/FJypVW2dxbFgQlWIzFILg/bPbjCTGFPQIAsHUhztbhnYc1BOWMcIi2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 22, 2024 at 07:52:22AM -1000, Tejun Heo wrote: > On Mon, Jul 22, 2024 at 10:47:30AM -0700, Boqun Feng wrote: > > This looks like a data race because we read pcpu_nr_empty_pop_pages out > > of the lock for a best effort checking, @Tejun, maybe you could confirm > > on this? > > That does sound plausible. > > > - if (pcpu_nr_empty_pop_pages < PCPU_EMPTY_POP_PAGES_LOW) > > + /* > > + * Checks pcpu_nr_empty_pop_pages out of the pcpu_lock, data races may > > + * occur but this is just a best-effort checking, everything is synced > > + * in pcpu_balance_work. > > + */ > > + if (data_race(pcpu_nr_empty_pop_pages) < PCPU_EMPTY_POP_PAGES_LOW) > > pcpu_schedule_balance_work(); > > Would it be better to use READ/WRITE_ONCE() for the variable? > For READ/WRITE_ONCE(), we will need to replace all write accesses and all out-of-lock read accesses to pcpu_nr_empty_pop_pages, like below. It's better in the sense that it doesn't rely on compiler behaviors on data races, not sure about the performance impact though. Regards, Boqun ----->8 diff --git a/mm/percpu.c b/mm/percpu.c index 20d91af8c033..729e8188238b 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -570,7 +570,8 @@ static void pcpu_isolate_chunk(struct pcpu_chunk *chunk) if (!chunk->isolated) { chunk->isolated = true; - pcpu_nr_empty_pop_pages -= chunk->nr_empty_pop_pages; + WRITE_ONCE(pcpu_nr_empty_pop_pages, + pcpu_nr_empty_pop_pages - chunk->nr_empty_pop_pages); } list_move(&chunk->list, &pcpu_chunk_lists[pcpu_to_depopulate_slot]); } @@ -581,7 +582,8 @@ static void pcpu_reintegrate_chunk(struct pcpu_chunk *chunk) if (chunk->isolated) { chunk->isolated = false; - pcpu_nr_empty_pop_pages += chunk->nr_empty_pop_pages; + WRITE_ONCE(pcpu_nr_empty_pop_pages, + pcpu_nr_empty_pop_pages + chunk->nr_empty_pop_pages); pcpu_chunk_relocate(chunk, -1); } } @@ -599,7 +601,8 @@ static inline void pcpu_update_empty_pages(struct pcpu_chunk *chunk, int nr) { chunk->nr_empty_pop_pages += nr; if (chunk != pcpu_reserved_chunk && !chunk->isolated) - pcpu_nr_empty_pop_pages += nr; + WRITE_ONCE(pcpu_nr_empty_pop_pages, + pcpu_nr_empty_pop_pages + nr); } /* @@ -1891,7 +1894,7 @@ void __percpu *pcpu_alloc_noprof(size_t size, size_t align, bool reserved, mutex_unlock(&pcpu_alloc_mutex); } - if (pcpu_nr_empty_pop_pages < PCPU_EMPTY_POP_PAGES_LOW) + if (READ_ONCE(pcpu_nr_empty_pop_pages) < PCPU_EMPTY_POP_PAGES_LOW) pcpu_schedule_balance_work(); /* clear the areas and return address relative to base address */ @@ -2754,7 +2757,7 @@ void __init pcpu_setup_first_chunk(const struct pcpu_alloc_info *ai, tmp_addr = (unsigned long)base_addr + static_size + ai->reserved_size; pcpu_first_chunk = pcpu_alloc_first_chunk(tmp_addr, dyn_size); - pcpu_nr_empty_pop_pages = pcpu_first_chunk->nr_empty_pop_pages; + WRITE_ONCE(pcpu_nr_empty_pop_pages, pcpu_first_chunk->nr_empty_pop_pages); pcpu_chunk_relocate(pcpu_first_chunk, -1); /* include all regions of the first chunk */