From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0191BC3DA59 for ; Mon, 22 Jul 2024 17:47:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D7F86B0082; Mon, 22 Jul 2024 13:47:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 687006B0083; Mon, 22 Jul 2024 13:47:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 500CD6B0085; Mon, 22 Jul 2024 13:47:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 337516B0082 for ; Mon, 22 Jul 2024 13:47:57 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D68541C394E for ; Mon, 22 Jul 2024 17:47:56 +0000 (UTC) X-FDA: 82368121752.21.19BE20C Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) by imf26.hostedemail.com (Postfix) with ESMTP id A0517140020 for ; Mon, 22 Jul 2024 17:47:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eHTZlzC3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721670423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ANlfruZmo4l7ccwD2B2KKiZpD4Y7MpMXUEVtTMzZJI=; b=SXs5nKBprswBILRVEhFStPKvvp/Yw4qH+34/PbZEs40UQiDldASf1Q6UbF3G3ZIU9JwIcG Kqe5ydj3V8myYc25vt+SozBQmtDHhRWlWSMHbwns5iPrK30bzmCTzeKlA3EAnspg/+k9fI G+1hlNhXnhwlWH6Dvyqx+MD09dqV8JU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721670423; a=rsa-sha256; cv=none; b=Tcdd9EWS5MgcLLH5WjHSxgvSyKlingHfW5VOz3m8slV6Sv1nv+y0MdOMHCacPsShp8ANPk TOBkR0yrLw0vDsbgXWo/JgxdVuXkiOtDDJYoWr9oSOOO1jEdH0Nb01MfNxnni2zTsUA4Bx aSysn3/6dQGe8YwfH98/X+UoaRLwjkw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eHTZlzC3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-4f5153a3a73so840049e0c.2 for ; Mon, 22 Jul 2024 10:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721670473; x=1722275273; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=/ANlfruZmo4l7ccwD2B2KKiZpD4Y7MpMXUEVtTMzZJI=; b=eHTZlzC3iQeDiHO8vMh8vG/mdJQp/CxkbkGr5jMsdt40sPD86hiRFiNhslQf4IFBdX LINNyqgPjtse++fiMovA/K4AobEqYjqL5IDnlClFQsLojLLRD9FPn6dgx9ih4sjpMwzL 6H8XQmDWZtTKq4Zg637msUbWDSm9aSQ77QVO5OZrxkpQ4OScjOwP9zCa5V9d9AkpXASh yh5P1r6Lb1p0ZtG7r6JAZP5wvB95L56D8jZpBxSK1+xbHvZODcdMOlppWJLAz9OvAV7/ 27uXhfYj/+0kvVESFBmFKXToorE6SV30JMkWFpVGVKGC7mrXCCTn+lkc1u4vAglEa/SH xaWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721670474; x=1722275274; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/ANlfruZmo4l7ccwD2B2KKiZpD4Y7MpMXUEVtTMzZJI=; b=FDLlFbTyfkSR8Oo2t9mr9wn2Hb1JkmbsucgNMnYmjMHDZNKmktciInz39ccGILLnSX XN9nb6kQkgLP1Cr1u8Fb6a/sjohqFLVV9CbcYUYsErpd50jVe3+BTfVqPONt9zLwkK3W CnUeaPTvW5PyK5f2S7AN7cR+Scnz8r+P8rFy4j6Yn/PmNMUIzRA4qAjoYGEZfbym6c8m fPjX+92I7wctN5bETR65g6dXtrgZmIke1l2lTk+VNom/85CSPWcN4xjrYbkBs5IKIqm4 UZDnjL3OxDc8/oGTB4Qz5YDUh474yQM6UMrFs+JDgWEIk+2LsGUVwt+YnX8uofPxjDed 9xiw== X-Forwarded-Encrypted: i=1; AJvYcCVHZufQhqfvmdvsXd+XacePnFiUcpmi/Yxx4ObhtcIdbI0SYIkeUOSPQS763MdD8B/N9iqQ2BPYa3Z+t/7mr8MgUf4= X-Gm-Message-State: AOJu0YwJeBQwAfFzgZU/4VEfX8p1M52NBAq2lwcBhoqa28N0ri0YoIOz Q3bOhNIPHgZ4NT/pYw5efMtIu4ia/K9c22dUZeM33vsZb+GdWxC8 X-Google-Smtp-Source: AGHT+IGaojxqHxb5zQdMj/U7MB7QnqT/LcZ56HsdbQYnOJUSYoy0tjW0By+nVVAUk0K46UfhYyWndQ== X-Received: by 2002:a05:6122:4597:b0:4f5:1ea3:736f with SMTP id 71dfb90a1353d-4f51ea386eemr4706788e0c.13.1721670473446; Mon, 22 Jul 2024 10:47:53 -0700 (PDT) Received: from fauth2-smtp.messagingengine.com (fauth2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a199013905sm382964385a.67.2024.07.22.10.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 10:47:52 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfauth.nyi.internal (Postfix) with ESMTP id DC79E1200066; Mon, 22 Jul 2024 13:47:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 22 Jul 2024 13:47:49 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrheejgdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhu nhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpefhtedvgfdtueekvdekieetieetjeeihedvteehuddujedvkedtkeefgedv vdehtdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghuthhh phgvrhhsohhnrghlihhthidqieelvdeghedtieegqddujeejkeehheehvddqsghoqhhunh drfhgvnhhgpeepghhmrghilhdrtghomhesfhhigihmvgdrnhgrmhgv X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Jul 2024 13:47:48 -0400 (EDT) Date: Mon, 22 Jul 2024 10:47:30 -0700 From: Boqun Feng To: kernel test robot Cc: Suren Baghdasaryan , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Kent Overstreet , Kees Cook , Alexander Viro , Alex Gaynor , Alice Ryhl , Andreas Hindborg , Benno Lossin , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Christoph Lameter , Dennis Zhou , Gary Guo , Miguel Ojeda , Pasha Tatashin , Peter Zijlstra , Tejun Heo , Vlastimil Babka , Wedson Almeida Filho , linux-mm@kvack.org, lkmm@lists.linux.dev Subject: Re: [linus:master] [mm] 24e44cc22a: BUG:KCSAN:data-race_in_pcpu_alloc_noprof/pcpu_block_update_hint_alloc Message-ID: References: <202407191651.f24e499d-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202407191651.f24e499d-oliver.sang@intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A0517140020 X-Stat-Signature: hdgwmrbrpr56tgfegg8at1879phrrcpa X-Rspam-User: X-HE-Tag: 1721670474-148005 X-HE-Meta: U2FsdGVkX1/zqSB63L0Yz+C/rxrvUc2gfbHvrhwwdZEajzNBNzfrgHpSnLV5erg9gVDzbPS3sDT3C0VRoN/8LE77F7Qef8Pgx3Bwle5e2LS4NXb5MlSheG78sf7DD09jqu6HNpeBThibGnA3kxd1qEkVmzy4ePamO4s7nCDtjj14yM81RV7wrJBkVpGPp+6KgG7eVnh5YikBErC7F7mzCwfF2z05L17yhfvrmQhuBufOmEvZ3n38MQuCSVTg0Yyu054CqGhoj1XNC2SgCS8fCl7cBtrBDB8atz49H+JtFiQD5jKGG40CJ9dmIZci3ziPHh/3xqaZ76vViC+PZi9wTDoAsIm85MnQgX8VTieUTAkio+z6KADu9NBX2BauLLfqCeQF0kW4ZQGYk+/4pC1MmdXqCqyaR9uK9rUSTKR+BfhBCbiuyM0oBLOizJd2J0DEN/x3HiWudK124LWfVeFB+vwlG7zpgj69zQoMQFtmBTngUzvYNnw4jVkLnHlmkn6qn/JgHgUK8fJxtAofEtQX0VkXzuya7M1jIbOq+C085dA5+J9R/edFoYwH/8HwMjzc1jsTsnMrsrnNJgTVVPD9FI13KCAL7qNdhYjNgJ4tYD3VrZhHWY3uFyPYzwImhS2eFtIMTaQrUjkbk6gAxAKjt9M2nWzXSBe4/YrY9LUgv0zX9/MeFWwNF9XhyyX1NwwWATnX0M3StDYIyqwKTBB5qMv93FUPnNsVtkC8KGUNjm8d/44axCKQYSJHwDG+mRNVcGTVbQiSJsDkyBNIEHMQrD2qs0NVN6GgGMg/zv4tmrO7o2Pwj/xYQtcestqT+H59HvVLNWNE10dX5xMa//uXWb/6E6L1567/3D0A4Rv/UI5iCnXujRo/t+4xKOcrXWww0n24KydciuCXPbQvw3NuWTT80zZWeMlqOGNrcoMLszcwXWgBVXCxJbf+V/m9OFZFAeWF7Xqy0x6VvDhtmzW 0Uih86az 5QH/hGoftzHFD5Rc6UongAtpRR7XTlAW3sfNFHBuVRNPkrvtteFhDkZtTsef89gBwzKc1BIdQXaF+uK1QTNgneJdL4l3p3xv7INJpzJKa3JHsfWi3sHhEt3HcFDHI8srtQ8JX6ggXB8LPPg6SP/qpwJwn/96uOJykk8WgtZa+eG9tgQYtVGiv3/GEoCRaCkV7ufqFiV6mctJZaeJlp3pYHNQvN76OmKJrNAUCsmvFPPtuHokMloJL9L7acKDvAmw3jq1RIXzSNGyhmjCNSpmHWf4A9IIY//q3EPqNmsXmjEDLDSt/1uRfUpspRE5Jz83UubrG7Cxn7uUEDAnHE+JLPkok2wepafxYIiQ33INcNrOYjUIS21IZe84AtPnUt4A7Gy4WyJAtZgerOKG6xa6NZF/xaY65xL/nIqSfvM0Zi6t051+36z5LP6Iz45HsrZDNUk6nAwtfAltsjJTQ626dE+1FsJt2uQrZy/hyl5fxE7Xk7NVhYV0TGjMlS+JPprOgiESclAkZ4MQni4hzwTsRk40JaQ+uK3LgNa8d6eTtgx6jJBs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 22, 2024 at 03:30:01PM +0800, kernel test robot wrote: > > > Hello, > > kernel test robot noticed "BUG:KCSAN:data-race_in_pcpu_alloc_noprof/pcpu_block_update_hint_alloc" on: > > commit: 24e44cc22aa3112082f2ee23137d048c73ca96d5 ("mm: percpu: enable per-cpu allocation tagging") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > [test failed on linus/mater 68b59730459e5d1fe4e0bbeb04ceb9df0f002270] > [test failed on linux-next/master 73399b58e5e5a1b28a04baf42e321cfcfc663c2f] > > in testcase: trinity > version: trinity-i386-abe9de86-1_20230429 > with following parameters: > > runtime: 300s > group: group-04 > nr_groups: 5 > > > > compiler: gcc-13 > test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 16G > > (please refer to attached dmesg/kmsg for entire log/backtrace) > > > as we understand, this commit is not the root-cause of KCSAN issue, just make > the issue change from form (1) to (2). furthermore, we don't understand why > the issue happens randomly. but we failed to bisect the issue (1). so we just > make out this report FYI, not sure if it could supply some hints to any real > issues. > > 60fa4a9e23231721 24e44cc22aa3112082f2ee23137 > ---------------- --------------------------- > fail:runs %reproduction fail:runs > | | | > 281:999 -28% :998 dmesg.BUG:KCSAN:data-race_in_pcpu_alloc/pcpu_block_update_hint_alloc <--- (1) > 296:999 -30% :998 dmesg.BUG:KCSAN:data-race_in_pcpu_alloc/pcpu_block_update_hint_free > 25:999 -3% :998 dmesg.BUG:KCSAN:data-race_in_pcpu_alloc/pcpu_chunk_populated > :999 29% 292:998 dmesg.BUG:KCSAN:data-race_in_pcpu_alloc_noprof/pcpu_block_update_hint_alloc <---(2) > :999 27% 269:998 dmesg.BUG:KCSAN:data-race_in_pcpu_alloc_noprof/pcpu_block_update_hint_free > :999 4% 44:998 dmesg.BUG:KCSAN:data-race_in_pcpu_alloc_noprof/pcpu_chunk_populated > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-lkp/202407191651.f24e499d-oliver.sang@intel.com > > > > [ 117.357897][ T3648] ================================================================== > [ 117.358568][ T3648] BUG: KCSAN: data-race in pcpu_alloc_noprof / pcpu_block_update_hint_alloc > [ 117.359222][ T3648] > [ 117.359424][ T3648] write to 0xffffffff8559e600 of 4 bytes by task 3653 on cpu 1: > [ 117.360048][ T3648] pcpu_block_update_hint_alloc (mm/percpu.c:602 mm/percpu.c:598 mm/percpu.c:923) > [ 117.360554][ T3648] pcpu_alloc_area (mm/percpu.c:1260) > [ 117.360960][ T3648] pcpu_alloc_noprof (mm/percpu.c:1835) > [ 117.361393][ T3648] bpf_map_alloc_percpu (kernel/bpf/syscall.c:466) > [ 117.361825][ T3648] prealloc_init (kernel/bpf/hashtab.c:338) > [ 117.362211][ T3648] htab_map_alloc (kernel/bpf/hashtab.c:573) > [ 117.362618][ T3648] map_create (kernel/bpf/syscall.c:1320) > [ 117.362987][ T3648] __sys_bpf (kernel/bpf/syscall.c:5642) > [ 117.363348][ T3648] __ia32_sys_bpf (kernel/bpf/syscall.c:5765) > [ 117.363738][ T3648] ia32_sys_call (kbuild/obj/consumer/x86_64-randconfig-013-20240713/./arch/x86/include/generated/asm/syscalls_32.h:358) > [ 117.364151][ T3648] do_int80_emulation (arch/x86/entry/common.c:165 (discriminator 1) arch/x86/entry/common.c:253 (discriminator 1)) > [ 117.364578][ T3648] asm_int80_emulation (arch/x86/include/asm/idtentry.h:626) > [ 117.365004][ T3648] > [ 117.365203][ T3648] read to 0xffffffff8559e600 of 4 bytes by task 3648 on cpu 0: > [ 117.365797][ T3648] pcpu_alloc_noprof (mm/percpu.c:1894) > [ 117.366210][ T3648] bpf_map_alloc_percpu (kernel/bpf/syscall.c:466) > [ 117.366627][ T3648] prealloc_init (kernel/bpf/hashtab.c:338) > [ 117.367000][ T3648] htab_map_alloc (kernel/bpf/hashtab.c:573) > [ 117.367400][ T3648] map_create (kernel/bpf/syscall.c:1320) > [ 117.367766][ T3648] __sys_bpf (kernel/bpf/syscall.c:5642) > [ 117.368120][ T3648] __ia32_sys_bpf (kernel/bpf/syscall.c:5765) > [ 117.368503][ T3648] ia32_sys_call (kbuild/obj/consumer/x86_64-randconfig-013-20240713/./arch/x86/include/generated/asm/syscalls_32.h:358) > [ 117.368907][ T3648] do_int80_emulation (arch/x86/entry/common.c:165 (discriminator 1) arch/x86/entry/common.c:253 (discriminator 1)) > [ 117.369341][ T3648] asm_int80_emulation (arch/x86/include/asm/idtentry.h:626) > [ 117.369761][ T3648] > [ 117.369968][ T3648] value changed: 0x00000003 -> 0x00000000 > [ 117.370454][ T3648] > [ 117.370662][ T3648] Reported by Kernel Concurrency Sanitizer on: > [ 117.371179][ T3648] CPU: 0 PID: 3648 Comm: trinity-c2 Not tainted 6.9.0-rc4-00089-g24e44cc22aa3 #1 > [ 117.371943][ T3648] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 > [ 117.372811][ T3648] ================================================================== > This looks like a data race because we read pcpu_nr_empty_pop_pages out of the lock for a best effort checking, @Tejun, maybe you could confirm on this? If so, a fix could be as the follow, i.e. telling KCSAN that the data race is expected. Another fix is making all accesses to pcpu_nr_empty_pop_pages atomics (via WRITE_ONCE() and READ_ONCE()). Regards, Boqun (is there a way to tell the bot to issue a rerun with a diff? ;-)) ------------------------>8 diff --git a/mm/percpu.c b/mm/percpu.c index 20d91af8c033..0626ef12099b 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -1891,7 +1891,12 @@ void __percpu *pcpu_alloc_noprof(size_t size, size_t align, bool reserved, mutex_unlock(&pcpu_alloc_mutex); } - if (pcpu_nr_empty_pop_pages < PCPU_EMPTY_POP_PAGES_LOW) + /* + * Checks pcpu_nr_empty_pop_pages out of the pcpu_lock, data races may + * occur but this is just a best-effort checking, everything is synced + * in pcpu_balance_work. + */ + if (data_race(pcpu_nr_empty_pop_pages) < PCPU_EMPTY_POP_PAGES_LOW) pcpu_schedule_balance_work(); /* clear the areas and return address relative to base address */