From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB92C3DA59 for ; Mon, 22 Jul 2024 14:59:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98EFE6B0088; Mon, 22 Jul 2024 10:59:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93F4A6B008C; Mon, 22 Jul 2024 10:59:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 807856B0092; Mon, 22 Jul 2024 10:59:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 64C166B0088 for ; Mon, 22 Jul 2024 10:59:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 031181C402E for ; Mon, 22 Jul 2024 14:59:07 +0000 (UTC) X-FDA: 82367696376.13.3A1300F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id BFE21180004 for ; Mon, 22 Jul 2024 14:59:04 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uscHRmSR; spf=none (imf24.hostedemail.com: domain of BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721660300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0suE9iJedWZqthG1aOPFasnjcurHspan+ck/bWfHjIM=; b=N2sK/OAIfczpvvO6lHtoSAtyOiSUdYm6YLI4aVk45OG27SQVm0SLFVU4s5oj3z5rySaGzz bzIGtZNAE9l3fYkMPjxH7a9/uKZsUo0MuXPZwdUZHMqRiwx789n1U8xejQl1CFqd6L2tlr GkErFy1V3c8j6jQ+8vYakieMbCJIlWo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721660300; a=rsa-sha256; cv=none; b=Ns0sNvL2djNEYv1YGqnv1JemlOE42TJ3pXL0rhcNJ8UBfwEyc1H/fYp+1ymsaHNZb3Z+qC DV+arVeom1YC1uZpK62uQNUziEYL8VtuQlbG2JPSrh9ol+weImRVUCvJllwIiuotVHNL+W zfYGXogDhC4s1M6bJ0ISaVJAoE/Fnjo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uscHRmSR; spf=none (imf24.hostedemail.com: domain of BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0suE9iJedWZqthG1aOPFasnjcurHspan+ck/bWfHjIM=; b=uscHRmSRk+y+GLKM2By67lV+UU XSe59nM+l1Wg4HS0TEVTy8Isy4qoRD3oDcyXG01Zr5MGgKKuptPm4GszuWQaT/o8pRNdYYP+rW8Pg 1N4v40UJ2ZySxHcyHfcEX/+ZK4CYBW0R/8qdLu5PVChSyWm5/6a9ep9e/nqjUom3qWbOTNGwqIT0y j9t2EvHFCj/arb0e8JdsN2gigvaj0N++Wic+yEFZWCUsYQB0ehtMRYIojlE6lLS1EO5EAM2ZoN8mE D+xQpR4L8SF519STJZ9dEed/Pep3joo3U/GQyxfP3cjmVgp/VI8xufqfttws5kLMp01SAxxETU0DZ WZDAYEnA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVuV4-00000009r7o-3jBD; Mon, 22 Jul 2024 14:58:54 +0000 Date: Mon, 22 Jul 2024 07:58:54 -0700 From: Christoph Hellwig To: ysionneau@kalrayinc.com Cc: linux-kernel@vger.kernel.org, Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jonathan Borne , Julian Vetter , Clement Leger , Guillaume Thouvenin , Jean-Christophe Pince , Jules Maselbas , Julien Hascoet , Louis Morhet , Marc =?iso-8859-1?Q?Poulhi=E8s?= , Marius Gligor , Vincent Chardon , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, Robin Murphy Subject: Re: [RFC PATCH v3 24/37] kvx: Add memory management Message-ID: References: <20240722094226.21602-1-ysionneau@kalrayinc.com> <20240722094226.21602-25-ysionneau@kalrayinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240722094226.21602-25-ysionneau@kalrayinc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BFE21180004 X-Stat-Signature: mj6o7bi7cu1snkai5z5wrhcye7npqe1i X-HE-Tag: 1721660344-781426 X-HE-Meta: U2FsdGVkX19UrLNxDfBMbcjMUB/GQe0mcxqxQaUl78CT0yTmb8q4oDZErP0jkezSZl/Xq3JuOketjoOz1Z0kBvnyBA1ymCxyYbxfP7bxeOjQp3CTgGbakQxpqbiLpdURH3xm9haiLk9LktT6En1EzVeRSUIuO1y2CgCurjE3CE6J+OQICM1K9xTUTHdwkcwcOCGS3zxymmxyYcFyvtkcPYKr/sKuNNQx/l2CaYOi8yvgop/ldFdIpEDCFyVEcxrGSVTdfv7It2jjfAhQh2r5Nzy5hAokPDzgAxCMpZfqlx9CjF7E7nz2vMzqnq+viAd0NEFyKpPJk7y0LvPZqfSbUqrJuxAjH3MmXSuNo1wRjCSeIBfOSzsc/SoPTt1qYSAF8NOeIWi3gU3UKIWRF5K2A6slorEWoQBbAyuYlDX8CgsFrHZM6UTNE/wsto38PfuQkySpZsxJoFwJFRcOd0xoYJoDVD6JSgekyIpo8mzvOHSEWppoiaTAPoKUQaDmRy1f2aVVqJcp7XGF/EnV4C8mfesx/wxImCX537leIGH1jqEkyXEZMVpATUQk1jrBUUb6ECJr91p9lPe3kEAMfY5SoYvNmar0ViyMyUdBDwecEXrfnVXbCP0eVSN8b+cvF3PtaLSJnLRvnxo8sTVcV+97yXrhez2ZY38o8lX6Vs/lZBExgpUi89tMVJfNFWMV+vPvp4tDmCj35Trd5xJHgZ414Ajwus3CwPu1NOFKZRsBSnzocJ75iNK14IyCSMNvMfhj93ogtLdgHFTzz0Am3ialwx30X0IRtTqSDosFUtpQI1hqkHFgPGepvBeS8dn/Un04pdazCIuXq2msqH+o00YNaSN79OgOWJHwQh1XKpXKs413B96FP9oVWYmRhi+dQo9LFIFsSyUHg6iA6zmaEOqzsqXerrmFk1zKyfOTyBMzNx+S/V4xE84VvrjtEj+GeJbgU7QFQL6R5iR698J0gpS pNjj3SZe n9SM0OeeEysd/j95UDD3Z0QDMonn5ckPMsEDP6geAUBq3zGFU7a5CrglooK696bNjPPm7F4LCALwTA6w93VmhuN/JclIJBawH6QwywPNsniTqbDg4U6P3iNFM3FVRdUizoypu99zR2RpYLJ6wS20e+KZWT3Gf9FoBOFGfeh+D11ZiDXl/sjwdAVfxL+gTyDPIwZS9aFNLmROeyc6rOeyjh/IJmWMBlSQoAkq0tC+FZjZhYK9/EG/2RSKN9Ga32bQbnXT85BXYFNwgespyZjSTS9MxYwUY2hhjHZyx0iV0CmJYmYZMBb7ropCvF4lc0HuDw2v4eYSQeIIU2KbhbDBHbQv4+7JBxewbdgN6p5D1aemTyW21NIxZeq01d5X3uHjG6NTuKTqE1Ko6pncmULPfH0AFYzbkD5N6QozsB7XH7T5anl3gezygALVZxpyK7wd4Bv5+TsB4rbJ3fgM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +#include "../../../drivers/iommu/dma-iommu.h" This is not a public header as you can guess from the file path. > + switch (dir) { > + case DMA_TO_DEVICE: > + break; > + case DMA_FROM_DEVICE: > + break; > + > + case DMA_BIDIRECTIONAL: > + inval_dcache_range(paddr, size); Doing this just for bidirectional is weird unless your architecture never does any speculative prefetching. Other architectures include DMA_FROM_DEVICE here. > +#ifdef CONFIG_IOMMU_DMA > +void arch_teardown_dma_ops(struct device *dev) > +{ > + dev->dma_ops = NULL; > +} > +#endif /* CONFIG_IOMMU_DMA*/ This should not be needed right now. And will be completley useless once we do the direct calls to dma-iommu which we plan to do for Linux 6.12. > +void arch_setup_dma_ops(struct device *dev, bool coherent) > +{ > + dev->dma_coherent = coherent; > + if (device_iommu_mapped(dev)) > + iommu_setup_dma_ops(dev); > +} And this seems odd, as iommu_setup_dma_ops is called from the iommu code and you shouldn't need it here. I also wonder if we can come up with a way to do the ->dma_coherent setup in common code and remove a few of these arch hooks entirely.