From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8155C3DA59 for ; Mon, 22 Jul 2024 14:21:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85B4F6B0088; Mon, 22 Jul 2024 10:21:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E73B6B0092; Mon, 22 Jul 2024 10:21:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 685C26B0093; Mon, 22 Jul 2024 10:21:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 488CF6B0088 for ; Mon, 22 Jul 2024 10:21:17 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BC42D161859 for ; Mon, 22 Jul 2024 14:21:16 +0000 (UTC) X-FDA: 82367600952.05.5B972A8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id B1EA340020 for ; Mon, 22 Jul 2024 14:21:14 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="Uag4a/Xb"; spf=none (imf12.hostedemail.com: domain of BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721658029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=41WPFfseiK2/vJ3aOz/gu8hVRXaDWwMZhSZxVhZSgnk=; b=RJ20q62Duhnms9MeLIGmRISscKgp4XJG4DWpyVmW06v9WJ6erNcnIYy0td27GMOeBOnfy4 6QF+A0cl74oLAOkQ80hgbKoLtchN4ELZetXPV0DWWC0SjRCitc0gIgXpp1kTA/lZhk0A5z 9Tnnh0gL4QJ5ur8m3E9ve3yGYGWdAEg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721658029; a=rsa-sha256; cv=none; b=Exa4TL12XSZ+SWL1rhvxVH/IKuEi8yseKqTmzGhmJYz3eg+3QpyT6aTd25RUkkTt73i21o eddPkkvY9eCDNb36AgxGOev+P/WtPYQMQ86Tk2F0iEzU7VGkswbhwkYrbsLWeTkwPmVMYg Rz7bIvTzSbeHPs7AKa8vWD78QjqRwoE= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="Uag4a/Xb"; spf=none (imf12.hostedemail.com: domain of BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+aee584a80ff3c56ff720+7638+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=41WPFfseiK2/vJ3aOz/gu8hVRXaDWwMZhSZxVhZSgnk=; b=Uag4a/XbVp5GzwCmpiQxJluvKM RJqjTPvd6JQEg9x90iTXqzLTUcVtB+AvaiDBItO4QSGPZjGdJOYQct6sv1EcAvZJ1Hz7uLa4WxuFL kEBju2iyspJqhzxYHos6wEfkEw7MGQpB4wJaj40iIBMpwwvBc17xnk3E7nIpbw4tNIsPfGpNIXXaK jiS3huDOxde7be977VGHk2wDewSyXu/didHBmQ5vK4iwVzlSqm+4FRAzxaGaMGTMaT7VFLPSdtcX+ kTNyvmbHLNKmKon0SKXGYo5UfUrbZyhl/2RUOMbC8qHWWRk12Q0dxqaHVTeUt0R4eTh2/UUa3+BX5 WRtEK/Ew==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sVtuZ-00000009kxr-0GiB; Mon, 22 Jul 2024 14:21:11 +0000 Date: Mon, 22 Jul 2024 07:21:11 -0700 From: Christoph Hellwig To: Yang Erkun Cc: zlang@kernel.org, fdmanana@suse.com, fstests@vger.kernel.org, linux-mm@kvack.org, hughd@google.com, akpm@linux-foundation.org Subject: Re: [PATCH] generic/736: don't run it on tmpfs Message-ID: References: <20240720083538.2999155-1-yangerkun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240720083538.2999155-1-yangerkun@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B1EA340020 X-Stat-Signature: jw9gzys84881oh9bdw9it85qq6u85woy X-HE-Tag: 1721658074-504055 X-HE-Meta: U2FsdGVkX1/qo7qzuMfR6O8tvtcuB35VCKFYcAdkrHb38jDVYiqgwY7E0EJRMs8ZWIEMQRRtqbL82wcVz5D04pzwm/KfWueiNEYZLlFWyFg7jBP0IX43oSOA8r/qwkO0SUroYxJKE3dE7DRtgnBpJl/idaE9qBSA2ve6D1ZSb3TZfhzxuEPKZpZy2UV+VUCifF6sXb09E3m3BW4l1bKojgEeY1cdD6wOD2e3XovGwV2YeHqncfp0h21m5rXZtIzai2r1OWJ1XR0Sa1EM1Fkbccjsh/dIN1I5Xvp2IgLrMe8V3t6qnKVJeOrH1NXXPOpiCEYV4e1meSRYE9snMV1NwlRszE8U/pfsBEPm4ZvNF9Rps2SPnsotasgIUEVLd5fniFV8rc4xXIN08IuPoBdGw3g9rnFFkbDR6iTSYqb+vsnfqjfT+/X25VBsnIMHVImvWbhSzIrs/p3MhZMMXYaIoq4TJSCMeD8yzClmO3wzOCLdTyZRWY6zCcWDUYekPA6YRLqglUmGhNmjPO2M1f42ovSYQkaDl39zyQepUufs3oS3P1F+sycworxXtERgVc8a7gHme5CB030xH7h0RWIK/Vic9AYJoiR+EyvFyzBHs5muyQMKo7Glfu+hgEvBCCz9S7x3USmsuMh5Ma0SKHlqHGIofZOBWCiWMTIi+ukT8fNG7MBWjXqSpiItlHicRQaPurSx+VrmaASgnBefT57cQy6zv1iY/lg/zDfaPUuiaqWVeaoWXVEchYuj687lnoLAM81ONHs7/1OFxWWcd/YrxdCuzUyLKFWbSTH6X7y9u8+rK9G3MyiqT7o8IdgHLjvBgf3tKBU6MrIAHvFlxJJLU2K85D4ytoJK6Bl6J1xo1TmrRwtkSx9ZGCxlSIu3AJ0Yt+5vT5wysR8p8E4Wrj833CxUgJcMX5MdG39ef1je+tMqYb7Js2dVqdC3R1dLezkBaYvJW7KWsGmUAJ33U9+ Yfb19PjP xwChQnZ8dokaN20A01y11FiH4PTRUUqBoiHBWF7qWe/ykzTRSw5Z2vXziLtT5r/qKvD2aS2WgELESRqpnhUEA93bm62gJdOI1jDScTc4ju8TE/99jvp1cDmfYVQ5VYQwwJs2y4WDlakOvvbu1kaGhpiJHH71aqtnCGkvG7qH9Ev0KQTjYxCDezofBjRNhOy0dyqgJUSU/iO+FVGWJMNcryQFHA48neDBgXTSv3tgMUWISypW0DFimN/+2vJUxXis9XFKIFtOkCdVICJS5WYDWUaifPEktKPL/lhEDu7RGkUYg7sUhhxL90WM58yWJt82A7sqHurlRQJxYefEw6jXdLSmVQ9Bf/IglpAci01b6M0cKuPMehFjZmICPMwP7uFQiLr9qQWmpwikTzZsI6te5j8BhbEcqZcOyeYAdbuf0FjyXg8MsHg033LATGQ+IA92nIP3MrUKugBadnt0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jul 20, 2024 at 04:35:38PM +0800, Yang Erkun wrote: > We use offset_readdir for tmpfs, and every we call rename, the offset > for the parent dir will increase by 1. So for tmpfs we will always > fail since the infinite readdir. This honestly sounds like a bug in tmpfs, so maybe we should discuss the behavior first? If the changes goes in please write a comment documenting it in the test case.