From: Christoph Hellwig <hch@infradead.org>
To: Yang Erkun <yangerkun@huawei.com>
Cc: zlang@kernel.org, fdmanana@suse.com, fstests@vger.kernel.org,
linux-mm@kvack.org, hughd@google.com, akpm@linux-foundation.org
Subject: Re: [PATCH] generic/736: don't run it on tmpfs
Date: Mon, 22 Jul 2024 07:21:11 -0700 [thread overview]
Message-ID: <Zp5q16N3m6qGilMu@infradead.org> (raw)
In-Reply-To: <20240720083538.2999155-1-yangerkun@huawei.com>
On Sat, Jul 20, 2024 at 04:35:38PM +0800, Yang Erkun wrote:
> We use offset_readdir for tmpfs, and every we call rename, the offset
> for the parent dir will increase by 1. So for tmpfs we will always
> fail since the infinite readdir.
This honestly sounds like a bug in tmpfs, so maybe we should discuss
the behavior first?
If the changes goes in please write a comment documenting it in the
test case.
next prev parent reply other threads:[~2024-07-22 14:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 8:35 Yang Erkun
2024-07-20 17:26 ` Filipe Manana
2024-07-24 13:30 ` yangerkun
2024-07-29 13:53 ` yangerkun
2024-07-29 14:21 ` Christoph Hellwig
2024-07-29 14:26 ` yangerkun
2024-07-29 14:29 ` Chuck Lever III
2024-07-29 17:35 ` Filipe Manana
2024-07-30 1:02 ` yangerkun
2024-07-29 14:32 ` Filipe Manana
2024-07-30 1:05 ` yangerkun
2024-07-22 14:21 ` Christoph Hellwig [this message]
2024-07-22 14:25 ` Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp5q16N3m6qGilMu@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=yangerkun@huawei.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox