From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1300CC3DA59 for ; Mon, 22 Jul 2024 07:34:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A25D16B0095; Mon, 22 Jul 2024 03:34:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AF526B0096; Mon, 22 Jul 2024 03:34:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8293B6B0098; Mon, 22 Jul 2024 03:34:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 602AF6B0095 for ; Mon, 22 Jul 2024 03:34:58 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0BA81A4E35 for ; Mon, 22 Jul 2024 07:34:58 +0000 (UTC) X-FDA: 82366577076.15.6B76C5A Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf01.hostedemail.com (Postfix) with ESMTP id 22A7F4002B for ; Mon, 22 Jul 2024 07:34:55 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Yf0rnxs9; spf=pass (imf01.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721633650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LsvUE0o57OouoC7fjzRG0Fp0z7u/TQO/RaOGGl1k+XY=; b=urYJsGTIYMlt+J9ForSxoeMiv/qSnMFH8JnbhaK4JKMTc/UV05VrmrNWcD2yjpYmO3C1ea ES1/FX8NIvIvCh4OmVy9FxKtB4k9iPTOPjfg5bNE/wusc4+qLmZBcHb6hyLs3E+Ud7QpNs EPh1s0ki0nkduxFyRrOXe89xXAVsLSs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721633650; a=rsa-sha256; cv=none; b=oZiTEPZrdZfGJW4TYFzBT6wfWAhq1NxFeIF+jp9MmVFHVJMFLFN79W46VfxQ360QMxDmn2 5qRDNYX3bwVoczDpYX1FAHR5wqulawyWB07I0GFjFSqssHl54L7A42MKchXuCdMstClZ45 yOoKoxd2qrAEjnzVzEtkHqEc34GgGZA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Yf0rnxs9; spf=pass (imf01.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5a156557029so2913063a12.2 for ; Mon, 22 Jul 2024 00:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1721633695; x=1722238495; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LsvUE0o57OouoC7fjzRG0Fp0z7u/TQO/RaOGGl1k+XY=; b=Yf0rnxs9ZpZHrete2c9MSRDorTLBJlZux1LTe59SWUXDr6VoZTKRovfoPZ2XqskOvo vEEtRk/o2BLVh1FxCb+Zm/oHTwTvsRfAWnBjaGPFv7E/ija/fupDmC5iK02kWuySG6WC RWd9MkXBBv64Vkymjhk2UV/slZfGoVt1swaRecXrLinK1iQhO++/Y9OkP+9kXWIVoJ8Q UwBBv2PAnzZrCmZYImG8pQhxOH+UhAPfOlrJ0/nQqFSYMr7c/vYTuCYL8gb7GSHP70nD k3B5hVQOGIdsUGYQUWpdfCnWcwdFTS63oS29zEupajgdoswg3ylxI5tLxwi2nYZw8/sl NjZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721633695; x=1722238495; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LsvUE0o57OouoC7fjzRG0Fp0z7u/TQO/RaOGGl1k+XY=; b=xIsI0FNH+0cVFSrJgA24g4nzHh0MzIxd43YDhvr4GpZnt7ru+CWnn25XuezpUKc6iL 7lNNQG9tr4HRfWerW7jEy8n4N6f+3Gr3v1FJCytjGTolMe/7xQmLrHehBsdKhNFJfo1h 1gQU3AAo6BfBNiXsgjlxxSxA3MBw6cSarbHudOnAONrFBC/V+CgQ4X/U+rDG/qO4SIUe Uxm4iITR/1Eq5DnirewAWc2Ah4LlWLKh3/HZFTgJIShYYo1IEnwCtmQPIUeAIeAGgM9D dN//N3wwN/+/zISfE312blfhO84+/GYAIRZmhsP5Z2jhpPbUcKHkYZ2ZInkdjoyve8jq YSuQ== X-Forwarded-Encrypted: i=1; AJvYcCW63m4FOWbkGR/iuYkBbMDdXoHoZNc39nqONIyrJNye7Ir+GR4KiSuTw05Q5aqjo5vgsMSRSyu3EGZyGEAbP2D9N28= X-Gm-Message-State: AOJu0YyE7Lcv0Xo3/jjmG4lB2acOLtE0sT2sD+YUKc9ZhcDwQcPxNwj9 V++Zz8mnmvCv/AeJ9KmFd9wjZbBc9SvIMWN4mjxDRuJwqSUIbRXXi357nyuTtEs= X-Google-Smtp-Source: AGHT+IEmWXROwHA87dq+wBT3GDAicPjakH0kJc74UbfmBRFfMAtxkJmSTHsiP8RgLPulsbfgFkyeVQ== X-Received: by 2002:a17:906:c142:b0:a77:dd5c:d7f4 with SMTP id a640c23a62f3a-a7a4bf39ab2mr351235466b.15.1721633694678; Mon, 22 Jul 2024 00:34:54 -0700 (PDT) Received: from localhost ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7a3c91e052sm384748366b.153.2024.07.22.00.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 00:34:54 -0700 (PDT) Date: Mon, 22 Jul 2024 09:34:53 +0200 From: Michal Hocko To: Qu Wenruo Cc: Johannes Weiner , Qu Wenruo , linux-btrfs@vger.kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka Subject: Re: [PATCH v7 2/3] btrfs: always uses root memcgroup for filemap_add_folio() Message-ID: References: <6a9ba2c8e70c7b5c4316404612f281a031f847da.1721384771.git.wqu@suse.com> <20240719170206.GA3242034@cmpxchg.org> <9202429f-e933-4212-a513-e065ba02517a@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9202429f-e933-4212-a513-e065ba02517a@gmx.com> X-Stat-Signature: 9odx7czyq598ucrkunmehwjn4p5kwiby X-Rspamd-Queue-Id: 22A7F4002B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1721633695-128150 X-HE-Meta: U2FsdGVkX18irD8XLxDsZW7YwUCKwyyH9MYPqUTr7t1EboSa/f03V+DzDIAp1Klu0JJ9rwz1x9LpYcf+Lt3+DFxfFPk6MgI9iXsSS1my/ugA9pMUs+dvu8QgifyRbTOkeyfvDyi/oD2+v+WBIeCrnGo7Ip9HMlIe69d77ZaxUmEd679JlTRTkBHSZv1vGfwt7X8CEeDmof5d1NAbGJp0oDuBLIthgz9MVYf8oKXoQQdv5KNOKwVz/6gNYwS3iVtS/vECEhxUG/GbFWnobOC0f73UmmiULTPOHuChMFhUdJ7263hHUWWG55qRWdb4xPuq3Lx1ULehMiLnsdoMeEjdOwUR9BHAzY3QrrPpFWgErhbCKdTxLdnsPbcLcd2zsbLj9DETcxpYxiKRrXfZpBeoB+i+lyAK40buvTEtoxeLCKHRLvNX26lHN63Hw86cM7EinxxN9lvgnmFPJAeZs13iV3zOqRi9CJlKXOnfUx0eF8E/T3SI0K5nmmlue1R90E3I+6Y2dbgGrK/YQqmIOb3AolIPw6ug9c8QSlZXB9Ex3GalnBoVHRyvkbiMMx0a/oL5RqjxE3mmYO3cBpFbHHY7KP3NrgEOGjyo/0y2MLgdxOGE6EHDuLr+ngGXLc15qD4KU9Ow9iOgroZspB92FRxJM2NYUvlgYKClcAYp5CYSGBIpajpJ8MZesoD3S3LW8J5gGfPI4zMLRtkd94lLbXl/MbdPr/oVFfu1CzObDpAGKe/y9NfoW5dC4ChuLjxbsuZQnR2iLcuvigLmIpoUdjWfORI4lr/+LXkTtul1grgI3HAjxo7GT0bnlbGm0JgbxQQ8GMTbYQW05Fws2nj/FmI5m418dvAlnYcZ2/MEFzWQLYKX0kHmbTjdvuRTH0/BKGNku4z7bHVtVLuSjKcbvS8K7pxL2kVAAUQKux5XoJTX0wgW/mey/Nv7ByfRrvS8jdf2ZaJc865CG9Ww0HjE4Mg xqvk4h8E jcDMQ4qAtckrMXbjvgOVvvc4UAU1z8LujF/kpOFaYPPmF1LcpoVVwBfHUVsEAOw5I8VO2cs8WRBC801ebT4wsuHmIJv1MEyWA6RlJnV0k5LoJQhq+xklm+fhU8jRWE2Qbe1T5cxuEULyjEpsXxAEbH3ZpOxl2eLtwPwf7XEP9yRde/xPyrFp+HxbyfiS232jLgLoXT5+2CCppk+4XYKVyQhr0sFEc45g1FM/gw8Cow/uZiDRO5UBAZdcUyIeidPUUtlGNdOz+FWIhtrj3LBdq2yV7QQjUXNfS5c2BLnahL4Wm7dJFls7O8KLT7CIZNBDsS7IyrfqfMG09/P0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat 20-07-24 07:41:19, Qu Wenruo wrote: [...] > So according to the trend, I'm pretty sure VFS people will reject such > new interface just to skip accounting. I would just give it a try with your usecase described. If this is a nogo then the root cgroup workaround is still available. > Thus the GFP_NO_ACCOUNT solution looks more feasible. So we have GFP_ACCOUNT to opt in for accounting and now we should be adding GFP_NO_ACCOUNT to override it? This doesn't sound like a good use of gfp flags (which we do not have infinitely) and it is also quite confusing TBH. -- Michal Hocko SUSE Labs