From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FDEFC3DA42 for ; Tue, 9 Jul 2024 08:45:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DDE206B009E; Tue, 9 Jul 2024 04:45:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D670A6B00A0; Tue, 9 Jul 2024 04:45:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C090A6B00A1; Tue, 9 Jul 2024 04:45:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9F0596B009E for ; Tue, 9 Jul 2024 04:45:49 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0A805C17DC for ; Tue, 9 Jul 2024 08:45:48 +0000 (UTC) X-FDA: 82319581218.27.A313194 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 59FD014001F for ; Tue, 9 Jul 2024 08:45:47 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=paxxODwG; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720514713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Uvk5noDuLMz57iYzp9yK8mEncqsPYy2SNzcOg8zb48=; b=oVjvOYMa8riOSdk9NkULOqYfPkXqDrFJYqZ/fKpVvVvSwBffaUWTDHShFRKeaN7qQYvXe4 Y7T7zgaWDONSP8H05IjIOG1NEdXP7j0GgVRQ4WHUm2854Mh0bMXwxq2Q65a+H98vtRxrx8 2PkFGyV0UsP79Obww4ASolJNRf31M9M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720514713; a=rsa-sha256; cv=none; b=KCO7toBV2NI6+mn2RIqhiiNC1V60mQcyXiqfjOPuwMcVUnu5etpRTDdbOx00g6TOe62Es/ 6304zUDZP4jqNA4VwoULf9BV5qLiCbOoO4P3/s9mRpEaVzgBEzQCLGo6ntaIGPYeK5yoWO 6mHVuLVXJriA0UwqFifO0lAv2jU/mU4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=paxxODwG; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 683F661228; Tue, 9 Jul 2024 08:45:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D5A2C32786; Tue, 9 Jul 2024 08:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720514746; bh=HzI5ANFt9GMQuaC6OglWBygqf04hLrubGkDWVL2nkdU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=paxxODwGsxgN/pEQCvdzSL8hJYt+b0437kRpZFx7gvuqp0Et6MibQNDT7dw5OJenl ZpP2v5NDKIt5qyUIhYTRz9iwsCSYGTL4xOG8t3P6yP0guiI3pgywBrHRp6GLfiHsBm XejMQMS/XS45WISy9JQmiIx7rBSzf+xqah5JK8nYpVkjQ+WZB8L8rIuiZLWJmJ4WP6 SIUiCF2pYL7MLtZQGccyomcq/53rjq1QmSSws4PPLTBqgRBfJkdsR/SL0bWXzUx+2+ f8qPAc8Wxo9bxVRJkowDH5pLFadbbratB99pJeRW9j1/8/ABGTqkFuW+O5CfYhrRMP JNxz6kechq0bg== Date: Tue, 9 Jul 2024 11:43:01 +0300 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, brauner@kernel.org, oleg@redhat.com, tandersen@netflix.com, mjguzik@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH v5 2/3] kernel/fork.c: get totalram_pages from memblock to calculate max_threads Message-ID: References: <20240709023609.21332-1-richard.weiyang@gmail.com> <20240709023609.21332-2-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240709023609.21332-2-richard.weiyang@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 59FD014001F X-Stat-Signature: jhod496a9txtzdo9ft1w19mpk5furs6u X-Rspam-User: X-HE-Tag: 1720514747-20467 X-HE-Meta: U2FsdGVkX1/2CqPYYdkMaKDQH5D+oB3i62mGjW7GJFEILoiBeM2Qoh5YRdd3/jNLV/kaItdeqHjPJUb/INe3eZVszWz+lIyDsRbJqX+9J2ZUzO6MYYjeiKoA6cW1geygrmQwVH7ar5LzME51ZYu350naNbqmB7+Sh0bSQt6l/foOL/uQmi/hqEMohMOaqeFOA8p6ffpA3SOIQmCAUkH395kcyjaXFs0B5mwqaWOCl4uVDIGZgjyLY5MLUbNMoacjdaPWecl+oJNvu4joMopZHmdmdCuNWDpF+x3Y788KPbuDEgXgHlRBYm5uPo1Aie47IY8KhhOCjyN1DaLLdh88w8+Z7LkjlfCM8gBVemFiPOzEJLvWjYlE8oqGEnjcETs+U1CeYtLOXU/4ACDhVaMl1f+ABE0OsTmrrlMElFJXoDP/mWhojB272DW2l7hPHgpv4aVX7kp8NXHpxqryT7FWAWlhlow7zPhenv22q7g5bNyqi4wgfoVZja1UYIc+ghO0QOLajH3Yon6Op1ka+vJBoImyNtvD+mytgFQZAqiRiINdpume/+aKWNi4cOLYu2AQUJcXMwF3mowZgYdWrIgTnFcIie+8MWMs0ovObTP0Ed4CKVUlMv3hJQM67+kCnFbjxKpyaaX5butuGrZc0zLUKdp6ZHrD85sxTL/0n/BPU0kyqfFFnOhNvfLKMVo8/m8HOuS2OetJThXmS2PLINbj2/FpxKyAhCFr/EJR+fLVrz34OMvqkwMqW278bzLM+B8SwLI7Jax4hl4E+D8usSH5VrQakMzoUJeNT2t2mli4WdBZBGEoUOeZuJ/axFHCJpaHliJFbk7yReqSIvNhj0pnlluEpV4w80j4NYdKpy67goviH4p9EMl0Rr/EiTFB0q1pGF3trrwKcLjegnhbyE0oE3oTl0MflN1dOEwh3cfZbK+LUS8FWhUy59a0HJy4L5kD1yYCi11vhBqYs8xx3S8 K90CWTGN HsU/E14L2NLUwVO1zBC8z3KAo5C3BUzUM7N4MS76Z6d4BiL7KUxWOh+t4iV0+rvHF4t2zqvY6v1XZuPy/TDpY5Bqbs29Hcd8h4AUxNgmQLrKChI80DPEguNtuqT4pmD6pv7F/US50gFmqsui5WglmDjhkrRzvVNwftSfI9/XYJ3uaETeaM+sRDA1/P1EMK//7gTuQWUMeBFxlk5GFquBFKTj5c/sBUvF+I+wIyxD/TqKoEAxxeU0VfCRjjweFqr/zFhtPVOmqxN/8H07F53r0r3RA5VVO2rHP1xv+2RtBpYfBi4IpuAqsfYkls+JcyPA+39LAEbuAkGi2EIXPsz3fOz9W151H3mwlX74KDhnfD6Yb72YG1+qQXFuZffx3u6HcSN3OYbO/QDVTUEmhEQJTTBA9H1JlLdMPHHu65bAaEIdvwTOjPPpKXPDvHZ9p1zX/ADwZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 09, 2024 at 02:36:08AM +0000, Wei Yang wrote: > Since we plan to move the accounting into __free_pages_core(), > totalram_pages may not represent the total usable pages on system > at this point when defer_init is enabled. > > Instead we can get the total estimated pages from memblock directly. > > Signed-off-by: Wei Yang > CC: Mike Rapoport (IBM) > CC: David Hildenbrand > CC: Oleg Nesterov Acked-by: Mike Rapoport > --- > kernel/fork.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/fork.c b/kernel/fork.c > index 279efadabbf2..d6c2a4ccd532 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -44,6 +44,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -999,7 +1000,7 @@ void __init __weak arch_task_cache_init(void) { } > static void set_max_threads(unsigned int max_threads_suggested) > { > u64 threads; > - unsigned long nr_pages = totalram_pages(); > + unsigned long nr_pages = memblock_estimated_nr_free_pages(); > > /* > * The number of threads shall be limited such that the thread > -- > 2.34.1 > -- Sincerely yours, Mike.