From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 524F7C2BD09 for ; Tue, 9 Jul 2024 08:33:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C251B6B0096; Tue, 9 Jul 2024 04:33:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BADFF6B0098; Tue, 9 Jul 2024 04:33:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 963AE6B0099; Tue, 9 Jul 2024 04:33:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6B90E6B0096 for ; Tue, 9 Jul 2024 04:33:06 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 10FA9161789 for ; Tue, 9 Jul 2024 08:33:06 +0000 (UTC) X-FDA: 82319549172.16.7BA70A6 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2056.outbound.protection.outlook.com [40.107.22.56]) by imf29.hostedemail.com (Postfix) with ESMTP id 1E1FE12000C for ; Tue, 9 Jul 2024 08:33:01 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=arm.com header.s=selector1 header.b=NLMuXB1o; dkim=pass header.d=arm.com header.s=selector1 header.b=NLMuXB1o; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of Szabolcs.Nagy@arm.com designates 40.107.22.56 as permitted sender) smtp.mailfrom=Szabolcs.Nagy@arm.com; arc=pass ("microsoft.com:s=arcselector9901:i=2") ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720513948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fa+/cBsfraTPLWRjUaTedFIB+misiBywHLb6+XVNAvg=; b=SpEyMlQnaG78tQXOhdE4/AZ4gFfomINdXAjtMVfHvsUT7uvvq5sUs+pUMbPrYZtd9UAzQ3 NjG4Z8pAL9aSyio/ajDwSB1bqbkykHbha71LSKfEBBJF8302pDnQeSaKSJJXZFAdKtYBoW CFw9y2guW+oKrOX9hi5/DDEus9eOCUE= ARC-Seal: i=3; s=arc-20220608; d=hostedemail.com; t=1720513948; a=rsa-sha256; cv=pass; b=2/Mu4/JuIqlyRY0eBabJ7RpL4MAovyLAiBm9ZDQHghElu5+UZVCKwqK5Hm+88hG9aH7hlM Gl4OeHU8TlF0JNZ/js37Gey/3Fl+YbKyayqbVWFsXlhVyiPpvqPVam3IV06u29SlFZMCjS e4fbNXlxSszjR8Ge70sHGhAQIetv72k= ARC-Authentication-Results: i=3; imf29.hostedemail.com; dkim=pass header.d=arm.com header.s=selector1 header.b=NLMuXB1o; dkim=pass header.d=arm.com header.s=selector1 header.b=NLMuXB1o; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of Szabolcs.Nagy@arm.com designates 40.107.22.56 as permitted sender) smtp.mailfrom=Szabolcs.Nagy@arm.com; arc=pass ("microsoft.com:s=arcselector9901:i=2") ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=P5Al6AU46kZfW8F4SstEwyyNJJtMTExJdWsr53XfYIVRR6Nwl2UJz4MgXOgFwAKjxthE2yaIUFniJM1Xi8yy/A4X4Wv21EvxZjHyKPciIhUkL0W96mC782OuM6z3ICJ2aCECRzbUYMiL5BXb952oZ8QjMAPYXDLq+csbJWSSzoBokhSOP122n86dO2sGHN8HKt6ZNEGYQZtP2AL6dbNcoeV0n3uRNDcMKd9bY/VnamNu1jR5AwrmnqIhm9srv4R7lfWbirdYy0U3W2h1BJ3L5N6de/3uZ6/XB+RgGSu1/6v0GxRPdlVYStmu/WLZifud0IMPW2+dzpSK+8Xp4gHh9Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fa+/cBsfraTPLWRjUaTedFIB+misiBywHLb6+XVNAvg=; b=C4Mj6A9JkotLTbHlO50ECMQF41FQ/SQvn4HbNqgD06wyi4ddkQB56sPMu71nJtcdtxTbdeMYeVLL3w8RgT4Kdx/FuqgMsxRmRasDtdErNnBNu/g14+VSw0TrB63GzOuEDWO/XuVcZ9JpM51rx9nLPHMuw83IAxTInloUwmrAI72PF4a99zwz5ZmB7xcvafpHyXxfJqiUopk0f344nVRuU42m5JL1G4QpRb3yWlvT6CD3x0IPR4xTWi4p5pnV8HIOrrWw/C2A7rxn2isEQwm/09dkziVVf4FG26KTSmU13qqTRxarh2FPB6fKRY9ANdhLEf5/VvrhPSalQwILQWXq4Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=kvack.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fa+/cBsfraTPLWRjUaTedFIB+misiBywHLb6+XVNAvg=; b=NLMuXB1oez5YyZVVgHKZVhT5FI3KaMF1SfGAmcPT+CwoAaw/Na85P2IFCTvcudr1mRG0gtAc1BaVBCfmOHUytNkaCfhHYR1XNHA3INGDLDb12FGcnqr9PLI/lJ2Dgl6b7wtSD9ZKDrn4JevkXWNbtIn3KnL3RQOGLixeA92m+Qc= Received: from DB7PR03CA0101.eurprd03.prod.outlook.com (2603:10a6:10:72::42) by GV1PR08MB10729.eurprd08.prod.outlook.com (2603:10a6:150:164::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Tue, 9 Jul 2024 08:32:55 +0000 Received: from DB1PEPF000509EB.eurprd03.prod.outlook.com (2603:10a6:10:72:cafe::7d) by DB7PR03CA0101.outlook.office365.com (2603:10a6:10:72::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.36 via Frontend Transport; Tue, 9 Jul 2024 08:32:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF000509EB.mail.protection.outlook.com (10.167.242.69) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Tue, 9 Jul 2024 08:32:54 +0000 Received: ("Tessian outbound 7c3e8814239e:v359"); Tue, 09 Jul 2024 08:32:53 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f64dcc8c5b7c941b X-CR-MTA-TID: 64aa7808 Received: from 34990bff5547.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 635D81E7-D5B7-4838-9F51-AE528AEE27A6.1; Tue, 09 Jul 2024 08:32:42 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 34990bff5547.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 09 Jul 2024 08:32:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lj66p5Bbg3qbGUNS4u7VmfhPrbvMf7D7KOXbohf10gDiP4fOm9P37SpcvH4semFb4ygHD5ElM5P84t6RmOkjdyA33jHnUIRnuMaXON9RzbOPVsLh+6edZx6m4HzJJQMG9JljZR0nYc3z4m2QRDH4PoFwEIwZUJAvaa3dZubjuQzm83mJDvQeZLCaOxgrWhjAHjU0hNo2KQODsUnGEeqMeeJbiYlEqtOYPf/1GTMKsKakvnwMV0Uz2oie6AJz2GGjRfmXdZDeP/Yd5V83mQHEZcHLquPFeMXEO0a1vrl36Pg58nGTd/QouojdPeY7RmVyzMbKRGcK7ecBz5pyYIZQ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fa+/cBsfraTPLWRjUaTedFIB+misiBywHLb6+XVNAvg=; b=bxVubXjY7fTFxPhxKCCpV7/dIM9n0A/tXmEvmOV+JjTjUrSivam+bK4CF8lJtAu2LZF6n3u8Fr2u3G1G1gx3iTsbrI5SAa5l+xLfSDgHGlQp2jQ2pwDdkecM0nA6OeoXZm0CyX4A5puKQoUNFpFxb2XswCWLyocURnfuS3KPXHtT/FmmgevB/I8i2MjJIhdFgb2gwfX0hRftrYCf+XZGVffpjNrK0wla8xKee5LwMkmOCJ7GNyTEXbf1sg0Dj6kT6OmQz3VOg9xuhRxR4D/HBRz0/lFJvFqgCueEVX9JYTVaZbaPTRmZ7g+wXBAWmXLrgHYOCKAFg1K7S+j6bRBsuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fa+/cBsfraTPLWRjUaTedFIB+misiBywHLb6+XVNAvg=; b=NLMuXB1oez5YyZVVgHKZVhT5FI3KaMF1SfGAmcPT+CwoAaw/Na85P2IFCTvcudr1mRG0gtAc1BaVBCfmOHUytNkaCfhHYR1XNHA3INGDLDb12FGcnqr9PLI/lJ2Dgl6b7wtSD9ZKDrn4JevkXWNbtIn3KnL3RQOGLixeA92m+Qc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) by AS8PR08MB10361.eurprd08.prod.outlook.com (2603:10a6:20b:56d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Tue, 9 Jul 2024 08:32:35 +0000 Received: from DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::7d7e:3788:b094:b809]) by DB9PR08MB7179.eurprd08.prod.outlook.com ([fe80::7d7e:3788:b094:b809%6]) with mapi id 15.20.7741.033; Tue, 9 Jul 2024 08:32:35 +0000 Date: Tue, 9 Jul 2024 09:32:21 +0100 From: Szabolcs Nagy To: Catalin Marinas Cc: Florian Weimer , Joey Gouly , dave.hansen@linux.intel.com, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, christophe.leroy@csgroup.eu, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 17/29] arm64: implement PKEYS support Message-ID: References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-18-joey.gouly@arm.com> <20240531152138.GA1805682@e124191.cambridge.arm.com> <87a5jj4rhw.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LO4P265CA0078.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::7) To DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB9PR08MB7179:EE_|AS8PR08MB10361:EE_|DB1PEPF000509EB:EE_|GV1PR08MB10729:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f358667-d7ca-40e6-d4ec-08dc9ff1ba71 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?S0wrRXVOYldzS1lSZDU0QjZHTzZKTlM5RzkwSkF4cHpOVVMwTzVMN25qajln?= =?utf-8?B?bm9oazNnNlMreXBzWFQ0UmFUUmJHb2RUa2FtTUVWR0g4dnZNTWI5a2tRbE5p?= =?utf-8?B?blUyMk4xd1k5OTVNRSt2Z2VMRnFIbzBadTBjelNySW83NzkzSllrTjFIMFhn?= =?utf-8?B?UUszVnRUMmZ3WGVDMnJ3ZDkzMzN0M0pzNGcyZTZWd0I5cmxVTWZVYXZrdGhj?= =?utf-8?B?K3ZPTWxaL09kMTJhdE5DQ0g0ZUtnYjhHSEhoOGlFUFZYc2VuR21yRWw3Smcz?= =?utf-8?B?Z2N3Q3BKVlJVQ2Z6SkJxTUw1dkhFaG5BeEVuMyt4SmNYWnRUNlV3MGQ5K1kv?= =?utf-8?B?L2RTb2VYNFIyU09LRDBKbUU3dzBudG9YalM1dnBtMExYNmhTcDhWOEFHQzVF?= =?utf-8?B?ODkvRkNBdkNTMndiZnJTZnlmK2E0WWp3VEIySTJTQkVQM0htNW8wbVkvb2ZO?= =?utf-8?B?ZG1aeVBkSTFtL2pWT2RzS2dsSjc3amxaa2dUY0hUMkkwRzhyaFBhYXFrZXFB?= =?utf-8?B?L2dRRzcrMEcwUkdqNFljNHBUbXZxbGdXNVppYXNTaUlaWDBkVXJNQ0Z2akl6?= =?utf-8?B?azZvcjFKeTZRL1hsRDYrMVhlKytkVzFqdVlCbHBXYkVsUTFOQXBZc1dZSVlx?= =?utf-8?B?aDRGMGV4WlJKbFEzRzZjVVhHS3BzWHJsZ0UwS2s4T01YdWUxTTJEbWVKSTUw?= =?utf-8?B?T0JMVTE2eWg3Q0R0Ylh6TmNKV21jeE5JdzZueGZ3aTlYMXhnditQenFSRUxp?= =?utf-8?B?SFZwb0hZRDFqTDIzSHFpTUI0YncyUGQ2aWlSeGRJaVlHQWd6bGtmekRocHhq?= =?utf-8?B?SnVmV095aXI2K2dVaVhrRUhFeEl2ajNjU1RwTTZ4Vk1oSmpaV05LcFhTTW9p?= =?utf-8?B?R2V6TmJqZWFSY2ExWTlTVWhEM3ZMQ2k3d3FWRTJHRDRvMTluc2pKRk1xUlV4?= =?utf-8?B?eUxPZkZDc2drQ3JmeXZhTHNwWDlrZnVOb3JNUTYxV1pXY0I4ZTU1dDE2eUVh?= =?utf-8?B?YWhrZ2RwTzJEOFJiUEtCRWFKSlhlWFA3R2xHSW5xQmErelpsbzhIanA2N2lP?= =?utf-8?B?dU8vVkc1bVhmRzZzeWVacG96bEpvenF6WDBuSmRmWmlVelVKOUx1cmw4dFIv?= =?utf-8?B?Qk1XRFhmMG9CcUNhd1V2T3FzTW80dTF0Wm4xdWcvRnlZNC8rb3lFNS9KNlpN?= =?utf-8?B?RmpDMXJXVWZaUHdNd3FSeGpzNXVHYTYrdmp3dXFxRlJSQzVDazYzTG53S2lZ?= =?utf-8?B?d2xzTmpGQm53U3lISFh0V3BCSmFCanZFdksvQ0IzV2h3N2NhWGlJWTlOdlRJ?= =?utf-8?B?ejJHbjBkRkZkTCtRekJnSXM5MFQwMm0zQm4rV3AwaFk1dXhFSDZacTdsTmM2?= =?utf-8?B?TXhPaUlRZFJHVTFMQWtoZEtEcnk4bHZseHFYU1NvVWwwMXFYTHdTT3QwTjYx?= =?utf-8?B?eS9LNHBqTmVuSVcyMnpZUERQTHJDVVI4QzgwVkZNWWIxMGZEd08renVUdmlG?= =?utf-8?B?YjlpY1cwSmVNeFF5ZC9NVDBuYTU5WU9VcGtjdC9ncUtkcVpBSkdxcUtqVVdp?= =?utf-8?B?ZjRvMXByeXdNc2FPcHJETWlEZXpsOWFJV1pCM204bEl3aE13NkJnWDBBbzdP?= =?utf-8?B?QVM3eGdHZWRSQWJvMHQ4NDhTK2lSN1F2ZjV4MHFVZ0N6LzZRUjIwVDdWSjRs?= =?utf-8?B?QnVGajVVZGRFS2lzbkNmUzR3cmx3UmRRYmFBdFZ1UStMMERZelVLSU9Zd1Qv?= =?utf-8?B?TURSTmFFY3oyNElmOUNwMTJvME9SVnd1UnExdnNDMkt4RFBBYmtWOXQ5ZDRk?= =?utf-8?B?VCtpTFZWWXU1N0RZd2Y0dz09?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB7179.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10361 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509EB.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b0ede9e4-ae99-4548-f34b-08dc9ff1aefa X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|35042699022|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MXp5RWh5anRWeDFtdzJZT3hJZEtaK1hoL0ZFU1lQZ0c1ZUI1RmlSVkUxNnNj?= =?utf-8?B?RTVTeHpPajk0NWtweFdQQnl6M0IwdkowSHZzbGJ2K1Y0S3kwL3NBRm5VRis3?= =?utf-8?B?M0tWWkl3b1czWUFNNTdQOVU4cjFaUmlkM2NiWTlXMFdLcHZVTUZvWG5IazJO?= =?utf-8?B?M2xnZWFlUFI4RTdqV1pKTzJtcWVTcTV4U2hTNXBJZVhiV0pVNE9VNnRuQTQ1?= =?utf-8?B?QnFJcTFENlJuNVVIZkF4Vktzb0RXSjM4SW54RTFCV0lLSXljeCtMWlN4RVUw?= =?utf-8?B?bitlVUp3Z2NMcWJ1bStjMGE4WnNic0hTWHFSd0dKYnFxSmpaR09vRmNvZW10?= =?utf-8?B?UVMrUjdkUy9lUWNZTDkreUhWMWdHT3g1em9XZUxBZHgwbzkzM2k3MUk3bFRs?= =?utf-8?B?bEVBeElyTmd1Q2RPS2RVVHhrbm5JeXp6N1hrdEdEZHlSUVhJYm90U0Z1RGNO?= =?utf-8?B?RmFtQ0xiaCt5VmJtSUFLTHpvbWtuRmRiV21OSXVxUHdwZUM2N1pYQUR1RURX?= =?utf-8?B?RnBIKzJNWFkvUEpvMS9kSXh4WU5CVDhXcEZwZ3I4ME1mSlJoSHFUemJySWE2?= =?utf-8?B?WG1PYS9RZFh6YVdtQVlBWERhRXBWUi8ySTNTOGwyQm13MVFFdTlKMUtEM29L?= =?utf-8?B?VkxSUFFCcExDRjFRMmFHTmk1eEFnRFdweUZ6eFlPQU1zL2RZYzh0Z1poaTJn?= =?utf-8?B?dEVJWHNPRGc4TTdiL3pBZzFnWUU5TmdmOSthR1RVR2dpc0dydVlwWnBHeEVV?= =?utf-8?B?djdyR20xN1ZqS1ZCaEkwTUw4Rm5DaVU2b3E1MGpyb05SSnpIWW9xWTNmNUND?= =?utf-8?B?VDZsUTNSQWJ5Mjd4ZDFxMUtlRHQ3Mmp3NHZSWDYxYncrVUc2U2Y3WXRPTWxv?= =?utf-8?B?MFhaZ1FrUURjMXJYcVgzOURFaFlybHhLU3Z6M0lmaXRYMStWOGlLWURadEd0?= =?utf-8?B?YTdzOGV6VzgxT3B4a2dsTkR4U2V5MkpYdHE4SGl3S3B3M0pxbkdvbVpkVVp2?= =?utf-8?B?ZzNrcG1JbnY3Q2ZIMUJ0bjltTDNrTHpBREJDOXh5alVKVnQ0VlJNVzhIeVFK?= =?utf-8?B?dzF0TXJWQXpzVzhFSENBMmNCRjFuVUNpeldLSWVWei9XOWZ1M0J5Q09HZFNx?= =?utf-8?B?MUhRS0pHN01tYmlwZ1pkVG5ZTHlEbTh0Y205K3hkNlhDMWhFSnNaOWhwQ2hp?= =?utf-8?B?WGcvSGxkb1Ryc1NCV0I5Z2w0ZkpiWlJMVHJyQytweGhmeDdIVjdxRHdOSHF3?= =?utf-8?B?OTdyZHJoQTJVd0c1cTNXTmFjckFxUHU1YWQ1QmxtdUxNeHRGZUdBRHBBTXZI?= =?utf-8?B?NEVwSjFEL3RoSm54RnpHKzdvVVFFNzVvUkxxN2lmOE9qbmxIUzJZeGNuVmkz?= =?utf-8?B?S011UFFYZHE4ZW80cFdCZWtaOE5FTzJDd29hWC9oM1VLMUpSTXFtVFVYRkI5?= =?utf-8?B?NkdQWmg1Ry9LU2tZZmdxOU5ZS20vL2l1UTIxNWpWV2d1VHk2bnhRaDZRdW84?= =?utf-8?B?c3RDaFpMc3ZlWElIbHJrWlUvTW1FWTVjU2xncFV4NkVNVTd4WWZhYktFaVhw?= =?utf-8?B?WXBRWWtSSGNQRzdHQ085MHJUNHBlQkZ0dW9vakF4R0lwZ2FlaXlNcnM0cjM3?= =?utf-8?B?UG5ic09SVXNvc3N3MVErL2U0YzUwNGtzM3M0bDRhTEJIRWV2TmhpcFZjOUZj?= =?utf-8?B?MkNpNzlGWURaNjVLTW5PWFNIRE8vSDd5azd0Qk8xcXJLa0liU0FHVDNGVlZM?= =?utf-8?B?Mk9FZDNjSjBsbUhZOXlQdk1TT2Ria1FVbkIrWEJ1QWpzczU0OGRJVVhUTGto?= =?utf-8?B?cThUbnNJMWJVdGJFODNxWlA2NUV0Um5wL2JvaHNTNVBjeWhHU1BuTUcxdlZ5?= =?utf-8?B?c3ZqQnY2d1pybFJtSStzajhhaXJIdXJZZ2lBMEhyUUVORHlpYSt2M1o3QmhU?= =?utf-8?Q?W3tyV4ZXRtQMNH5BPCPrum3QedfeTut1?= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230040)(82310400026)(35042699022)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2024 08:32:54.2630 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f358667-d7ca-40e6-d4ec-08dc9ff1ba71 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509EB.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB10729 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1E1FE12000C X-Stat-Signature: 5rtywatyo378kg6ybofw8896rguj47ix X-Rspam-User: X-HE-Tag: 1720513981-294732 X-HE-Meta: U2FsdGVkX19BbBlbcvXl9Ffo5KpNTpP1h65EAIve//7/3BoRNU2Yobq+Lhmu9xAxD9iFIqJZFw0cD58LQFvnaJM8Klq/Luz+muEN3xxq5FtLXqimtfsSZfmUhcxcCsqqwOWSw/gRBCmHCkWLV4Jr5VELFYxxcyTHdzRJc7nI0R2BjiZ9SuXf9oeqzzEQUz6xOkE/3O8xUK41EgnlZLe+Uz9Bm3bC9PO2iiaOwM6DMFZt+NFTdFQyB2+niKcU4qaSYqDQNXwd9Aqb4SsbwGl3Ml5rUExCzuQg/MBnr8UdFz3ksTNQvtYDZv68UWBVYQ04J5jbybC/v0uzJeD9VJWiQeNZjKvOhFoXfI/Jwf+Nk99cINtvv5jMYTlpvZC385DOF0Kn7gM0f4fT3zu4M4sAWHIAJve5MAhamI6kKEIPyGr6k9XtJXb8BfN8g/WawR582gL9YWgjO6zPrGc2s6It2hBqSYpWO7HzvYh1Y1GMem/rZLobMPrMu63IQS0dXq2ot6+JEbffTF0wIlkLcWJNG7qjZV7LAEY/LsPyokNYI09UhUULUbxIsD9wcB0rH4RWvVjXytenDvlqQ8C10Da+1EnHk3ovxXeyb+3QsoeAQ1bhZwMpL5dyEabVrbXtbKy5xX/CUztLeDA3upt7vIlVnoDzdiwQqExanaHvvuBzpTqCjnB0w6ME0MiVe2kTukkSfpkEV/1QxdN5MJX1O9Tpz76wMKb0sIJRDDa8Q5zMfLgk1BwG6loGWnTj7P4cHtT36xQBuxj8Wlic3XOV7+HAGg0PdqOq4kS6pAIywESoc5TlNWQWtIe0cVGNwwGxCMwlhbMKsQ/SEyBfm+Wk51Wh7FiCWNA8SCuLAeui8oOYV6ZC+t2A3tu8x41oqvOW9dPf3ZZk3N60KCgILsexeVgr2VZzPhj0eISEUWT7tlGsKEC0wr34aSzBj2UaW4RgM/GxVDiR24YDBARhAZ0SHcM Wh1PwvUe 7kBpRcybAYXnQftue691FppYG2uPgxEvXTpfHUQKC5BljFRAqVAv6fAe2iKKqY23Rdn7arhNUcCEvfHBY/qPIauE9/C5AL30VTKuFTIqEgDBtFJtQBlZSWeo+posX/07KOXjBcclZbyVTFgJGDbq8YKQjN0VOBCqEFx2haUcu2MIoxel9pwhasq0x9QgW0a8nE+sjqi7froJC/qxet50x7tB86aQB1iYSut4Vc/D7BFpMUTGjMjlllopw11o2QD9V7ngymy3kujkN4CZ9qAmryVcBEEHTbfzktMcSCy8jlScJOxsr8sd00o+2mmcFLJJISrffUPoITgDVJaoMWLv/iDPAglU8wea0xFMWIGBfRvPpETGZKXetFlPk9xyNl+JnBDErIfJq7nSu9yvNUnoTi/uKKH+EIlk3/xMsiDSlIWIRHsQxJ5BfJ12hQQEYFz/dp6Qoe23bk3+tpuHZ40JWW3mea5B+Lk9pnhQD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The 07/08/2024 18:53, Catalin Marinas wrote: > Hi Szabolcs, > > On Mon, Jun 17, 2024 at 03:51:35PM +0100, Szabolcs Nagy wrote: > > The 06/17/2024 15:40, Florian Weimer wrote: > > > >> A user can still set it by interacting with the register directly, but I guess > > > >> we want something for the glibc interface.. > > > >> > > > >> Dave, any thoughts here? > > > > > > > > adding Florian too, since i found an old thread of his that tried > > > > to add separate PKEY_DISABLE_READ and PKEY_DISABLE_EXECUTE, but > > > > it did not seem to end up upstream. (this makes more sense to me > > > > as libc api than the weird disable access semantics) > > > > > > I still think it makes sense to have a full complenent of PKEY_* flags > > > complementing the PROT_* flags, in a somewhat abstract fashion for > > > pkey_alloc only. The internal protection mask register encoding will > > > differ from architecture to architecture, but the abstract glibc > > > functions pkey_set and pkey_get could use them (if we are a bit > > > careful). > > > > to me it makes sense to have abstract > > > > PKEY_DISABLE_READ > > PKEY_DISABLE_WRITE > > PKEY_DISABLE_EXECUTE > > PKEY_DISABLE_ACCESS > > > > where access is handled like > > > > if (flags&PKEY_DISABLE_ACCESS) > > flags |= PKEY_DISABLE_READ|PKEY_DISABLE_WRITE; > > disable_read = flags&PKEY_DISABLE_READ; > > disable_write = flags&PKEY_DISABLE_WRITE; > > disable_exec = flags&PKEY_DISABLE_EXECUTE; > > > > if there are unsupported combinations like > > disable_read&&!disable_write then those are rejected > > by pkey_alloc and pkey_set. > > > > this allows portable use of pkey apis. > > (the flags could be target specific, but don't have to be) > > On powerpc, PKEY_DISABLE_ACCESS also disables execution. AFAICT, the > kernel doesn't define a PKEY_DISABLE_READ, only PKEY_DISABLE_ACCESS so > for powerpc there's no way to to set an execute-only permission via this > interface. I wouldn't like to diverge from powerpc. the exec permission should be documented in the man. and i think it should be consistent across targets to allow portable use. now ppc and x86 are inconsistent, i think it's not ideal, but ok to say that targets without disable-exec support do whatever x86 does with PKEY_DISABLE_ACCESS otherwise it means whatever ppc does. > > However, does it matter much? That's only for the initial setup, the > user can then change the permissions directly via the sysreg. So maybe > we don't need all those combinations upfront. A PKEY_DISABLE_EXECUTE > together with the full PKEY_DISABLE_ACCESS would probably suffice. this is ok. a bit awkward in userspace when the register is directly set to e.g write-only and pkey_get has to return something, but we can handle settings outside of valid PKEY_* macros as unspec, users who want that would use their own register set/get code. i would have designed the permission to use either existing PROT_* flags or say that it is architectural and written to the register directly and let the libc wrapper deal with portable api, i guess it's too late now. (the signal handling behaviour should have a control and it is possible to fix e.g. via pkey_alloc flags, but that may not be the best solution and this can be done later.) > > Give that on x86 the PKEY_ACCESS_MASK will have to stay as > PKEY_DISABLE_ACCESS|PKEY_DISABLE_WRITE, we'll probably do the same as > powerpc and define an arm64 specific PKEY_DISABLE_EXECUTE with the > corresponding PKEY_ACCESS_MASK including it. We can generalise the masks > with some ARCH_HAS_PKEY_DISABLE_EXECUTE but it's probably more hassle > than just defining the arm64 PKEY_DISABLE_EXECUTE. > > I assume you'd like PKEY_DISABLE_EXECUTE to be part of this series, > otherwise changing PKEY_ACCESS_MASK later will cause potential ABI > issues. yes i think we should figure this out in the initial support.