From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6726C3271E for ; Mon, 8 Jul 2024 22:36:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00B8C6B0092; Mon, 8 Jul 2024 18:36:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFECD6B00A0; Mon, 8 Jul 2024 18:36:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DED1D6B00A1; Mon, 8 Jul 2024 18:36:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C19CE6B0092 for ; Mon, 8 Jul 2024 18:36:57 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2B52B140F22 for ; Mon, 8 Jul 2024 22:36:57 +0000 (UTC) X-FDA: 82318046874.21.3260EE2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 83773A0017 for ; Mon, 8 Jul 2024 22:36:55 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jYekUXxU; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720478200; a=rsa-sha256; cv=none; b=i9NX4fjmpISF6EUsIquglCwRh/v8mJ+uroooM+KxjIHLXB6e8tOrJzSuYYTAKl5lu4WKFt v7L5W6vSAghHo0uyLEJ+NY6GyuSiaUEd23kE8r3GD7n46blshUhKihgjnTPaWwanIC9O6c jM8tlOigjtfUGiTdrZHCUdnQTYnxw8Y= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jYekUXxU; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720478200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vExNcDqVQfvKTJvQscaouDwcx4jomkck9MJGjvfkkTY=; b=vqkg0+9veHsLcbZBkQ4mSj0zDdhTuUdGhgUvZY7gWSykcdxTMUUPLWQtZh873xBdeo/mjb dlCdzxhytxCcnmrbwLagqSun3CCovPCs2QiqVML6hUxGpf6MgGV3CFGlYBrTGVht2Sp9Mi 8KBDV4taN6Kt+abmyvfvS5PWI9DPLfY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vExNcDqVQfvKTJvQscaouDwcx4jomkck9MJGjvfkkTY=; b=jYekUXxUwqekTTVUALjCXiuOMv Il4SQGIbCUk2xq36vPTqTQ4QX1tKweis0UIj913Fr7lJpRX0CgwQ4m6ZMG8MBnppqbsfTfStRsK8O 7mDdmsWNEp6m5c9SlMle+BY0lDwhzQiRm+ENqHlng+luAETQtiefhyxVFbZoO22r8pRGGBzmySivV IQOuEmUH6R+N/pacv+ZOmHw6WA1rWSyZMhkx3ApjRxNeKyY/wwQku8oCg2nB+EPZf8wzPUSfsWoT/ jjVoCqJkmdiCzvyzfUJk70eGLbl9Hh1CGq8IVagM0qBnkkpw4/p16rHW2boMFgKSW543lTg7O47G+ Rpop5P5g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQwyX-00000007Ed7-3rvF; Mon, 08 Jul 2024 22:36:49 +0000 Date: Mon, 8 Jul 2024 23:36:49 +0100 From: Matthew Wilcox To: Yu Zhao Cc: Andrew Morton , Bharata B Rao , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable v1] mm/truncate: batch-clear shadow entries Message-ID: References: <20240708212753.3120511-1-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240708212753.3120511-1-yuzhao@google.com> X-Stat-Signature: wnegm81r1swsnt5cs8uoyo1eucxiofk9 X-Rspamd-Queue-Id: 83773A0017 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720478215-198640 X-HE-Meta: U2FsdGVkX18sOtvlwo5PD0gv74ZshCD0NXCfmimroL9xev+0GTQ5UdB9MP7nsobmGc6fvg/nX5YlCzraeSMGH6/kKPTSIFlDAzazdIJVYeypBmDF6reZjOKS/QTBvqXIdVaHdSAXdZXOqJRcPKo2vo8y0YNPKlvCH1EFEHTHOx0QgM6+ZzB0lFI2nYsTTQ5ozxuSmC6/c5g5fANxz8jpp9Xjj0LpCn6X5Ul7WE0OaOiCBhYrrNZSzHvjv0py3nSL7CEjCIjPevNfU2HhblDTd7iJuz3VJTzcoFOHQhjpLqnD9iheZenF4ngeDPB9kDjhDR6qp2/mQMNFkbwk3sU2mS3aauG+5yDmCwfBVlID061e53nVwwohj9cc+wX+C1BIFtR78Mnn/qypZYqBedWKugoRHxFRGXqSscI/9LFBwPO0WixBflCv1NZ56FWCXUsmSoGyo2/nNLZAeOTv/1KAqlphbsXVDizcx4LJPKVmVP9s8qXePnLcIT17nNAxD677/G92DSzgB22qEIQfdYSa83afe3ptyaVobpMfEWranj0uCkxMooIC4+030Dt0hJerZH1uES+hdlkUp9hsdwsD8kuvO2ByP5G1v5Tn5H/q8QC26Fm/39wi+YkQjnVETBNfwtT+CMOK5esLDejQN67nvf5yEUHqG6pGT30HI1ZbxfpeUpvtcq1HXjjyBpipuSgcvBDfJrvkyXl+l4mISlWzR7jFvFSrr3jepT1wOk6h8vO4+rgcH11IuPyBdA4aEld8kIB/Mk5HHAiyobQJydsVEPK4JL1PpAAP7iUTzbxQXQ/YaGlTu4S0Iv3/qFfHCnlKrY2Xu1jXBud7Bqc6aoyu0vQUz/gGQMIA5lebrscvmVQfMz4QxoOQr/mOmZae8TziiyVcpmzAKfqjqGziEFVf4Pqq74dDkqAVoVW67+InniLca+22NbDwDppVXFQC4+BSSjaZoAyc+Y+/UZ4lp/X HKxtkaCV 3jNpjx6s6vJsb0LWQ4BAK2YUMFa+2EL3We9wrmT9IledP8HDAvA8miZ11GWo/VGGvVVajwkZaBefbMSlbPkrNmLVOl5oHahrFPuJR7UnVQNLR+BS/jiQT/uJkYjc0T5iQ+/mN77WL3KqqIG8xopqx4Cx2Lb6hvSX8RRJN5gZV8GQzI7QCmNPCirGdAH9IUxVttXk8EfvJ2H5kE24= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 08, 2024 at 03:27:53PM -0600, Yu Zhao wrote: > Make clear_shadow_entry() clear shadow entries in `struct folio_batch` > so that it can reduce contention on i_lock and i_pages locks, e.g., I think it needs to be renamed, perhaps to clear_shadow_entries(). > @@ -503,8 +486,8 @@ unsigned long mapping_try_invalidate(struct address_space *mapping, > /* We rely upon deletion not changing folio->index */ > > if (xa_is_value(folio)) { > - count += invalidate_exceptional_entry(mapping, > - indices[i], folio); > + xa_has_values = true; > + count++; Mmm. This is awkward. It's supposed to return the number of pages, not the number of folios (or shadow entries) invalidated.