From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB59BC3271E for ; Mon, 8 Jul 2024 22:18:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B5D26B009E; Mon, 8 Jul 2024 18:18:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 665B96B00A0; Mon, 8 Jul 2024 18:18:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52D906B00A1; Mon, 8 Jul 2024 18:18:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2E52E6B009E for ; Mon, 8 Jul 2024 18:18:18 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DC8E61A1588 for ; Mon, 8 Jul 2024 22:18:17 +0000 (UTC) X-FDA: 82317999834.01.C67CD77 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf29.hostedemail.com (Postfix) with ESMTP id EE2E8120014 for ; Mon, 8 Jul 2024 22:18:15 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=e8xEcfMl; spf=pass (imf29.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720477081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lynMa0qMQvKrU3+x9nFoEh4w764WLqy+q+oFFlPFpes=; b=R1auoVIIQfVhmHvdyMpuuLyxyr5dOf4hGQMZFIvIMM9YUX5X7is7JbJGNFmSqCZH9V4LJX UOhIULikx8oqRrfWhAT401cyib8AxaEuac0HTB+bk1GUPNrpzihCfgjdIhIFT2hbFv846E 2rTbQg102tkyvToXcy5KUkV8uFTg9Tg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=e8xEcfMl; spf=pass (imf29.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720477081; a=rsa-sha256; cv=none; b=cVGfI8gXKY982a9Ag4rmQLOX45onHOg8Y3qxlTRIYXH5hkfzm4cDzktvhNoRiAiKf+5jo0 gBUE10hWagTqz0YSsSjlDRlmaTj4LQkubcRSWFBwQeU3n9qHuMJshFUPFenwjsi+iNy2fN 4JNEz1TNkebe8F15oV6gF+iS6c9VIWw= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-70b07f27788so2457839b3a.2 for ; Mon, 08 Jul 2024 15:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1720477095; x=1721081895; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lynMa0qMQvKrU3+x9nFoEh4w764WLqy+q+oFFlPFpes=; b=e8xEcfMl/Pnw59HBrvJEmpU5aSevBdSd8E5e9JPlhkRuhjexZDrM9Z1KjbkUMhzUrh dK8P7ejBGI6Pi4Sz/SctmpcVrKbu1yxoG1Zy5eThPvovElyFRDIHV5sjrkRJmJGoXIek smontI5NHKeX7sUlbTEjaCp7AeuQ/1BlmL280pL9i2QyuIcLNVOm1U6y0yI/OxlQih8E wTewPrEvXyqL1V7CMANEHj4alJu5iTxbGmKdtg6L5MzA5jWI2Ys7bDrkTJ0cxgKRgGJY ufXfwVIF2BdGFUKsipoE0JCoz5wOcCvHxylydS0pI+nhQP2t2J3UXDHLe5NnmXBSScVY dWQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720477095; x=1721081895; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lynMa0qMQvKrU3+x9nFoEh4w764WLqy+q+oFFlPFpes=; b=Z4eqiFY2ZwjkAzNVpDjCo6WbHx0Hu51gG6Tf9JTZOnV6umNC6tlQWoWE7ZrpOlijo6 gMtBgOl7tvtC+/g+ln2+u4TM7fpyRTrubpOYWlNvI2dMuLwR888GMnpfntEI50F5ati4 oeIlSLVpb5rJtm3gPUnMD/D8bGaAi9DieKllJQoLf7eaAJ4RAqjEP1SHa1bhUkMYfNlk 3pgpiXWR24shFnFZgtdRqLAAbz7diCUbjIj0gN+PF7dE1odBJkzuGZrt/mFdky/ExKkX b1aIUg3etv+OOvHZwCTF9sDCtC0y3l9F3N6eOwko7FzR8MLhVRp50vXh0ZB4u0MCHi7m JJGg== X-Forwarded-Encrypted: i=1; AJvYcCUsQ4YLjmnL1eyelYMe0DlrIUmF5IfcLfcdNGRVGGBrFDi9oDTJ5zaGAJvQn8TEPZMSsdAnzGOcUbrqOM9+PsrQs7w= X-Gm-Message-State: AOJu0YwDrspGdn8tRPvHOVeJOb3daF3x4nTW/7Cl2k6mXv60HchVwe1m BeMZAjV7B3YVlQXR96y5DKToyj6KMqIXIMaybqYJhi7T+7MFMO0nGZkmpk0Shqs= X-Google-Smtp-Source: AGHT+IEjV9bBXGFmEQTeSIY+iK7kYcB7ABn6Uk4Yy8He+5O/cUUPNO91G+kyGhhILxTgai05zaVU7Q== X-Received: by 2002:a05:6a00:1885:b0:705:9a28:aa04 with SMTP id d2e1a72fcca58-70b43650817mr1185390b3a.23.1720477094695; Mon, 08 Jul 2024 15:18:14 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b4371fc2dsm406119b3a.0.2024.07.08.15.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 15:18:14 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sQwgV-008zrf-2q; Tue, 09 Jul 2024 08:18:11 +1000 Date: Tue, 9 Jul 2024 08:18:11 +1000 From: Dave Chinner To: "Pankaj Raghav (Samsung)" Cc: willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, Zi Yan Subject: Re: [PATCH v9 06/10] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: References: <20240704112320.82104-1-kernel@pankajraghav.com> <20240704112320.82104-7-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240704112320.82104-7-kernel@pankajraghav.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EE2E8120014 X-Stat-Signature: wr5yornq7bm8fz3pux7uz4t3xzhduurh X-HE-Tag: 1720477095-851143 X-HE-Meta: U2FsdGVkX1/Y29jm9jlZTNIlnoDholYmSpTS0QgkjuDfzbYegZnh9m1ShV7dlD2mlXVuAZeU1cyo2RPfDAFxBHuT9ESu0ogIPgVN/tLGadiBP1F+Pq5Qu7CjjnO/Agp0BviBouCU8vTYnxGC9ZzQ3h0vfUQtR8bcEyLhtjYvO/g5ZznRlsmBnf4As9LVwEY/GNk5EJjzrN37kUr7VyaYlas9k+eVMuLk5mr7ng9TDHd0bzisHOmChb0ERigyIbNQeb7lfkzmTJmT3ANMiozCuuUJrU5kkVAb1RYQygtLPbXlizYuRx4kXMewVhd8t+T8hFSoqIpuV8Q6kDNvW0GgESCxmFZ37p4ic4ztoneNmGHd4dvVP74eBf2XwL+lKUkod29WwkHry9u0RLu4QcZXfSkEErbIkLN4TCrGcITICoNYt304IKyEtG7+VGCUhQQUorlkG4yD+VFgpvWZJuyQHVNMiBkVWZp2koZTzuZakem5OaJgn5+5h+pnyzVj4RNPzGBe+ZEmCTAqb3i8rI/k2Df1boZfWl2BQyk8J36Pi9HLIKT72Mps6PIWtmD8sP5Uf+PPsZTfp+iQCnTO7aKyRaIMAKRxtOdv2YTP5UaliHTgFtNboWtVRYGfo2/VFNv2S+Z6aqi00H3P2ROaq0ZCf88G+POJhXt11y9tX6XisPanSjb4tTlIau9NKOFMWWrrj8g5Fgacsy+MjdHMl/ShHOKrt0nNl2VGqbnFlVg2NsYn0mj2ILdt6dLlW47J5uUfABk2baNm+h8OEM9stwS78kuo640e8ymCaPii77cLoVIdi8leYIiKTOpJkMb+thHwZKEumtEcPGjLPdk1+K3cjVSEpScsz8W67lgrfaHYwVBYb4m6WDxWQ4JnNJelUgO/CbK8DzbkTvEu41gCi0OUeceVatKzC3MCyvoHjUMgki3wjbRChuQArO0FX0B4Kug9CVWIuBsgL910zsZL4LU S3z2KeVx GpSj4ju2l0+tP91BTJomeR8ZcR2s+b65/r0ru0iQ1rf178N6m3byYd4csEjjYFhYxpz7uSqHtxqLJ8u7eHC64A6m1haJSGJ7OkLB6qmS0y509Ba8q5J3EE512nKBcBTeJ6iPB0tPQHxdIjm6VcP7sf/q84r56AnRjGuBEMB38h6Nq3HmcWqzkzIsxrJ3wAfe0yNMmTgG+sFN2eweKJdcPMuMCylWnkHJRC9M4Ir1aEbxqiy4zVhbewgk2QDeNma8vQVo4PT4h5BKw71QU4HRfSsO69WzVaeTFAlz6Sscpj6bwHXXlPqryen2osjRKfDkE0YYfEcP3XVjkMJ8iqU1cMedRqZ4TfW6//eXRxpRLINHxs34D5yDX/xvJuippWbOeDjWmn8brHZbHHU3lsg3OUhUNpXr4gTi+JN+HL1nBUDlkc/85msxmH/DDOoZkR3ARMDqXIBEePO23BmDPIdm2KIA9/kBQqQQe7neT+1M6+Ssop70= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 11:23:16AM +0000, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > iomap_dio_zero() will pad a fs block with zeroes if the direct IO size > < fs block size. iomap_dio_zero() has an implicit assumption that fs block > size < page_size. This is true for most filesystems at the moment. > > If the block size > page size, this will send the contents of the page > next to zero page(as len > PAGE_SIZE) to the underlying block device, > causing FS corruption. > > iomap is a generic infrastructure and it should not make any assumptions > about the fs block size and the page size of the system. > > Signed-off-by: Pankaj Raghav > --- > fs/iomap/buffered-io.c | 4 ++-- > fs/iomap/direct-io.c | 45 ++++++++++++++++++++++++++++++++++++------ > 2 files changed, 41 insertions(+), 8 deletions(-) Looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com