From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 401E7C3271E for ; Mon, 8 Jul 2024 17:22:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB7806B0095; Mon, 8 Jul 2024 13:22:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A67C16B0096; Mon, 8 Jul 2024 13:22:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 907CB6B0098; Mon, 8 Jul 2024 13:22:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7473F6B0095 for ; Mon, 8 Jul 2024 13:22:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B9CD5A1458 for ; Mon, 8 Jul 2024 17:22:35 +0000 (UTC) X-FDA: 82317254670.18.2E455A0 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 8203680009 for ; Mon, 8 Jul 2024 17:22:33 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720459324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VPc2tLV7VFqqvakpQC7xlgW47cbbpJmS4MsPvBZTcWE=; b=WOQJNmPjAvva0VyBOkQfIjL10+0UNzTvtKk/SewanGZ9eEyIkP9LcwXpSL262VyBN5AkEk 8gaXweG9A3KhMksfNkzb5xFlMMSmMclgoHOaseJ8nDnhm7H0lYmXhWK6DpZl65Wyf4tsOl Ifim+bTilNddwkIBEEB2wid9W7WWZeE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720459324; a=rsa-sha256; cv=none; b=tuWYXUR8seGbm/c2PhkohPEbuJConvAh9hMg/Lx+12qvIAUY9/e+xK9l6PrXHI5BSUPBep DEvrzK28pMzTpbDpnFGbhXFkoY6kWZErCYybDPbCVOCVPlwPvz2q9CO/ZJNjcwDQFCJvKr /sLnFHaHpOuJHgle7loKC1NXPoGqB/g= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C4898CE069F; Mon, 8 Jul 2024 17:22:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6469C116B1; Mon, 8 Jul 2024 17:22:24 +0000 (UTC) Date: Mon, 8 Jul 2024 18:22:22 +0100 From: Catalin Marinas To: Joey Gouly Cc: Amit Daniel Kachhap , linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 13/29] arm64: convert protection key into vm_flags and pgprot values Message-ID: References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-14-joey.gouly@arm.com> <4f7d8691-fe19-4e8a-95e5-9f7680c82021@arm.com> <20240704124704.GA3548388@e124191.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240704124704.GA3548388@e124191.cambridge.arm.com> X-Stat-Signature: u4jdtba584kn1ogu1eaxhj9e3somacsj X-Rspamd-Queue-Id: 8203680009 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720459353-662279 X-HE-Meta: U2FsdGVkX194WsLmox8toP3cOy4Im+rG6U/Z05ko3YHv+1vKIaw8dq5rTncD1U06P4DU/y9VtlT2Q2nOtRD6WJOqd7jNtAmL9l5CrrkznHovetVPzdOMe8byq+RmEdzCvbnWVil6rCp6HxIse+TvsvMjaE0UtlifOLMhbd3G1a3OtLfj1AYaF55OjvqbtoZISNjYAKrM3AbVY5uvgqmoP2eMR+ZgNLQ8iv5u/gIBaNYaAAX9hKEjpDLXa8geIQ9+Bqmii1pRkNmGrfOH+pAKxS4lewcSOux4J6b6yA/Cr3zYwgbJgAM24xMiT5gYV0uafU87PC7nvRe1HBVIAnzZgN9A1qP6EkgOldX0ZJ48z8J0pyHMLf1pSwYhJO4+CfmOnQHSAAAyqyX9xdxrLmtEuDQ6J0EsyC3W9Tn0EDa0XFHln7ZsSDCDApBIBGkHbW44YfdVckri/h+07R2BbkAQCOOSHDZvoSRRQ7lW7sNK0NIRwERJgd81Cbx6qQwTAK2tNTzF52+CeGJiXXTuCci2hKgveiJKNXzBxmOaKJgMRifsHdPprqhAgQURWf36HaqnfjNduJdM8+5WJB2MTuyMuq8yBWq2/wvL9F5X2at82IJrknkGs8z6YQlSVMxCP2ZeHMbHOmdqXoR/KYMvAlkCOp34HfwdIV5MFl2f+RY5LyIscF3GS0vn9+Ns3+JMoVy5N7dBTIYcnHEiYdEqYbxtr2jT6awWC6Q7KG/c9/u1CwtGq2DW6rB1FfwMunFYcBpiwrjfxOUOQ3xesOZ7mghVh1d27tCWxEsYeBCjd2XACza+6KOEHyOckAXSQBBHW2oAj4oVgLrL/k67TqBM5IfV05tq5CezEsjkEfbds+RVWJVtLi0QcvRnQQ+oVQ8WUfO+v7qPLwk7rDQFG6MRpJN3thaWBNRv7soVkeMoGJoaMlnP+h4ZnlF1kBGGZv2hTZBzqmBGbJvIyN1K1vG3/YZ 6AWiwJeo QsZD2lomMWVpzYOjCO3GsMT9MgVBEeANd2uLbfK2ryUXaG3XYVUbZv9Iie4KUHWUZnR2J9eCk1bGZWHljRgG6qdNcU2ge3Ws8BwSBMN/EOTCVLAyvHzUY7Smm/sQ7GnOBH1maHMu3uFK9KBwHdnjFMYbgHCh4GIzhwvpH2ieEejyUES6O3tyFaWL13X7IIF4EU52tDvnLabVDuPiklfgGXvyWJboX73usN5F9ZHdSlj62U0I2ab6db2fBRCmQqAZvdQ1LJSIvTzRsGmR08tIAanT6uCR1ZHRVJuXo+1Uw4fWUlryLpUKRSKmHChoFwI6oA+qvLurIwF2iNlanVCIrNHLM6Zl7lLqlL5vISsTWAtaQGAGH4nzzDNQc5g7StD5UPrHJAHpG8fmfcgA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 01:47:04PM +0100, Joey Gouly wrote: > On Wed, Jun 19, 2024 at 05:45:29PM +0100, Catalin Marinas wrote: > > On Tue, May 28, 2024 at 12:24:57PM +0530, Amit Daniel Kachhap wrote: > > > On 5/3/24 18:31, Joey Gouly wrote: > > > > diff --git a/arch/arm64/include/asm/mman.h b/arch/arm64/include/asm/mman.h > > > > index 5966ee4a6154..ecb2d18dc4d7 100644 > > > > --- a/arch/arm64/include/asm/mman.h > > > > +++ b/arch/arm64/include/asm/mman.h > > > > @@ -7,7 +7,7 @@ > > > > #include > > > > static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot, > > > > - unsigned long pkey __always_unused) > > > > + unsigned long pkey) > > > > { > > > > unsigned long ret = 0; > > > > @@ -17,6 +17,12 @@ static inline unsigned long arch_calc_vm_prot_bits(unsigned long prot, > > > > if (system_supports_mte() && (prot & PROT_MTE)) > > > > ret |= VM_MTE; > > > > +#if defined(CONFIG_ARCH_HAS_PKEYS) > > > > > > Should there be system_supports_poe() check like above? > > > > I think it should, otherwise we end up with these bits in the pte even > > when POE is not supported. > > I think it can't get here due to the flow of the code, but I will add it to be > defensive (since it's just an alternative that gets patched). You are probably right, the mprotect_pkey() will reject the call if we don't support POE. So you could add a comment instead (but a system_supports_poe() check seems safer). > I still need the defined(CONFIG_ARCH_HAS_PKEYS) check, since the VM_PKEY_BIT* > are only defined then. Yes, the ifdef will stay. -- Catalin