From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F27C3DA42 for ; Mon, 8 Jul 2024 16:07:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E27536B00A9; Mon, 8 Jul 2024 12:07:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD7686B00AA; Mon, 8 Jul 2024 12:07:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9EEB6B00AB; Mon, 8 Jul 2024 12:07:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AD34D6B00A9 for ; Mon, 8 Jul 2024 12:07:01 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5432B12144A for ; Mon, 8 Jul 2024 16:07:01 +0000 (UTC) X-FDA: 82317064242.07.6910C46 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf22.hostedemail.com (Postfix) with ESMTP id 0DB11C002E for ; Mon, 8 Jul 2024 16:06:58 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XO3N9Lwz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720454797; a=rsa-sha256; cv=none; b=rNofryMbmko0UlCtFqXYVbyLj0+8E8J7JFkklHRtp332JAfSQBCEe68sPVJS2PeB7Mt0hm m/a+Vzpjf3zhJyKnCn58iuAv6kIGa5TRJgSZunA6JyYVkNGuZETIYw/uSSpdC31EUNSbXe T4m30fulxBhCqr+7/fmrD61XNB++Xy4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XO3N9Lwz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.45 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720454797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ij25sqUdevns5tkTNnYc8JRUONkaiwAFtKXPJUw+bLU=; b=x4cqiYFTJDDc5nx6Q9StQ9n/sH5vbdQf7CO1V190/9UKf5UXQxayClQj3d0bUMQOPIHP0T BurvLivtWvJSP1wzB1cM6lGP/qYWS6AVS84bL+VXpdQfQ7mhqeZ84gLhZDx1C+vJQukLEC ig9VCeJFfuRw0X6aj/OAe3ceqVPg2WU= Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-52ea5765e75so4133536e87.0 for ; Mon, 08 Jul 2024 09:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720454817; x=1721059617; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Ij25sqUdevns5tkTNnYc8JRUONkaiwAFtKXPJUw+bLU=; b=XO3N9LwzfqWi4KwRt/ncInOSQjXgEOCsHJ/PHWBaDOg8CXVSdYQtIw6bwvH/IENSfE ZJpX2/wHtxJJGH0FzDz9czAczc+Amda8Aa8LNUKVsABjRk2m5Jl/va9UbX5WRbyFNQh7 lYp88b4sJx/ji9BBFenr2PcI4DCrKrF+MIAzKgitB6Mi3+dGdCs84r0ZysTPSizVcTpB Libmfn0Is43DEtoOOL546CLC8b7WErkW+gnRSKuiU+jxaF6dokBBbDb2Dp3AHHSMwyRO swl8OFCNWp+4+SuEKZ+Aa8ugq5mQFrEYzCmVg10eyBW48eZDM8LvdZlaaE2COzGZipdi xyiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720454817; x=1721059617; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ij25sqUdevns5tkTNnYc8JRUONkaiwAFtKXPJUw+bLU=; b=wCh2CZMWA0LLXEOc3rAXu7O629pARZrPDtYXs7iMJ5OWxueMeYznt0ouK8Xyf8NT0o au3KyVWU2y+2YVwcZK9EhaQ7+kkq9cSUhRnXA3sEYJoGzsdoGqGGKugORhridJXKRMui pJoMnup6ZEiFy+ffHd1HAjTRH6S1klT7fNZ8QNypJt/lDzIus2+4Qmz17wAGb0hK/8WB cL3OHPx42lGiAyVTtY9XBIbseMJd8x2xoI3nAZb0svHWbxxNL5V3G2lZJN2UExrrJEst XvhIoSd+QcdpEN2J5n8j2w9/AWhAnMaY3SipHWLuWdfIs53TFkn/UHCob3grBf2giFwh fo9g== X-Forwarded-Encrypted: i=1; AJvYcCXZ4mEreWZ79ibjOAEDth1++IZSoWg4zlEr8/QA6F8BDCj95b8p+oYoLoOpuFFoZ9z3Miz4wVop04HG5dPPYDWAF78= X-Gm-Message-State: AOJu0YzFJVpYs9BqLGk2FTzIuz2droIhpoL79X/cXgG2VDKeZREhdn1M OnonAbJ3vBUf/yk2r4cXfBcbxrILNOEshJFYHXgN9ZKU4Tt/mlm5 X-Google-Smtp-Source: AGHT+IF/hrw4dhXyNpsl+U7poN/yPOjQGKFeq3B2IbiPefe0FzqELZ9Ys2LIlNm3+EGL+ueuEfb9HQ== X-Received: by 2002:a19:6a10:0:b0:52e:9b68:d2d4 with SMTP id 2adb3069b0e04-52ea06e76afmr7735829e87.56.1720454817039; Mon, 08 Jul 2024 09:06:57 -0700 (PDT) Received: from pc636 (host-90-233-219-252.mobileonline.telia.com. [90.233.219.252]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52eb8e346a5sm12760e87.35.2024.07.08.09.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 09:06:56 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 8 Jul 2024 18:06:54 +0200 To: Adrian Huang12 Cc: Uladzislau Rezki , Adrian Huang , Andrew Morton , Christoph Hellwig , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Jiwei JW10 Sun Subject: Re: [External] Re: [PATCH 1/1] mm/vmalloc: Add preempt point in purge_vmap_node() when enabling kasan Message-ID: References: <20240705130808.1581-1-ahuang12@lenovo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0DB11C002E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7b795khiescou4kknzmed7ofzj1a3szo X-HE-Tag: 1720454818-831119 X-HE-Meta: U2FsdGVkX198Z92xocl7YVyfqjoysVAbYon7/0SmaFh8ysrZhkk0R2akNTwz9LeBaty1DWffSIOCqURzkLAZ/G/1Htumv9C1fbgxdUtPfyl3p2M1Vzf6Y9uDseD7mfQh7+l0/ogkZyR9viFnTpngYjhKSib3YV4opDIazmtD9+HGS0SVCazxokdarvl73P4rUfuuAPSsx7/f8877KKJkXx4olRHI46Rd8tGLroXobwZbOtV5QV9gAFnJ7oDIY7LZw8ADxU7TvOu3K+ijqtzKSkWzokAFueu3hOn86jZm/yuM8e6bU/b/sfSNNOyVOwZx5ZADHIG4bdO3+3M/UjHMBvLqbwNzvS7zWgc4IwT2oEV6nJeuDioi6VYm4e/2T5OqAmfCTjXOuo9C+jdQCqvI9mzjebpvfwh83Wn2I7k4GILrPsvykXYpXmGUmfI9q2mxRge0vmqHyFnyGPxkT7l0kBiUdwvK3W+PwhJTA5HXwwvFloYzxwhL8pftkh7mu9B+ErMMOBENm0WIsueukkvwZ3Hs1/XxRcL9MSxSliCRYkcufZVf+ZwGsNYrE3YlbewfiYRRa2pSO//Utfm+V7prOxNLZoO+Dxd7IbyolNWfnacBBkcEOrxhabOLi2UUS4AJtd+tOHK5U181tDgYwvCNqe2L1Xdpp5FwUtTlMqctqGW9ijPh1f9xoWQpbSRK0wXQEQcj4iFUaE/qYRuEOs1ZXH7DTPJJ1kxuJQ7rP2StoJzMJXD3cRxGN39H1dLNn/qIwTTNF2VfY260elHu0M8IP05fFbIy8BpVHBuj+eB2uOCuhVjpDduYDmI6NM9eJCKaqUAXG46a+ra/YHwJVWJWCNwRe/NuE9fvWb1x85m3/MK92EntWucqhmI2MWGRuqntqreLTZVFPSGXVA/tBr5ztRpzCvfGWleIwB3W4LBdVtL3roza7NEdkpYjeu47yS5YkR0V88xbVAfftMEw8dM CGX2fCWA gsaAZnhnV4YZXmI2uxEg5hB/r/eUpCL7CtVLRS3XWjUj4xHJ+PEbKi34P+Eq6T+MzBg4a5n64UFphdguGTWeKCQNDujzeeC1AVqd0ICPY25ir+v4a5CWqQmZz15nz8zsBmjHmNnMNUOD7SsdQcBd/TLRCqO8KZvwQrA7m9v/JuF86RkUpXl0U8yWEHCXk0OZBHK0+06W4a1062wWcd/Iwrx8T0mBskdBgj11N8vdRQWi28EaJ/u+sumSGFDCCjp+Jom4o/4aJJ9l/o8j482UysKMOnK/R384c+lYJa8RhD1Qz0Ht73UHP0W9dzrR6ZTLZ8UJuC3vfjYb/CN9GQaMTDfwYr4WZf7RmIHeX++P5Vt+UOdOsR3+I3GYIOHijfta+pwdI4z39tQdRGoVD8mVoeDlqhXHDpTDahL8tvtrsyUrO7xda67fClSeVzD4j86Sl8aL+YwDjlfgSBtZopGMWp292cHzcUBFIYw5Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 08, 2024 at 01:39:57PM +0000, Adrian Huang12 wrote: > Hi, > > > Could you please test it: > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 03b82fb8ecd3..6dc204b8495a > > 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -2190,10 +2190,12 @@ static void purge_vmap_node(struct work_struct > > *work) { > > struct vmap_node *vn = container_of(work, > > struct vmap_node, purge_work); > > + unsigned long resched_threshold; > > struct vmap_area *va, *n_va; > > LIST_HEAD(local_list); > > > > vn->nr_purged = 0; > > + resched_threshold = lazy_max_pages() << 1; > > > > list_for_each_entry_safe(va, n_va, &vn->purge_list, list) { > > unsigned long nr = (va->va_end - va->va_start) >> PAGE_SHIFT; @@ > > -2210,6 +2212,9 @@ static void purge_vmap_node(struct work_struct *work) > > atomic_long_sub(nr, &vmap_lazy_nr); > > vn->nr_purged++; > > > > + if (atomic_long_read(&vmap_lazy_nr) < resched_threshold) > > + cond_resched(); > > + > > if (is_vn_id_valid(vn_id) && !vn->skip_populate) > > if (node_pool_add_va(vn, va)) > > continue; > > > > This patch can fix the issue. Feel free to add my tested-by. > Tested-by: Adrian Huang > Thank you. I will add you tested-by! -- Uladzislau Rezki