From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5EE8C3DA42 for ; Mon, 8 Jul 2024 12:48:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46AA36B0096; Mon, 8 Jul 2024 08:48:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41B076B0098; Mon, 8 Jul 2024 08:48:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E1D36B0099; Mon, 8 Jul 2024 08:48:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 11FB26B0096 for ; Mon, 8 Jul 2024 08:48:19 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 958F51612C6 for ; Mon, 8 Jul 2024 12:48:18 +0000 (UTC) X-FDA: 82316563476.06.122746C Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf26.hostedemail.com (Postfix) with ESMTP id A36F0140026 for ; Mon, 8 Jul 2024 12:48:15 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="Z/ctLcK4"; spf=pass (imf26.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720442880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fK5HtVriGenm5ML1JpdFXOU3g+iCUeiv2gozAo0WN/s=; b=m0yb60rM0KplIFEW8dVBjhSv/fD8osV/7U1jWoUUBcA62jyOx4bcqCqh2vps05VznZnWrX JfMxqfeKRNSCP4QpmdOk+Dt1ctrxXE0m0dIBbxVpPS/yNAImlOdcE40e5EyrClngx+JRQX Pzhoh5XIPlZ+ZbDj0TgTRBicyU2H5eQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="Z/ctLcK4"; spf=pass (imf26.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720442880; a=rsa-sha256; cv=none; b=58gYqB8yYEzHoh9Ql0tuGWQa8X2r+3VMHhwBYLPeHAGdGoawBptG5/fKbd8GV/V5FpjABO ATo6V17latIdVlL6zJJGX7UU6yatEshMQpC4lqLjEV5rIIht5CQRdQn6BwOwivghavYlLm QPopfYEW04lLjai+g/akvxVWLo7GcDI= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a77e85cb9b4so163639966b.0 for ; Mon, 08 Jul 2024 05:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1720442894; x=1721047694; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fK5HtVriGenm5ML1JpdFXOU3g+iCUeiv2gozAo0WN/s=; b=Z/ctLcK45NDKmEXQPJhHiLcI4eTFHD1qznBmjMZAS5UGQhENaWpojL+g4LVSwVCo4x ABJnqOdU8WLNbTQSw517DbHxzt2+0ydoczlbbWpC793KK08Fj14cVwEA/Qg+kSx4786W EilSe7a0nRPP9QMW8vG5S3AqQZK4KeBuoW6mgAspOQFtQhefOdf7tuS/ICAJ5sIXVhAT Sa/k8EGlzGzdzsKFjowcoJKNDIMfQUl4qIj7SlcsZEjj5ah/MsWxRPpHmz4MUdw0ogTb /8tOmybDAohS1Ka9RG7SOrM7y9AhyzbQ902/sy70M+YA8Osqgqttt2BMP6c22rDdlTo2 BxBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720442894; x=1721047694; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fK5HtVriGenm5ML1JpdFXOU3g+iCUeiv2gozAo0WN/s=; b=qxLBcgrF6zxytdEyqP7GywWnjBk1vFlubhyE6SzvPKQU0HFTKXp9J47reL7xbk5Y2+ 0t6tPaWAlbzYZBIZBv3g1VTJXiT7jxL1uohrqnGfv6qNFVVw/bm7YVrO3OnPrlZs4h4t zXU4z+j5N54b+0/4Nr4bi/LrTRYBGVQJfMfHHL8HfDLGr1X5mkW9q4DwmjFFXoRubnTq dNck5GDNWMTOZ2njk5xju35wupnR53vr5HLegCLLWWQbI+40MV34/qAMcDgd31BL7AQ2 kuwx2ygq0tcCDAgCannDIhRBEpq0HNrOPQ+T4gSufgneCgYft5Md+TFxOOzRvXBfuTR0 g1Ng== X-Forwarded-Encrypted: i=1; AJvYcCWSnxr+AmlLmA+PMJRUWH1YMnlabZw7JsmTyFy5SpNMOBl11gooWPtcqOeNJNetme+7hg5MaNaI6Cx8nncPJkHm26E= X-Gm-Message-State: AOJu0YxWY9icIXjiXyhjKsZaLbEQKFuxckdST0FczK8XvwIWLiMJKl/C YM6MBZPPB8fvZ6NHigmHBpTB64lQVgDUQfXTpGYc4Allcllr1F38A3soE1tJEGY= X-Google-Smtp-Source: AGHT+IGwaHfNVUOdVeIQh5PDgHlFtNS0KriPJG08xmwkOUQ8J2Y8vvp7jybJ1dinpCMovCYMRlZEhQ== X-Received: by 2002:a17:907:969e:b0:a75:110d:fa53 with SMTP id a640c23a62f3a-a77ba70baf4mr939217266b.49.1720442893911; Mon, 08 Jul 2024 05:48:13 -0700 (PDT) Received: from localhost ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77d808b81esm278822266b.151.2024.07.08.05.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 05:48:13 -0700 (PDT) Date: Mon, 8 Jul 2024 14:48:13 +0200 From: Michal Hocko To: Andrew Morton Cc: xiujianfeng , tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, corbet@lwn.net, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sidhartha Kumar , Miaohe Lin , Baolin Wang Subject: Re: [PATCH -next] mm/hugetlb_cgroup: introduce peak and rsvd.peak to v2 Message-ID: References: <20240702125728.2743143-1-xiujianfeng@huawei.com> <20240702185851.e85a742f3391857781368f6c@linux-foundation.org> <6843023e-3e80-0c1c-6aab-b386ffebd668@huawei.com> <20240703133804.1d8ddf90f738a7d546399b3b@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240703133804.1d8ddf90f738a7d546399b3b@linux-foundation.org> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A36F0140026 X-Stat-Signature: o1zu7mq3yi4b63e78swyjp3g6y6kh1ra X-Rspam-User: X-HE-Tag: 1720442895-674062 X-HE-Meta: U2FsdGVkX18/1WdNV2pEGwbV6TVcVzs70HWuABtZek0/mIZ0K/oJal3dRd966/G9YGS6c5rOaCEX/ObbxHHDvz6VJBLU7uLGICg1QVhzHDDh+LLgALLFU0EJC3NNLrIGl22aQKjEEk9jGKVkUAYi6h9EAKGAnE3UoTUOumbplnHBou2Y3SYBQeXw8nGpCGFTmtBqrO09GwWR2r3Ton2YDBjDYZga7T6S1gTdysmyZanvoMoaErvaEP8zYENN9lMrXYwix/wDXNwAv3Y8wNyKkKkGxGspIqYCIchdab5YTOG/wQCtpEwhNAtpKof3VOMhrbx0Q9ish8bjV5doU7DFiWsNY2UyWOqQlc031lp3JlKlZp5GBGMpaEsFzxTYGNVI++WLAjW8jUHTDJL5AZqtos+3sfPuA2XJAbGIBlCtIjNP4o5n9082I8q0DCe/yVsG8wVrmFB+Fg1ccUXwQDoTztmcaMkFz8E7OnaqzMtjvOauB1DOVbd2KBvWev91xeEBjulbGffEbftDPEbwM/7Vd0enGULHBDJPWSfAjSz145EaISvKvNalFn2CdUlQ9GO0XQ4bw27SrcSxfg9EOGyXW2AVNgqJzXFV2pPc0oe/1AOnixAwEbSh3pmhpU8zjQX7/OPfRAlprwoxQ1gI300Z36D4FNFLCXd4K3xWbDgGyT+yazK+sFuqAX61vmo6NH55x2Xu4STsbexBUnEsRKMuH4xhGBwtQwwFxxc1cVrplv6QqnNYhe1gEuB2MNVimV+++/+GHjo7yYXq5h0EnshH6OKP4DiGtv3xyap4jxJeFigRxJ2hPi8w2yWA+528Q5hJWxpNRtw8HwI2byqsvAWuzifmss+yR0zYc/htZlSifONM2bpA5kcPynTWtGu3BHOPeUv+fOlqtTGKccUV8R7iU3F0QNYrhh/ACVICGRmMvbeq8VQqQtUOfj54QczKgwGTTKcgu+NaSZoATnFUADO /yWBiQdo Btrbe0tODty+p+3hczJhV2rMSWEiDHgM8ngXZ659qcjVYjXV1mXHzS2kmR7UEMjLIRwAsPTiArEFzrRgWaTh12Zxx/s2dM14tvRUO6mQ9QBFxAupPKarGRZmzDc/fgKPA0DLCbiigdrgjZB7rgloJBliZ1dl3LKdXRGUDGGG7rS8ySqjq7On48llYOnuvWLANmK7n79zDQPrJD8bbqlJF50ZplcndGGWKBgSmQ9qn6x2B71Cw5Rowhr2OXDYJHcc5HBAYBXWKHtM1w2xGer24AItcw6QZeNcv/5Vv6TK1+6VUP/wxPn+m5eyz14FtsyKIvkuuRcXxqbyMHh9RiHauvaFR7I9ovPnSbAcuQnHWcXZiPGc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 03-07-24 13:38:04, Andrew Morton wrote: > On Wed, 3 Jul 2024 10:45:56 +0800 xiujianfeng wrote: > > > > > > > On 2024/7/3 9:58, Andrew Morton wrote: > > > On Tue, 2 Jul 2024 12:57:28 +0000 Xiu Jianfeng wrote: > > > > > >> Introduce peak and rsvd.peak to v2 to show the historical maximum > > >> usage of resources, as in some scenarios it is necessary to configure > > >> the value of max/rsvd.max based on the peak usage of resources. > > > > > > "in some scenarios it is necessary" is not a strong statement. It > > > would be helpful to fully describe these scenarios so that others can > > > better understand the value of this change. > > > > > > > Hi Andrew, > > > > Is the following description acceptable for you? > > > > > > Since HugeTLB doesn't support page reclaim, enforcing the limit at > > page fault time implies that, the application will get SIGBUS signal > > if it tries to fault in HugeTLB pages beyond its limit. Therefore the > > application needs to know exactly how many HugeTLB pages it uses before > > hand, and the sysadmin needs to make sure that there are enough > > available on the machine for all the users to avoid processes getting > > SIGBUS. yes, this is pretty much a definition of hugetlb. > > When running some open-source software, it may not be possible to know > > the exact amount of hugetlb it consumes, so cannot correctly configure > > the max value. If there is a peak metric, we can run the open-source > > software first and then configure the max based on the peak value. I would push back on this. Hugetlb workloads pretty much require to know the number of hugetlb pages ahead of time. Because you need to preallocate them for the global hugetlb pool. What I am really missing in the above justification is an explanation of how come you know how to configure the global pool but you do not know that for a particular cgroup. How exactly do you configure the global pool then? -- Michal Hocko SUSE Labs