From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B273C3271E for ; Mon, 8 Jul 2024 08:24:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E296C6B00A0; Mon, 8 Jul 2024 04:24:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDAC76B00A3; Mon, 8 Jul 2024 04:24:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7A6E6B00A5; Mon, 8 Jul 2024 04:24:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A8EC16B00A0 for ; Mon, 8 Jul 2024 04:24:22 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 526E3161194 for ; Mon, 8 Jul 2024 08:24:22 +0000 (UTC) X-FDA: 82315898364.28.AC7B36A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf01.hostedemail.com (Postfix) with ESMTP id 1438440002 for ; Mon, 8 Jul 2024 08:24:19 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=w8oaJ4CP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4SqZ+WtW; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=w8oaJ4CP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4SqZ+WtW; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720427027; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qWXPETxPIsP7YGSU/X1TKH8MVdKI3GNs9fRlVyTz56Q=; b=ggzOfq3aI1vIJjfKGrg1FLUrJgCOk+n/BU9xITqvzgFxEIBlVHlJHtdhVUD8iDdyuYJ1xF b08k7Jw+6CLRg/AxXeP4C/RSZf0B/4sIs0kYfrAbZd3E+3Ikg/QmSOfcs38fRmoDlK98PQ tBW0BWt5N0QPjzsyazvbNZopCw5Uu1g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720427027; a=rsa-sha256; cv=none; b=c4TVHfJYPguwUmpWz6vWMgpHoi0OYeC8JOOoMCXJzcZvUvlzYY434XzVd37YQxG/uzNHun DxvdPhF2RDIpWpd0EVzlpO9EAnaMSt6dJVHJq3ARxzKFMILnQvHnJBgts/IMXVsFejBk7T gAip0OShzTdmiZHnqC3TebJ3EMDqh58= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=w8oaJ4CP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4SqZ+WtW; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=w8oaJ4CP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4SqZ+WtW; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7C1F81FC0D; Mon, 8 Jul 2024 08:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720427058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qWXPETxPIsP7YGSU/X1TKH8MVdKI3GNs9fRlVyTz56Q=; b=w8oaJ4CPZWa/KytcGmJ53wiWN1gKgZOqJYCe5aSl4KFKPj/NUVr1VDWh7e80/UhNZaMF5S Pa9kQfHfECWXZykGwW4c8VGzq85rFA52jfVlAh5AwqC574fgpkxrKzkEEb1CaiuZfsNg/M 3tFZuUy8Ntuf5FdVHJRPO7gNSvWQpQU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720427058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qWXPETxPIsP7YGSU/X1TKH8MVdKI3GNs9fRlVyTz56Q=; b=4SqZ+WtWeDjccTVpTpGt8xXZxDQvfxhAmrcivfqO6MCCB3rpOq3h0rx05mAbUpIHSQTofA nkVLIEc33q3g/+CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1720427058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qWXPETxPIsP7YGSU/X1TKH8MVdKI3GNs9fRlVyTz56Q=; b=w8oaJ4CPZWa/KytcGmJ53wiWN1gKgZOqJYCe5aSl4KFKPj/NUVr1VDWh7e80/UhNZaMF5S Pa9kQfHfECWXZykGwW4c8VGzq85rFA52jfVlAh5AwqC574fgpkxrKzkEEb1CaiuZfsNg/M 3tFZuUy8Ntuf5FdVHJRPO7gNSvWQpQU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1720427058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qWXPETxPIsP7YGSU/X1TKH8MVdKI3GNs9fRlVyTz56Q=; b=4SqZ+WtWeDjccTVpTpGt8xXZxDQvfxhAmrcivfqO6MCCB3rpOq3h0rx05mAbUpIHSQTofA nkVLIEc33q3g/+CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D6AB61396E; Mon, 8 Jul 2024 08:24:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Ws6TLzGii2ZyIAAAD6G6ig (envelope-from ); Mon, 08 Jul 2024 08:24:17 +0000 Date: Mon, 8 Jul 2024 10:24:11 +0200 From: Oscar Salvador To: Miaohe Lin Cc: akpm@linux-foundation.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/hugetlb: fix potential race in __update_and_free_hugetlb_folio() Message-ID: References: <20240708025127.107713-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240708025127.107713-1-linmiaohe@huawei.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1438440002 X-Stat-Signature: qncb8u4mp1ufi1ahwrtr8ywxy65c6jd7 X-Rspam-User: X-HE-Tag: 1720427059-272734 X-HE-Meta: U2FsdGVkX199aFguXEcFt+mux3+xJaJtzRJSh7XuYiLdYtjtFeZxH6Z/KLIc6Ztd66r+0LF9Nf6u9WkS6GZ5FwWc+SfwJ21In1a7yxZTgUO2Es1VYQx57ml+TItwgQ5ewW43ltsBiwGqNhGdBgQUR7C9xbQWpwqqJcbjmkZlboOi78lYS1+WEQtOSIWkppY81wAc5krhch3fixRNbBRGx508OYt64yKjUy32qPDP/iz7Bj1841rPYN5emGzMFJOsQZRfCWtGDv3TMmtMIa6+/KcyW9uWwpREdjKCowiSSfUHxbnxEoals8CqjWFlzBk2eDkHlm0/9eVEfZi6+G4SZHn4wHx2VrXggGDMFhxLNGbXS7jIfLk6h8ilJ2DWJsE6RjElB9DmoFr/EBHNMF6m7Zh3vArkLG30QGbP1SmcvV/sWyRYqI6jCZZmAaPyTWaW1uIXgqsYrnO9ftG+zsyr2NE0XyRmjxiG4CQtLaa4Pl2GRF4k14aqXtb8YUj1LDg5AjzAX/dtsX9XnxpGe5E/qWPzhRLC2uiOcDJiO/DvgZs92yQTYvli7BL5l4fvJDnLiWAljj3rmvi1+ZXDTJdTIZZF1eEUhaLFgeCQV7FMMjZUvCmmD9WFG+8f5/uy8RqXmSBWSeiRRg/NXZkC2z6W4Epgl6HF9DJK23pik7p2MHRhR7lo21MVzRkRgAk1GhsjJcKgl/ZBVke7za9QlRJ9Sm5/UkTXVKNLFLyZFf8psnYjUY3UzEtZiNliJhDQukEahaCC7LvSHtNaIg4sVpLQghTSUaglTlqkcwbhVvcpIVdsVfQd+RgL5Lvlw4md8P8OVgssqUza6Wx+DfKRdajYScjI5p3+VAAe+ObnRbrzML44RgPLCDiDbEOLV+iMOIRQYg7gyKxEQFoMHextQYrGuJYd9gAIZifIlm3YtwIsk/6jsGpx0MuQG5mZ5gc5iqq7RjbqXtvXMSNl8/5yUFe WqdBkvQh vjaDt1HROfnYON7TQkPgvG0soG7ify+y9ljDc9v+VF9X7MQQew4vIP0a2mTj6D7D0TAnIDnu9/17nSFLTO30L7FdcoWO674nuddvss4ZImFbnV/fSvesStXOm4koJPeoHgrRfnqz9/vJ82du5ujbVcF51YS2+KJs5k559d1HJV2EB/aFTHhqGXWVKiWfh5K/Icxvk5xJK5F++2wuQUqARlsh6fLfsXbP9ZD0LqtIxnMykg4ILuytD0bw+h5SJldnHLdtgkJMYxBOMP9DoXyEHJQP0Sh9vH1SBKgHKHP34u15cKmWA2BD9wzqt9yM69TxCZE+FZro1iVddVekunGcvsRny66tOzmP0bxf6rKDWcq7axWQFzgVrjGBRKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 08, 2024 at 10:51:27AM +0800, Miaohe Lin wrote: > There is a potential race between __update_and_free_hugetlb_folio() and > try_memory_failure_hugetlb(): > > CPU1 CPU2 > __update_and_free_hugetlb_folio try_memory_failure_hugetlb > folio_test_hugetlb > -- It's still hugetlb folio. > folio_clear_hugetlb_hwpoison > spin_lock_irq(&hugetlb_lock); > __get_huge_page_for_hwpoison > folio_set_hugetlb_hwpoison > spin_unlock_irq(&hugetlb_lock); > spin_lock_irq(&hugetlb_lock); > __folio_clear_hugetlb(folio); > -- Hugetlb flag is cleared but too late. > spin_unlock_irq(&hugetlb_lock); > > When above race occurs, raw error page info will be leaked. Even worse, > raw error pages won't have hwpoisoned flag set and hit pcplists/buddy. > Fix this issue by deferring folio_clear_hugetlb_hwpoison() until > __folio_clear_hugetlb() is done. So all raw error pages will have > hwpoisoned flag set. > > Fixes: 32c877191e02 ("hugetlb: do not clear hugetlb dtor until allocating vmemmap") > Signed-off-by: Miaohe Lin > Cc: Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs