From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1495C3DA41 for ; Mon, 8 Jul 2024 10:14:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26C836B0088; Mon, 8 Jul 2024 06:14:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21C516B008C; Mon, 8 Jul 2024 06:14:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 096286B0092; Mon, 8 Jul 2024 06:14:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DE48D6B0088 for ; Mon, 8 Jul 2024 06:14:51 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 92DE4121224 for ; Mon, 8 Jul 2024 10:14:51 +0000 (UTC) X-FDA: 82316176782.02.18A2376 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) by imf12.hostedemail.com (Postfix) with ESMTP id 9B9BB4000C for ; Mon, 8 Jul 2024 10:14:48 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=LQG2a9za; spf=pass (imf12.hostedemail.com: domain of david@fromorbit.com designates 209.85.161.51 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720433659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8o4FeBTkQydEY+E5Ft9ergtCpLoarVxrr2b76p2ARdE=; b=fTbvwHQW5IyPNpPNAmFvXBAB0S8GaH+xk4yi1QY7/qrlbkIIbtj9PJ+5HAwjgs2/h8UBRc z7I4VO7CkBn5OYB8Vb4w4gS1fFaaiawXPjcqLQnNSgXWvUP4l9WKfP/2aud25PpH8wlesR XMvlT5a3C1Marr3TtHTdIH5EPt8+N2g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720433659; a=rsa-sha256; cv=none; b=ilb8d8XodyD9XDYAVEYILXWqY8cfheZppf5hpTEgkxGT+l8Etdiu6psdeXqKQ+/j/vbcfs MvVFTYdXZFTujDOZeawaRM7dXzoBqZLq9hme0vP2bikifLCiTm9umS1vOIzHIdHMx3KFus lJj6zh/WiTgLsG3h3sqcRTyYxtASSUU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=LQG2a9za; spf=pass (imf12.hostedemail.com: domain of david@fromorbit.com designates 209.85.161.51 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-5c44ec4f2dbso1978578eaf.2 for ; Mon, 08 Jul 2024 03:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1720433687; x=1721038487; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8o4FeBTkQydEY+E5Ft9ergtCpLoarVxrr2b76p2ARdE=; b=LQG2a9zamloE1HA1MWbUGGOTyAZNPrapO5UbBg3x7QUw4eg+LDhEXaXCLQpy+IuBBC XjnXiegtuZeWNE/dZEdBaC6Q/jhmvIYI2sGkCIO4VWJyBmuH2khLaVYnLFtG6aljOe6V xl4+dYhJzU+9X1DSFgBYxHm4NMyopPeKtqw3nA1p8fLs1++MxWQ2sZPFkNApXx5fxlds jZLWk9iHheo9SabMGQ8YMSgmvl0shuRWn5LR2KKv6qR4K29DQPmqSTucjGHFK67ov07M sNISNWgyZaQOtA5+4NwZLhpgaq7wyGhnZsa8meQ7qZ/19DCGIVQV+LOt9p54cOeZ0YH2 U1Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720433687; x=1721038487; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8o4FeBTkQydEY+E5Ft9ergtCpLoarVxrr2b76p2ARdE=; b=S9wvP9342DcrciITpcnpLY17g5hyxOEY2TEAtBewC+77XCy/bo/PgrkBmPb1J9dch1 crI1e+E4zIrZl5G8hghOkdSR9CZl/vY5uzk2qVM6uZC4IfwiHwDQwmdqONlxSOLB+/1M 9ik1+Z+Q4/oM+n+R91pjQFcux9a5eIIlaAxUYLVCSI7Rq9FmPJ3OUtGgUkth/etAIzvN zLh3zjScmgTkx7Pbq+mIW0ZvPSYJHvhGy0HlrkiGIRUvX6bDZPZxs48e6UeAcdAFwuLl IY8dm8pR+NZo6HMnQ6MT4yQMXnWItncXGXfDhsbSPXzx2x0Z2PhmMaILz8dUaoVh9XJf tPqw== X-Forwarded-Encrypted: i=1; AJvYcCVEObGDVPRjHvUU6Vs7h4o0E56JNzRoUl3pYZOqXm1VLzuZ8yPcHrfi4+DjfOZyw9tNjD7TPZPf9F//zp7xYtEK5eo= X-Gm-Message-State: AOJu0YxJmYVZmoOkNfqP0UUQdrHQ9myZMdBQQDcdkpItGsqtFiSMdEz0 b32GqsK3pyaNjnGA4CeTRgkHDLXpUccOEpXjSK/P3o4yB/ZaKpm/671F+Vbp/kU= X-Google-Smtp-Source: AGHT+IE/zS6WEa6AYR9d5DtByxCxkrGdmxNX7wGLzq43cS2MXgaaIKi+XNyuyDfoV7t+ibOfdSJHMw== X-Received: by 2002:a05:6870:5b81:b0:25e:15c1:257e with SMTP id 586e51a60fabf-25e2b9de8cfmr11531140fac.6.1720433687408; Mon, 08 Jul 2024 03:14:47 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b03a9d996sm7596909b3a.96.2024.07.08.03.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 03:14:47 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sQlOO-008PAB-1z; Mon, 08 Jul 2024 20:14:44 +1000 Date: Mon, 8 Jul 2024 20:14:44 +1000 From: Dave Chinner To: Alex Shi Cc: linux-xfs@vger.kernel.org, Linux-MM , "linux-kernel@vger.kernel.org" Subject: Re: xfs deadlock on mm-unstable kernel? Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9B9BB4000C X-Stat-Signature: z8hdh3ygprztniuogpn9z51577pqiguj X-HE-Tag: 1720433688-17540 X-HE-Meta: U2FsdGVkX1+wU7oy8+3ZNg1YT1reiQTZAAxlQkZSWTmUxbLteWVHlRhG9mO1WQCQ7Y1/civmUykWx/ED8Hup0mAyke51olwNJcCO1yupigLyIcvpIpAVl+7ukfv/3TGSEMKCMJOvQx8cs563LDpsxhlBfUahCguc3ysOEIN40N2l+UEJdKEWG+NkYb98uT3tCRt/INOmEckMO7dgOWhsK85hKrrQ1iR8N8GubRzfX/5a9Mgk0CV+ORce2TAGHwpM5ukyFcYmw66BFXlzXKmnxNfK0sYzeEST3ggjGhNObt8S6fe7tPXVYCR87TnMsfe2EAuJLQZxv90PwjWNQynrYSVjNCQ4CKbeOZYBfo88LHxpvGXY5u/SY4SFYWwibhOuzAsmtj7DLc51dJzyLvSDWF7gGDPpWyih46PPv54OuISLfFBNUUC06u+aDEOrR6jtNU9Ir+J8ooqqEMV9O7XHUwe6dHzvT4Sz6jHiWvtAb/FFFahrcoyR4hNgOt26oGZsuXYiWDl7XpPVZDunkeDCbG8PDPncgiteGzpePAngahPPtXK5WhZHaeByaBzWLP6f/tWo5QteIOkP8AH5HOlPmcHwlE6n4bi43t1uZRbGVbgQOXAQ2Nn+2Me+nHdF5Nvm5/bJSVCTIwn1/fSsgs0EcT4XDyc35WQUay0piaw7yCmc36CeFDXmiJ/RUWQWwQ3LHH+eQJKkFWC6mPFh4NrOj8jjnv4ByLjTCgQazE/xwLZvntbXbNdj0TCINNYDTPBAysKVRqQgxjbWSsX/wcYrKBcUH5lCNRJ0pxMAlWNLo3KdxDjDeXUdwA3Izz2QrFs3xlbZstU4xsyUb8U3QknkbghuoyBeDaXExK66CXDvZDQxMpaWJsM3+jMU+WI9lqtQNBpmKvzh/K02AmxhNTaG+qvWIbFSu27hyPYDjLTNPco1xjEdZ3fEhOtlm0Q61I8kOM0H14FgTIosJxhe3LZ NaOI4SCF eMA4JJtMvomLq+E0fGJ1KbbbbylkjGId2rezV1lmsG+PXdx6d8NcDMhSvxV+jhTGt/Y482GObfRj2RtzgaSN2HXvR+wKBdr2uHzUuALTMLz6F447Z5utIjMlU2vKd87NGrdkuPcPegRTrVAaLAVZpy6MZdZuF9p+UOV0JRSi8tUwtfu2FE+l7kyISSmH2VS43Uxt3hCjUaJZYD/jADT99BEMIcrxNgeROiq0uSrRaHsvqRTyuGaKkhPL1NqGdGL4Yryzjkqg81zl4ZBoK5QgbuyNVGSii0f9HvBX4PVsKHQz8DhCDbMLcO8mDnM83CSy+BtPS9eh2DFdQtGlINKctjYQZczodz0HJ+otO/PQQZx5GWcpFjTCkg4wiQ5LR2O36BCKhLHU8El3/1t6f9cn2Xa7yBRjNwJq4wvtkGOfqrIP/8UCKc+unXTf3wMPy3rgmYRJXg41WxZzSU3D+iJlO3qCTv0vkSIpqqBMv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 08, 2024 at 04:36:08PM +0800, Alex Shi wrote: > 372.297234][ T3001] ============================================ > [ 372.297530][ T3001] WARNING: possible recursive locking detected > [ 372.297827][ T3001] 6.10.0-rc6-00453-g2be3de2b70e6 #64 Not tainted > [ 372.298137][ T3001] -------------------------------------------- > [ 372.298436][ T3001] cc1/3001 is trying to acquire lock: > [ 372.298701][ T3001] ffff88802cb910d8 (&xfs_dir_ilock_class){++++}-{3:3}, at: xfs_reclaim_inode+0x59e/0x710 > [ 372.299242][ T3001] > [ 372.299242][ T3001] but task is already holding lock: > [ 372.299679][ T3001] ffff88800e145e58 (&xfs_dir_ilock_class){++++}-{3:3}, at: xfs_ilock_data_map_shared+0x4d/0x60 > [ 372.300258][ T3001] > [ 372.300258][ T3001] other info that might help us debug this: > [ 372.300650][ T3001] Possible unsafe locking scenario: > [ 372.300650][ T3001] > [ 372.301031][ T3001] CPU0 > [ 372.301231][ T3001] ---- > [ 372.301386][ T3001] lock(&xfs_dir_ilock_class); > [ 372.301623][ T3001] lock(&xfs_dir_ilock_class); > [ 372.301860][ T3001] > [ 372.301860][ T3001] *** DEADLOCK *** > [ 372.301860][ T3001] > [ 372.302325][ T3001] May be due to missing lock nesting notation > [ 372.302325][ T3001] > [ 372.302723][ T3001] 3 locks held by cc1/3001: > [ 372.302944][ T3001] #0: ffff88800e146078 (&inode->i_sb->s_type->i_mutex_dir_key){++++}-{3:3}, at: walk_component+0x2a5/0x500 > [ 372.303554][ T3001] #1: ffff88800e145e58 (&xfs_dir_ilock_class){++++}-{3:3}, at: xfs_ilock_data_map_shared+0x4d/0x60 > [ 372.304183][ T3001] #2: ffff8880040190e0 (&type->s_umount_key#48){++++}-{3:3}, at: super_cache_scan+0x82/0x4e0 False positive. Inodes above allocation must be actively referenced, and inodes accees by xfs_reclaim_inode() must have no references and been evicted and destroyed by the VFS. So there is no way that an unreferenced inode being locked for reclaim in xfs_reclaim_inode() can deadlock against the refrenced inode locked by the inode lookup code. Unfortunately, we don't have enough lockdep subclasses available to annotate this correctly - we're already using all MAX_LOCKDEP_SUBCLASSES to tell lockdep about all the ways we can nest inode locks. That leaves us no space to add a "reclaim" annotation for locking done from super_cache_scan() paths that would avoid these false positives.... -Dave. -- Dave Chinner david@fromorbit.com