From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 557D8C30658 for ; Fri, 5 Jul 2024 14:43:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC1D46B009A; Fri, 5 Jul 2024 10:43:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B71DF6B009B; Fri, 5 Jul 2024 10:43:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3A106B00A0; Fri, 5 Jul 2024 10:43:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8588A6B009A for ; Fri, 5 Jul 2024 10:43:46 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 134A41C01D9 for ; Fri, 5 Jul 2024 14:43:46 +0000 (UTC) X-FDA: 82305968052.21.E8BDF02 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id CACE5C0026 for ; Fri, 5 Jul 2024 14:43:43 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="YliE/fNc"; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720190612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j0SJsEEP11U4Vk7UXdQukCdPjJQfadC3871Fcu4WmXw=; b=Bsae+Tx3Go5kFxo1S1CcFtSn8yIM6CacAkE5SobDUWzSbuFUKgD+y28pUmCoreHR9mHJYO S1crJE+Wgw71OftrW0ddmFZdNl/U7KilpA0puXO8WufZIwoIC50mavYoVHkBvs7BFe+pEW hF+m5R65oIOLMckAFWFKUoj57cMpHjM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="YliE/fNc"; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720190612; a=rsa-sha256; cv=none; b=ewOXLSjkvd9L716XwTy1hToMtF1lSfXQgiYpkewKoyyjdNp4LUKxTBvl9Rk2Sz3WsNId4s Wd6dvNa3FzGnEhYPoJobC3zs/II6WHyI9CG5JMA4KXr00q5Gyt/taWfpyGOPopdlzaBccd 3Qi1P/Pkhn9AfA5RzBs3hFNOAWqF5EQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j0SJsEEP11U4Vk7UXdQukCdPjJQfadC3871Fcu4WmXw=; b=YliE/fNcZFURKz25OvdBvqgnuf +1PmeQN/O1v6WBIJ+Gv+jojfC/8t3vkeTLZYoSn/auGiQgisQAkSqGDwla2AXCLDSikU4RoVMVIBd hWK2horQVBCMKv75MM/NUwlC/rY46ZaHjfKZTGe4IIdpwj7at//b6yeNX1+9dpuir3Gq1UlKhgiTx mZwFQO3KOpWy3j02EhgCJY/8hqPdV1kIHfs8ZMnvhXe5dbYZBtjUy7rZpk6JDXCgC3IJ/QlwqDetr 8HuGC0hEY02EYq5rWDwyY0lnE+Yw7d5dbaphF8MvvQjtGF1iwHWMoCzJteMpydff6sj/IMMNZBBSt NHh3YJvw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPk9y-0000000447K-1T2F; Fri, 05 Jul 2024 14:43:38 +0000 Date: Fri, 5 Jul 2024 15:43:38 +0100 From: Matthew Wilcox To: Tvrtko Ursulin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, Tvrtko Ursulin , Huang Ying , Mel Gorman , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Dave Hansen , Andi Kleen , Michal Hocko , David Rientjes , stable@vger.kernel.org Subject: Re: [PATCH 1/3] mm/numa_balancing: Teach mpol_to_str about the balancing mode Message-ID: References: <20240705143218.21258-1-tursulin@igalia.com> <20240705143218.21258-2-tursulin@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240705143218.21258-2-tursulin@igalia.com> X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CACE5C0026 X-Stat-Signature: kyd6aajyz6ccyut37whgy8pidff3hgm4 X-HE-Tag: 1720190623-982739 X-HE-Meta: U2FsdGVkX18pTRhT5r+Rh1RNrk8OVl3jhB2a3cbt+rH7I9GgYa49jkUCehp65gaGKwnxIYHntBvsHEZ9fxZu+QZLYyzxob2iS8FVeWfbw1dbnL84wUcB0kZhC0At5W6bYy5qenFQ5ql83VAdqrgQjxDkOpQYj5b34tyvPGmfICeNyL+p/rZVcurUcLxG5nE4K7NB/d895SNR6tccN4nnep2lw1BShKpIGSrU3XHANIZlF2+JxSCtalX6iXIRZ1VNfX8T5DPc6O/1qJtYbp/HT3bdC3hs8OPEbnZEXs7Bw1OtE1GnB+QITLeXAoPG2E1MET3oHEFeRuue6fTxtDqAu48tWX+xBW1HAT776aDJOVgHDGb/7ZkoEtUSF1sGJLDN6+uOdgrm+oL6HyAIBF6lJUl32g/fUNKKg4cbEDXF765Gh26ubirGPDBo6D7RBkNrcHPc/OjpnASalLJMAiXuDAs0BNHc5+wS/20sOHnDgSmMu8TlGD/9rNOYk1xY3wYlIGREbA3OOV5UbIye/1vCW3hLJWswHIgi/EplJVcGogT0QTkMO6Xx5vlR+XyUGb/f9vg29sm7+RNlhOOQQRz33OiONt0id0V3vC8is2+TvF1JhPmwRY/zeXQjamewxmB9pmjn4oHqylMpyPLZnqt1/OMbnUqEZSzGFnWvTY/IY3PyakTBA9Gl+I7gtVCgS5XywraiQ6U5SNcknmEkC+Dl7w2sS4h0E97xxU2R4EyebED09PkJfI5/aq86Hdi2Cz7KFPZrci6w5Ul5o5sa4WSTwtbNh2gV7XEFCxjTicCTgNQDoCV/XceF3cYE0XiUY/PgW3FC7h3JKZ1m4GhoopSljCakNn5FC9mDU65B03KSUhc1/S7dmWFrR3nSLA/yxFEemJD4CPiAKuX5pWuuVJnGa1CrQsZGXagC0t2hOK65L8rWWMRZSsyUh5X/KVNBeey7Jl9n04RojKrImKTJ/Ir wBxrUPcP 6cOkWHg47Cc+Z28BUjBV4guOzjG2yw4KfyqVCVObOg1n9cvCGHHgrax7vTE61TbL5UPr/hQZ3BRr7yggnbo33gRhguZi4uyJGWh0oCyzeFKETGwIVvnKBG6hbm9/RR4ym5PFNkyxcPi2O19bso6bVySn2nHavNI0Idwq2CqMHIDPgDUk/qM5/QN7dJKkgKsuN3Py9SMzt9oDtj42g9teyL+4jK0qS/CgyFCdtu+PPZkpCU4bjGDsrxHYud9P4Cb5j/zZa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 05, 2024 at 03:32:16PM +0100, Tvrtko Ursulin wrote: > + if (flags & MPOL_F_NUMA_BALANCING) { > + if (hweight16(flags & MPOL_MODE_FLAGS) > 1) hweight() > 1 seems somewhat inefficient. !is_power_of_2() would be better. Or clear off the bits as they're printed and print the bar if the remaining flags are not 0. > + p += snprintf(p, buffer + maxlen - p, "|"); > + p += snprintf(p, buffer + maxlen - p, "balancing"); > + } > } > > if (!nodes_empty(nodes)) > -- > 2.44.0 > >