From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0721C3271F for ; Fri, 5 Jul 2024 09:12:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E5BD6B00A6; Fri, 5 Jul 2024 05:12:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 594C96B00A7; Fri, 5 Jul 2024 05:12:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45C676B00A8; Fri, 5 Jul 2024 05:12:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2763F6B00A6 for ; Fri, 5 Jul 2024 05:12:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 67FE5A2DE0 for ; Fri, 5 Jul 2024 09:12:31 +0000 (UTC) X-FDA: 82305133302.06.C2BE8AC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id C0F9E4000F for ; Fri, 5 Jul 2024 09:12:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=X8GIlS8c; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720170730; a=rsa-sha256; cv=none; b=iAsqeydWYVMoXPaGdSC5hFOIYEI9CN+jIWIyth4qXIkdk0ZT/qHhT/kAjL/DzYJwWe3nt+ k/iIuh3QT8CWmgKc1xBnzIT/lBXLTZrcxujMJP9CRBvfUQYsoMQ2SctfxJ+FoSLy55kjIu eS5jN0YczOAX1u4uHqzitMmlQuHskkI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=X8GIlS8c; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720170730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XYcpj7Rg8Zwopn35u6X08VkMCJj4WHrn+udxxdoJAtk=; b=T5Uo/1RtdWs1f8zWp/Rup65FT/3ZHbCVeK571/UVTvmJNv1bbQdPUqXC8OHxPfZLhIUQ9W HLe5dFm7SH8erQGrz4I/B2ru3CpiVocFOHMuN8MptFurDwpIT/aZv4+todYrIBABc41AbV XT1Lj5EI5eWFYPhIUJ4W9u1GqnSHij8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 921A062A6A; Fri, 5 Jul 2024 09:12:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AA4DC4AF0A; Fri, 5 Jul 2024 09:12:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720170748; bh=tZOrKLTxHWQw0WT54iRymsngckqcvsL1CHpv+SYW4LE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X8GIlS8cwm9zDhg0WCkYc7zfrq2CwvZZpjWfg0AXvGNbFrcIRMZeA+Vk54rajSCcx KsJuAvQpIaPQQ4bApxnBif/Di6D97P5yCZ0Jrmrr7Oizfp97MNSSai4xu/w0fSpL/S hSTB7iLmciq4+gNw1seNjvQQAxRwFmZljYCaLTqQ0gj5PeRe2gKwGhPUOa10VN+AXp 1Nq7Jog8XpoTFOBiJn0C6kjnGsHvmvGu/eW8a+3o2vmRqvlGYxHn1DHHJzlAR+Ip+V r3VZYr+iMFEIc90vh3l+q0fPSaE+kHc/quiiTht3/mrPp2Y4ZhSHPTupOJ7/dqN8Sn QSP5zA41Z0G7A== Date: Fri, 5 Jul 2024 12:09:48 +0300 From: Mike Rapoport To: Wei Yang Cc: akpm@linux-foundation.org, brauner@kernel.org, oleg@redhat.com, mjguzik@gmail.com, tandersen@netflix.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, david@redhat.com Subject: Re: [PATCH v3 1/3] mm/memblock: introduce a new helper memblock_estimated_nr_pages() Message-ID: References: <20240703005151.28712-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240703005151.28712-1-richard.weiyang@gmail.com> X-Rspamd-Queue-Id: C0F9E4000F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5jogfktfrh1nyb6japyjq9u7i4kdtwfy X-HE-Tag: 1720170749-207659 X-HE-Meta: U2FsdGVkX18sOw6YK2azs0GfyKj0teM4RzGSBEIHuW0ohTsivtah5Oem3yRveng438ioHJt+oSTC6Ovtof8WINw1luSPeY73HW2Gs3jM+NGTcaUMJpQgTwHt+vFGQMVf3ukyOaQ9c5wuizLs25UoJb9QYACc68dlxXoFCn8jwi8OHxfhSFOBsMx5ibcW92rdxRN9QsVbcC2HE1ZIkjDDS/W4oFTnJcKTfocPMg1JJCvbQZ726f+coyTq1ntQHu+sLRVobMMtFdF9o+afJtCD8uyJkOQa12srgGWhBviLTpMPprBVR7o7RTdw0DU98Igiqp/UiJYT1vWo7f+spYJoUav2GfkzKL1ZfoWlJ9MzYPzyRvGvW46myGJ2di4cO01NVJtbdtegASFbs5HcQwHh6x9tId6BR3aLDYbBJUjGRiVKzDJiAyx/Ll9JgsuFFfvd9ufsTyEyHWcbetSTWI0YUUcNSEPCTHnQH9t7H7t2ghZZugBseDxhMDoZftvGAeTIjsxYrXuYB85bPZklARw/p6DDQUnlHTPx0e5NYPZ/FUPB7LuUQGy3aLvSs/8ofBJ0erShJxUAiPizQfl3WX1qfDL3VU/ffmKWtL/BkszTZXAw1FHXO3RQ0KvivofJt7SswrsvPYTe5pNSBdRqDnLzjl+hKcffOuvZNc2QTDDz69g5cZ7nRPI375SbePMHV3PtHPF+qDk19fNlr5hlryIpFkFjCKFw5hKxU6IhDZDs2aH5wHDzpGMocqKwq1h4/vRFbbKTH1AghRCd/cBogpj1HcPuwcX0FaO0KGxbLbMITqp170kThtignVt9VrZZumTkBjGBzmGD30iLxOUIzFV3MxDX1t4YtboyFu5+9XYVrykVAmQPPPn7qAvEKjz7vyhNJ/B3/6gjUs6dCSQtX4e/BXnQDWMNoSaQJEGVj3bG2o/+0sRg3VR/AR4gmQmFKdJJIUsaD59pZeBVd2yjvKi 6SXpqF7e P3rm9JBUzqxR/XMLiqjE2ww4e3EMj+kRH8W9n1PI7yJuJnnR6QN1/cKsJUEKWy5A53dPmFoyUyBcgEdQZx157HTJXLmJtvndHUV5IzIw7flI+V2U8M+LVbqrQaXmxR5/UCACk7Acvtl2EfmO3bTrxiJlXjwXGdT4nnCePxql8/T1cw0C4C+DGS2Fi65I8QTBe4eBy2MgEu/D78Yfo2m2h7c06W3zvykAwVNVjNkCHMZwc97gAMsDUWZ3bChuP8jG9DiduLFNTGdlGgDLwF9Zva8++IJCHNDZ6nxFpFBoxALk1fTkY219PnkgVIP9opIAi2XWYQxWIY2bHlSou1b/1E7h2EaSLWHN028uzg3tT8z40kYk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 03, 2024 at 12:51:49AM +0000, Wei Yang wrote: > Instead of using raw memblock api, we wrap a new helper for user. The changelog should be more elaborate and explain why this function is needed. > Signed-off-by: Wei Yang > --- > include/linux/memblock.h | 1 + > mm/memblock.c | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index 40c62aca36ec..7d1c32b3dc12 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -486,6 +486,7 @@ static inline __init_memblock bool memblock_bottom_up(void) > > phys_addr_t memblock_phys_mem_size(void); > phys_addr_t memblock_reserved_size(void); > +unsigned long memblock_estimated_nr_pages(void); > phys_addr_t memblock_start_of_DRAM(void); > phys_addr_t memblock_end_of_DRAM(void); > void memblock_enforce_memory_limit(phys_addr_t memory_limit); > diff --git a/mm/memblock.c b/mm/memblock.c > index e81fb68f7f88..c1f1aac0459f 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1729,6 +1729,25 @@ phys_addr_t __init_memblock memblock_reserved_size(void) > return memblock.reserved.total_size; > } > > +/** > + * memblock_estimated_nr_pages - return number of pages from memblock point of > + * view This function returns the estimate for free pages, not the number of pages in RAM. How about memblock_estimated_nr_free_pages()? > + * some calculation before all pages are freed to buddy system, especially > + * when CONFIG_DEFERRED_STRUCT_PAGE_INIT is enabled. I'm failing to parse this sentence. The return value here won't depend on CONFIG_DEFERRED_STRUCT_PAGE_INIT. > + * > + * At this point, we can get this information from memblock. Since the system > + * state is not settle down and address alignment, the value is an estimation. > + * > + * Return: > + * An estimated number of pages from memblock point of view. ^ free > + */ > +unsigned long __init memblock_estimated_nr_pages(void) > +{ > + return PHYS_PFN(memblock_phys_mem_size() - memblock_reserved_size()); > +} > + > /* lowest address */ > phys_addr_t __init_memblock memblock_start_of_DRAM(void) > { > -- > 2.34.1 > -- Sincerely yours, Mike.