From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D87C5C3814E for ; Fri, 5 Jul 2024 09:03:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6554B6B00A1; Fri, 5 Jul 2024 05:03:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 604296B00A2; Fri, 5 Jul 2024 05:03:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47FB96B00A3; Fri, 5 Jul 2024 05:03:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 240166B00A1 for ; Fri, 5 Jul 2024 05:03:13 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C74E341754 for ; Fri, 5 Jul 2024 09:03:12 +0000 (UTC) X-FDA: 82305109824.10.5E88DA1 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id 29A61140015 for ; Fri, 5 Jul 2024 09:03:09 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of catalin.marinas@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=catalin.marinas@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720170164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sSNvdqKDG9szaWitzy1YhCUYpyEyUrU8/tStpBFx0C0=; b=xdzaCWUojpiu5Mty5uDgZeJ9TpCbEHu6BhOhMIboh2TXAM0Di9ZzQKv4RuD0riUG58mlIX tokv82g3uSfSV2Sy3YwqthYPcjxIzHxmcT35b7/KthCMFqNos3Ov2tYkc+ohL6/wxiajCg AtV9qy67q1lB3/gvJD7o02Xt8u+PND8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720170164; a=rsa-sha256; cv=none; b=Kyf96F9890qNoKMugyqQikZGCJw458u7fa1xmPmwHe1N3kxheBuWkX2nSmfhoVwCkch8PX DGZzYWspeI7nmgdJlJov/WqmFnQbEXhqsfWuF9iTlhAmzQVLKpLZ4Op2Xul2v/zTfiXs3a 9gZ1EIoIe/fLQoHXXZAwVYfj0nhMQhk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of catalin.marinas@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=catalin.marinas@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73467367; Fri, 5 Jul 2024 02:03:34 -0700 (PDT) Received: from arm.com (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7C0B63F762; Fri, 5 Jul 2024 02:03:08 -0700 (PDT) Date: Fri, 5 Jul 2024 10:03:06 +0100 From: Catalin Marinas To: Marc Zyngier Cc: kernel test robot , James Morse , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Russell King (Oracle)" , Jonathan Cameron Subject: Re: [linux-next:master 9019/10049] drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used Message-ID: References: <202407021807.cBuWVBVa-lkp@intel.com> <86cynt4jem.wl-maz@kernel.org> <87a5ixp1fu.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a5ixp1fu.wl-maz@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 29A61140015 X-Stat-Signature: tqn6sm9z9qqdz7se4pc7m3xfnrn4r9gi X-HE-Tag: 1720170189-704915 X-HE-Meta: U2FsdGVkX19fWiKVS6tyrwnGWyPYcCgWBrrhEKptsBa02mdHajdyuc3DO5rtvju8V/z/l5zucMj99NTpDt2toBHbe3tNpGkxGR6qnh5MZPVHzeRMHy2DL4JBfnDsdBBrNVUdZCWF64d9r2VV4pVRXJg4EV5CsjhwmUuJ4jk0uQvH/TpDCXRS+oKLV3kBXVNaaKLhLfuGv5u66M7n4EIoFQ+4Z/NfWlyg7Qgun9fglVZJ9X4KAY+4C+SUUF8ED52tjVbuO5jhkxHUvioDwD/5hIxVGU8wTNVKGDX+4YN8eylMzVUk2VuhV4iGCtDYKx+g7hL1uRQrYq9LB6rEVc7LwrOW8hD2QpMd7QMWTTpv7xovbcNojld9UYAVVx095UgQsxevT9zEKWNzd2WJDdOfMBduIf2Oy2EzSejvmrdT+o7/H0XGLYTbALjkX0f+hqycZ0s0ccVBgMrCC5f126kxsvJWJg0dEXuTVSVjPCl30t0suvTAuSSbrJ8B/0CfT5NJr9tpwUr5m/Jk2xea0U2EecDPF6GQueKXuZtPaYaoAQRDeWztjsJPGF1EQbNGAP7g0o71lA5HcWK5/RQsHgAvgc/mm+HEKkaSdVTdCW9CIVCGF+dDQuUr7nEeOB4GAGYl5tg3MNY5tyqAEDb6YHO0fE/UYAI4TvxyoUeLl+Bp3ySc8AaDc1CAGUfJ2jhNWkI4rIQkQwZ991BIL+MEBe7K8+KrppbBVa6q3G4lf7IdPGRwUCVZKZ93eSZcGrQMo3LAN/VC+AFd+gRxDg1z8LkGwBE6xf1zieZSbE0iBVJaD4GYsuREYCse9M9wwCBtzPxPXzH1PMlfEum0P8sWhvPsFaP/kyZDi3TD1a8UAw4lYzIOfEQBbT0qAFrVgLzLD0sg6/kM/tWZEw/SvOj37hfgjyguA0U+JfmtmD9AQSYjcDVBla07tvvxxZnOnkvEa/2fYu/b+9zeHPTpmuUh1HV DgBl3M9H 2XljQDrfCOpDR90DIToq59uN+kVZE4vSAt5SWdDvOHXMuWkOYkLSt+OFA2OsfJTMB08aFaObVEj1Wh3T78we+oXB0CtKH5YMe2bmxTxi57DMTMUvb1KVyU0pBcD89pEyntOGBBYoPUOH6AhxWc6u7/+GckI1qwo8AheXhdRSpEptey9lRSG7ODso3Bp1DLcW7bSiCrbIupeW0Sug98SmCdTWPVjBTT6Db8M/INNY865LNdCVhQi/vm4okHLaCtt3VOhQHUjXveso4Jczk7kFvf2S20+NRPSwx6kSATxLTYZWLyrvD8ugfqYhKVq1ffKQ43tL3on/PTTR5BBAW2gXDcYcY2mhTn9pVfdVwZlEYGuAnx6kCUYjPgcdlyGqru2TuSYRJzSMdo/AaFNunZsYqR/E7zoU1ndugXAWmYdRzc+0PkdAiLJO76Izv90OAnqKsmohDykWQWdOXAqg1/kTiEPZExQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 05:27:33PM +0100, Marc Zyngier wrote: > On Thu, 04 Jul 2024 11:27:28 +0100, > Catalin Marinas wrote: > > > > On Thu, Jul 04, 2024 at 10:05:05AM +0100, Marc Zyngier wrote: > > > On Thu, 04 Jul 2024 09:52:16 +0100, > > > Catalin Marinas wrote: > > > > > > > > On Tue, Jul 02, 2024 at 06:40:12PM +0800, kernel test robot wrote: > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > > > head: 82e4255305c554b0bb18b7ccf2db86041b4c8b6e > > > > > commit: d633da5d3ab1a0eb26a2213d65da1e189e82f8ab [9019/10049] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs > > > > > config: arm-randconfig-r034-20220810 (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/config) > > > > > compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 > > > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/reproduce) > > > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > > > the same patch/commit), kindly add following tags > > > > > | Reported-by: kernel test robot > > > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202407021807.cBuWVBVa-lkp@intel.com/ > > > > > > > > > > All warnings (new ones prefixed by >>): > > > > > > > > > > >> drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used [-Wunused-variable] > > > > > 47 | static struct cpumask broken_rdists __read_mostly; > > > > > | ^~~~~~~~~~~~~ > > > > > > > > > > > > > > > vim +/broken_rdists +47 drivers/irqchip/irq-gic-v3.c > > > > > > > > This can happen when building on arm32 with SMP disabled. So we either > > > > add a __maybe_unused annotation or we move the variable further down in > > > > the CONFIG_SMP block. Marc, what's your preference? > > > > > > > > -----------8<---------------------- > > > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > > > > index c29b424d1d0c..6393f3d780e9 100644 > > > > --- a/drivers/irqchip/irq-gic-v3.c > > > > +++ b/drivers/irqchip/irq-gic-v3.c > > > > @@ -47,7 +47,7 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; > > > > > > > > #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) > > > > > > > > -static struct cpumask broken_rdists __read_mostly; > > > > +static struct cpumask broken_rdists __read_mostly __maybe_unused; > > > > > > > > struct redist_region { > > > > void __iomem *redist_base; > > > > -----------8<---------------------- > > > > > > > > or, > > > > > > > > -----------8<---------------------- > > > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > > > > index c29b424d1d0c..187948f41bb3 100644 > > > > --- a/drivers/irqchip/irq-gic-v3.c > > > > +++ b/drivers/irqchip/irq-gic-v3.c > > > > @@ -47,8 +47,6 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; > > > > > > > > #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) > > > > > > > > -static struct cpumask broken_rdists __read_mostly; > > > > - > > > > struct redist_region { > > > > void __iomem *redist_base; > > > > phys_addr_t phys_base; > > > > @@ -1316,6 +1314,8 @@ static void gic_cpu_init(void) > > > > > > > > #ifdef CONFIG_SMP > > > > > > > > +static struct cpumask broken_rdists __read_mostly; > > > > + > > > > #define MPIDR_TO_SGI_RS(mpidr) (MPIDR_RS(mpidr) << ICC_SGI1R_RS_SHIFT) > > > > #define MPIDR_TO_SGI_CLUSTER_ID(mpidr) ((mpidr) & ~0xFUL) > > > > > > The second version seems to be the most logical one, since we already > > > have this SMP-only block (note to self: constraint GICv3 support to > > > SMP only at the earliest opportunity). > > > > > > Feel free to add my > > > > > > Acked-by: Marc Zyngier > > > > > > if you decide to push a fix on top of this branch. > > > > Ah, it's also used in the CONFIG_ACPI block further down. So > > __maybe_unused may be easier. Or add some #if defined(CONFIG_SMP) || > > defined(CONFIG_ACPI) but it seems too verbose. > > Ah, of course. Go for the __maybe_unused then, it's not a big deal. > > My Ack still stands. Thanks. -- Catalin