From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A10ADC30653 for ; Thu, 4 Jul 2024 23:34:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 305926B00A6; Thu, 4 Jul 2024 19:34:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28D026B00A7; Thu, 4 Jul 2024 19:34:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B9846B00AA; Thu, 4 Jul 2024 19:34:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DC8946B00A6 for ; Thu, 4 Jul 2024 19:34:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5CE0214134C for ; Thu, 4 Jul 2024 23:34:39 +0000 (UTC) X-FDA: 82303677078.04.471BC0F Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf10.hostedemail.com (Postfix) with ESMTP id 6DE75C000E for ; Thu, 4 Jul 2024 23:34:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=aW2PBxU5; spf=pass (imf10.hostedemail.com: domain of david@fromorbit.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720136043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dljpTEIW3bUCTF22+iL12CHvB2MQxQGsJUr215F+SI4=; b=ng4bEerKjOOUnXaYQnEVlnG5xLR42l4JkXwqVgRhSqn4ddUkBsSNzESNm3+PVjjSA6v1D/ OQX8mKB6at4ZRuSNzKJ7ZAChTCqtGbkNpbHHltZm5xSG3jAt/nb5u4SgiUcxqMHz52ulJG eknaarBtjxGwB0t/qMz4R8L8Nw9fhqI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=aW2PBxU5; spf=pass (imf10.hostedemail.com: domain of david@fromorbit.com designates 209.85.167.170 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720136043; a=rsa-sha256; cv=none; b=2IkmAqYjaOfyrAt4UE2w8Pus4y0mLkb1WhnRKxsa4D8nv2ZsfCR9Fz3uomKJwfRE6nifIa emXmpS6QiW4Ds+GjPJHCF9d7wQ60WjPQ52WOs6rEbFABVdGU3ldQCmh2b5gBRwpKOmKfVw wsrkIEW0McYL5eiJ5X29qf/sQUHeDxA= Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3d846aade6cso534844b6e.0 for ; Thu, 04 Jul 2024 16:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1720136076; x=1720740876; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dljpTEIW3bUCTF22+iL12CHvB2MQxQGsJUr215F+SI4=; b=aW2PBxU5QLIB+OA04v84a80sZ75PbTJCzd6Lq8JbqjtBfPxMZgSO+TRJzqTIgDXNyr mM8JUzg/XgJQxtxGdHNYCcqYqgIwmAnTyNwjB7fCaSMxm60G3cMvzcUtzAPGFXvVCwpk ziRFxFk2O48ie/OYmAdNBB4UqgrYMBPVIgTtt8Wk/ThbV5Jp6UEthXXXYxZxZ6sYbVA0 5eDYtyBvwJQbVpdfVTodOG9Elyga9aiguaY/506yIQyfp6x8bSpBuHxzZrwcCHEL3pGM wFSQCohldMNg1d12HXthDp5n+xWmgUtR6HDcxjr4hStIhNx6gdovnuUELlg81pe8RbDc Gphw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720136076; x=1720740876; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dljpTEIW3bUCTF22+iL12CHvB2MQxQGsJUr215F+SI4=; b=KK4UFIQCqHWNZVmNYUidBGiGCjY7VgXvMvckrSSL4XAoVzyMdT5WNX5WTC8XAvaiJK stZmQfjuiEJLW9QyQFL5FsDZuh/C/KRJFnyVc01RYXpO69dxJAPtgOzNZ2lJdzmoYRBP nV1KpY9d7Yb4e3uzfzUvTLAJnNDLTYQ40Dh9R1hs3+Y7J9BHg5lW+6+BOYDIiqfVwj8M jCnrJ92s0vFx9IqmFfLnIaEq2/WFJwJdIGg85RcEWPZ+GV6H4AnD7xtUCkPz8v5sQ7F2 zNBSnUB8azFAW+fkYvloGERGVdoXNfJZpKlDHlqINQ+4eLNMAo5vn9rGfvOMTJjEkxyq O8VQ== X-Forwarded-Encrypted: i=1; AJvYcCVcmamSpDiKAQ2p2ydWEWR+0eWDNgw00TZU79BVtNZrUx7D3wKYR2OzNHajWTD5Fo49IpI7U/xBOIA83AmkbYo2hN8= X-Gm-Message-State: AOJu0Yz3dIsgs38n6BdVug5Tk92BgNDnxQmM5NGQE1vpxabQ5BUFsqcO S5wx+YruTNUWn8umKlWZS131TpiJvKuaGqEgCd5IYLkYwFglwdvjQ4zmP9ne3AQ= X-Google-Smtp-Source: AGHT+IFNIbaahogwbzijyX3zYF3lr3s2hn9+6ybBl0AP8I3qaAHGF+j9b1pdlCKXaFl+LFyp4Jsh7Q== X-Received: by 2002:a05:6808:1a1d:b0:3d5:6599:ae2b with SMTP id 5614622812f47-3d914c45476mr3932615b6e.8.1720136076352; Thu, 04 Jul 2024 16:34:36 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b0c18237bsm356018b3a.12.2024.07.04.16.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jul 2024 16:34:35 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sPVyD-004NR1-1Z; Fri, 05 Jul 2024 09:34:33 +1000 Date: Fri, 5 Jul 2024 09:34:33 +1000 From: Dave Chinner To: Steven Rostedt Cc: Matthew Wilcox , Hongbo Li , muchun.song@linux.dev, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 1/2] hugetlbfs: support tracepoint Message-ID: References: <20240704030704.2289667-1-lihongbo22@huawei.com> <20240704030704.2289667-2-lihongbo22@huawei.com> <20240704101322.2743ec24@rorschach.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240704101322.2743ec24@rorschach.local.home> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6DE75C000E X-Stat-Signature: 7gghaw35um48mkteb1jwx1gpqe3zojgb X-Rspam-User: X-HE-Tag: 1720136077-717602 X-HE-Meta: U2FsdGVkX1+llRxcRL3IxZry2svsRmwjhvdZD+icfVKgyGyG3EavAq8xDWZCz1kwYvyhddlAhQSaHHIKtcbG7eeT1MupotNElmbD584qxxMXRZbXECDhS7cmkPS8lTw9kS0jD0BRltW1vWHkRlH3Zb1u6/7Dcp8knBAAftsbA1c2SM+IDeYnwvNhe3OnuFvfRP4wmX+nZ+oI31WlmMaDkm2GDGodhLPKlI88Nm347Un7LtEGDztYPzH8B+YSLAtHiT7dV65mRYZkISOz8DPfCNQnpG7y4piU5vQaTklLF+k9obdeLyUu2QLIRmNC/+QLqNiQXstQjUTX/Ug708SmezbI54q41hME2MBx2Sn2HiqDS56fTCx8b4LVqTMmysTsMNb3kcDRGJs8kgqaydkIVU6BZNVrnqEw7Ml/i+v33/RnofAUMLAtPJietFJXGjjDgc7qqpxorkvpMRxT2zxXFvwRaWAEDJUAS+vHbtj1LHgqkr90EQWkNEoT1n22cjcHRlkXtw63bV4FNsP4T3rbaxtsCuJfSNWth19TALGAzpx0aWm5GfNFb8ai1eORSCT12f8s4owAAAq0RwyNv0X+mBgCm98pKMYaI4ftQZcM/6fiyQMkwy307xdIytNByq7N3EOzYB14qARL9+G+YaRYkbmUO7rusEtBBebykzDxlvyKQC/bXADtbMsi39td+liusDyEFJuKCxhb2NGDEApYAdYNtwy3HzctDWRe9Jx10HuivH9/b/Bo8M6qt0xkWWI08ZntJJg/XJq4pnJBy+1FCaKZ6vDV7uZEMTgNFgsdxCt1aPU+gG0jL3jNmQW4vmYU8fVKIVLNw+Vnq9zIFYP0aBUpGiaXckc5dTl36xKf0GtttTkdiZ0tcGJ7WzgFtQCmX+3ix/5vEo9WONpwMM1wdrT0kcrRSqPHsDQSIE6u4uDhTXg8ctCeqW/8ZWLpaHay0sbHVtgWpB5l/K2pYSW 51ssLm6i W3V8LwNozcJnbULfXrmDSY/ZS98DoUIzCs0ZNY/cUHdhX010AIIt0ozYn66/VobHvZ0LeuCL5gbgMvWzGHMMaOhZ5DkfYf6bIGS7Dnz9d5RUemrt2BPqm8dluhep7sFxLuEbWGqryt6J96ERldzBBxZs7ylxc6kAkqODy5HYEnDMiej/6aMjQ42vzBKCriK9yBO22Fh4xaNK6qrlZpat7Iw1NWzf1UyVsqwZFqoL6en4jrO11b6YMEirfx6MQVzcQbzea0RWzOsvLBr8UeczjaceRmN3+fY36MHdZhS9ftnvMq3RzgWztQbgkJUawXRJ5eYz2Nm2v5RzGWKo5DOxWGILifz8ALeMFu8pmru7peS2Wgi0zqCDFzK3X3IMQg8rsZfpe4sqpr9dmq04= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 10:13:22AM -0400, Steven Rostedt wrote: > On Thu, 4 Jul 2024 22:56:29 +1000 > Dave Chinner wrote: > > > Having to do this is additional work when writing use-once scripts > > that get thrown away when the tracepoint output analysis is done > > is painful, and it's completely unnecessary if the tracepoint output > > is completely space separated from the start. > > If you are using scripts to parse the output, then you could just > enable the "fields" options, which will just ignore the TP_printk() and > print the fields in both their hex and decimal values: > > # trace-cmd start -e filemap -O fields > > // the above fields change can also be done with: > // echo 1 > /sys/kernel/tracing/options/fields > > # trace-cmd show > # tracer: nop > # > # entries-in-buffer/entries-written: 8/8 #P:8 > # > # _-----=> irqs-off/BH-disabled > # / _----=> need-resched > # | / _---=> hardirq/softirq > # || / _--=> preempt-depth > # ||| / _-=> migrate-disable > # |||| / delay > # TASK-PID CPU# ||||| TIMESTAMP FUNCTION > # | | | ||||| | | > less-2527 [004] ..... 61949.896458: mm_filemap_add_to_page_cache: pfn=0x144625 (1328677) i_ino=0x335c6 (210374) index=0x0 (0) s_dev=0xfe00003 (266338307) order=(0) > less-2527 [004] d..2. 61949.896926: mm_filemap_delete_from_page_cache: pfn=0x152b07 (1387271) i_ino=0x2d73a (186170) index=0x0 (0) s_dev=0xfe00003 (266338307) order=(0) > jbd2/vda3-8-268 [005] ..... 61954.461964: mm_filemap_add_to_page_cache: pfn=0x152b70 (1387376) i_ino=0xfe00003 (266338307) index=0x30bd33 (3194163) s_dev=0x3 (3) order=(0) > jbd2/vda3-8-268 [005] ..... 61954.462669: mm_filemap_add_to_page_cache: pfn=0x15335b (1389403) i_ino=0xfe00003 (266338307) index=0x30bd40 (3194176) s_dev=0x3 (3) order=(0) > jbd2/vda3-8-268 [005] ..... 62001.565391: mm_filemap_add_to_page_cache: pfn=0x13a996 (1288598) i_ino=0xfe00003 (266338307) index=0x30bd41 (3194177) s_dev=0x3 (3) order=(0) > jbd2/vda3-8-268 [005] ..... 62001.566081: mm_filemap_add_to_page_cache: pfn=0x1446b5 (1328821) i_ino=0xfe00003 (266338307) index=0x30bd43 (3194179) s_dev=0x3 (3) order=(0) > less-2530 [004] ..... 62033.182309: mm_filemap_add_to_page_cache: pfn=0x13d755 (1300309) i_ino=0x2d73a (186170) index=0x0 (0) s_dev=0xfe00003 (266338307) order=(0) > less-2530 [004] d..2. 62033.182801: mm_filemap_delete_from_page_cache: pfn=0x144625 (1328677) i_ino=0x335c6 (210374) index=0x0 (0) s_dev=0xfe00003 (266338307) order=(0) Yes, I know about that. But this just makes things harder, because now there are *3* different formats that have to be handled (i.e. now we also have to strip "()" around numbers). -Dave. -- Dave Chinner david@fromorbit.com