From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D447C30653 for ; Thu, 4 Jul 2024 17:02:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E3FD6B0099; Thu, 4 Jul 2024 13:02:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 893C66B009A; Thu, 4 Jul 2024 13:02:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7357C6B009B; Thu, 4 Jul 2024 13:02:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 545E06B0099 for ; Thu, 4 Jul 2024 13:02:46 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F049FC127F for ; Thu, 4 Jul 2024 17:02:45 +0000 (UTC) X-FDA: 82302689490.17.1393213 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id 70F4A140011 for ; Thu, 4 Jul 2024 17:02:42 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cYDhpaEp; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720112544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GY7/X0M+gI9Jpp0bI//NE3lhiuxlSU8pX2nOGe9YRDw=; b=gkA9sxyqfT8s44nmpEpryv/P7MTONf0x5RQLgXM57hFYdAuCvEOhnBselYl89wIJDZ3nm+ 5XY+D+eytMNgFRpm4Vza89EL2OQzI5S/wjhq5K8Pbovb6BhgimXTi3UN+MlPQ0Ox1Jztik 623gKyArN3Ct85asHnKrjKxEw6bmDDg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cYDhpaEp; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720112544; a=rsa-sha256; cv=none; b=j1RCjWpJ+Fck6JagMyaskZFz+KbPQaVuPQAQgmKxN5SxaBNPRpiF+o9vIyUb/pRHDeMSAa xwxx/wRr6mfIblkiJJeIE0ZnoVKcZ9yLtvfagVqtGVqormAXHcJMnVkLCdYSwVncnGVYfO xgffhEYiRNRHgmukoNhZctQ7Ix8OrJQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GY7/X0M+gI9Jpp0bI//NE3lhiuxlSU8pX2nOGe9YRDw=; b=cYDhpaEpztN5af7E8bRP9PpO7G 4OAsGGjv+rfnfSemDBe6UVLQzgP55uV1g8yICN1AjG6ampErvcJctrgTK+Je5AxYk7Jk60pSkytEY 8YvfsAtotDFCTYpFy4tfzpvoPWnf/8ZCtW2RRG8cK5oAt8GvSUDfp2HJlVDg8cI1NjCw1UAibXipJ VQk0dDZaG974XJw1MWnZ9htTsrO2uQh2d4e3jsTexzxRlZXrlL7vlM4VByzgPQmky/HSe4k9eJXjF 95lnPkVRjwC6V8rtNzMtNxYzhiEZdDcwPqRTEKNrQryELD/9BdYjK5oWPJOBHwqASbpiWmiuL1Do/ VjPke0jQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPPql-000000033Fn-03Ps; Thu, 04 Jul 2024 17:02:27 +0000 Date: Thu, 4 Jul 2024 18:02:26 +0100 From: Matthew Wilcox To: Martin Oliveira Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rdma@vger.kernel.org, Andrew Morton , Artemy Kovalyov , Greg Kroah-Hartman , Jason Gunthorpe , Leon Romanovsky , Logan Gunthorpe , Michael Guralnik , Mike Marciniszyn , Shiraz Saleem , Tejun Heo , John Hubbard , Dan Williams , David Sloan Subject: Re: [PATCH v3 1/3] kernfs: remove page_mkwrite() from vm_operations_struct Message-ID: References: <20240704163724.2462161-1-martin.oliveira@eideticom.com> <20240704163724.2462161-2-martin.oliveira@eideticom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240704163724.2462161-2-martin.oliveira@eideticom.com> X-Stat-Signature: tmcdbins4jk8d8ofwxosy1ugm9at7jmu X-Rspam-User: X-Rspamd-Queue-Id: 70F4A140011 X-Rspamd-Server: rspam02 X-HE-Tag: 1720112562-47395 X-HE-Meta: U2FsdGVkX19S+H4wdCjzV7LABIeSiTqFJJUhMtwRZ0PHs66MF80ysetqka/5IVeidHJ0zB02t62YlvLhXr0GX99hGag9Vp8c86vff6rnYFXosF4EUcnrhscG5TRttVy18ZQZelOn9+9L/1INkEZVQM/84tnWAy4s4Mz9Ezysp8FLYjlQiasUwTXjbpeSv0W/YYYq8QsNhvtiICmpWKn3VRoOfuyibrvTPgy1TILE+6rji0I9dLb4hb3b++gH21NCeYbYhGLSnVXUdyknPz+mNRxZ8vT1JsZK5841Qwm8kKe6K1KadDW4gyCQ4kyw3p1GkYuaV0inG+Ppay6y7ANoIT7HA8LQmGxzzNhTAP7w51H962aSi4JvTs49l24IAPBGmK3yaD16CskAzEPQbXfxIp3DIqvvcBetCd+2YumkcjUrgMQLWSP+lex7lu0x2+w2EzvhmBuvdNda2ooIGN1nM6TCPF+74fkRctVQgVYJaajJP2VlQAfttXQAVk7QTaBSXpuEMkWAgRWO21fKWn0Ba+iU7KT2/a/TU5cCz+GeYc5IBya3RPfpnzRUOfXXkgOPr7LjMgJTI+MvDpXT3WuHQFxFJUS+IkT8pdq4fir4zdqb5Xj++I9Y/sWh2T+f3stIsR5y/hF4Ha78S4XL29u21IyS5/SlrWBhiiZVEvlvuYL+xQm6vin6Ept8oC6GrjuG2vAwBPS9mkzGHPNpyXMR2yFmGJYqtaHkb9ssqQi1AFwLbvBxckP1irpxdFniaIwi23WfSOT6B8cwPumH1Bdb6FPKzMUDl7danRpfu5j2pxdZV2lp5+PTqRGfCP1ZMxrChJQensavddFZYBYUqxU+afkPYXblQfg856wUU0HlPPbdMespUV+Tp6T/p+vnG7XfNX7fPPXjVGqTEdJk/pl3MzGBAucoMA2vbOs0mh0qBxLAqmjt6+fWdXR0ESZP3QDwTtICCq0n+OS9gWlwYSV x7t7RC4i BfB9OuSoXkLM45mNNq9d4URoRuyg9D0ra8TCngPAHFLjLuzxT20A8LiTB+HbQkNr+fMAjNcWjo+wKt60CdvbQiCnF2WqysvFi3LgGZz3VNcqDFpjOUKiu4yZIpv9ROF/3lottp/lPDEZCkhXAy7pLchtSJ5Yq72TY8DIw5hVlmsiuPI55drUSYE9seYjfQ3dLhTbz8FqjbYCDe9z5ItmXpMqlVuOIAfA0LpBOtqq6kQ9nHYTnuP9JEUPhBXnYZxaYDpES X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 10:37:22AM -0600, Martin Oliveira wrote: > @@ -482,6 +459,8 @@ static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma) > if (vma->vm_ops && vma->vm_ops->close) > goto out_put; > > + WARN_ON(vma->vm_ops && vma->vm_ops->page_mkwrite); > + > rc = 0; > if (!of->mmapped) { > of->mmapped = true; Seems to me we should actually _handle_ that, not do something wrong. eg: if (vma->vm_ops) { if (vma->vm_ops->close) goto out_put; if (WARN_ON(vma->vm_ops->page_mkwrite)) goto out_put; } or maybe this doesn't need to be a WARN at all? After all, there isn't one for having a ->close method, so why is page_mkwrite special?