From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAB48C30653 for ; Thu, 4 Jul 2024 12:56:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 086D16B0095; Thu, 4 Jul 2024 08:56:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 036876B0096; Thu, 4 Jul 2024 08:56:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E40B56B0098; Thu, 4 Jul 2024 08:56:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C5AED6B0095 for ; Thu, 4 Jul 2024 08:56:35 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3FFDA1411FB for ; Thu, 4 Jul 2024 12:56:35 +0000 (UTC) X-FDA: 82302069150.17.3DFAC09 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by imf10.hostedemail.com (Postfix) with ESMTP id 52B1FC000E for ; Thu, 4 Jul 2024 12:56:33 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=KYsgpYSK; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf10.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.50 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720097765; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cjid4GTFzfR09h4v9US7cG+cmJ1miiJzUsalhJBWqP4=; b=RdkOe1eoIuRbLAyLbcjJ0AW7IDlXmOdMcHJAmVyYT+jbL+a7QhVdV38WAGu1zD11MC1Oy2 tOfbZBjDbrqMqZB0HIy74VOG2EnB4TV2eWigCtjZ5HHO7Bz0AwpkPwXemQmp7nlmLQ1Ns1 0JnAZzPCTLVWrcCUwxO3xGjofWujP+Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720097765; a=rsa-sha256; cv=none; b=NiH6/I9Bk2YdNU3vaOA8XFYnnK6R0E1cDjjEg3NO1T/Q9uHAurMb+BK10H/O99geTnC/xd cBvyw8foYMlWlEppXv62+DJ7RlHDcFYfr/FY0irhSenSpXqlwxYslJM0A5yU66pu1h46pG eAVIsBu/mU8bunMZTcl1IY+e1VTuL1k= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=KYsgpYSK; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf10.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.50 as permitted sender) smtp.mailfrom=david@fromorbit.com Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-701f397e8ffso351064a34.0 for ; Thu, 04 Jul 2024 05:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1720097792; x=1720702592; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cjid4GTFzfR09h4v9US7cG+cmJ1miiJzUsalhJBWqP4=; b=KYsgpYSKB//GiIEQSfhjnfE51w6fGcAhDpUE9dLoE9QeS9JjoI2NmFy/JLBpOiCXka 8H208wLtzt91N8hxR1Lgu/qUoufwJcfu+Oy6xyTMSFZt33ceVAvI6xgP+bLPVWVOk6XZ Ea2G2D/NDf0Vdb3vQI4Asiz0C0HSxQkRk/kPmoAwC7CkumO45VeB2nS9sThvD0FupjWx J9UFrxcsHtltCLCSvQ+e3uC2tUq9x2Q/T9mL/kqMv2AbTc33f7boVtegXCp8VePiHq+s HG4fGOU/D6AOb8Gt9PbqClMNTkw7igc7QRJ4yS+2hl5AiH8dyQ48dp8IXVIumo/fnOCT u/rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720097792; x=1720702592; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cjid4GTFzfR09h4v9US7cG+cmJ1miiJzUsalhJBWqP4=; b=hvsDd6OqNZ6udnOeOWyOCqiZ733D+z6swgc8UCF0mOwddf4V/cdopzbB7/oRNmwWKc 7/0PPWCxjztd1PxFV4+wCgpJ8xqEV0ij1qcC+8HdJ+wbVSa/l+iq3vA6AdaTzVT8JFrm pur288zE/EKXHrEhVTpTBlSAJkxtSo0VpSRivRt2mjosyFSZyH2SyDt33V5NNWidnnQ7 o2XOlcEpVYtm3JPlusMriPxmKXQh66hk74Ywumui8NjrVI2m8bXsTuS3nfgltRGMuiEX d/OvAR2ro+jiNt72OPCEgyoZnsUuJTkgB1RRPa9KjeVWVClp6Sznoj0GDcm4Hrg/f4Jj L5hA== X-Forwarded-Encrypted: i=1; AJvYcCU/QCbkpq8gGwWNdM5AqZ14dYJ2H8sfNcCQN4jfWHBX5iQjtSGZg0cJKF6GBwhfRAy9ynaWOlpQWOpJBISOpNUC4vA= X-Gm-Message-State: AOJu0YzPr+PUT+T8F0V41+olKNwQNQzN8c72abJMNyE/UuymxCrgboLj fVkjYQDu6Jf7MssReldNZDmJhTnrIs7SHBRhTe5VpirTihOttVeB9ZCkMyW2mMU= X-Google-Smtp-Source: AGHT+IHHEKbhN34mmx22VmG12egb05zVh7bP1Nwrq7g2TDcyoxukSUTmEnpHf209XtQt5Suwgnd4Tg== X-Received: by 2002:a05:6358:714:b0:1a1:f9fa:bb7a with SMTP id e5c5f4694b2df-1aa98c51e16mr116888355d.16.1720097792230; Thu, 04 Jul 2024 05:56:32 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-76148ca3d12sm806521a12.33.2024.07.04.05.56.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jul 2024 05:56:31 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sPM0j-003rAh-2f; Thu, 04 Jul 2024 22:56:29 +1000 Date: Thu, 4 Jul 2024 22:56:29 +1000 From: Dave Chinner To: Matthew Wilcox Cc: Hongbo Li , muchun.song@linux.dev, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 1/2] hugetlbfs: support tracepoint Message-ID: References: <20240704030704.2289667-1-lihongbo22@huawei.com> <20240704030704.2289667-2-lihongbo22@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 52B1FC000E X-Stat-Signature: mdtknn5xtuux4de3j4xy5fqnzro43nxk X-Rspam-User: X-HE-Tag: 1720097793-529301 X-HE-Meta: U2FsdGVkX1/owbxrMdU6EDLyRjWpifxNjYSuoN/jto+oHAH0EW5cYjFQPov+QKsBT5AbJi614s7b3AJUtIpoRYyetAzBBGMIIv3TlIDFJzjDA3z7JNCa0p5s/RTBOSI6Q8VlSgb63KzNWUJGmf5E+L54aDAsjVmTmrATtFD8YrbHnhSuD3DpF6ItkldaeVGf6IBLlFtCzz+OzFT5kJHUSm4vxWpg015XFtjJet5k1eVHqV/9VGwXTmBnnQmF8eD1H09FYA0lkeH2Rqv//LNwQc3wVXS167yEoIOkMwGLF5JSp1OwJ+FgAh7Cer3aueMTFmQ+SoTidxwDzp25W+Ty5xmAr3k5v9UCR84ayJoAIEoCN0GFeiURDmYFs8aJGQlcg9L5XGRRwt9Gy/5pmSL4T4UwGxVi32A1v1eZ3EYcXBzXBMWHa5Q51aifHeg0XMqsH5j3PK/8jiuROWfKSGFfRGCO9KDbiaqKigQpFFUcAORc7o8kxNzCC8bjrfcLeaNuK5wCixayNzwwR6zYLUI/mb6MAtPUbvgfSkzsn9rbYQZJZKI7dHPhLh168vf7vRJ/iLgy/sCs0VUKXdBipcaia6kYLesWAa3LbAbDkoITHBHGK2jXtY0NeEgGyhaUwQMOvO+DWNZ5gVC92UHusTD2SGatzHn2O9A6QDJF2w4eXVwMXrZC6iCIEb5YXlab9Wfvhiq6CX/8bPvTY9qpVEWXfDuFZ1eTtG3VUe8cJYvzNPZep3I6iigTi2lrENTIkZrinVsBvD2RbNw+JWqYY/8oiup9yF7Z67r6A81mJbEAG8Oete1Oo7xbV4UnUgPst6g38yOOluSU66dMD/jP3vCCzUZOuQNfwKk1QKeoSrr1ku1kbeo2gT37cQu05nl/ys2hpstZpqJKQowLtttWTlz0mETC/fEkl4t7bHNXCWnfVMVtkum9hmgLO9lv0qozbqb6K8X7+1hGCyrxB5yID67 z5arZdE6 cV+q3Daib53zEXZ9B2u4iHJYJeU4klyeyS97gb0OFpO8SQq3EXYpfSGep8INkXa7Tm70szcu0Dox0YkRbfqKKoQ0hy+LkJ2+gfTSCf8gWtJzkfIIyBYIOP/EySavNKkJ3LfIo66wqsR/+qtF8u+g39v3vBVgm1EOiXSdUx3eCL5isgyD/p1XRmQUVL7wAXs6z99SLFTe9/v8HJYthws9cH4WZOBxjPCtmzE50tyG8umqm+QbWr5ysF0AGa095ZTOgHECnLB2WZyJ0FHi0Y3H+vZReqVoZYa3YhgLEuelXXpBZXZS1Qd+Po17endcZDlYL+3NZiWJIt3MzAUOhpeSBumpjmsEWB3e6rB9KPm84+ne2Yf0xDiHK9iE8/nGBDROSZDyGiA+1lVIw8/g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.013868, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 04:37:30AM +0100, Matthew Wilcox wrote: > On Thu, Jul 04, 2024 at 11:07:03AM +0800, Hongbo Li wrote: > > + TP_printk("dev = (%d,%d), ino = %lu, dir = %lu, mode = 0%o", > > + MAJOR(__entry->dev), MINOR(__entry->dev), > > + (unsigned long) __entry->ino, > > + (unsigned long) __entry->dir, __entry->mode) > > erofs and f2fs are the only two places that print devices like this. > > "dev=%d:%d inode=%lx" "dev %d:%d inode %lx" i.e. every token in the output should be space separated, and no commas between values. Any other format makes it difficult for post processing tracepoint output with sed, grep, awk, python, etc. Every token then has to be split into name and value parts, and then the value has to have the comma stripped from it. Having to do this is additional work when writing use-once scripts that get thrown away when the tracepoint output analysis is done is painful, and it's completely unnecessary if the tracepoint output is completely space separated from the start. -Dave. -- Dave Chinner david@fromorbit.com