From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDF79C38150 for ; Thu, 4 Jul 2024 15:03:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A4FD6B008A; Thu, 4 Jul 2024 11:03:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 554DE6B0092; Thu, 4 Jul 2024 11:03:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F5D06B0095; Thu, 4 Jul 2024 11:03:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 200896B008A for ; Thu, 4 Jul 2024 11:03:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B1D31141352 for ; Thu, 4 Jul 2024 15:03:01 +0000 (UTC) X-FDA: 82302387762.01.1A459AB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id A705F140023 for ; Thu, 4 Jul 2024 15:02:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AcQEtNIO; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720105353; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mwlF2nZy/FOptazxuSTgaLV2WhMmNg44kTgmw/1H9t4=; b=CeLeD9J6zv9pmcT1V/bwMJGa6OWS0hf/pHhvcWqMDSnoVlLHuSMWnu6TSS3IJKjjgI/gpK B92PIczikLlk1lETR1yT2H4PCpYusN6tOimLA8fhQdAyNop/AHqHVJcdEUdV9kFh/fiutW mYyYdbCPu3HrLX7QUCweoeY4ubboBpc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720105353; a=rsa-sha256; cv=none; b=3khsDOG4sXJdn/3qouibQFPJtaCqJz8uzOZG1Q3SrLIsi7QOG3gH/aOTrUfiTyYPI4KWaM HghCKfQN6hwRavv9rgAtKcLkXOKi+K07whWpVNLzF6V7ao2OoKHtfFcR/JC3FV2Tjrheul 5SUvnibb58an5mcgX2RQp7woZd4LkBw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AcQEtNIO; spf=pass (imf23.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720105377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mwlF2nZy/FOptazxuSTgaLV2WhMmNg44kTgmw/1H9t4=; b=AcQEtNIOjc4Z5hEMOmFK+GtrV6U/koAApsPGwmn/w4A8I/1SvaylTvvd2z52PMbbTjI3P8 k7dkvGYDMjRllKukvcQZDwYo09LAUeWqDgXRN5q2anjaUqeO2YWoxMyxNNilquWTfdUWIG pSiLTXpWoosM9togLJldu2Mdtfw3Lx0= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-8KgeUooIOnymcbqwrJTrwA-1; Thu, 04 Jul 2024 11:02:56 -0400 X-MC-Unique: 8KgeUooIOnymcbqwrJTrwA-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6b5e41e09b6so1946946d6.1 for ; Thu, 04 Jul 2024 08:02:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720105376; x=1720710176; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mwlF2nZy/FOptazxuSTgaLV2WhMmNg44kTgmw/1H9t4=; b=mm59cAs06vShGSNaDZ4CtIJQ6tse6lV8eDLbbNYAOgY3bLzOWfrB7dWFiJFPIcQGe2 SYROnxVbML0Ij2PUzXmenSeLbp1aMCFbcw8rYurALZO8riogvcr4kkjd7aIUJv9puPvf Lrjj2gdnfOI7tN2dbLpC4fPUZM6s5MFK2PjRJk6Dn5NIJdrVldu2cHApRJsdIerrbo92 l+3XtiQwKLTfgF0RGilIIrkvJspOIpBe3qAZtjSHFbyZGtUK6c4R2xZeAQ6lPLr8D2W+ 5FqtumbdF7or1f/7jW9czU5rg4TMHeQUaOrorkSSe4vcpDbjd1PeBP/w6ADLGV6mxJJE F6Jg== X-Forwarded-Encrypted: i=1; AJvYcCV84joEFRS+10t85rnz53dXCqL8eQDw+VaNc50Dlk7BX5DwFb2PwLteWUyOXKjw783fB+pKE31GWqEsRGSCwFge/04= X-Gm-Message-State: AOJu0YyQFl77QHgyX9DfrVyVv3ZkzoGY1x8/pM9XihM0ZMq5REaVUbdQ rVxv6Mhadxp9xIExqn1zT+3dZ5NaURLpwWIwG6bP1v6SSYhdMOCXH72QkTmyncdyts6AJvK2Zmx N6BK1/+KqMNoSp/oPesnUjrlDIH0sZTSQhQ31NIReV6Ef93jk X-Received: by 2002:a05:620a:990:b0:79d:6685:4e6e with SMTP id af79cd13be357-79eee1aadbdmr171276685a.2.1720105376024; Thu, 04 Jul 2024 08:02:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjTnriP6wmPjUsy0qF0I/XGttLsiy7TWZGX+/WY5WX+mLiNQ7rJeIhIk3guLOr/46pXiAiLQ== X-Received: by 2002:a05:620a:990:b0:79d:6685:4e6e with SMTP id af79cd13be357-79eee1aadbdmr171272585a.2.1720105375435; Thu, 04 Jul 2024 08:02:55 -0700 (PDT) Received: from x1n (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79d69328d75sm679815785a.127.2024.07.04.08.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jul 2024 08:02:54 -0700 (PDT) Date: Thu, 4 Jul 2024 11:02:52 -0400 From: Peter Xu To: Oscar Salvador Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Muchun Song , David Hildenbrand , SeongJae Park , Miaohe Lin , Michal Hocko , Matthew Wilcox , Christophe Leroy Subject: Re: [PATCH 02/45] mm: Add {pmd,pud}_huge_lock helper Message-ID: References: <20240704043132.28501-1-osalvador@suse.de> <20240704043132.28501-3-osalvador@suse.de> MIME-Version: 1.0 In-Reply-To: <20240704043132.28501-3-osalvador@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: qb8s9ixdtxbux3fbdtgc3dwsaaixu7uf X-Rspamd-Queue-Id: A705F140023 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1720105378-665895 X-HE-Meta: U2FsdGVkX1/SdeDWAqmni1dZw6b1y0tJZrsYm8Ph7x7iZbBo4VxfmycxsQUC0iQ3jJN4JtAUi67XWjYo3gZyuJ2AGBLE3occI57JAmYvIaPPQDnzgw6RbSTgRZvNudZIE6CqQufESPsHfXUED6LJLD6vX/C0RJGWPHnm5cY9RTiwWhU7e/bv9+xyTILgWdYeurdjPLGV45+ddCre7HVy76etqj831JtxaTGkpT4igeK9lro9F6+UBZnw9Xangh3hSbEdT3WkopBjtaFV+6qAI3ARq4TzNSIwc3XzQeqfidyp6ldZ3X9h1YC66qEg9DDM3neG4WWuUhLfBFv922GSVEdspmVslxhuQ0Dakjt5YF6Mbz9qd1zrewXlZyNNtOXWIOz9+jruo9EhZLMGr+DRfk+V8BzE0kbT63uhBQDzhuSBQ3Svb5Mcmxl7ay/hjktJbxEZVSu8ToTzv25Z5hw0q0J93Nq5kc61PYBt1dtrn8oF03iXvikGTIcoYNT3HsvPq3M4iKx36jfunn33CqFmKWXKkNoE+5Av9bOY+WQlwBNhI6ubRChqZbvNvxEITAiKxV2g0bZK3Waol3PuKT4FKrcmq91er/ujOnmL9fEFjkG1QzYSsKHfphjTBJoqU9fFZoiXxiUKYdgq+AGpjNbJWQRREc+C3VQ2pLPk7zwY665uddFLI+vw4w6nRvQT1QJDfZreUaFxSiyr2aCJ6knFo18yL1RPuvrc3CgGuGtFEsvwG2d4Asquv57qVIQomDTtPfKhL+M6MngO5YczLyQirXdVKNTPStVF6zFcyvhb8itxoi3FcTCsmKEOpwqkXsA/SbUUvVmDbsRC9nPf0VMUspOevEHnp+HDUh5/8zhSwvzDJ8m2u1lgfVfZmIrc9fSYD7FmHGACabFfAOmBPcv2aC7kydtRWikDEDbk8MYmvcJvUSvHsSZm1rFfTA1+Pg/2tiAByCc/y8l6oQ9gy4B dldl6mGI xg7Bk0SPvjanUStO1IvlxNWLqtvsyMKJXrUc669pjbgwTKXTk/X9zex4m4wDYzpRbtiehStnpvJ2v+CwHoRKmdLNH50pM3nEjqXm4iGIsxITbJ3q7gYj/ShnrwS0c7hk740aCpmnl8fu6veDs+I1eng9mGIjm+i9R8iITptHyPkyB1RLjtQSprXe5PsLTGLq3BvMauCzGXPNNZtMp5bDFJt8XOw+4F8JBzBP87tUEwj2JO55PTIGRIvYpuZiGnL9hBChHNGjE+bOyfTmVmnlng8mYerc4gJ+WozcoiQjA/PQoZkV8rTTZHfgtUh3Ykpz4AIT/WzlVOsfCj5Jzfb4EGA5+Z7ihwzAgjJgUWzYhs4dtYvoVsriRGFW2cl8EwTuWhg3vo5zUpDwncx8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 06:30:49AM +0200, Oscar Salvador wrote: > Deep down hugetlb and thp use the same lock for pud and pmd. > Create two helpers that can be directly used by both of them, > as they will be used in the generic pagewalkers. > > Signed-off-by: Oscar Salvador > --- > include/linux/mm_inline.h | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h > index f4fe593c1400..93e3eb86ef4e 100644 > --- a/include/linux/mm_inline.h > +++ b/include/linux/mm_inline.h > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > > /** > * folio_is_file_lru - Should the folio be on a file LRU or anon LRU? > @@ -590,4 +591,30 @@ static inline bool vma_has_recency(struct vm_area_struct *vma) > return true; > } > > +static inline spinlock_t *pmd_huge_lock(pmd_t *pmd, struct vm_area_struct *vma) > +{ > + spinlock_t *ptl; > + > + if (pmd_leaf(*pmd)) { > + ptl = pmd_lock(vma->vm_mm, pmd); > + if (pmd_leaf(*pmd)) > + return ptl; > + spin_unlock(ptl); > + } > + return NULL; > +} > + > +static inline spinlock_t *pud_huge_lock(pud_t *pud, struct vm_area_struct *vma) > +{ > + spinlock_t *ptl = pud_lock(vma->vm_mm, pud); > + > + if (pud_leaf(*pud)) { > + ptl = pud_lock(vma->vm_mm, pud); > + if (pud_leaf(*pud)) > + return ptl; > + spin_unlock(ptl); > + } > + return NULL; > +} IIRC I left similar comment before somewhere when we're discussing.. but we may need to consider swap entries too. I think it might be easier we stick with pxd_trans_huge_lock(), but some slight modification on top: (1) rename them, perhaps s/trans_//g? (2) need to also handle swap entry for puds (hugetlb migration entries, right now pud_trans_huge_lock() didn't consider that). Thanks, -- Peter Xu