From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3DFC3DA49 for ; Thu, 11 Jul 2024 13:08:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7334D6B0093; Thu, 11 Jul 2024 09:08:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E3AB6B0095; Thu, 11 Jul 2024 09:08:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D14F6B0096; Thu, 11 Jul 2024 09:08:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3BAC76B0093 for ; Thu, 11 Jul 2024 09:08:39 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D3DDEC05BB for ; Thu, 11 Jul 2024 13:08:38 +0000 (UTC) X-FDA: 82327501116.15.C432F29 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 67CCC40029 for ; Thu, 11 Jul 2024 13:08:36 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="E2bNu1X/"; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720703300; a=rsa-sha256; cv=none; b=2AlZTrE7fXb4u6gbgLaEUacKYFJicvwhX7P83OzOC/K/N5CnQQsRnzxDCljTk8mxwmNRaD IahGJQqi2lj7UqLkdb+jnPobUVwIWRDgsK5EsG1o1POKoNX/lpPmpCKtB5rheA3osh67Wg cZKTFWYbzjJGwvLZs35dgyyHWNEGJFY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="E2bNu1X/"; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720703300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NFf3uHXmFSDdJu+av0ve7/UXaiDn+6SGLQPlv++sSyU=; b=jkaQA1OJ/3+SSwjAsMR8ezYOs1vTPHK4lzQkFipqDAN3sYEqwmiC970ucsXt6Uz6x/6ovi 0BoHYKGs42gloJq166jJQl0xUTNx7cYwow32B3i1znK1nKZTfHUQ9rBKC5CNBc6JDI74OR TK2SyNJ/tQ4GAdK7KqlLu4QUaylK81w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NFf3uHXmFSDdJu+av0ve7/UXaiDn+6SGLQPlv++sSyU=; b=E2bNu1X/yDxVrx/nEoo7IDC3NL 0uwB9UaGXE20+DTNR5HghBzsZJJF0KPm1ryc3odKJKaxEHw2kLr9QIdfe1xvXXc46Oy9Zk+lccxMX X+X/mY4FpBKnPAUrxHAo6LWMDWRK6UQEqCh8lAffvLwAKwYxygk3yQJNy0VfLfDObrE77cqFM+7D2 cWj97klHOpgfO38s8DDNhDdIJ+U2dGtO/gfMHj3ptUJSlG002YudvJJN2XmWdWE6VR+WIQbLMriKR 62bUKFw/qi43h90jYsbMaHCTMO3ZMzJwp3SknDI5e0RZeE+bMxnUuEAvr/BGrV4WK2wXokx/waC0a U08WAMXQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRtXF-0000000B7ls-0Jvl; Thu, 11 Jul 2024 13:08:33 +0000 Date: Thu, 11 Jul 2024 14:08:32 +0100 From: Matthew Wilcox To: Yajun Deng Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: unified folio_test_anon()/folio_anon_vma() and use them Message-ID: References: <20240711130351.2830-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240711130351.2830-1-yajun.deng@linux.dev> X-Stat-Signature: dqgkemp3815jqpojuncgi69dkb639bwg X-Rspamd-Queue-Id: 67CCC40029 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720703316-608196 X-HE-Meta: U2FsdGVkX1/AGCszFSK5cDJX8cmJ2bbkCSkqn0OVYNLCl9UY7F5Al5lLdNUs444yfTH+lc6rWb+qg4FAIXaIHF2jQlLkRT41ya8yntaQL7j90pBZlEkl+Y3aZVWcF/a2Mfc3dPMh+tRTj2bB1iwS6WzXQwVG6cyqghyyZ2asv+hdWZsg5t6XhGAxqe3uLFBcz8PoCXGLnneymcdcvMmFOVk1OkD6lZ5YWNgiwwkzkrdZihmrg5xtJ90yn6b+M8RzjuVjOgbxjjghQ7EzM7CYXRwOsPGlcHF9bk4gjUByJcm+w0TrfZX/qbLw43NLor/HcdR+ARvskJaP1hwhVnSROxHWfadyPPmj1wC2AvKyGz8ydhak7IuNd/OWQK48+C0+IFDvrZe7c8pjDzrUEfz2s0TTcFvLJvpNi5QRzM5cFT3IXb2ZgnQe/9e4YOc2Z7rvwKZp9nA3I5J9efu/mpu5XrtGOC3oKqDacwRWiGxsPBWTP/fdZC9FX0t3F3S/7ObJOKKo9qtQ4faBynQDAQcXWwV/4wNSjEjoctyVSYVKgs5vHw+kcWgNVQcpgYllGll+lVK9QgptM6jIO3zOlQRe9QGq5pUbVr2uJ+PZjHij4YBma6CgAtToSoOIVY+ONdqOFDFX0mdbGr90SNmuS/HBmCZwVAaASY28XXmRIywHUo83m6CAw2JIlTMjglnsLoo51wQQq2wbCVGN1W3Zqr0T56YvfOtf9vd8Qgisurvq8vzuwkuVBBgw1GZwYPQAZ5j7VQ+0MmN99xX47ffx/uCRx/YwGfl5TIvTQI+62M4tPxTtVXD0LSwG7eTq1AUnLTD0xf2HXy/b3wEvbYqZzVwi24Ga1vLn1/I5K8TLmCGHMEX4EORLLnhxISYps+aN64r1hJEnsXUAEr48movPpAie11mJD0PUpYww9rpGbOV4jFFxhDLgO3VRAyGLCljYB983f0G1SwYFqNdCJZW+PZE QBhltvEh nMOZ5oDTIHPNF8TJEw0dnAuUYc/fTHHETGiBuxYCO4B+nIEjfDCjgj5fnTZ2TWX84uNROcNYtVS+8TNmIl+BBU1ZsQ0OcLtrCOK6TzzmlCuGHukkmFmP0uLfDZqeP7oNfGlzaCczmae4QCcA+29LJy+eEB0ydHzY2VadcMtVg/uagi0mYEt8Ps94wf8IJsmk4fHuvE4Y253PuuOF1bwjo3VLCv2O+txYXH8/DHZHPupn8A1vwJvLt7WZTKRAK+Y1O6FyG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 11, 2024 at 09:03:51PM +0800, Yajun Deng wrote: > +++ b/include/linux/page-flags.h > @@ -691,7 +691,8 @@ static __always_inline bool PageMappingFlags(const struct page *page) > > static __always_inline bool folio_test_anon(const struct folio *folio) > { > - return ((unsigned long)folio->mapping & PAGE_MAPPING_ANON) != 0; > + return ((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS) == > + PAGE_MAPPING_ANON; > } This is wrong. KSM pages are supposed to return true for folio_test_anon(). I haven't looked any further at this patch, since the premise appears to wrong and you clearly haven't tested.