From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A17BC3065C for ; Thu, 4 Jul 2024 08:52:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 770866B00A9; Thu, 4 Jul 2024 04:52:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71FF16B00AA; Thu, 4 Jul 2024 04:52:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C08D6B00B0; Thu, 4 Jul 2024 04:52:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3CDB36B00A9 for ; Thu, 4 Jul 2024 04:52:28 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8BD22120C55 for ; Thu, 4 Jul 2024 08:52:27 +0000 (UTC) X-FDA: 82301453934.03.C3A1E41 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 83CAB18000E for ; Thu, 4 Jul 2024 08:52:25 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720083122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r11vJQlrkRQc/8EDLE5obd5tqXEo2R7XLTpFyf7XPms=; b=QKBzQ57n25dUUSagKu5gstQDwbTiCTWw+rihsPilQgLLvtY774/v/+vmXJIH2JV5lj918F bxsdbhvKw5LFfWFdqdjrzDU0bfoKGcX/osbUrxd7PBJ6zT19XmlJmmkq7d7jlTUmfeaeRc dBhXsgrKl+2gXJ3pWEM9UwW4pWkhMW0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720083122; a=rsa-sha256; cv=none; b=njj7vQcG/P3HUhMbyyohhQ6qqQTQbaiYKZkT5ZH3efHuvSkmNayy7kkTz8EaLp4BvzGDI8 YSo0R6nCzWNF0RfsYu/dmsnPmHJ+tWbHG5eLoYTHWtBactogUXle4zEuSkiUuhTSMlcSR2 e0xerQ1fGTN2fGtTw1epnmig+iR3ukw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf06.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 00889CE3119; Thu, 4 Jul 2024 08:52:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF8D3C32786; Thu, 4 Jul 2024 08:52:18 +0000 (UTC) Date: Thu, 4 Jul 2024 09:52:16 +0100 From: Catalin Marinas To: kernel test robot , Marc Zyngier Cc: James Morse , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Russell King (Oracle)" , Jonathan Cameron Subject: Re: [linux-next:master 9019/10049] drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used Message-ID: References: <202407021807.cBuWVBVa-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202407021807.cBuWVBVa-lkp@intel.com> X-Rspamd-Queue-Id: 83CAB18000E X-Stat-Signature: pgo8gtj99wy79hwkqewz3p9ko891fnfz X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720083145-325396 X-HE-Meta: U2FsdGVkX18uHXDRlZf79TOwRHduqFICCzi++mODHC8IflSrXrom/VREjqAVP7SBB01lbHg9CbMPgS3BIXgDdlFi5hGf44u5Liq2oCzQQAlThsfMPIzciTqHRjMA5MDgaOED/QYbZPUlD/Lr95OYnsHK+FoX6Xfk6BDfi2WckOiRnF1YomadPml0jJiY+cXHw381ocgbgwXt8b7mVsfmeUESyMgPPIZFK/6YmQkjikJaf3/y/xSGnuS3kzXW4x5Ue5rgu5YUlEMyYOgrZcFrvoGEqRrTupkwaHiAwcKfZgBsUBxakHlfBCJOfRu2k6+LZ+8Kdm6TuXUKElRtmUz+GIGuMw982C+MxF+WPrYFkI3NRvMZaoF5smEyh7Iohj5AWZJYHkRL3xEcbkig9T8iZgmweCpNfB8IQ7vakSCNDESkh7v/bhiMG+8pZsplkhMgJP48AS9jwCPJQxeun7C6/7zFMMTloSx0INjAGdJ641ffZaKc61ZPdbxUxxv5Mpnt3k9KY+NEq9/GjPtFv+V9fU3DYIpQ3yzfGF3MLOck2bzLnIlMQg7LL/E2Q8CAeuuHr1YGxCR7ve2PXlOU43PYbHnVKPeHWYh1vbjmfqtfYdg3ikoT18jCvVr9/GVL4vGN0PEcE9Qg14HWWQ3NZMvgh4Goibt4TKT+OYLJEvLEgo3wcLXY7PjmEeJimtyQcv3J1/iP1PJep+K9ZIaWdlh7D3HpfMieFFwzuvJLdyvO79n5+4u/jN8lB78lJLhFoPKCZHZBhLbGo/uKTM7CMDZ17w/SJKjhghsOSqbEBj8HltBJlPNHjfoFcY9p1LozS23OtVmvAnm/36pGCfhmHDgq5wWU+8uGSATdAYkSFy+Hxr9ncneU9NxhylQ3626HmeBKj5SijbodqX/VlgJLrOQcNrdrqPVIL78E+Y/5ZOg8Ioisp0O7e/8T4mfYt31+QF24d9yhsShZ++LQAzC1+Kw gqoJA13a ds7Hg8jF2boEnIEVBoiBkkdkoRV/H3pcnliefB7oP9p3eKUupzynXkr31kwkz269nNZ2nOD8jF9xjh0ja+nOjiAUq+jbUM0NRvPvEf9YcwJDFKajsOi5PRs8rDcW9LBx1vU4h0kENjR0Jt2hb1HvDyLSJTfJG2mYJUi0ZLzC3dRQnGHhVytKVBRMU50XI6ffDOykqr7ZB1YfG6My4bNEDiv1nE6VtebmwA1dutylS/V4DyVNU4d6amFRydhskpqiJQ+skNklGlfiOPeL3D6IfqN4lZNN16lnklyiifHdjGjZfmvI+O/R8Uzj4zNcRpJWV+pshmkHIVpCEXsvYlntBI8tmWATjnuBYx+M58WW7YQAbJBpkB8Yy3kT/EjjG3EWjx0zy2RCwM63+kOwk13bFAiKCm9RUDz9PpNXPvsB3pZtdcuS3yTCRxScSj2BeHykzvU9MqxKgKWFAFW3LSyNDw3/NiCIO0yp0M0Z25iLIJSFjEGvUZ51Lp1Jab07keicGnuJDfFtpPLpJJFVD6UYPECMHF0aZ5MBD0rlGI15R+7o5puKj8AegT9A5iBFfxP8fW5/h5H/plwGLADRD5mm4dcmV05bN6ewW1f00QqV7fpO5YQ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 06:40:12PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 82e4255305c554b0bb18b7ccf2db86041b4c8b6e > commit: d633da5d3ab1a0eb26a2213d65da1e189e82f8ab [9019/10049] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs > config: arm-randconfig-r034-20220810 (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/config) > compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202407021807.cBuWVBVa-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used [-Wunused-variable] > 47 | static struct cpumask broken_rdists __read_mostly; > | ^~~~~~~~~~~~~ > > > vim +/broken_rdists +47 drivers/irqchip/irq-gic-v3.c This can happen when building on arm32 with SMP disabled. So we either add a __maybe_unused annotation or we move the variable further down in the CONFIG_SMP block. Marc, what's your preference? -----------8<---------------------- diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index c29b424d1d0c..6393f3d780e9 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -47,7 +47,7 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) -static struct cpumask broken_rdists __read_mostly; +static struct cpumask broken_rdists __read_mostly __maybe_unused; struct redist_region { void __iomem *redist_base; -----------8<---------------------- or, -----------8<---------------------- diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index c29b424d1d0c..187948f41bb3 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -47,8 +47,6 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) -static struct cpumask broken_rdists __read_mostly; - struct redist_region { void __iomem *redist_base; phys_addr_t phys_base; @@ -1316,6 +1314,8 @@ static void gic_cpu_init(void) #ifdef CONFIG_SMP +static struct cpumask broken_rdists __read_mostly; + #define MPIDR_TO_SGI_RS(mpidr) (MPIDR_RS(mpidr) << ICC_SGI1R_RS_SHIFT) #define MPIDR_TO_SGI_CLUSTER_ID(mpidr) ((mpidr) & ~0xFUL) -- Catalin