From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 795EFC30653 for ; Thu, 4 Jul 2024 10:27:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03E646B0095; Thu, 4 Jul 2024 06:27:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F305F6B00AC; Thu, 4 Jul 2024 06:27:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD0DD6B00B4; Thu, 4 Jul 2024 06:27:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BA8606B0095 for ; Thu, 4 Jul 2024 06:27:38 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 77160161187 for ; Thu, 4 Jul 2024 10:27:38 +0000 (UTC) X-FDA: 82301693796.17.2943B14 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id 36467C000F for ; Thu, 4 Jul 2024 10:27:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720088838; a=rsa-sha256; cv=none; b=iJ4Yxw6nmBClW597DDVgc/793v4daHVsyvBltGguft8mJFzsH6URFtG1ggHGlRyaV5mBfd EBOikN0O9S59JwIkCrvGEVXBL68blzs7Pv75ZKelsnGuUCvnAuvaMx6kEUVj4D1pQjpu/L ndTR2xYhJVZ6k/ATKJkG1fSErZ3RcJY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf10.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720088838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XYQvPkHkriRLvLgOkHwoMUZHhGtuYDKqvliVzxTtLiM=; b=aHg2GgBAZa0rwxJ/DTGWg03/dCrDRUjMzePPsotU76Oj4ZeRnw/TyuyvRM1858/BfWvDz3 m6ojXshKKWZkBnY4CoXWv7L//3x1zZ650wwtKvyV5iMmkVDNjETnVaUcccRLfenz99dQHn hAeZV/MnIG975BF2rqDu23A1JndD7l4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 590E7CE33A2; Thu, 4 Jul 2024 10:27:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 328FFC3277B; Thu, 4 Jul 2024 10:27:30 +0000 (UTC) Date: Thu, 4 Jul 2024 11:27:28 +0100 From: Catalin Marinas To: Marc Zyngier Cc: kernel test robot , James Morse , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Russell King (Oracle)" , Jonathan Cameron Subject: Re: [linux-next:master 9019/10049] drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used Message-ID: References: <202407021807.cBuWVBVa-lkp@intel.com> <86cynt4jem.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86cynt4jem.wl-maz@kernel.org> X-Rspamd-Queue-Id: 36467C000F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: fzr7shbjtj4h888oco6rbp97ir565x3g X-HE-Tag: 1720088855-555715 X-HE-Meta: U2FsdGVkX1+wn1k0vfiht9GZF0FJ/OtbEOxKrqvCMGKzmzVrIqIXOy5FtaIwY6V3R7RWOH19kw6mZbZycEfuPfIR5eKYqPV+DxcT9Y/l8L93lj/82y2dKcJiapSlIJo89xrCX9Sdf35MfLCiu5Tc5itJlGcSNJAvM8txl9uqoIubeqfoOxqGBvy7GPxWOsnGaJN/KIw0aNMB02IBP7y2ojmKSnNjuWcBeA8edckvUFOYRi9VlwzoQ1ElrEYJ3YwRRuJnR2NuY+iWsTUdw1HvkO7hj1wokCwxMQwoj5ij1xOOOUhNI4esy5jyD0ewsXJMVEubFPAFgaOLE+vhVSMLtnwk4WRq7wPkffKTPqi1uDxvE8wd22sB3weJUGDLFMJ4oT7ZgOQKQBqv4HJrhbQjb9r6wyzr7g8eVBNcjCIvfTLoQN1atpysBkVzZ8nV+wRzX1Lx0R+Py52ZqhY3OWTRiKN28uboH8k3vbu4rHlxjgNTUsWjw1Ot9sS8lDwWzgvrlT6HwnGKwgpz5+zYOSSBUVg3MVem/VLu9QjJa1Q85dQbuNZygI4FmR7OtAB88nvEmoYBLvQcBU2wVIy4SVVmjd+zBdI41R1KdZxpGuXUFmFLhy4fy8M9UkU2eAgC6WDLE3Lk756/EMM32miksCGdS1ISJ0KacioGtvEXorU0BQz4gduwwkBG6Wx4GVttf1nvX936Ylmb5AQLXb3hjWJeMNCCAeRC9K3b+jgK2JpBgJTgAE1pu1OY0A1xC5Iq4vSlemu07/phZ9tnP16aqwZ01ZOX6V7KZiV9JNFwTC2J7bdV1I4VOVr0brtMnUpBJMHrLxlo8QC5JZ5Xp0o/pgZ9K6iJudK4SR+Kx0pOXMMPEoCsZEINeSG7l+XJk/soS8/Kw3KBJE6Q7aq69lTXzw00rD3OTXg8fj4+Vn6tKkewrC6j1wfyJH6KNQPgDifvaSLA8hLDSrTDexzyJ+EK8kN GOFnQEjB zTVxcmYRi1gwQ2lliSdsMJvh81g6coSfyyOnvtaCK/401Pyp2OP4+KwaAPbp9eXezN8wAr8Si++dfEbYfB9PjXXWpqGfxbkVqQ1Pk1kpynrKNFdmlZgPNbaPuMClNCHZnSRT8SBWb4dhZUjgthyYnnzpsAHNXWv4P+GyrVFpCJPmv5JOVO8euLcBkoViv2gmwk7qqNxBUkQy/4r3muCnp6ckdv9ztEWinVkfg8Go1Mblh0NWxaaZpAKjMdvndTAwvcZK7rhs03TXWT4OGCjPwx9ZaRVfyljLtYkSCX+LPcYXgndyS3ACqP23+9iLJFouFFZpwadKAXLVFvxkTFlLatUQmPwVdxEU4p+7ydjVQ5P4rSIWsfvOpMFDMuRDOf2z/eDoTHXQQO0fZtWIlWrvbfyo8NPQX3P0vTYkaqEU/wEeUuJ4hUC8au0TBGRVkfi1j5LCM3E2xuhQ6jxGU2PA3H8wZx01w38Ct3OHRWJhO89rdiiMDoZeQgjiqcLf0n/gdY8sqs5pa2wT6GlTcb0ekMZB6w/L4rxpS2Li5DT7VWr5gFUP1g92iTvq7UFr6c9jH1UpE15ecnjHX1XuWrDEolLMC86Epyjs7X3U7l/QS44eprxeY13PqiU3qt6z0oqduVc68N5UDag1svZgtWl/RHQirx1wmnBs4OZ95 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 10:05:05AM +0100, Marc Zyngier wrote: > On Thu, 04 Jul 2024 09:52:16 +0100, > Catalin Marinas wrote: > > > > On Tue, Jul 02, 2024 at 06:40:12PM +0800, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > head: 82e4255305c554b0bb18b7ccf2db86041b4c8b6e > > > commit: d633da5d3ab1a0eb26a2213d65da1e189e82f8ab [9019/10049] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs > > > config: arm-randconfig-r034-20220810 (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/config) > > > compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/reproduce) > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202407021807.cBuWVBVa-lkp@intel.com/ > > > > > > All warnings (new ones prefixed by >>): > > > > > > >> drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used [-Wunused-variable] > > > 47 | static struct cpumask broken_rdists __read_mostly; > > > | ^~~~~~~~~~~~~ > > > > > > > > > vim +/broken_rdists +47 drivers/irqchip/irq-gic-v3.c > > > > This can happen when building on arm32 with SMP disabled. So we either > > add a __maybe_unused annotation or we move the variable further down in > > the CONFIG_SMP block. Marc, what's your preference? > > > > -----------8<---------------------- > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > > index c29b424d1d0c..6393f3d780e9 100644 > > --- a/drivers/irqchip/irq-gic-v3.c > > +++ b/drivers/irqchip/irq-gic-v3.c > > @@ -47,7 +47,7 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; > > > > #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) > > > > -static struct cpumask broken_rdists __read_mostly; > > +static struct cpumask broken_rdists __read_mostly __maybe_unused; > > > > struct redist_region { > > void __iomem *redist_base; > > -----------8<---------------------- > > > > or, > > > > -----------8<---------------------- > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > > index c29b424d1d0c..187948f41bb3 100644 > > --- a/drivers/irqchip/irq-gic-v3.c > > +++ b/drivers/irqchip/irq-gic-v3.c > > @@ -47,8 +47,6 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; > > > > #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) > > > > -static struct cpumask broken_rdists __read_mostly; > > - > > struct redist_region { > > void __iomem *redist_base; > > phys_addr_t phys_base; > > @@ -1316,6 +1314,8 @@ static void gic_cpu_init(void) > > > > #ifdef CONFIG_SMP > > > > +static struct cpumask broken_rdists __read_mostly; > > + > > #define MPIDR_TO_SGI_RS(mpidr) (MPIDR_RS(mpidr) << ICC_SGI1R_RS_SHIFT) > > #define MPIDR_TO_SGI_CLUSTER_ID(mpidr) ((mpidr) & ~0xFUL) > > The second version seems to be the most logical one, since we already > have this SMP-only block (note to self: constraint GICv3 support to > SMP only at the earliest opportunity). > > Feel free to add my > > Acked-by: Marc Zyngier > > if you decide to push a fix on top of this branch. Ah, it's also used in the CONFIG_ACPI block further down. So __maybe_unused may be easier. Or add some #if defined(CONFIG_SMP) || defined(CONFIG_ACPI) but it seems too verbose. -- Catalin