From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 613E4C30653 for ; Thu, 4 Jul 2024 10:15:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF1736B00B3; Thu, 4 Jul 2024 06:15:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA2086B00B4; Thu, 4 Jul 2024 06:15:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C69FF6B00B5; Thu, 4 Jul 2024 06:15:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A1BE46B00B3 for ; Thu, 4 Jul 2024 06:15:18 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2CC5EA3FA5 for ; Thu, 4 Jul 2024 10:15:18 +0000 (UTC) X-FDA: 82301662716.06.0C74E10 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 7836940003 for ; Thu, 4 Jul 2024 10:15:16 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf07.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720088096; a=rsa-sha256; cv=none; b=2Pw6n6OllfLHo5nlAag+JyDeukgRCBrjdG9+f8Ulk7XrVubsi9rxRghb6TJR37Kd5hUX93 x5PzfawZdRr9lR5b5hv+s+aP0cVz8T96+0aCpvm88UKQZENxmXxSw26CWXUP5Bx9uA28Tv uX9Wzy1fxNb5PqBBlgK9hvyN3u5n4LY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf07.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720088096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AuFWkHJs6pDWMaLSlYP4XJVut6nxc3/Ta+LEW4xHJFc=; b=tzZ7l8RhTr3pPSFni8UZaxWJtxUwRD9vPZ6iZsxpWncXdZIhh2fPtcPmhCZZyBILv/iGQE XmbO3J7/IRgPfNHqQKlsQSkRBVnvZaFTq8Xjfjq2SwIwWX89SO9jgOYR+7Z8vQUCDR6ZUu QWhnHgCvKxqO1U09e72R6YkA+n5xPkk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5B35D62601; Thu, 4 Jul 2024 10:15:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96510C3277B; Thu, 4 Jul 2024 10:15:13 +0000 (UTC) Date: Thu, 4 Jul 2024 11:15:11 +0100 From: Catalin Marinas To: Marc Zyngier Cc: kernel test robot , James Morse , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , "Russell King (Oracle)" , Jonathan Cameron Subject: Re: [linux-next:master 9019/10049] drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used Message-ID: References: <202407021807.cBuWVBVa-lkp@intel.com> <86cynt4jem.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86cynt4jem.wl-maz@kernel.org> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7836940003 X-Stat-Signature: 1d6setykrnwsnczfkrdmoqeom448qrum X-Rspam-User: X-HE-Tag: 1720088116-838633 X-HE-Meta: U2FsdGVkX19Q++sJI/RxBiHMoeSBb6QTQUaSKy3TsoI1tve+trzMX2jgXdHnN4yrcrRU548NpXhYeIVGI5ZBQFWty+4fRMs3rODg+uM4VVqjWy/iTH2go5nNMEsbmfYfWmwsZ3Up2wFT5Rk22JBUfbrVlBKbIG6qqEaPDbXbE/FSUKtzCfZ5nIIRJqGJm+RqJrEgQHl4hsWNhC3/0sMH2AesEU7yDgnQ849yYgBEAnDcq7YYLqi9Q0ASzDhRC9PrEssx0pG4oPNMImVTUEe8j4zgPowJ+SGeB46yRArhm/WeD9jhwIeYDEjhBBbYrZLiV0xj8D4HuOkZclWZUCCcObMYNVyhlACy9a6+CDZYcvld8XWa1sI3xRf8fu2PtRNfzrCSFxrY+YD4TGHu8OVieppSuq/ylDMUsKoMtxzlkUMKLiMavAEsDwHiEfjD9YyiyvSxdzkSZc03LE/FNyo/pKC7R6D3ZGfOz2IbvHAi3bzZkwvL+3u8iVYSw7bxxcrWIguovT0dLQtAEHgX78T2rwGQvUfhkrRFR1/ao8QBOCX78UGwyiURo/P1P8t2Ay+PF4Z4Nc74UKHREMwKyvYZS4PYSdww1wCkkpTqhRxoMC62drlneLnLViJgY6l3JJ3yWMK7UWBF9KaYdUCeys7d3cZ6WxMT2iBoL/Fb5m0GRtONkjjbcBHqE4z3Vso2cX3G6WBghSFjgISGy2CM+unvoE/A2rQoTS3ppgqnp/9Td5FxcVfSY9xpIRP55GUR3GJ6A5rShW8N24eL8YRbR6cy/2OPJBjbzoj5MHXvL07L5ehuvaQpeU7kVd6VlSMtaX5KWfEiO1RIe+oMqYh850/ZlVM/V4EFUMwiSJ3PnCBAg3Y0fHI765lvEat8FesZufV/9woEd1GENld3esEVfBZEupWwnafCPlTAnlhnkmNkQ+d/bIcHWW9kNCH/faJ1OLvqm0yVrZL8B7yba/dFIPL 75njwYor p4vMGu0Gn3+5SQNfJLSfEeC36fpPq1a4/NNFwDryf7nkqN0QLSPiPsDuwHN2rxOHAbjQVN26dRO+7+uwLvzmkPLHEOQkZtAnbMpW3mGS2mZxlzsJ2O7880aark7rEqLGJjRXme27/gaOnE1r19bLhRdIKuEJtH9MG9RB3ZQjHfOsS5cAAlRea0IY8zIeX+nd6HBt2txcU2R8dFBN5kSEW3ELZp7nLL3/Z2dDEnNRhvGX7VRAv+BCB62oFvFOixNNZrekK9RFUUpmFNVsoDU98Qzvhhynk9RHwXvdebPQPszsXa9f6XvWkI99LgHbvnIGeiDAgQ3NALWGwy189arL0CDtV1D6vtHGGB105TQ1E1Tad/T/wQkdLYm+fkDxPw2x/+dk2egy0NUcBk0aWhKoV2f7CfhRScdkdw20LIF2DfOvqzhLZDoMfVUJXuXym2zEb7a775s5AUWTWh3BYH4e9CDMb053SYz2IjQXrMvHKEM6lbO8n34joMMN3BuyUfefXvkYCRAXbqeF5KsnWWsV0HumfzDw7RqgA//GN5A740gPrLkZ46bxqiBe646ZiMFKILInb7pAtQNZ+JUg6tw5EBY+bngxpjgc+CMeNhNVcCiQue5PDuww4aTwaL2ybmW3P98wciqotx4r5vco2h5m+EIPzYuASDeYNLWQxyPWr0mx2kuw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 10:05:05AM +0100, Marc Zyngier wrote: > On Thu, 04 Jul 2024 09:52:16 +0100, > Catalin Marinas wrote: > > > > On Tue, Jul 02, 2024 at 06:40:12PM +0800, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > head: 82e4255305c554b0bb18b7ccf2db86041b4c8b6e > > > commit: d633da5d3ab1a0eb26a2213d65da1e189e82f8ab [9019/10049] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs > > > config: arm-randconfig-r034-20220810 (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/config) > > > compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240702/202407021807.cBuWVBVa-lkp@intel.com/reproduce) > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202407021807.cBuWVBVa-lkp@intel.com/ > > > > > > All warnings (new ones prefixed by >>): > > > > > > >> drivers/irqchip/irq-gic-v3.c:47:23: warning: 'broken_rdists' defined but not used [-Wunused-variable] > > > 47 | static struct cpumask broken_rdists __read_mostly; > > > | ^~~~~~~~~~~~~ > > > > > > > > > vim +/broken_rdists +47 drivers/irqchip/irq-gic-v3.c > > > > This can happen when building on arm32 with SMP disabled. So we either > > add a __maybe_unused annotation or we move the variable further down in > > the CONFIG_SMP block. Marc, what's your preference? > > > > -----------8<---------------------- > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > > index c29b424d1d0c..6393f3d780e9 100644 > > --- a/drivers/irqchip/irq-gic-v3.c > > +++ b/drivers/irqchip/irq-gic-v3.c > > @@ -47,7 +47,7 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; > > > > #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) > > > > -static struct cpumask broken_rdists __read_mostly; > > +static struct cpumask broken_rdists __read_mostly __maybe_unused; > > > > struct redist_region { > > void __iomem *redist_base; > > -----------8<---------------------- > > > > or, > > > > -----------8<---------------------- > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > > index c29b424d1d0c..187948f41bb3 100644 > > --- a/drivers/irqchip/irq-gic-v3.c > > +++ b/drivers/irqchip/irq-gic-v3.c > > @@ -47,8 +47,6 @@ static u8 dist_prio_nmi __ro_after_init = GICV3_PRIO_NMI; > > > > #define GIC_IRQ_TYPE_PARTITION (GIC_IRQ_TYPE_LPI + 1) > > > > -static struct cpumask broken_rdists __read_mostly; > > - > > struct redist_region { > > void __iomem *redist_base; > > phys_addr_t phys_base; > > @@ -1316,6 +1314,8 @@ static void gic_cpu_init(void) > > > > #ifdef CONFIG_SMP > > > > +static struct cpumask broken_rdists __read_mostly; > > + > > #define MPIDR_TO_SGI_RS(mpidr) (MPIDR_RS(mpidr) << ICC_SGI1R_RS_SHIFT) > > #define MPIDR_TO_SGI_CLUSTER_ID(mpidr) ((mpidr) & ~0xFUL) > > The second version seems to be the most logical one, since we already > have this SMP-only block (note to self: constraint GICv3 support to > SMP only at the earliest opportunity). > > Feel free to add my > > Acked-by: Marc Zyngier > > if you decide to push a fix on top of this branch. Thanks. -- Catalin