From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE0BC2BD09 for ; Thu, 4 Jul 2024 03:37:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1A256B0096; Wed, 3 Jul 2024 23:37:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF0C26B0098; Wed, 3 Jul 2024 23:37:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E0186B0099; Wed, 3 Jul 2024 23:37:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7DD026B0096 for ; Wed, 3 Jul 2024 23:37:44 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 257B340F21 for ; Thu, 4 Jul 2024 03:37:44 +0000 (UTC) X-FDA: 82300660848.09.547CBFA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 8AE56C0016 for ; Thu, 4 Jul 2024 03:37:42 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LtKILiiJ; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720064250; a=rsa-sha256; cv=none; b=bWVqqPNQ7Dn8s3YVXxwF91i54dkydppZA4frw7wJ5MIWaI3nglrThqjLXg16Bq6oxzynK7 /Z9iEXVYKw7ygXfMheuXQJueBXaQsmGQVo1mSusovB2FSPpxpqN+c9MhD+ipbSEZVzGlP8 y1UFnCWVUceyAKw91w7fx7igqCfUzME= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LtKILiiJ; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720064250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gORZIWhR6haTvMb+DZRpC8xcydy5uoNOtr1+9XCCc2U=; b=BOamx/OjqlZW8oIZwXmW3JRfqhr0QsRezzCgfCkkK+EEgitj/jT3wURWVK8c4NC80BEYg0 8I5qBbL/efhJxxag8zYonwmx7QiQp2+qex7MIIUz+KF+fPeaFS/xQkcTp5P7yNQqMX1ZNl 4h88FNPynFysYcbIHzoed70HojPjyAY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gORZIWhR6haTvMb+DZRpC8xcydy5uoNOtr1+9XCCc2U=; b=LtKILiiJICdRaBaZI4iRLZCtHC T946GVBVEavpxoDQDV95jyLqqZGCdDAgqTdUsJWfHNsKbMQqT6Mz4uC+5+t/mv21MH2seslYE6ijM mOUxJDquYww1pFI1d1yvGP4tkzjX8Cz/dZUGQ/EWzUflR7fbeO5ZcxLTu1chABjkOqoOjGVqcK+BJ o/2hKmzcqNY9VMJufk1cv6TUptYwScVlbvq/b25YXz7j71mFmLphOsI7FdBXIZdgLEL4GE5LhMuPj gfDjTrau9lqhy51TS1vFgvN59+n1NhuQLpCcJW96lICw9TUykeUEXd5evfMpwGaZ5Var9UZ9quACh 3pvzAFZQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPDHm-00000002Rpx-1Ju6; Thu, 04 Jul 2024 03:37:30 +0000 Date: Thu, 4 Jul 2024 04:37:30 +0100 From: Matthew Wilcox To: Hongbo Li Cc: muchun.song@linux.dev, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 1/2] hugetlbfs: support tracepoint Message-ID: References: <20240704030704.2289667-1-lihongbo22@huawei.com> <20240704030704.2289667-2-lihongbo22@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240704030704.2289667-2-lihongbo22@huawei.com> X-Stat-Signature: aze46dr5o3gqwgotwp7jymagwjtrnopw X-Rspamd-Queue-Id: 8AE56C0016 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720064262-882804 X-HE-Meta: U2FsdGVkX19JgQ4ze5CLA49hgPU67HbLnt+IqDWUXS57VEniEtwXq5wi7GituNGLJxPrlerGA2u4x70dd31vKA6Qnme+goW5eGKiYbJAOlbLdIfcqR5U+axOtMgU8IIKsdRyNBHwrLY6ZdYBokbYZRjEZH+dyv46wsS1LywP+kXnCbfVht0DeaG5/aPjgFNmjG3TToYTQt35YlIc3K0HZB6mUz5jDPQM1aEYMdsKlyHEmu8D0TVt8Ic+r/KH4ll+bpBJxX2gyb/EdRQ8W6tHIxcyKuHziVBHPLFxAOvzeJdkgfgNkNAPMFSLV8zlde1yS/QEihwv0evFTvtLb5jyYeLaVX5gCKM3OqQE04mvkwX1TVIsnEv9Sdy4dLPBv9DwfqIZ8Dax5veHVTIQ1XwT4J0S3SdJHXYa1ibBUcwlsh5Q5Ly9CWA2bZbQEpy2kwJV+Pb9pORBTnjkYWidNaDz5wzFM4DaetB96UtdLWvgMsPElbTrgWwAFS8MKRxUSg/ejFsmm9sVOP04khSHyxUwFupHTYGw82GbJhMzTL2vzVMadG/HWX525xCQ2ztcK4TDMPD/JVC8WSazbRFfNK3FE9mk0EuZ/HmWyvU4rdgq/r6V8zifyThPG3lBrnS3kPgrD2B11nvytzfGyz2U2nZ64Sbz2QYM8d8syKfpisvW/rb2vEpLwEWInSXtBGvirq8NDCRQ1uS/V2TmQfOyH8XpAoh0AF3VAvxQ/pVySK+nCXGlJr1pCBTRAk167SIndHHBIS564ufiphUbsAX6V1vqfUeNS+KkZAci8luawqCeGTiQegeLABnC7Bbk7lQZziuDpfyi1SG+7I9Vpe2zMq3iE1KDiPBWJQIpTSF2NOMC7v+Z3fEKUj5AAdGQRopGxbzuX5+uR337U8ROFBq/O7oGI/ytNzsifzQX9vy5FIOuOo+7YEaaYCCnWBMC1iPjHV0pRlwpupMaa+GujoYLOxV 1a3zYiuh zWhVnE0b108NB94TwLhJn5LN6TZScS75VPIVaQbOUUbD6GPYIZmp8ax/P2M3/HNlfc4c6XMJACMGpLHjDPuHkLFmqWJDZGV5/hDOD+zDHg3RkZXQF8Id3bm+RLVzm+qMbLpAcjsqBgNaLv9Z4NZTFPi78tBS1ghpqqsS02v2nwUIPxCWEyxCXhXieEiWHTtkiPXQVcKjsF1ArP+M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 04, 2024 at 11:07:03AM +0800, Hongbo Li wrote: > + TP_printk("dev = (%d,%d), ino = %lu, dir = %lu, mode = 0%o", > + MAJOR(__entry->dev), MINOR(__entry->dev), > + (unsigned long) __entry->ino, > + (unsigned long) __entry->dir, __entry->mode) erofs and f2fs are the only two places that print devices like this. "dev=%d:%d inode=%lx" Why do we need dir and mode? Actually, why do we need a tracepoint on alloc_inode at all? What does it help us debug, and why does no other filesystem need an alloc_inode tracepoint?