From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 213B6C2BD09 for ; Thu, 4 Jul 2024 02:06:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 901C26B009A; Wed, 3 Jul 2024 22:06:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88ADC6B009E; Wed, 3 Jul 2024 22:06:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 704406B009F; Wed, 3 Jul 2024 22:06:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 521EB6B009A for ; Wed, 3 Jul 2024 22:06:54 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E95711609FC for ; Thu, 4 Jul 2024 02:06:53 +0000 (UTC) X-FDA: 82300431906.27.4DAA409 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf30.hostedemail.com (Postfix) with ESMTP id 9E2C48001A for ; Thu, 4 Jul 2024 02:06:51 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Gb1sfqYr; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720058792; a=rsa-sha256; cv=none; b=IEg2RO2/yE1bVrp5uI7lDwkYLucu/0E7nizdAUHi7n1yoNtoLZlwZREnnu8wTUj8+HJfHJ hZaSLAuP3eovhwg7n1Rx+jNM9uRSTQBJRw59EwpmMKvBw+5w7fdg4PnB0g3d1ABKPh1Xrg 7QsT1KEDfsZK43HzBmeThcb7W6Bx/yg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Gb1sfqYr; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720058792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZKBv5U41uQIoh1OWg83ciI9iZQQe9QfjrQtrgnHXa08=; b=dMNEhWsuMB7MvzTQ9n2+1MwLYlTh4XSr15PMROpq2dTvAuXwoBoyEubgkLrJhX+DMbban5 /KfXklk1IKLQJIJK2zR3KfbSQb5unB/p5I++e1ae18Ny6ZVoAg3h36whdVvewtIiGoebQz k0zy+H62tU3oG9KYGjPVdn8JnK5Ldh0= X-Envelope-To: akpm@linux-foundation.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1720058808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZKBv5U41uQIoh1OWg83ciI9iZQQe9QfjrQtrgnHXa08=; b=Gb1sfqYrGurbYP8fLRtjQPHiIaijHbvwaJw/MAg3uwREwJaMKru7WpzIaZHszeUc5HoR3C i3nGv8aSJhHyfU8Ozt5aNV4xGwacxzEMa5U70gc+j7j6pFzklDfcqOZ97MBT9JLK6+8sBR OdeVBqwH+biSdFTwmFeq+Na46V8qyak= X-Envelope-To: shakeel.butt@linux.dev X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev Date: Thu, 4 Jul 2024 02:06:44 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Andrew Morton Cc: Shakeel Butt , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song Subject: Re: [PATCH] mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c: fixup Message-ID: References: <20240704002712.2077812-1-roman.gushchin@linux.dev> <20240703185250.ab96286a5e4747665520ddb0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240703185250.ab96286a5e4747665520ddb0@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9E2C48001A X-Stat-Signature: 7nae9eejnmjeaq67qb164g1rzdrdgzgp X-Rspam-User: X-HE-Tag: 1720058811-7988 X-HE-Meta: U2FsdGVkX1+EzxXOZ1ekokvnwULXskf/l8wO6gpiLEYrkk/grri7qFq2OwavrViWVXH/KHm1GqDRy1q8WM6YjeeMpMivU4XE7nyXSSuLdbzHYRR3bQPccfkV3/Bi3757cOjuJI/ERfzMzhbj1p33qmmpjigMpnNgqmVQtL9tZ9mWDel7lnumPrSxBcZ5epP3RP1ERc4ESgtBFkmmidKYbkN+NTMCy4q2nc0AWs4TF9+8T+gcgqvzKLmJ/Hu+MZFlB3hEdVoZA1XQwpr2Yc64SahI24OTTBQUho/llcQtX+DL1yV76IhY3uNYJPYUwh4QNENab3lxxyorAfEBsbhsLpM8xX7wJkuKDyb+EcUbSvvyijJt7z/X+COjMCgfBraqS549KkWVkkERnSDEN3ebg326TwAus7HxRDG7QmD08mkkAJnk+udL0afzgun6OwnUh8ZJ5PQ6oA9qM0saGnk67Tsuwsz6XQtEPTzAnzuNldhXR+wdvctdfA8lh/peiEpgafLmPiheEw9Q4PloGI1hyO3jXZ0Ewv5/5SFEbk0Ou6uUnBZ94PD5ykjnLQR7Ti0EWmdPFpSjPlFvRU9+uPERXHXvYCBceikDK7Kvj7dWCokjv+EIu8nbzSXsDqh/x8JRtQWzPB2m7x5L74B99LYBTCFlXJBb68F2fB4FY9nNLoSSKTBk5OfEyKA8bCKz5NcARaJHPcNTXlqnzsuOruXuyYilj6iEeaCPGzp9zWpii5f5uc79rBOAvophM+8Y1/LdvWbVIJqKcFOfCVEizz/D5h4pd13XHQyXx17E37l5Jnilpx7F2Kl27ecDPHWoNV4hkbbhgktZ3daJI4t5BQ6KAua/lES7WRqRPwdUUdkr99PtP8TFXC17cjBw/ruZED3Oj7m8l9vu7/ZlnXwfrFplBcgRtSjoPPgEAooZEk5poYlJxvdnpiG3UjB7f7VktSsPOAEq9KOc69TBKcyvae7 juDhPsrG HA/pgCeNseF+WpzP+iJD+S7r0w0AOadTAwPvhh+ICkbrcQcXxPSnI2oAU2J4ahlT8ha6jUV0NqYymyP+2W/5+0YfakJGVODtNrKg2G2LqQWeJRZVZlRSfLZisHaYFvjwKcmrL5oDVi8ANf8JPbsZA8YJIJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 03, 2024 at 06:52:50PM -0700, Andrew Morton wrote: > On Thu, 4 Jul 2024 00:27:12 +0000 Roman Gushchin wrote: > > > This is a small fixup for the commit > > "mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c". > > > > I forgot to actually move two functions mem_cgroup_node_nr_lru_pages() > > and mem_cgroup_nr_lru_pages() into mm/memcontrol-v1.c, so that they remain > > in mm/memcontrol.c and their commented out duplicated versions in > > mm/memcontrol-v1.c. > > > > Andrew, can you, please, squash it into the original commit? > > > > Seems this wants to live behind "mm: memcg: move cgroup v1 interface > files to memcontrol-v1.c" so that's where I placed it. Right, this is the proper place for it. Thank you!