From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3856C30658 for ; Tue, 2 Jul 2024 16:52:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F11D6B00A0; Tue, 2 Jul 2024 12:52:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37B026B00A5; Tue, 2 Jul 2024 12:52:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21BD66B00A6; Tue, 2 Jul 2024 12:52:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 025C16B00A0 for ; Tue, 2 Jul 2024 12:52:02 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A9051C030C for ; Tue, 2 Jul 2024 16:52:02 +0000 (UTC) X-FDA: 82295404884.07.31C13B0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 11F80100011 for ; Tue, 2 Jul 2024 16:52:00 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=aj1qMLLz; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719939090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t7a/aHEDbr14CJa/+qvpFMgVsA/T3gcImqxhM0zCkOk=; b=nSbFGkWu6qrevyBsBXXmxk2tzi5H8/MYW4IFLZR42xe1fZc+dTLp6cldzxy14ArXtZCMw0 pAq+V5XAohHrGzNAk7GA7w4oLzc9rTc+OLNnug1JLC0pSG3rFEYv+lcsWz0RAR6eKD5iJP DGg3TGFWuYS3WXWId6JPKYH+AS6NCjs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=aj1qMLLz; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719939090; a=rsa-sha256; cv=none; b=a8+C03blUUU5HGVLpwULsTzC5w9xnbXFHLM1GMEAQcDAH73aZckU6A9bYRxbvJCHq0Mog3 /+Novaku2eziBcQNITykq8PsbiT0NWY+eb331p1Qbyvy2FDNv6EgaVTjmkfGTaEuU1Tn0K sOlXc+vlYz3OyoJwHR00ChG8FtnwSnM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t7a/aHEDbr14CJa/+qvpFMgVsA/T3gcImqxhM0zCkOk=; b=aj1qMLLz45jfsjGgj3OABoFYSY XY+0xFseGxJzE8ONLBlJtdBF3IdVifKJr/bG03yY6f/KA9aq+TqbhUw9sXH5/a/JUV5Fis1nwhj8Y lzHLKxD9MA0vx83hW+lV5CjDITJXQkHhFQjNLwgNFy0XwU2CycPspT1hh5yMi931AhAkR5zM6qQ95 EIbp2N0xGY+c5K9sB1CtbJooSLTIBpKuFyq8aW9GNrw7DhLGbl/zkIMbFdIpAa2TykQkK1EGAFoTC bZxujctftCqYGsTRDps3U98p6YpYESSLqoo2NurKHjyaUHIbfZMFXcpWkEkXSh9ZUzsXfNnyQ+MG2 R+TaRBlw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOgjT-00000000xhV-0F3Y; Tue, 02 Jul 2024 16:51:55 +0000 Date: Tue, 2 Jul 2024 17:51:54 +0100 From: Matthew Wilcox To: "Pankaj Raghav (Samsung)" Cc: Christoph Hellwig , david@fromorbit.com, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, Zi Yan Subject: Re: [PATCH v8 06/10] iomap: fix iomap_dio_zero() for fs bs > system page size Message-ID: References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-7-kernel@pankajraghav.com> <20240702074203.GA29410@lst.de> <20240702101556.jdi5anyr3v5zngnv@quentin> <20240702120250.GA17373@lst.de> <20240702140123.emt2gz5kbigth2en@quentin> <20240702154216.GA1037@lst.de> <20240702161329.i4w6ipfs7jg5rpwx@quentin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240702161329.i4w6ipfs7jg5rpwx@quentin> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 11F80100011 X-Stat-Signature: j56sw8mep11m1biz17er1a4jsjooe5ys X-Rspam-User: X-HE-Tag: 1719939120-732176 X-HE-Meta: U2FsdGVkX1/C3FHMgQE9aX229aY3KO6+oKHcBRbPVD0X1gQ86SHcKnGhrjrnmche0CARRV/cceQff101h1kXrQnpmDaYZnoBanJQW0FjBPfaf/Yztoqst5iHHJuwGrWvvY7M1jXgZ5Z2BrquyeD1ko2yUd126WB/h26DDJCydJO74hX/nOlWRvUh/tn9mCtPt9RSAathkPHFKuRph8LQWJwPkleAd0A57dyvXDgo/CjYdSPMWQg+CkNz4cNwfArJ0XSFoyWXb1rCnEHcJD0Yqan4rLv9WZAiq+Sz4Q6hqwZ03JDvPZa3ZEWUNsKwToXYnDHqFOOUlW+myUzwgv2w9YUUesHTCxLOVkuCbXxKPnfQte+tK4AyYVVsP8fgnPUfyhAFXEswrClB3uDoYPfqA0VkleK9TSCIph4FEYK1xuaCTMIGTibbw4CGfZcpTkhiU5rqzk9OVn66srOf2G39RVsX6LP81CVPHLLkUgQjEHjMJrdEpEhCYXhHqmOfFfNX23VLx4kefyNYS8PSTpXoWVg6WZFgTYLBGWAfuqr6yTz8AV2FB7vvGzLXi2NA3OQlIuoye0WsfG5AmMMAcpM189/hRty/C9F6GfhIS7nKMpG/F99N5Hztig3jEiOP4KyTznB+wozlGjn5EDby0i2r1ZEHnMWf/PPuTLn2rlJZ9tp6uJnZkk1C1yd0h0ifiA+fnSLD6Y71+dt5BRhitYr42kz0LC6PZI17o8LTJ3dO531rpB/Bs+iV1OFYzJ4xhNl3cWaUlq4wtIS8tya68FLcAiF9HUH1rxRST7NMRqeSolDb0VuZZN4Hv3xvp2er6vbV1OTxCqC9xB5RHbvFhz9BExdGMuPX0yiEKf2gaj3cLyccn5jliHPjW1/UuNfV44sAgf+gXj/L6hxMt7lxCL7QYzMvFR0Vo1WcE9/H64QHMSEDmpxm29MiKEHB0eWc9WqOdYFROKGXXtRAoVfz65i aCFNjycD nrFD7bN0h2hZuQ7/6ch1updZMU9tXaGH38pQV6x1AT0b3x15LJwWUEPEs7EcBAkrS22NSN/9FxDW36X3KkAMbbyIg2YoOSwXbUB+/cXjfr9GBj97A2Gr53QxrijBJeF3JC5Us21G+6Zssz1h6EPRaA6lzQoK6GX2s8MVmqeuoZmzR+9Q72Y2n+XB0IVAGUcyZd2nxOIbBIgNW2okah0l2nDtqkVVUTELc2WH+w7TpMiMwmVkWHy6V9/FdLv8uyaXz+pEP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 02, 2024 at 04:13:29PM +0000, Pankaj Raghav (Samsung) wrote: > On Tue, Jul 02, 2024 at 05:42:16PM +0200, Christoph Hellwig wrote: > > On Tue, Jul 02, 2024 at 02:01:23PM +0000, Pankaj Raghav (Samsung) wrote: > > +static int iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, > > > loff_t pos, unsigned len) > > > { > > > struct inode *inode = file_inode(dio->iocb->ki_filp); > > > struct bio *bio; > > > > > > + if (!len) > > > + return 0; > > > /* > > > * Max block size supported is 64k > > > */ > > > - WARN_ON_ONCE(len > ZERO_PAGE_64K_SIZE); > > > + if (len > ZERO_PAGE_64K_SIZE) > > > + return -EINVAL; > > > > The should probably be both WARN_ON_ONCE in addition to the error > > return (and ZERO_PAGE_64K_SIZE really needs to go away..) > > Yes, I will rename it to ZERO_PAGE_SZ_64K as you suggested. No. It needs a symbolic name that doesn't include the actual size. Maybe ZERO_PAGE_IO_MAX. Christoph suggested using SZ_64K to define it, not to include it in the name.