From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C3D2C3064D for ; Tue, 2 Jul 2024 07:37:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C80466B0098; Tue, 2 Jul 2024 03:37:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2FE86B009B; Tue, 2 Jul 2024 03:37:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF7CD6B009E; Tue, 2 Jul 2024 03:37:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8696F6B0098 for ; Tue, 2 Jul 2024 03:37:58 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DB5061A1B9E for ; Tue, 2 Jul 2024 07:37:57 +0000 (UTC) X-FDA: 82294008594.17.9901DDB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 02A99C000E for ; Tue, 2 Jul 2024 07:37:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GCBLdFrj; spf=none (imf22.hostedemail.com: domain of BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719905853; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rxGl+63oN1WDMSTt3tuoEFowmTF6ElvlJY4+FmesakA=; b=moRUDSU8WhGtV5V2+svo9uRo9MSxGPc1dsyeR9bvHy/Puh83enDVRJACvXRTvRnwgF5Pzv j3AfV8LwQoVv0G+/TaaV8YPqSL4rGo3YyOK87TFkHbYTmgHkZT3To/ITVEAEzI8B3b+sSf aB9lVvf5pZmsK9ZfVIUzVVSKn9LGgm0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719905853; a=rsa-sha256; cv=none; b=K4S8w66OuOew5vQOmbmfViu5abcyUgj9vGsoxb3lVohtnHLhu+f2efde/FrOphZZWzibSm 9IjxRYv6Ebqe948dtKlLTErxRzqjMkrQSUXt3vWGdfl2RNTtVAzMgCi8srHxua42CCW5dr NkPVqYPNRR7TtcPYdIv90kofIKDGrMY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GCBLdFrj; spf=none (imf22.hostedemail.com: domain of BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a6dac4ac77a4219ad85f+7618+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rxGl+63oN1WDMSTt3tuoEFowmTF6ElvlJY4+FmesakA=; b=GCBLdFrjfKQdOXAbJDYAUldMcU DSmkwndO1FhRCRFEv30KICrnRNwrFf9kJcEYMqhwqQDtLGuTCsv/XKs1i4qYzbEK4bDB//29ZIl/Z TyUMsccI/iUY5NQUTOrNNQZM0hhSV+5kkoK79H8Po0NcbQPcICCM3GQwh25NRLhmhXCICDRSuyiPq wrFue8viWQOTqL+Fg5JPI4ghXP1YvSA80e3qc0eztth2PFfU/1m0gidDEYPN+n80rPsZURhP7EL1V ZfShbVBnFGywltDR18+pzXwEuIrHk/UYIUMD5W1zc+qOJRqd8wAWe5dbAhyAv/2NL90AXPEqVJLQ0 Xb2L/HoA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOY5D-00000005sux-1EZd; Tue, 02 Jul 2024 07:37:47 +0000 Date: Tue, 2 Jul 2024 00:37:47 -0700 From: Christoph Hellwig To: Jeff Layton Cc: "Darrick J. Wong" , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Chandan Babu R , Theodore Ts'o , Andreas Dilger , Chris Mason , Josef Bacik , David Sterba , Hugh Dickins , Andrew Morton , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 01/10] fs: turn inode ctime fields into a single ktime_t Message-ID: References: <20240626-mgtime-v1-0-a189352d0f8f@kernel.org> <20240626-mgtime-v1-1-a189352d0f8f@kernel.org> <20240701224941.GE612460@frogsfrogsfrogs> <3042db2f803fbc711575ec4f1c4a273912a50904.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3042db2f803fbc711575ec4f1c4a273912a50904.camel@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 1tce4h6h83kz8iud3tyrk7gxw9bxk3g5 X-Rspamd-Queue-Id: 02A99C000E X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719905875-292966 X-HE-Meta: U2FsdGVkX1+niYH0zXbV5qnqHz935G9Q8trZgFKimyt6w6lP0QQOTTdtGPO7HPCBJc7pOZSjClF3zoY+z2WstEv9t1855MpR2BE71ZcCzO0b0eBbO5EzR4IQ90tgMTlhtsicp6FgXxmZuR0PhDhlUHBd2lg/GgWsGetrYxO+ouh8AGyhe7PlK2+kWUu+LHKPzWRjai/WFiddltTWEVIiQ9UWEfOGvEU1t+gHW/af/koPwH2HX95lXuEH7fdmh1/tEdiIs3W8N9B0sxAJJyvOdtVAHdqVw2ZJjPlHMRluZtPbYV4mbpoyE1ue50YOIcmwOE7kOMpjZ88YCVm5T3+A484Tj2RnfwyS83YriP0V0UEwzVKoF8V9F52VrnEUCwJWATWNOiZFqMQguySLTWNPmadakAlz3xd2AD7I72EyitDJgnfK2Sw/G5CDZ4SR5YyFmq9l0B5FuPjs43zLnXz2TRrkewQfCAJja0Bgj9JXBoo/Z5pHwDLjxKplWy+SpvYLvXULcRT/Azk7Y0cu2iP3D9wzJGBnZffN8yyNvtgLQ5O30I/WBr+YkNTAufkHXPK5XBV6nNYRtAx8iT56zJ2YJ9teuuzbXhRf5nCfxXVxLzLXAexJsfvLvG3fipggWdDEcLV/Vf1sFYEoxBuJF5omyF/WmnJ362ZxhlJKo00obg4QZiZHSq2BQ0QZ6uoxs9SMK7lEi0/XNp6+dA3gIM1nOh3sz1sV8DLoBA0svf7w+4pSIPHxQhKuQthsfHbZ1sb1DC9Qff2Wv9WfLS7BAKvSoZMHSKsM2YMEU+Jt9woQp2Y1eFyLm7yFY5U7IupkgHuNUQQloZtz8U6GcAaR+m+930YsmDMKmmmtn5/m6wdnoRRZ5jW/fChMFSZ+1g1LvG6igxlReJhtGekXmMCUTGcntJZ+AoAjLS/hOgBnXaiftR+gCtYsh8qCtw8989AMRZn0siwGHDc21Kpn03eHxCC xblwCWVt eP3bKelgbqkIb4kUzIVvhsYXhP3VnEDg/Bww9o4QzngEIC66HJroMxmRsFll9EqILgUFH7+H7jANgp9HM4Pu/O1L49Xq8/RanfHirK19D0ituesF0sKFJs/OGt99MDuxE+elcZ16zo3ZH4i9o0xKpJHuAGkOhfhVMuSLon1JJtl+2wxJZIhObWm8UKgo35YO7GUHRC5fT3uoJI9XU7ZhMEuOiTRbsHjVuJgeQri6dVJZLSd3PVboXHITlELTltRlpu4j9YlJyEu7Kt6LY/fWBElELlw8Ce9WeyS7RGxOj/BH1bEfg8vH376w5Xob5aw6O4RNCd3Icp0BscQE47sXMQRdsJmPE82ruplXIFxBflaMcCoYfLZBuuytfObSfTawS3pvwhYjQxRxTzTcBv8BBEAYnNaBrtx1FCgTPEoU9ZCzmS6CKVDHAG/iBCJobnUzq6Sbf+1s7NVhsrLsancoiOsi0JpcTN18ovpz01mAYCRQGy4EugfmCh6CFM7lNyXWle2V02pn3OFlCF1OtcHloCkZLjw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 01, 2024 at 08:22:07PM -0400, Jeff Layton wrote: > 2) the filesystem has been altered (fuzzing? deliberate doctoring?). > > None of these seem like legitimate use cases so I'm arguing that we > shouldn't worry about them. Not worry seems like the wrong answer here. Either we decide they are legitimate enough and we preserve them, or we decide they are bogus and refuse reading the inode. But we'll need to consciously deal with the case.