From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97A3BC3065A for ; Mon, 1 Jul 2024 04:24:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE6536B0083; Mon, 1 Jul 2024 00:24:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C96946B0089; Mon, 1 Jul 2024 00:24:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B36106B008A; Mon, 1 Jul 2024 00:24:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 955906B0083 for ; Mon, 1 Jul 2024 00:24:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 02BB24190B for ; Mon, 1 Jul 2024 04:24:42 +0000 (UTC) X-FDA: 82289892846.11.C360E10 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf05.hostedemail.com (Postfix) with ESMTP id 0E239100004 for ; Mon, 1 Jul 2024 04:24:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=tqsisg0F; spf=pass (imf05.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719807860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q8FaXxeW49XxQjIVoOOnJuKPW6Isofg2ljkc7tdAOtU=; b=hg3iE/fIUI5JUxmFumqT+cUw7kSV0vGWGAr6/B6a2CUeTCBqvU7A/BNI/lRAL32oUHVBux DSTxyMjnwwWWDIJDlREpolwTUcgZKuBYSC0+jP+uMZjowf8o8N8XiMg5xQ8SoG1kogAK4g MUVcgZq7U2VmeMuHVENVfQMNNUTWbEQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719807860; a=rsa-sha256; cv=none; b=65eYxjZG/k61/9jmMsioIVoHo84w3sMeeSJuEpZ4WnlE7pCo41jM7+0vYySFqWO5YX35xs W3BziJFm7IerfxhW7toUidF+cGvxvJd7BopQKmfeyT+vs1heCemxfuZEln1/NKl+K5JcnJ cI3fxOgsmLrAwxfyiqHmzQYKliswdzI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=tqsisg0F; spf=pass (imf05.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1fab03d2f23so16706305ad.0 for ; Sun, 30 Jun 2024 21:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1719807880; x=1720412680; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q8FaXxeW49XxQjIVoOOnJuKPW6Isofg2ljkc7tdAOtU=; b=tqsisg0Fl1g+A8fr4OsJQfrrUEp5J5sSoghPkp1F6iBA2Q7yDp9dgCx1IdBTBR8tX6 /8UhZGVtDG4Qr/ZCzU33tt1uMFbPWPOZ56Ue2HqXjlp8WrYFWB53pxGrCLMR5/bNqh4m lMU8cabhsD/2jI4iLlxWsPIGmAZIszRZYr/fdte5zyqqYLLc8eKxdpogOHOj4t+u+DM8 cAdIPwsT67KkY1GlYLmBNMi3I1jqm5dmt2j2ALzwxDVGZxbVyw3NMmRmqXLFZaa0bY2T vM1N2WvjTBteqEdpMgc8fQayjt1GyW7cIdmbcrCBJSz8n5JjRV5BXIxZEWjxbj/gJh9Q l8JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719807880; x=1720412680; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q8FaXxeW49XxQjIVoOOnJuKPW6Isofg2ljkc7tdAOtU=; b=aQ3bsemipOLU6lBwagmlLbbdGeGI4S8b5HV++x0pPD0oDeT3zlrtzjvXN9heQ3jEwj G6b1fIkcQP9kb5bI6UjNSgzdwjOUA4KuOPawP6VDcIAfemt0Z5v7WBpDdvhooGd67C02 4ShhbZZ/VQrpVuBTUf9n+YEJ4VpsMkJ87O7tWK6UIaJ7Orha6xewuraEMN7H2BdfPy1k zh8iTbS3Z+Ae/ZG3E2aCJ/YmWCfAMN9ctA0AoVFQB7/wXWsGbb3r6YiMZE+oZoaYcTmd D5uYqx11LEvVERmdVlmCHKF6Ze6eF8waBHlY97gMlZCfva8qbrnPnSO9p+tVmP3JyyvO ugNw== X-Forwarded-Encrypted: i=1; AJvYcCUYvCXN5x+HoKCHhu4ypxvK4678af7alY3fSLWMwz2C+V3vQLVAOYzR3GZULMYc3kIslc3YDxk6tFi7wxNxvK0Tdn4= X-Gm-Message-State: AOJu0YzR0UBQ4taYCW1oRC3ZPiQOHvNrd2LRmkeBVdDsNhn+oGhKkCVv 41yrGzrfA0MFgWO33BfXDX5DnBSedOWizINYyFZEPk3kOQ4g6wM6Fwd6SnJIkp4= X-Google-Smtp-Source: AGHT+IFKQ7mlIRHK3qLypxLI+wB6C/xuRboouR5zOv5/KrFwuLBxwDWk/1+R28Hzvt5tq0xC0UW+Zw== X-Received: by 2002:a17:902:d2cc:b0:1fa:2d0:f85b with SMTP id d9443c01a7336-1fadbce9d59mr26040185ad.49.1719807879574; Sun, 30 Jun 2024 21:24:39 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac1569051sm53926215ad.215.2024.06.30.21.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jun 2024 21:24:39 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sO8ai-00HWNB-2Q; Mon, 01 Jul 2024 14:24:36 +1000 Date: Mon, 1 Jul 2024 14:24:36 +1000 From: Dave Chinner To: Alistair Popple Cc: dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de Subject: Re: [PATCH 00/13] fs/dax: Fix FS DAX page reference counts Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0E239100004 X-Stat-Signature: kdb3dwdoske6681frebapudk7ekaikh1 X-HE-Tag: 1719807880-158862 X-HE-Meta: U2FsdGVkX1/yTWnrV6bhcwoDyPEm9SyjCNcQxcn5i3+5c6BwpU2G11llgr5w282ndsD0HLgefL94XnMRmsSbIwa1Nk/QmfiK728MAwW6TIJb1UkJtD2gtkcKeBAVA6Nel2VizCOndddRriLJG9cFkI20bTWkcxd7Ykk1P/DEVCv+khaR5UMQjIcOE/Ekv2Pg6a7Ofw1taXzGafj/JggJE01F+lf/Q7MQ+zLpRZoh/XUTxAAiJWM123wwdP36Tw8Kf4Gr9rXA0uoEUHQqjRovHeN4Q3d4+wtFav4th0cbluoTDmwR9WaX/Mvlkgq+xQJQHNa7WdXJ+GnkUw0/H4MT5rpRLRAxPLCGxBmeZ7PS8r6LOCjpWpHZEgAoeYIU5nIiWpjBmdKo372HGMsTc6gMryAHAl82MqLc7EFXNu2U2a6njJD044WgXb7X64mwMpvM0cYuPWR0u559CZFDXufK9ioKrqAixt3C6BBzkHqYHcUWKCTBFPhaFQCcXrGOHNJoKWObzojW5lC/SqowHlT+Ye2AvJlVBGUXMF7+sgQYo0Pp0BNoRztELtl2vOcHaeAFbvzHDyg9pQjB1836mk8JEjsNiL17/taHp1zTPv3wxwNjyZpHJlSxXRNjzMD3l8LMFsdPoHOuXnYChGtV9gvVbO9lrwPnP4b2di+GVKeOkta13/K0hec+WiKhqAzbeUyhPgbACSfxqWMa5EJPZ7QIu4rzNZQ0ixTP/iEHY2QEj2XhEoG0rsZZ8WbWuulIOpoI7Z/HAyDxj9Pg4Y72YglJLqVnon8zSDHDLTSAL9bee/7clqi/ysqnDQSdwvoie1rRUKaBkUJ5N5owFTNzApw6CqOz7+W3sKv37ztx3uaS0uDEe45OEQZW27oKk2MhoUnycEyq9r5NPWKPJhRWmj4IZCYYHoXDl5rxoPmkb+XdpTYknxGb56kigikMMVMpLqjFUunrNRj8JkZURGH4rqs 1WJPQ9Pg USFTsgdfQYT/ic0EuKVHCXjWop5Zbftn2sy4S3+4UFTu6J9UMUiJw+TxJKSDUKD0zsq0vcHjy0sRbUs61DtVJHRsD0BH/tyBLjI1g6RojESCLUppvsJT2o4UPEsZRLnEjL/p5D4utLJ6KSMaiBwJtN9U25L3IBidxFNs7jkfAz2zxb6+Ez6TSmRLeSCrxYSP45XyaBdbXxOdIOYXsBD5GZdbAoc70NtbM+eCxwat31/lm021RK3KmluXf3qULb2yBR+eL9B+ulKGjm3kpiLyha5UShoJYnnwJqDjzMyVX0ZauDuhnsiyPuPshdq9veYteZLGzSkluvFM9nFTr+0dbO/+ki6ZmbQNmtDenB/IgFNLpP8XGyoPjmRckE3YIwA/hLdZ8/QY1RnmO/sg6MLZWxwawzW7wrzUZpqjD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 27, 2024 at 10:54:15AM +1000, Alistair Popple wrote: > FS DAX pages have always maintained their own page reference counts > without following the normal rules for page reference counting. In > particular pages are considered free when the refcount hits one rather > than zero and refcounts are not added when mapping the page. > > Tracking this requires special PTE bits (PTE_DEVMAP) and a secondary > mechanism for allowing GUP to hold references on the page (see > get_dev_pagemap). However there doesn't seem to be any reason why FS > DAX pages need their own reference counting scheme. > > By treating the refcounts on these pages the same way as normal pages > we can remove a lot of special checks. In particular pXd_trans_huge() > becomes the same as pXd_leaf(), although I haven't made that change > here. It also frees up a valuable SW define PTE bit on architectures > that have devmap PTE bits defined. > > It also almost certainly allows further clean-up of the devmap managed > functions, but I have left that as a future improvment. > > This is an update to the original RFC rebased onto v6.10-rc5. Unlike > the original RFC it passes the same number of ndctl test suite > (https://github.com/pmem/ndctl) tests as my current development > environment does without these patches. I strongly suggest running fstests on pmem devices with '-o dax=always' mount options to get much more comprehensive fsdax test coverage. That exercises a lot of the weird mmap corner cases that cause problems so it would be good to actually test that nothing new got broken in FSDAX by this patchset. -Dave. -- Dave Chinner david@fromorbit.com