From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C00F8C27C4F for ; Mon, 1 Jul 2024 02:34:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F8546B0099; Sun, 30 Jun 2024 22:34:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CF4A6B009A; Sun, 30 Jun 2024 22:34:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 396776B009B; Sun, 30 Jun 2024 22:34:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1948B6B0099 for ; Sun, 30 Jun 2024 22:34:41 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CDE2A80943 for ; Mon, 1 Jul 2024 02:34:40 +0000 (UTC) X-FDA: 82289615520.06.66337AD Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf22.hostedemail.com (Postfix) with ESMTP id EAE6BC0007 for ; Mon, 1 Jul 2024 02:34:38 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=wDysCvGq; spf=pass (imf22.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719801267; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DDgWV/1M0ZHGACEenRn+Ob+1qKeNo9iohlOwDr3DlCI=; b=OPzznC8uVOK7/LK/tDEkdTSDP3ikSUyqQwClfhaq1RduaJO0x1X+qOa6OrGaqv2VfXUsAU /OHt8RKmU0QKMKCI46Mi85dYaqocgzPdmecTJV3hV8U4eWYmumeaN261BgHIKo0DmqOr9T ozQ7fCEQDHaV2ojtBRHbY79G0jPs44g= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=wDysCvGq; spf=pass (imf22.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719801267; a=rsa-sha256; cv=none; b=PjZM/bp9HLohsgp9YV+fTiMVK7tRIgRmZ86FLKQeVZd93UCcFSfdrhfUpK2kTgYPUyxWzu lhRz7F4DU5UQBKVUSmXbdjD6UoGLSa8E1twc4GSjscP6LiaDvaqvphfd3pJAxpwCN7K5jB yIVqUjdNr6/PIubW7rdsM6uW9Jg5RvE= Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-701fb69e406so925299a34.3 for ; Sun, 30 Jun 2024 19:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1719801278; x=1720406078; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DDgWV/1M0ZHGACEenRn+Ob+1qKeNo9iohlOwDr3DlCI=; b=wDysCvGqVgKCal003lw2Vm99GJedqAziLmbTuW96n1oyBQNMdCv2jErr1SLuTddU79 PpwM1a8EBSCsKqGUn6FSRhDZmRICbfkKTQa+lbEH/A15YrIJsSKjXomPRzIMqLkGgD+g uDV0tzUkNytDd9cl+91P0xAp6A3+NKzLn2/DcwJ8JNc4O+/8kwfyqqM1VVzts4u2CTa0 RmYMgjs5KrAh0tWs3ZWBLDyxLeN/FSGCl+5O9JZYEDTT8VuEeHr0CJdRggNdPWKuucrD wMV/EewQzlb8XLu3+pZ7kyS1UPgd8quVkedcGFnmQ5p13MW0jIbVv2izfd/vEl0jegYT /zBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719801278; x=1720406078; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DDgWV/1M0ZHGACEenRn+Ob+1qKeNo9iohlOwDr3DlCI=; b=gsVmtQ60hKJRY8caPc4NabT4OM+KhxMnCsTXC78TjFpGHqz2Hzy1gbqDYzv8vUfsfL udEMfebtwMmfxrpjRg7ySVGBXml8GdeIR+mXLwjcuqwF8oeIY9+geaLOZwkKveMNpCdy iwsqRFyHSToLGaiGgblNOJISJg/o/NU4WQZFriVQLs/pS/RF00iCo+iX4mf8ozl7k/Pe c2T5GeSeCd5mVvKIDsCOQFJu9NK3jhBPntGjIo4tWsk4X8GEoUYFmzieY8/4QXjBPUHx R8EgMHaWBtC4di7kfJVGa44WFKjAf6rAx9TyElLonHCPg7LEuP/+2STNboNF5kqSnCpI 4R+Q== X-Forwarded-Encrypted: i=1; AJvYcCXpYeE29QKCOnjSK72f3vI6Ipl03r8FXDE09udTGOpCH/6eh03IKH4CZ7RkjV4Rpph1tSO0g9rLnMOmmW6sF4gnEFw= X-Gm-Message-State: AOJu0YxXltf3JKOEzQ5yN19STs9QeKX86/djf3uJ+jG7xQtZC1mgBrGV aaX9ylvEUcFHCAHQenKjO9SK9b8+669FPGrvWi0nKAV/EMEkXnhhXXN+WDfGoP4= X-Google-Smtp-Source: AGHT+IGgOd34C7aRGMh1d04uXW7hNhMkkm6eNwIGWoMV3VIS98zXVTuuNpmdYFB3rotkj3bxL+qTug== X-Received: by 2002:a05:6358:78c:b0:1a6:7af3:22ca with SMTP id e5c5f4694b2df-1a6acefbf70mr99620155d.32.1719801277568; Sun, 30 Jun 2024 19:34:37 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6b0adfb1sm3536332a12.44.2024.06.30.19.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jun 2024 19:34:37 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sO6sE-00HR0O-37; Mon, 01 Jul 2024 12:34:34 +1000 Date: Mon, 1 Jul 2024 12:34:34 +1000 From: Dave Chinner To: "Pankaj Raghav (Samsung)" Cc: willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, Zi Yan Subject: Re: [PATCH v8 10/10] xfs: enable block size larger than page size support Message-ID: References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-11-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625114420.719014-11-kernel@pankajraghav.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: EAE6BC0007 X-Stat-Signature: 7tt435jku1xi931ktiskcx677fy7sp9q X-Rspam-User: X-HE-Tag: 1719801278-447574 X-HE-Meta: U2FsdGVkX19adST5exIqnx2nC0WM2/mH6Rt0+ktqKy36TU5Et5Ot0Yyoaxgokjgz72bJqBtolJHSoGhATl0j+UsrnRvwkuNcN43UyhZwARR5Q2FdYZcrqnsx9V8sf9wFfakn0QKS0+1UB7D1UVNMAfVU0z40mSuAo2ZVWZ1kzjNHsD+LtEgmxXo/6i9xv68fLCfoQtckGWmz2DuUAtKTBzqoXqyxCqIOALoI8fkd0a9B8uDSNjohlP1hYVW57OUjvd57r3EdWoeHaD7RBwQ2r+dTPTeUNfgPt+mlh7Dy+p0Npv0vVMEV6bzXaNrvrIGYhXh7VEeFhnAotbS73ySbIGAMKxRTd8WqHBxa0liILimg55gBz72SLMZxyEor7Ul9HILQacNGIkAYl7GTfnrx1cts2qlpnxaGU/D3OLYS0n68pKdO6E53ru8Riwuo4EO44qLbAy7QvEOyjFMorH1YQ/vT1NhO9+YT8Ydf/sL9DiGphtNPqgiEV1h4zX691V/GLrbE45FGOUxV8mrAkVTLfjEw9Aq9I85yfOuAcfpr//v056TmedLT+GdMzPlsVA9lbM8TUx/bPE4uhl0wwCMCACYFmoPp3lwt8H+PGO4oY/yZ+ww2mqakpLP+eFxI8QjrKdL9lqKycUIJCihCTLVXnN38yUwIN08tI+rS9FFZXhNaXSpAq2RJDx3z68vNLCYQYZTUJOZ6eJXAcaktKCjjTBtmJM/ek6zF0amko3Bu+okXfiStgPp23w2Haxu914YUjiCLud6ssmK1BRCvVBadytsxekzKucVUpu7aONR5k+JjlYX97d74aH/QcXSR1Y9+vVVm+pPyTgub5nRIwfHf2GBaLSybNHKtbZewOiWarQcMKzus1hfgibwF2SHTs7T8BMPw0ra7YtN2zpTtzKZ3zohyjrpq1biUcvoh2NUBnV3+gVLeggEC+AUPNGJpQRjBoI0Wbr4mdPIv0xRMELA tFnkJ7Ko vTjb5E1kpc1bEysV/YepjBT356VMovGGg9xaY4Q+VhAAZQCAf1e5o64uzprVWufT0ByEBltyyNNo0V7WMYoZGNVnX0gG8w8HjBuiRmCelIcC1lGeBtolyJ+xpJpLVXKyDo+962Me75N1cTltvlyRPjkzVoGLK6e/orPwI/xXVjkW4StPMWGVQegB8oFY4/RKXU0dHTum3m722jsYAAeBcNE5KDJYK3TYqYEeXZpuNzH3ygH4enBrJWy/gHHRGxZCdEdKMNAfovSPiKe/b89p3KbuZuVpAhg5BwVCgEf7Xq8HLXhrXl2GnMEL1k5ua/ON1Zqj0qkZaJ0ojnpp8ilrnpZ1P0X5ouxcmZRD94mG+0HEXDgqBuQ3RFXsNtZ0qIKjQSeAcI52QJ4YYWKsnVKuB+Fm/yLw6pGIOoKcsByNLK5Gx/RUzOoiHPi6kHKITQHU61VTv8nYn+D3K4clCN9c+UTvHdXgaTRWEp1p+YjoQLqjgSDxV+t6lEY+Zow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 11:44:20AM +0000, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > Page cache now has the ability to have a minimum order when allocating > a folio which is a prerequisite to add support for block size > page > size. > > Reviewed-by: Darrick J. Wong > Signed-off-by: Luis Chamberlain > Signed-off-by: Pankaj Raghav > --- > @hch and @Dave I have retained the min_folio_order to be in the inode > struct as the discussion about moving this to xfs_mount is still open. > > fs/xfs/libxfs/xfs_ialloc.c | 5 +++++ > fs/xfs/libxfs/xfs_shared.h | 3 +++ > fs/xfs/xfs_icache.c | 6 ++++-- > fs/xfs/xfs_mount.c | 1 - > fs/xfs/xfs_super.c | 18 ++++++++++-------- > 5 files changed, 22 insertions(+), 11 deletions(-) all looks fine to me. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com