From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2D4DC27C4F for ; Mon, 1 Jul 2024 02:33:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 211A66B0089; Sun, 30 Jun 2024 22:33:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C0ED6B008A; Sun, 30 Jun 2024 22:33:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0882A6B0095; Sun, 30 Jun 2024 22:33:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E108A6B0089 for ; Sun, 30 Jun 2024 22:33:50 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6619F1C1003 for ; Mon, 1 Jul 2024 02:33:50 +0000 (UTC) X-FDA: 82289613420.21.6C24EF1 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf20.hostedemail.com (Postfix) with ESMTP id 7CBAD1C0006 for ; Mon, 1 Jul 2024 02:33:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b="xDhPvHr/"; spf=pass (imf20.hostedemail.com: domain of david@fromorbit.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719801217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rAT5VJO6josRz7Xd2YJx3BcgEAz55TMwlzh28Gf/4Kc=; b=bQXbMy+nBRU0rdXGbE82YgvGFK1/WD2zhqLQPYDH1n6sIkwnM+rJcBe5AlpduXLOfLGUUT +HBQYKICQ9xgCCL++xQ2xcQrGBb5swaQ6iR6ouJKVH74EVNkYlGBezznhA/M7IuWt7M+U7 LRsf/1l0zIRaMLio42r1I7yv9VZhPm4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b="xDhPvHr/"; spf=pass (imf20.hostedemail.com: domain of david@fromorbit.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719801217; a=rsa-sha256; cv=none; b=iixo8K3SzWMDkxI0nLhuppnujZPsZ7DLgQ5AJ6OrD8n2aX4vA4FkqAiv/h0XsOH4YuDinV xWmgbzDobNpma+4hRE3p5ntZ8er1I1XJ5B604m395qVdkV6NWYUkYemDhhCF3sbmS6r1ym BCSFMll9nT22dlnTsQJPIQrMyhWy9kQ= Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-e036eabc97dso1179236276.3 for ; Sun, 30 Jun 2024 19:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1719801226; x=1720406026; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rAT5VJO6josRz7Xd2YJx3BcgEAz55TMwlzh28Gf/4Kc=; b=xDhPvHr/vEz59V7gpJpsK31ft93ktG0C47aHaMH5JjnV0cRXxaVklambX7pBkkqjlv RvRrylQQU1Z5elyUk4MRU6/lgO6m/H7GxSkTxEBXpMHDRZB2taVjh+vV/4M34K0sc3r/ 5kASFyiWy40LIGBTemZRCtjPSsU0ZZ98VWiILsfb3cBiUy9d1Ht3p2mu9HyH5qFbD4j9 MEsyJDg7uCDz8rG58IgFHfeIiL/D8X0MG6MI9iTuO6IfDr0l8DZ+hyhOQXLTUOi/9Ocq q+n4oy2jF/Qly2TFEtfWH6bVpb3y+g2ErgJopg75Eiw4cTgSdUYrsKeNMPQfGwFEpART RqrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719801226; x=1720406026; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rAT5VJO6josRz7Xd2YJx3BcgEAz55TMwlzh28Gf/4Kc=; b=batpEZZorV6tQhYOt9eu0TAb7bhRJie6CE0ahIy/okp4K6ZxMI30QyFO0sTkD/Vh/g NeSyNJGYP9N4cbES7i49g0ew2gX2ViYXnUM6FxmoKbJCFIMK2qLaq3LGX9KSyQg9feuF ZKpbtCtomHhoqcadZiNJPwXudwzEGhI4oezs63YwvRaWKf+uNrwEg7jAk/IS0b59H+E7 xIE5f0UOiM2+ZK0ieomcsce8TYan7A7+aDAGG1UycnsCoGxwZFc27rYAnW2fpVi6en+e +UxKWplhM0IhOx0eV+XFpbClpA2ng+Uqo5z5hHjjBvWFWCPNaEv3t89mMWcTlBMsblON 7Ong== X-Forwarded-Encrypted: i=1; AJvYcCV4/TUTTrZWGq8aIgXeRcNU2k1v3r8Cn218L8j3+FYj4rFEkgmpNhH1v0OnL++NZ9GjrRQs+jn7jrMz1SsrI7tpwlU= X-Gm-Message-State: AOJu0YzBIB4EDr9vvWjv/mbGsAGMGfUC/4VtvBInR/QcotIJV00oQZgg h+buw1YUBo0rCu4txSLYPqMl++9cqKnVFmAeX9Tu0z0b4iUnMtFlnPDDOnuWrdU= X-Google-Smtp-Source: AGHT+IFPkkSrPPqv4X4aSJd3e/zTZRULT6hsrrhdjadbuvfh9lj4wv9ZexQEyZCPWxG2Sz5avisCCw== X-Received: by 2002:a25:c307:0:b0:dfd:b3bb:ac11 with SMTP id 3f1490d57ef6-e036ec8b54bmr4805340276.59.1719801226290; Sun, 30 Jun 2024 19:33:46 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-72c6a31b463sm4237653a12.21.2024.06.30.19.33.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jun 2024 19:33:45 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sO6rP-00HQxp-12; Mon, 01 Jul 2024 12:33:43 +1000 Date: Mon, 1 Jul 2024 12:33:43 +1000 From: Dave Chinner To: "Pankaj Raghav (Samsung)" Cc: willy@infradead.org, chandan.babu@oracle.com, djwong@kernel.org, brauner@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, yang@os.amperecomputing.com, linux-mm@kvack.org, john.g.garry@oracle.com, linux-fsdevel@vger.kernel.org, hare@suse.de, p.raghav@samsung.com, mcgrof@kernel.org, gost.dev@samsung.com, cl@os.amperecomputing.com, linux-xfs@vger.kernel.org, hch@lst.de, Zi Yan Subject: Re: [PATCH v8 08/10] xfs: expose block size in stat Message-ID: References: <20240625114420.719014-1-kernel@pankajraghav.com> <20240625114420.719014-9-kernel@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625114420.719014-9-kernel@pankajraghav.com> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 7CBAD1C0006 X-Stat-Signature: 55gjebj4n9cu3f39f1gi1bshbjc37had X-HE-Tag: 1719801227-603200 X-HE-Meta: U2FsdGVkX1/MrlA48egJtis4rZmO9DtBg4iIWHjnVV7I0q8iQ0WCAf9by+LZOjJeySwKvw5ck232Xli65dTkLPRbsPm4/bdmwgASe55u6lbWU91cFGDHLgIpG6WA0FlIdor4fSyewsklr/hUt0CY1MzQztZOdChDdYLJzJw1Bwv+OmVddXAhnR0HKfGK8+xkyvB5aqH+OegCdvknhBQZ3YGeBgymtyevD86XPRGu2bNq8LfmNGZlNrIC+zpbEUZ/sqrZ45zBw+XtsFne4136eV5uB9PebTQ46mxrroBPZvLtqBr2Ylzqv87bKP6jqObAWHvxLGU+tawBMfx5f8IEb+fWVvsew2Uq6dzSwxdsMKlYkhnkdpbnX+OY94SPWYEnbeG2ldHPvWvoy5Gn5J3HRqBSbkgAlpfb/EXun2NYnSvo+yaDfiRbuz/L/watC+PR4fXXDOt15yTPOhglGpPEA0KD+VAbSI9hQPGzs8MfoQAzn8hFAM00RB+beO+Lhgkx9I/QnsX0D+Ewbk1jj80j2YGvaJDMbRG8ScEhfqbVH9bNXw3HvqHmxmirIT1CElY94Y9YuTCiFPgWJ3cfSmLhP8NMHHe4ARYFM+Q3GI5wwfvQOA8+nikmdSQiabfxlXU9TizcCpmUZtl5lkUkR6u+j9i7K+nxs1FHo+Zq/Cw0z5VCUz7y2mp1Wxtc1FdDQKLFY/GUDkIMd06LrJagfGGkdlFfd+qZVKPhz1Dednr0tXWgsDByaG03g7Kl9hzBsguA6RL+pZkY/jjcGlHilazwPdXB2slgYB1ICy6PGS6fvnolQV+rV2V+nlnlABeIzTg86KDjl1tXewo5z2TpShXLpiroDsDGhIupBGqo5H6GIaEyb5GpoRnwdkTlIkbtxZYzC/Y96QppXoRubd60KqdHZ6UbfefjFElBAnvH3WEIv7pP0P4zuE0iVOms8RUdGwHRR080cXSOnMC9rO7IG5V RZ/ImFtc tR52jeAZOq4hTn+KkbFzbnrKO8oZDNYJJ1PYlBFoTx2+gU/jNQhynb0yptqqVzQN+0iav7mGugcETA7b5Djl0AzL2LhSt10jhC5+Z+Q1pOBHftS2f6GZ2J4nV+ixohS6fYH8aOWyk/beV/aTB6KZZ/MrBXWb7ZBVKaagyy5rLOLa88Yj/eW36z46adi1bcHdCGr77hhAI9JOz7KFWgeLIqIWIEvld8YrDODczyS1sLbxnHwyc9hKnrdl0S3GBCwzfNtSw2ifV9tUQU4VFj/PI8v0IebKpEp01wh7w635ePDP/9siGbYolCENww68usFr7avBIFDRnb7J5zpYzbMCcvITkOXQ4f3tNJr1iw5c9OkGhDkCuoXkTq4OkQMk8RSPJiuU72KpWURQh8/Nz/AckCVt3sI0DKRe865PucJ+zYbwzqtt8na23mqGwKrCnQbS1rdMxloHRuAFoM48/fG6/p13tTvPiNg/56dewWsl4kskcX7mdC0TAbQ5RIsBVH6Rnd4GshRXHqEYpvnZc+Xow9v7Rs0v13URuRjQwlpvkaAFJZxPB0NgYPHTefg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 11:44:18AM +0000, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > For block size larger than page size, the unit of efficient IO is > the block size, not the page size. Leaving stat() to report > PAGE_SIZE as the block size causes test programs like fsx to issue > illegal ranges for operations that require block size alignment > (e.g. fallocate() insert range). Hence update the preferred IO size > to reflect the block size in this case. > > This change is based on a patch originally from Dave Chinner.[1] > > [1] https://lwn.net/ml/linux-fsdevel/20181107063127.3902-16-david@fromorbit.com/ > > Reviewed-by: Darrick J. Wong > Signed-off-by: Luis Chamberlain > Signed-off-by: Pankaj Raghav > --- > fs/xfs/xfs_iops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > index a00dcbc77e12..da5c13150315 100644 > --- a/fs/xfs/xfs_iops.c > +++ b/fs/xfs/xfs_iops.c > @@ -562,7 +562,7 @@ xfs_stat_blksize( > return 1U << mp->m_allocsize_log; > } > > - return PAGE_SIZE; > + return max_t(uint32_t, PAGE_SIZE, mp->m_sb.sb_blocksize); > } Looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com