From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C28EBC27C4F for ; Sun, 30 Jun 2024 20:42:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F3296B0085; Sun, 30 Jun 2024 16:42:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37C0B6B0088; Sun, 30 Jun 2024 16:42:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21D0D6B0089; Sun, 30 Jun 2024 16:42:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 02FC86B0085 for ; Sun, 30 Jun 2024 16:42:54 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A6E07140A8A for ; Sun, 30 Jun 2024 20:42:54 +0000 (UTC) X-FDA: 82288729068.17.B74948A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 7C01420012 for ; Sun, 30 Jun 2024 20:42:51 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eZxNcw+n; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719780149; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EEDwXxAH5hVi2e+sIf29tXbBOc6lcXR1V9m+i/ZIVgk=; b=FgJ6iVrCgRJ8IoAaaBLNS9b+H4CxXK1a8bgrau1t3ksJFyLwvd5EpkMWdoes2KRT908256 cYvo0QPDG/5KCPfBgghsvvoHK43jsgxF1J2TWthlHvSXwDfVANmAHTkPpllLkvotpnTZZy 36toILA8eDp0Cs6xLUi7Ydzz7EyIbVU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719780149; a=rsa-sha256; cv=none; b=D37Tgsb63Lp2gzX2F89Bf2VXd5EBi/zLznPTZq5du+7pO6Qghyakvz23FymzSi3ScKjg12 mV0LX7+7bPxW8FfcVcjL6H7n5eKD3sjBN/fPqvrUg9GF0mE0avOBm64OX+dzldq2B6gfcq VsM26iT+QEuFI0CYlRsNtqCJVwPjQu8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eZxNcw+n; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=none (imf03.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EEDwXxAH5hVi2e+sIf29tXbBOc6lcXR1V9m+i/ZIVgk=; b=eZxNcw+nVHspGGMuJkgfHQVEZ/ 8az/MqFP0jxI74bWxKIIGEXOAnT6kwPgjqLpDaWkQJJ94nCgz+WU5v3vtsMPbDgwbzSKICEDLIaYm 7Gel/IKa3PZuCG6Zp9nN+6a2eEeUV/H/TLx+Qdb7IQbOpSFH5w6aAb9W1YVHUxJ3YSxqBZ4zqkMJq 85Oq+A/CZNCfqbuaQjkNMSRXi7UWnsLkrjsYXiOZrnBfuxFiCzdzFEYHzW8k6qCtCrrTxv36pptGl pBKNbL/cviJBFEt11Sj+mDCcJUGue8hEHHsvw+6dO+xmFWmaJf8RV1/VsZ7f9NpsOwjcb8UuYrCsh HzCmlHWQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sO1Nl-000000011Fu-2N7w; Sun, 30 Jun 2024 20:42:45 +0000 Date: Sun, 30 Jun 2024 13:42:45 -0700 From: Luis Chamberlain To: Christoph Hellwig Cc: martin.petersen@oracle.com, ebiggers@google.com, p.raghav@samsung.com, hare@suse.de, kbusch@kernel.org, david@fromorbit.com, neilb@suse.de, gost.dev@samsung.com, linux-block@vger.kernel.org, linux-mm@kvack.org, patches@lists.linux.dev Subject: Re: [RFC] bdev: use bdev_io_min() for statx DIO min IO Message-ID: References: <20240628212350.3577766-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7C01420012 X-Stat-Signature: aafturtm9cnna7c93ccbs9n7drz1pa4w X-Rspam-User: X-HE-Tag: 1719780171-281066 X-HE-Meta: U2FsdGVkX1+UdBAQMHTZdtqvzCP/QyTG8+pJtzQjDUUU3vdoJXpCWQ0vRUYdjMK5gCMYXREigQEAH8CMcy3ZaZy+Z6nGJbWExeGDQU0y/E4g9OoMdgDaHEZ23fEAlLoIoJ66vXsiPbpoWFw+ZpUWL0MtY1zo8n/6rccbfabvQEEQ72Y4JWXtX+cdJgd4+DE7hOY4Nl2KWv3VsSCdJ8rVcrsKxl7dUU3kQgzTaWSn7hZZi5wTrk6RnaOUSCC4pAEPYSu9+MslkuvsoMC0W9lzKEmAynTmsDN8AAkyqSEDOoM+sU8xs6DzpF2HT6LjNDYLob8s4+AHxXYs4wMSmN/djPaSK58vnTOmLgsGClVoXhgNzE8Uk9EiZQkcmQrTPTDdEYHvDd1f5nJ+LOK4dSrrSmlrQuLG9N/CipA8065LE1TJNexyGMKPUptmBHh5mf6tjUhhDldryll5T3UnHnA4dZdzMwBrZCc0JNsC5QLfrVsz0tMtusZeS2EU2WvQB8rGIr4pJTcInib+wvVRdseHHH74P8z7ALL4k3MohqkzcSeM++0O8qyeMVc8O/QyzWHPEu6DZbS0e1NB1XCitZ/VpsEf568M77cyMKZASjj1NNZ7HF7bpzcK+qihy6SvOybVtjWeG1tq1obZGTaregAdBkcX+ded9IDXfciAjF6bY/CpC/QQpOgSq0IEp8L+/t3C011YyoB5YKwQ3TfhY/BImC2D7PmESH2euh7KXwz8z4R1GS0ng/ZxHYcpD23jaTEmEVWTq/u/8derEK8K1NxdRoBXzg7Q3GhSEWGidCW7G9xRc14Lwl5p3eIWmxJNUg9gc4BqQPyY0oNiHZnZp5yQwgVnkouXkUKHMKAtnjzQ69oWhz50NX9Pnu8IkqJRn4s8RXYpo6QaRt1e3gZFukpNebzG7TbBxE6Ih662OvfT1YNIwLIqT4WzoDlC0NHZsIVNuBwrpU2uISnotjfP+5D RJSYFa6R Q+b9IF0xGXwhh0nSJJOwp9+uzWCAv6668nT/USGh/bf4KtMJg6dsH8bra6EmvqMujsB3gFgWT/fOqL7hqnc/TnFuN4J3Y6IqP5L7LKqcAg8oJFlrX2eeEnS/zSjZjqVPbO65WGVs14xs3HegFbmeR6hbvB3z5rbt+Qa8/0GopkZXQUogZIKO0ZN/hzXABQgolzmKaqUPfav1cEfai0pz7940GBnwgzHDBlxxXvlJc2lo1zkpbmUPBjktf+I5ruJGY45bpvzq8A+hz8Qwbdg2p3SWX0HpfcEuOXiJxogrurJrssMVB9kKYHE+m9mzP07ftE8fcW3YtPCm5NEV5Un6PfVnKrvTOxwCGM9W5x5wtMwATpng+N9Qb8b1x28CUa+RefupKP029z/+PKJ3Y4P3oZFOS35yo741ulaqpqiTLcq2JssM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003202, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jun 29, 2024 at 10:54:19PM -0700, Christoph Hellwig wrote: > On Sat, Jun 29, 2024 at 08:24:00PM -0700, Luis Chamberlain wrote: > > > The minimum_io_size clearly is the minimum I/O size, not the minimal > > > nice to have one. > > > > I may have misread the below documentation then, because it seems to > > suggest this is a performance parameter, not a real minimum. Do we need > > to update it? > > queue_limits.min_io is corretly described and a performance hint. OK, great! > The statx dio_offset_align is actual minimum I/O size and alignment and > not in any way related to the performance hint in minimum_io_size. Oh, darn, I just read again 825cf206ed510 ("statx: add direct I/O alignment information") and the block layer change through commit 2d985f8c6b91b ("vfs: support STATX_DIOALIGN on block devices") and no where do I see any mention of it being a min. Should we clarify that? And should we add a respective value for performance? I suspect userspace will want to work with optimal values, not ones which could for instance incur read-modify-write. Altough we have BLKIOMIN to get the optimal performance min IO and BLKIOOPT to get the optimal size it is not terribly clear to me that users know they should prefer to align to BLKIOMIN and use that for an DIO size for writes when possible. Luis